From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] devtools: trap SIGINT is not recognizable to dash
Date: Wed, 01 Aug 2018 16:37:06 +0200 [thread overview]
Message-ID: <15666811.Czcatj4Lj7@xps> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23F3C5DAD@IRSMSX103.ger.corp.intel.com>
> > When running checkpatch.sh, it generates the following error on some linux
> > distributions(like Debian) with Dash as the default shell interpreter.
> > trap: SIGINT: bad trap
> >
> > The fix is to replace SIGINT with INT signal, it works for both bash and
> > dash.
> >
> > Fixes: 4bec48184e ("devtools: add checks for ABI symbol addition")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@amr.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
next prev parent reply other threads:[~2018-08-01 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 5:22 [PATCH] devtools: trap SIGINT is not recognizable to dash Gavin Hu
2018-08-01 10:40 ` [dpdk-stable] " Mcnamara, John
2018-08-01 13:09 ` Varghese, Vipin
2018-08-01 14:37 ` Thomas Monjalon [this message]
2018-08-03 22:17 ` Stephen Hemminger
2018-08-04 6:42 ` Gavin Hu
2018-08-06 17:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15666811.Czcatj4Lj7@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=john.mcnamara@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.