From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72EACC3A59E for ; Mon, 26 Aug 2019 08:53:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4381E206BA for ; Mon, 26 Aug 2019 08:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566809585; bh=MbPO7fFHCjLShn0oiQttX99r5D0QGsehv4H+1o5Gb7o=; h=Subject:To:Cc:From:Date:List-ID:From; b=OvO9p8WzVA1NBYBOondzfDdpLe4Noejxyyc+skMAW6Eu0X49uTd97YDv1PgPHP5wV L7ixdM4x4FtuvTsVI2VRhmaAH4vLYx2odN4vPjcOUCyMYA/qoSvVXzZDXcPJiUsqPP 2gv1vJ1uL7oJxk1L5A1ncOpeDB1eDilDa47BX0O8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729782AbfHZIxE (ORCPT ); Mon, 26 Aug 2019 04:53:04 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:45415 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfHZIxE (ORCPT ); Mon, 26 Aug 2019 04:53:04 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 403FC361; Mon, 26 Aug 2019 04:53:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 26 Aug 2019 04:53:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=xCOCfh pXGex3Ywp4Rw7RaoIdUmq3DUM3V1M4YFXMPFg=; b=eJ2TcpoA8GH9tYJvErhSWO 9QC/Kw2EB4LjGZQFXA7zx/kAK8f7ebp9cVyzaTtACC3d4ues9i5X5X9e7lYoTf/z dtsWzWCXIa5PR2r8GfRhPkA3Ifg+2MXrWpq5fW3UJ0ZL8Zb0yvcMtnMzmZejcjUh 3yKJDOvl/f439KhdZdhiCukVOq1BDNiekWEgOhVbCzzRG0I2LIi/uoQ0HsQLvpLO 1rTZZ52V8srPuNHFwzHgpVCwTTw4JV7U9aFj8wpxhv6M/s2EC31NzvWPtF9zL6Fl S+IrYZA2oATxQCX5lsm/HQOsV69UHPsnk+Lqz5RMsmOG6H3sJqo4i5kmVk/6NHlg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehgedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecukfhppeekledrvddthedruddvkedrvdegieenucfrrghrrghmpehmrghilhhfrh homhepghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [89.205.128.246]) by mail.messagingengine.com (Postfix) with ESMTPA id BF7C980061; Mon, 26 Aug 2019 04:53:01 -0400 (EDT) Subject: FAILED: patch "[PATCH] platform/chrome: cros_ec_ishtp: fix crash during suspend" failed to apply to 5.2-stable tree To: hyungwoo.yang@intel.com, enric.balletbo@collabora.com, stable@vger.kernel.org Cc: From: Date: Mon, 26 Aug 2019 10:52:59 +0200 Message-ID: <156680957919680@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 5.2-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 9cdde85804833af77c6afbf7c53f0d959c42eb9f Mon Sep 17 00:00:00 2001 From: Hyungwoo Yang Date: Wed, 29 May 2019 21:03:54 -0700 Subject: [PATCH] platform/chrome: cros_ec_ishtp: fix crash during suspend Kernel crashes during suspend due to wrong conversion in suspend and resume functions. Use the proper helper to get ishtp_cl_device instance. Cc: # 5.2.x: b12bbdc5: HID: intel-ish-hid: fix wrong driver_data usage Signed-off-by: Hyungwoo Yang Signed-off-by: Enric Balletbo i Serra diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c index e504d255d5ce..430731cdf827 100644 --- a/drivers/platform/chrome/cros_ec_ishtp.c +++ b/drivers/platform/chrome/cros_ec_ishtp.c @@ -707,7 +707,7 @@ static int cros_ec_ishtp_reset(struct ishtp_cl_device *cl_device) */ static int __maybe_unused cros_ec_ishtp_suspend(struct device *device) { - struct ishtp_cl_device *cl_device = dev_get_drvdata(device); + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device); struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device); struct ishtp_cl_data *client_data = ishtp_get_client_data(cros_ish_cl); @@ -722,7 +722,7 @@ static int __maybe_unused cros_ec_ishtp_suspend(struct device *device) */ static int __maybe_unused cros_ec_ishtp_resume(struct device *device) { - struct ishtp_cl_device *cl_device = dev_get_drvdata(device); + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device); struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device); struct ishtp_cl_data *client_data = ishtp_get_client_data(cros_ish_cl);