From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v5, 12/32] drm/mediatek: add mmsys private data for ddp path config Date: Fri, 30 Aug 2019 13:40:27 +0800 Message-ID: <1567143627.5942.10.camel@mtksdaap41> References: <1567090254-15566-1-git-send-email-yongqiang.niu@mediatek.com> <1567090254-15566-13-git-send-email-yongqiang.niu@mediatek.com> <1567142858.5942.6.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1567142858.5942.6.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: yongqiang.niu@mediatek.com Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIFlvbmdxaWFuZzoKCk9uIEZyaSwgMjAxOS0wOC0zMCBhdCAxMzoyNyArMDgwMCwgQ0sgSHUg d3JvdGU6Cj4gSGksIFlvbmdxaWFuZzoKPiAKPiBPbiBUaHUsIDIwMTktMDgtMjkgYXQgMjI6NTAg KzA4MDAsIHlvbmdxaWFuZy5uaXVAbWVkaWF0ZWsuY29tIHdyb3RlOgo+ID4gRnJvbTogWW9uZ3Fp YW5nIE5pdSA8eW9uZ3FpYW5nLm5pdUBtZWRpYXRlay5jb20+Cj4gPiAKPiA+IFRoaXMgcGF0Y2gg YWRkIG1tc3lzIHByaXZhdGUgZGF0YSBmb3IgZGRwIHBhdGggY29uZmlnCj4gPiBhbGwgdGhlc2Ug cmVnaXN0ZXIgb2Zmc2V0IGFuZCB2YWx1ZSB3aWxsIGJlIGRpZmZlcmVudCBpbiBmdXR1cmUgU09D Cj4gPiBhZGQgdGhlc2UgZGVmaW5lIGludG8gbW1zeXMgcHJpdmF0ZSBkYXRhCj4gPiAJdTMyIG92 bDBfbW91dF9lbjsKPiA+IAl1MzIgcmRtYTFfc291dF9zZWxfaW47Cj4gPiAJdTMyIHJkbWExX3Nv dXRfZHNpMDsKPiA+IAl1MzIgZHBpMF9zZWxfaW47Cj4gPiAJdTMyIGRwaTBfc2VsX2luX3JkbWEx Owo+ID4gCXUzMiBkc2kwX3NlbF9pbjsKPiA+IAl1MzIgZHNpMF9zZWxfaW5fcmRtYTE7Cj4gPiAK PiA+IFNpZ25lZC1vZmYtYnk6IFlvbmdxaWFuZyBOaXUgPHlvbmdxaWFuZy5uaXVAbWVkaWF0ZWsu Y29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5j IHwgIDQgKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYyAgfCA4 NiArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9kZHAuaCAgfCAgNSArKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRp YXRlay9tdGtfZHJtX2Rydi5jICB8ICAzICsrCj4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kcm1fZHJ2LmggIHwgIDMgKysKPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDc2IGluc2VydGlv bnMoKyksIDI1IGRlbGV0aW9ucygtKQo+ID4gCj4gCj4gW3NuaXBdCj4gCj4gPiAgCj4gPiAgdm9p ZCBtdGtfZGRwX2FkZF9jb21wX3RvX3BhdGgodm9pZCBfX2lvbWVtICpjb25maWdfcmVncywKPiA+ ICsJCQkgICAgICBjb25zdCBzdHJ1Y3QgbXRrX21tc3lzX3JlZ19kYXRhICpyZWdfZGF0YSwKPiA+ ICAJCQkgICAgICBlbnVtIG10a19kZHBfY29tcF9pZCBjdXIsCj4gPiAgCQkJICAgICAgZW51bSBt dGtfZGRwX2NvbXBfaWQgbmV4dCkKPiA+ICB7Cj4gPiAgCXVuc2lnbmVkIGludCBhZGRyLCB2YWx1 ZSwgcmVnOwo+ID4gIAo+ID4gLQl2YWx1ZSA9IG10a19kZHBfbW91dF9lbihjdXIsIG5leHQsICZh ZGRyKTsKPiA+ICsJdmFsdWUgPSBtdGtfZGRwX21vdXRfZW4ocmVnX2RhdGEsIGN1ciwgbmV4dCwg JmFkZHIpOwo+ID4gIAlpZiAodmFsdWUpIHsKPiA+ICAJCXJlZyA9IHJlYWRsX3JlbGF4ZWQoY29u ZmlnX3JlZ3MgKyBhZGRyKSB8IHZhbHVlOwo+ID4gIAkJd3JpdGVsX3JlbGF4ZWQocmVnLCBjb25m aWdfcmVncyArIGFkZHIpOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCW10a19kZHBfc291dF9zZWwoY29u ZmlnX3JlZ3MsIGN1ciwgbmV4dCk7Cj4gPiArCXZhbHVlID0gbXRrX2RkcF9zb3V0X3NlbChyZWdf ZGF0YSwgY3VyLCBuZXh0LCAmYWRkcik7Cj4gPiArCWlmICh2YWx1ZSkKPiA+ICsJCXdyaXRlbF9y ZWxheGVkKHZhbHVlLCBjb25maWdfcmVncyArIGFkZHIpOwo+IAo+IEkgdGhpbmsgdGhlIHJlZ2lz dGVyIGNvdWxkIGJlIHdyaXR0ZW4gaW5zaWRlIG10a19kZHBfc291dF9zZWwoKSwgd2h5IGRvCj4g eW91IG1vdmUgb3V0IG9mIHRoYXQgZnVuY3Rpb24/CgpPSywgYWZ0ZXIgcmV2aWV3IG90aGVyIHBh dGNoLCBJIHVuZGVyc3RhbmQgd2hhdCB5b3UgZG8gaGVyZS4KWW91IHdhbnQgdG8gYWxpZ24gdGhl IG1ldGhvZCBvZiBtdGtfZGRwX21vdXRfZW4oKSwgbXRrX2RkcF9zb3V0X3NlbCgpLAphbmQgbXRr X2RkcF9zZWxfaW4oKS4gc28gbW9kaWZpY2F0aW9uIGluIHRoZXNlIHRocmVlIGZ1bmN0aW9uIHdv dWxkIGJlCnRoZSBzYW1lIHN0eWxlLiBTbyBJIHRoaW5rIHRoaXMgYWxpZ25tZW50IHNob3VsZCBi ZSBhbiBpbmRlcGVuZGVudCBwYXRjaApiZWZvcmUgdGhpcyBwYXRjaC4KClJlZ2FyZHMsCkNLCgo+ IAo+IFJlZ2FyZHMsCj4gQ0sKPiAKPiA+ICAKPiA+IC0JdmFsdWUgPSBtdGtfZGRwX3NlbF9pbihj dXIsIG5leHQsICZhZGRyKTsKPiA+ICsJdmFsdWUgPSBtdGtfZGRwX3NlbF9pbihyZWdfZGF0YSwg Y3VyLCBuZXh0LCAmYWRkcik7Cj4gPiAgCWlmICh2YWx1ZSkgewo+ID4gIAkJcmVnID0gcmVhZGxf cmVsYXhlZChjb25maWdfcmVncyArIGFkZHIpIHwgdmFsdWU7Cj4gPiAgCQl3cml0ZWxfcmVsYXhl ZChyZWcsIGNvbmZpZ19yZWdzICsgYWRkcik7Cj4gPiBAQCAtNDIwLDE4ICs0NTUsMTkgQEAgdm9p ZCBtdGtfZGRwX2FkZF9jb21wX3RvX3BhdGgodm9pZCBfX2lvbWVtICpjb25maWdfcmVncywKPiA+ ICB9Cj4gPiAgCj4gPiAgCj4gPiAgCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6941FC3A5A3 for ; Fri, 30 Aug 2019 05:40:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 393F422CE3 for ; Fri, 30 Aug 2019 05:40:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ag+SItNQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 393F422CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=elcrFclvbS0lqihB1otKkV93gcb3mtw9f7Zy84kqJDE=; b=ag+SItNQR+pjR/ Csj/jTKh9zAywb+pYyAUHMXkuIxI29mZV0gA7smkallu4broHbtkZcfJeKi6cwBSEznwMaxDVuIm/ /05PNzXSdbU53pNquJYnyW69/f2rtqRvwvZa29LpQ+nsI/tJzkVKXa0pUL+U9J6YbMEG0el7G9CJC 6QQpnZSs+PavFTFT4d6Car9zkJASWut6/Lie4e2xzUY2vuKyYeEv2meuIBB5a+TyaTK804RlJxTTC 6VTkwOJ2hP+9CCCnqUP/96OrmGkNMIxsVXDlP9X/QyFbZZLsnMrZf58cB84Kwr3PtpIczx48gv2ij etXHG96njMb/sC9C7tWg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3ZeI-0000em-0e; Fri, 30 Aug 2019 05:40:38 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3ZeE-0000eG-NF; Fri, 30 Aug 2019 05:40:36 +0000 X-UUID: 9468da78b613427f8ba9aa748471e67e-20190829 X-UUID: 9468da78b613427f8ba9aa748471e67e-20190829 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 497296445; Thu, 29 Aug 2019 21:40:37 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 29 Aug 2019 22:40:35 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 30 Aug 2019 13:40:32 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 30 Aug 2019 13:40:32 +0800 Message-ID: <1567143627.5942.10.camel@mtksdaap41> Subject: Re: [PATCH v5, 12/32] drm/mediatek: add mmsys private data for ddp path config From: CK Hu To: Date: Fri, 30 Aug 2019 13:40:27 +0800 In-Reply-To: <1567142858.5942.6.camel@mtksdaap41> References: <1567090254-15566-1-git-send-email-yongqiang.niu@mediatek.com> <1567090254-15566-13-git-send-email-yongqiang.niu@mediatek.com> <1567142858.5942.6.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 63705600795A02F27505757BDD9CBCADFD9382BB26651453F850F28E9B4B8EDE2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190829_224034_770095_6EB0C9B3 X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Fri, 2019-08-30 at 13:27 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2019-08-29 at 22:50 +0800, yongqiang.niu@mediatek.com wrote: > > From: Yongqiang Niu > > > > This patch add mmsys private data for ddp path config > > all these register offset and value will be different in future SOC > > add these define into mmsys private data > > u32 ovl0_mout_en; > > u32 rdma1_sout_sel_in; > > u32 rdma1_sout_dsi0; > > u32 dpi0_sel_in; > > u32 dpi0_sel_in_rdma1; > > u32 dsi0_sel_in; > > u32 dsi0_sel_in_rdma1; > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 ++ > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 86 +++++++++++++++++++++++---------- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 5 ++ > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 ++ > > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 3 ++ > > 5 files changed, 76 insertions(+), 25 deletions(-) > > > > [snip] > > > > > void mtk_ddp_add_comp_to_path(void __iomem *config_regs, > > + const struct mtk_mmsys_reg_data *reg_data, > > enum mtk_ddp_comp_id cur, > > enum mtk_ddp_comp_id next) > > { > > unsigned int addr, value, reg; > > > > - value = mtk_ddp_mout_en(cur, next, &addr); > > + value = mtk_ddp_mout_en(reg_data, cur, next, &addr); > > if (value) { > > reg = readl_relaxed(config_regs + addr) | value; > > writel_relaxed(reg, config_regs + addr); > > } > > > > - mtk_ddp_sout_sel(config_regs, cur, next); > > + value = mtk_ddp_sout_sel(reg_data, cur, next, &addr); > > + if (value) > > + writel_relaxed(value, config_regs + addr); > > I think the register could be written inside mtk_ddp_sout_sel(), why do > you move out of that function? OK, after review other patch, I understand what you do here. You want to align the method of mtk_ddp_mout_en(), mtk_ddp_sout_sel(), and mtk_ddp_sel_in(). so modification in these three function would be the same style. So I think this alignment should be an independent patch before this patch. Regards, CK > > Regards, > CK > > > > > - value = mtk_ddp_sel_in(cur, next, &addr); > > + value = mtk_ddp_sel_in(reg_data, cur, next, &addr); > > if (value) { > > reg = readl_relaxed(config_regs + addr) | value; > > writel_relaxed(reg, config_regs + addr); > > @@ -420,18 +455,19 @@ void mtk_ddp_add_comp_to_path(void __iomem *config_regs, > > } > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25BFC3A5A3 for ; Fri, 30 Aug 2019 05:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76BF421721 for ; Fri, 30 Aug 2019 05:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbfH3Fki (ORCPT ); Fri, 30 Aug 2019 01:40:38 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:45816 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725902AbfH3Fki (ORCPT ); Fri, 30 Aug 2019 01:40:38 -0400 X-UUID: e3765b949a904a1ea0e241e9a73b7c84-20190830 X-UUID: e3765b949a904a1ea0e241e9a73b7c84-20190830 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 92452426; Fri, 30 Aug 2019 13:40:34 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 30 Aug 2019 13:40:32 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 30 Aug 2019 13:40:32 +0800 Message-ID: <1567143627.5942.10.camel@mtksdaap41> Subject: Re: [PATCH v5, 12/32] drm/mediatek: add mmsys private data for ddp path config From: CK Hu To: CC: Philipp Zabel , Rob Herring , Matthias Brugger , "David Airlie" , Daniel Vetter , Mark Rutland , , , , , Date: Fri, 30 Aug 2019 13:40:27 +0800 In-Reply-To: <1567142858.5942.6.camel@mtksdaap41> References: <1567090254-15566-1-git-send-email-yongqiang.niu@mediatek.com> <1567090254-15566-13-git-send-email-yongqiang.niu@mediatek.com> <1567142858.5942.6.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: 63705600795A02F27505757BDD9CBCADFD9382BB26651453F850F28E9B4B8EDE2000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Yongqiang: On Fri, 2019-08-30 at 13:27 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2019-08-29 at 22:50 +0800, yongqiang.niu@mediatek.com wrote: > > From: Yongqiang Niu > > > > This patch add mmsys private data for ddp path config > > all these register offset and value will be different in future SOC > > add these define into mmsys private data > > u32 ovl0_mout_en; > > u32 rdma1_sout_sel_in; > > u32 rdma1_sout_dsi0; > > u32 dpi0_sel_in; > > u32 dpi0_sel_in_rdma1; > > u32 dsi0_sel_in; > > u32 dsi0_sel_in_rdma1; > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 ++ > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 86 +++++++++++++++++++++++---------- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 5 ++ > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 ++ > > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 3 ++ > > 5 files changed, 76 insertions(+), 25 deletions(-) > > > > [snip] > > > > > void mtk_ddp_add_comp_to_path(void __iomem *config_regs, > > + const struct mtk_mmsys_reg_data *reg_data, > > enum mtk_ddp_comp_id cur, > > enum mtk_ddp_comp_id next) > > { > > unsigned int addr, value, reg; > > > > - value = mtk_ddp_mout_en(cur, next, &addr); > > + value = mtk_ddp_mout_en(reg_data, cur, next, &addr); > > if (value) { > > reg = readl_relaxed(config_regs + addr) | value; > > writel_relaxed(reg, config_regs + addr); > > } > > > > - mtk_ddp_sout_sel(config_regs, cur, next); > > + value = mtk_ddp_sout_sel(reg_data, cur, next, &addr); > > + if (value) > > + writel_relaxed(value, config_regs + addr); > > I think the register could be written inside mtk_ddp_sout_sel(), why do > you move out of that function? OK, after review other patch, I understand what you do here. You want to align the method of mtk_ddp_mout_en(), mtk_ddp_sout_sel(), and mtk_ddp_sel_in(). so modification in these three function would be the same style. So I think this alignment should be an independent patch before this patch. Regards, CK > > Regards, > CK > > > > > - value = mtk_ddp_sel_in(cur, next, &addr); > > + value = mtk_ddp_sel_in(reg_data, cur, next, &addr); > > if (value) { > > reg = readl_relaxed(config_regs + addr) | value; > > writel_relaxed(reg, config_regs + addr); > > @@ -420,18 +455,19 @@ void mtk_ddp_add_comp_to_path(void __iomem *config_regs, > > } > > > > > > >