From: Tomasz Figa <t.figa@samsung.com>
To: yuvaraj.cd@gmail.com
Cc: linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
kgene.kim@samsung.com, ks.giri@samsung.com,
Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
Subject: Re: [PATCH V2 1/2] ARM: dts: remove dwmmc nodes from exynos5 common dts file.
Date: Wed, 21 Aug 2013 12:34:28 +0200 [thread overview]
Message-ID: <1567576.DPSCbfljYs@amdc1227> (raw)
In-Reply-To: <52146040.87c5440a.4207.5aff@mx.google.com>
Hi Yuvaraj,
On Wednesday 21 of August 2013 12:07:38 yuvaraj.cd@gmail.com wrote:
> From: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>
> Exynos5 series SOC's 5250 and 5420 have different versions of
> DWMMC controller.So there is a new compatible string to distinguish
> between them.So these nodes should be moved out of Exynos5 series
> common device tree source.
This series should be split in a different way, because patch 1/2 breaks
dwmmc on Exynos5250 and only patch 2/2 fixes this, so bisection is broken.
Also patch 2/2 contains two logically separate changes - moving dwmmc nodes
and making status disabled by default. Those should be in separate patches.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-08-21 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 6:37 [PATCH V2 1/2] ARM: dts: remove dwmmc nodes from exynos5 common dts file yuvaraj.cd
2013-08-21 10:34 ` Tomasz Figa [this message]
2013-08-21 11:46 ` Yuvaraj Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567576.DPSCbfljYs@amdc1227 \
--to=t.figa@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=ks.giri@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=yuvaraj.cd@gmail.com \
--cc=yuvaraj.cd@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.