From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765F7C3A5A7 for ; Wed, 4 Sep 2019 11:46:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45CC320820 for ; Wed, 4 Sep 2019 11:46:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tCvirIxs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45CC320820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Tjt-00083G-En; Wed, 04 Sep 2019 11:46:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Tjr-00082U-B3 for xen-devel@lists.xenproject.org; Wed, 04 Sep 2019 11:46:15 +0000 X-Inumbo-ID: 992aa230-cf09-11e9-abb0-12813bfff9fa Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 992aa230-cf09-11e9-abb0-12813bfff9fa; Wed, 04 Sep 2019 11:46:14 +0000 (UTC) Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC0A920820; Wed, 4 Sep 2019 11:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567597574; bh=tHqEkww86KOLAmW5EQ0TIw1FCRFKi6/kyBIAI58FgmQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tCvirIxsPyDLuECE+MpjKKpTgje2DwSZK2A5hmcbdQiW1cyxc+Pvk1Lo7atnCLVqd CosZL3Ic2nMvEv6WwnDL97wUaNn4N5A+Gkfebg70iepgH2JEVTQIdksucUonvRQeuo 3wD1KK8jLdHLqfGD0e+FSyAXNsQrfLCOzsdDnJDs= From: Masami Hiramatsu To: Ingo Molnar Date: Wed, 4 Sep 2019 20:46:09 +0900 Message-Id: <156759756944.24473.4664241966878257420.stgit@devnote2> X-Mailer: git-send-email 2.20.1 In-Reply-To: <156759754770.24473.11832897710080799131.stgit@devnote2> References: <156759754770.24473.11832897710080799131.stgit@devnote2> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Subject: [Xen-devel] [PATCH -tip 2/2] x86: kprobes: Prohibit probing on instruction which has Xen prefix X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Peter Zijlstra , Randy Dunlap , x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Josh Poimboeuf , xen-devel@lists.xenproject.org, Boris Ostrovsky Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" UHJvaGliaXQgcHJvYmluZyBvbiBpbnN0cnVjdGlvbiB3aGljaCBoYXMgWEVOX0VNVUxBVEVfUFJF RklYCihpdCBtdXN0IGJlIGNwdWlkLikgU2luY2UgdGhhdCBwcmVmaXggaXMgYSBtYXJrZXIgZm9y IFhlbiwKaWYgd2UgbW9kaWZ5IHRoZSBtYXJrZXIgYnkga3Byb2JlJ3MgaW50MywgdGhhdCBkb2Vz bid0IHdvcmsKYXMgZXhwZWN0ZWQuCgpTaWduZWQtb2ZmLWJ5OiBNYXNhbWkgSGlyYW1hdHN1IDxt aGlyYW1hdEBrZXJuZWwub3JnPgotLS0KIGFyY2gveDg2L2tlcm5lbC9rcHJvYmVzL2NvcmUuYyB8 ICAgIDQgKysrKwogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2FyY2gveDg2L2tlcm5lbC9rcHJvYmVzL2NvcmUuYyBiL2FyY2gveDg2L2tlcm5lbC9rcHJvYmVz L2NvcmUuYwppbmRleCA0M2ZjMTNjODMxYWYuLmIxZTg2YWY0YTk4NSAxMDA2NDQKLS0tIGEvYXJj aC94ODYva2VybmVsL2twcm9iZXMvY29yZS5jCisrKyBiL2FyY2gveDg2L2tlcm5lbC9rcHJvYmVz L2NvcmUuYwpAQCAtMzUxLDYgKzM1MSwxMCBAQCBpbnQgX19jb3B5X2luc3RydWN0aW9uKHU4ICpk ZXN0LCB1OCAqc3JjLCB1OCAqcmVhbCwgc3RydWN0IGluc24gKmluc24pCiAJa2VybmVsX2luc25f aW5pdChpbnNuLCBkZXN0LCBNQVhfSU5TTl9TSVpFKTsKIAlpbnNuX2dldF9sZW5ndGgoaW5zbik7 CiAKKwkvKiBXZSBjYW4gbm90IHByb2JlIFhFTl9FTVVMQVRFX1BSRUZJWCBpbnN0cnVjdGlvbiAq LworCWlmIChpbnNuX2hhc194ZW5fcHJlZml4KGluc24pKQorCQlyZXR1cm4gMDsKKwogCS8qIEFu b3RoZXIgc3Vic3lzdGVtIHB1dHMgYSBicmVha3BvaW50LCBmYWlsZWQgdG8gcmVjb3ZlciAqLwog CWlmIChpbnNuLT5vcGNvZGUuYnl0ZXNbMF0gPT0gQlJFQUtQT0lOVF9JTlNUUlVDVElPTikKIAkJ cmV0dXJuIDA7CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcK aHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A828C3A5A7 for ; Wed, 4 Sep 2019 11:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 231D822CF7 for ; Wed, 4 Sep 2019 11:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567597576; bh=tHqEkww86KOLAmW5EQ0TIw1FCRFKi6/kyBIAI58FgmQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LLnj3+NSV2Wgha7D19dbUE71MS2EPV6jEuF26b5MwEq2//8qYbs4H01pxBU/s990M cNPBjdN7h31IjJ6GO8VmuzohmOAbeylErCaVlY0RNKBanWO8fefNDviqpGCLb9weha CFc9Uo0za8Bt8XmGztcZtev6Pm5pEWwtr7NPCDNI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729733AbfIDLqO (ORCPT ); Wed, 4 Sep 2019 07:46:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:57384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfIDLqO (ORCPT ); Wed, 4 Sep 2019 07:46:14 -0400 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC0A920820; Wed, 4 Sep 2019 11:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567597574; bh=tHqEkww86KOLAmW5EQ0TIw1FCRFKi6/kyBIAI58FgmQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tCvirIxsPyDLuECE+MpjKKpTgje2DwSZK2A5hmcbdQiW1cyxc+Pvk1Lo7atnCLVqd CosZL3Ic2nMvEv6WwnDL97wUaNn4N5A+Gkfebg70iepgH2JEVTQIdksucUonvRQeuo 3wD1KK8jLdHLqfGD0e+FSyAXNsQrfLCOzsdDnJDs= From: Masami Hiramatsu To: Ingo Molnar Cc: Josh Poimboeuf , Peter Zijlstra , Randy Dunlap , Borislav Petkov , Juergen Gross , Boris Ostrovsky , Stefano Stabellini , x86@kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH -tip 2/2] x86: kprobes: Prohibit probing on instruction which has Xen prefix Date: Wed, 4 Sep 2019 20:46:09 +0900 Message-Id: <156759756944.24473.4664241966878257420.stgit@devnote2> X-Mailer: git-send-email 2.20.1 In-Reply-To: <156759754770.24473.11832897710080799131.stgit@devnote2> References: <156759754770.24473.11832897710080799131.stgit@devnote2> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prohibit probing on instruction which has XEN_EMULATE_PREFIX (it must be cpuid.) Since that prefix is a marker for Xen, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index 43fc13c831af..b1e86af4a985 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -351,6 +351,10 @@ int __copy_instruction(u8 *dest, u8 *src, u8 *real, struct insn *insn) kernel_insn_init(insn, dest, MAX_INSN_SIZE); insn_get_length(insn); + /* We can not probe XEN_EMULATE_PREFIX instruction */ + if (insn_has_xen_prefix(insn)) + return 0; + /* Another subsystem puts a breakpoint, failed to recover */ if (insn->opcode.bytes[0] == BREAKPOINT_INSTRUCTION) return 0;