From: Mimi Zohar <zohar@linux.ibm.com>
To: prsriva <prsriva@linux.microsoft.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-integrity@vger.kernel.org, jmorris@namei.org
Subject: Re: [RFC][PATCH 1/1] Carry ima measurement log for arm64 via kexec_file_load
Date: Sun, 08 Sep 2019 19:31:16 -0400 [thread overview]
Message-ID: <1567985476.4614.224.camel@linux.ibm.com> (raw)
In-Reply-To: <0c7453d4-620d-2d98-3fda-f902b18da535@linux.microsoft.com>
Hi Prakhar,
On Fri, 2019-09-06 at 16:56 -0700, prsriva wrote:
> On 8/30/19 5:11 PM, Thiago Jung Bauermann wrote:
> > Hello Prakhar,
> >
> > Answering this part from the cover letter:
> >
> >> The code is in most part same as powerpc, i want to get feedback as to
> >> how/correct way to refactor the code so that cross architecture
> >> partial helpers can be put in a common place.
>
> I started refactoring code to bring helpers under drivers/of, but
>
> i soon reliazed the current implementation can be changed a bit
>
> so that some of the additional functions can be sourced from
>
> existing fdt_*/of_* functions since the fdt_ima was seeming to be
>
> an overkill. I have done so in the V1 patch and also addressed
>
> comments you have.
>
> Hopefully its(v1) is a cleaner approach.
>
> - Thanks for the review, and guidance.
"Carrying over the ima log during kexec_file_load" was originally
posted on 5/10 and 5/31 without a cover letter. On 8/29 it was
reposted as an RFC with a cover letter. The cover letter was v1, but
the patch itself was not. In the future, please use the "git format-
patch "-subject-prefix" option to add the version number to both the
cover letter and the patches.
The comments you received were based on the 8/29 version. I haven't
seen anything after that.
Mimi
> > That's a great idea. If it could go to drivers/of/ as Stephen Boyd
> > mentioned in the other email that would be great.
> >
> > More comments below.
> > -Addressed those in the v1 patch
> > Prakhar Srivastava <prsriva@linux.microsoft.com> writes:
> >
next prev parent reply other threads:[~2019-09-08 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 20:05 [RFC][PATCH v1 0/1] Carry ima measurement log for arm64 via kexec_file_load Prakhar Srivastava
2019-08-29 20:05 ` [RFC][PATCH 1/1] " Prakhar Srivastava
2019-08-30 5:23 ` Stephen Boyd
2019-08-31 0:17 ` Thiago Jung Bauermann
2019-08-31 0:11 ` Thiago Jung Bauermann
2019-09-06 23:56 ` prsriva
2019-09-08 23:31 ` Mimi Zohar [this message]
2019-09-09 23:18 ` prsriva
-- strict thread matches above, loose matches on Subject: below --
2019-08-29 19:00 [RFC][PATCH v1 0/1] " Prakhar Srivastava
2019-08-29 19:00 ` [RFC][PATCH 1/1] " Prakhar Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567985476.4614.224.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prsriva@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.