From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adalbert =?iso-8859-2?b?TGF643I=?= Subject: Re: [RFC PATCH v6 69/92] kvm: x86: keep the page protected if tracked by the introspection tool Date: Tue, 10 Sep 2019 19:28:19 +0300 Message-ID: <15681328990.F582D7fCB.15355@host> References: <20190809160047.8319-1-alazar@bitdefender.com> <20190809160047.8319-70-alazar@bitdefender.com> <20190910142642.GC5879@char.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190910142642.GC5879@char.us.oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Konrad Rzeszutek Wilk Cc: Tamas K Lengyel , Weijiang Yang , Yu C , kvm@vger.kernel.org, Radim =?iso-8859-2?b?S3LobeH4?= , Jan Kiszka , Samuel =?iso-8859-1?q?Laur=E9n?= , virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Patrick Colp , Mathieu Tarral , Stefan Hajnoczi , Paolo Bonzini , Mihai =?UTF-8?b?RG9uyJt1?= List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCAxMCBTZXAgMjAxOSAxMDoyNjo0MiAtMDQwMCwgS29ucmFkIFJ6ZXN6dXRlayBXaWxr IDxrb25yYWQud2lsa0BvcmFjbGUuY29tPiB3cm90ZToKPiBPbiBGcmksIEF1ZyAwOSwgMjAxOSBh dCAwNzowMDoyNFBNICswMzAwLCBBZGFsYmVydCBMYXrEg3Igd3JvdGU6Cj4gPiBUaGlzIHBhdGNo IG1pZ2h0IGJlIG9ic29sZXRlIHRoYW5rcyB0byBzaW5nbGUtc3RlcHBpbmcuCj4gCj4gc29vbyBz aG91bGQgaXQgYmUgc2tpcHBlZCBmcm9tIHRoaXMgbGFyZ2UgcGF0Y2hzZXQgdG8gZWFzeQo+IHJl dmlldz8KCkknbGwgYWRkIGEgY291cGxlIG9mIHdhcm5pbmcgbWVzc2FnZXMgdG8gY2hlY2sgaWYg dGhpcyBwYXRjaCBpcyBzdGlsbApuZWVkZWQsIGluIG9yZGVyIHRvIHNraXAgaXQgZnJvbSB0aGUg bmV4dCBzdWJtaXNzaW9uICh3aGljaCB3aWxsIGJlIHNtYWxsZXI6KQoKSG93ZXZlciwgb24gQU1E LCBzaW5nbGUtc3RlcHBpbmcgaXMgbm90IGFuIG9wdGlvbi4KClRoYW5rcywKQWRhbGJlcnQKCj4g Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEFkYWxiZXJ0IExhesSDciA8YWxhemFyQGJpdGRlZmVu ZGVyLmNvbT4KPiA+IC0tLQo+ID4gIGFyY2gveDg2L2t2bS94ODYuYyB8IDkgKysrKysrKy0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ ID4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2t2bS94ODYuYyBiL2FyY2gveDg2L2t2bS94ODYuYwo+ ID4gaW5kZXggMmMwNmRlNzNhNzg0Li4wNmY0NGNlOGVkMDcgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNo L3g4Ni9rdm0veDg2LmMKPiA+ICsrKyBiL2FyY2gveDg2L2t2bS94ODYuYwo+ID4gQEAgLTYzMTEs NyArNjMxMSw4IEBAIHN0YXRpYyBib29sIHJlZXhlY3V0ZV9pbnN0cnVjdGlvbihzdHJ1Y3Qga3Zt X3ZjcHUgKnZjcHUsIGd2YV90IGNyMiwKPiA+ICAJCWluZGlyZWN0X3NoYWRvd19wYWdlcyA9IHZj cHUtPmt2bS0+YXJjaC5pbmRpcmVjdF9zaGFkb3dfcGFnZXM7Cj4gPiAgCQlzcGluX3VubG9jaygm dmNwdS0+a3ZtLT5tbXVfbG9jayk7Cj4gPiAgCj4gPiAtCQlpZiAoaW5kaXJlY3Rfc2hhZG93X3Bh Z2VzKQo+ID4gKwkJaWYgKGluZGlyZWN0X3NoYWRvd19wYWdlcwo+ID4gKwkJICAgICYmICFrdm1p X3RyYWNrZWRfZ2ZuKHZjcHUsIGdwYV90b19nZm4oZ3BhKSkpCj4gPiAgCQkJa3ZtX21tdV91bnBy b3RlY3RfcGFnZSh2Y3B1LT5rdm0sIGdwYV90b19nZm4oZ3BhKSk7Cj4gPiAgCj4gPiAgCQlyZXR1 cm4gdHJ1ZTsKPiA+IEBAIC02MzIyLDcgKzYzMjMsOCBAQCBzdGF0aWMgYm9vbCByZWV4ZWN1dGVf aW5zdHJ1Y3Rpb24oc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCBndmFfdCBjcjIsCj4gPiAgCSAqIGFu ZCBpdCBmYWlsZWQgdHJ5IHRvIHVuc2hhZG93IHBhZ2UgYW5kIHJlLWVudGVyIHRoZQo+ID4gIAkg KiBndWVzdCB0byBsZXQgQ1BVIGV4ZWN1dGUgdGhlIGluc3RydWN0aW9uLgo+ID4gIAkgKi8KPiA+ IC0Ja3ZtX21tdV91bnByb3RlY3RfcGFnZSh2Y3B1LT5rdm0sIGdwYV90b19nZm4oZ3BhKSk7Cj4g PiArCWlmICgha3ZtaV90cmFja2VkX2dmbih2Y3B1LCBncGFfdG9fZ2ZuKGdwYSkpKQo+ID4gKwkJ a3ZtX21tdV91bnByb3RlY3RfcGFnZSh2Y3B1LT5rdm0sIGdwYV90b19nZm4oZ3BhKSk7Cj4gPiAg Cj4gPiAgCS8qCj4gPiAgCSAqIElmIHRoZSBhY2Nlc3MgZmF1bHRzIG9uIGl0cyBwYWdlIHRhYmxl LCBpdCBjYW4gbm90Cj4gPiBAQCAtNjM3NCw2ICs2Mzc2LDkgQEAgc3RhdGljIGJvb2wgcmV0cnlf aW5zdHJ1Y3Rpb24oc3RydWN0IHg4Nl9lbXVsYXRlX2N0eHQgKmN0eHQsCj4gPiAgCWlmICghdmNw dS0+YXJjaC5tbXUtPmRpcmVjdF9tYXApCj4gPiAgCQlncGEgPSBrdm1fbW11X2d2YV90b19ncGFf d3JpdGUodmNwdSwgY3IyLCBOVUxMKTsKPiA+ICAKPiA+ICsJaWYgKGt2bWlfdHJhY2tlZF9nZm4o dmNwdSwgZ3BhX3RvX2dmbihncGEpKSkKPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ICsKPiA+ICAJ a3ZtX21tdV91bnByb3RlY3RfcGFnZSh2Y3B1LT5rdm0sIGdwYV90b19nZm4oZ3BhKSk7Cj4gPiAg Cj4gPiAgCXJldHVybiB0cnVlOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FFA3C49ED9 for ; Tue, 10 Sep 2019 16:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1021720872 for ; Tue, 10 Sep 2019 16:27:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436783AbfIJQ1z (ORCPT ); Tue, 10 Sep 2019 12:27:55 -0400 Received: from mx01.bbu.dsd.mx.bitdefender.com ([91.199.104.161]:55174 "EHLO mx01.bbu.dsd.mx.bitdefender.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436679AbfIJQ1z (ORCPT ); Tue, 10 Sep 2019 12:27:55 -0400 Received: from smtp.bitdefender.com (smtp02.buh.bitdefender.net [10.17.80.76]) by mx01.bbu.dsd.mx.bitdefender.com (Postfix) with ESMTPS id 5CA3A307483A; Tue, 10 Sep 2019 19:27:52 +0300 (EEST) Received: from localhost (unknown [195.210.5.22]) by smtp.bitdefender.com (Postfix) with ESMTPSA id 3C3B8303A562; Tue, 10 Sep 2019 19:27:52 +0300 (EEST) From: Adalbert =?iso-8859-2?b?TGF643I=?= Subject: Re: [RFC PATCH v6 69/92] kvm: x86: keep the page protected if tracked by the introspection tool To: Konrad Rzeszutek Wilk Cc: kvm@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Paolo Bonzini , Radim =?iso-8859-2?b?S3LobeH4?= , Tamas K Lengyel , Mathieu Tarral , Samuel =?iso-8859-1?q?Laur=E9n?= , Patrick Colp , Jan Kiszka , Stefan Hajnoczi , Weijiang Yang , Yu C , Mihai =?UTF-8?b?RG9uyJt1?= In-Reply-To: <20190910142642.GC5879@char.us.oracle.com> References: <20190809160047.8319-1-alazar@bitdefender.com> <20190809160047.8319-70-alazar@bitdefender.com> <20190910142642.GC5879@char.us.oracle.com> Date: Tue, 10 Sep 2019 19:28:19 +0300 Message-ID: <15681328990.F582D7fCB.15355@host> User-agent: void Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 10 Sep 2019 10:26:42 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Aug 09, 2019 at 07:00:24PM +0300, Adalbert Lazăr wrote: > > This patch might be obsolete thanks to single-stepping. > > sooo should it be skipped from this large patchset to easy > review? I'll add a couple of warning messages to check if this patch is still needed, in order to skip it from the next submission (which will be smaller:) However, on AMD, single-stepping is not an option. Thanks, Adalbert > > > > > Signed-off-by: Adalbert Lazăr > > --- > > arch/x86/kvm/x86.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index 2c06de73a784..06f44ce8ed07 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -6311,7 +6311,8 @@ static bool reexecute_instruction(struct kvm_vcpu *vcpu, gva_t cr2, > > indirect_shadow_pages = vcpu->kvm->arch.indirect_shadow_pages; > > spin_unlock(&vcpu->kvm->mmu_lock); > > > > - if (indirect_shadow_pages) > > + if (indirect_shadow_pages > > + && !kvmi_tracked_gfn(vcpu, gpa_to_gfn(gpa))) > > kvm_mmu_unprotect_page(vcpu->kvm, gpa_to_gfn(gpa)); > > > > return true; > > @@ -6322,7 +6323,8 @@ static bool reexecute_instruction(struct kvm_vcpu *vcpu, gva_t cr2, > > * and it failed try to unshadow page and re-enter the > > * guest to let CPU execute the instruction. > > */ > > - kvm_mmu_unprotect_page(vcpu->kvm, gpa_to_gfn(gpa)); > > + if (!kvmi_tracked_gfn(vcpu, gpa_to_gfn(gpa))) > > + kvm_mmu_unprotect_page(vcpu->kvm, gpa_to_gfn(gpa)); > > > > /* > > * If the access faults on its page table, it can not > > @@ -6374,6 +6376,9 @@ static bool retry_instruction(struct x86_emulate_ctxt *ctxt, > > if (!vcpu->arch.mmu->direct_map) > > gpa = kvm_mmu_gva_to_gpa_write(vcpu, cr2, NULL); > > > > + if (kvmi_tracked_gfn(vcpu, gpa_to_gfn(gpa))) > > + return false; > > + > > kvm_mmu_unprotect_page(vcpu->kvm, gpa_to_gfn(gpa)); > > > > return true;