From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/3] drm/omap: Support for HDMI hot plug detection
Date: Tue, 23 May 2017 12:36 +0300
Message-ID: <1568350.O9b0OEWcFy@avalon>
References: <20170515090312.32051-1-peter.ujfalusi@ti.com>
 <20170515090312.32051-2-peter.ujfalusi@ti.com>
 <817d3ce9-f189-f8d3-1764-7701e8412af6@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from galahad.ideasonboard.com (galahad.ideasonboard.com
 [185.26.127.97])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B128689487
 for <dri-devel@lists.freedesktop.org>; Tue, 23 May 2017 09:35:45 +0000 (UTC)
In-Reply-To: <817d3ce9-f189-f8d3-1764-7701e8412af6@ti.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>, dri-devel@lists.freedesktop.org, jsarha@ti.com, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

SGkgVG9taSwKCk9uIE1vbmRheSAyMiBNYXkgMjAxNyAxNDo1OTowOSBUb21pIFZhbGtlaW5lbiB3
cm90ZToKPiBPbiAxNS8wNS8xNyAxMjowMywgUGV0ZXIgVWpmYWx1c2kgd3JvdGU6Cj4gPiBUaGUg
SFBEIHNpZ25hbCBjYW4gYmUgdXNlZCBmb3IgZGV0ZWN0aW5nIEhETUkgY2FibGUgcGx1ZyBhbmQg
dW5wbHVnIGV2ZW50Cj4gPiB3aXRob3V0IHRoZSBuZWVkIGZvciBwb2xsaW5nIHRoZSBzdGF0dXMg
b2YgdGhlIGxpbmUuCj4gPiBUaGlzIHdpbGwgc3BlZWQgdXAgZGV0ZWN0aW5nIHN1Y2ggZXZlbnQg
YmVjYXVzZSB3ZSBkbyBub3QgbmVlZCB0byB3YWl0IGZvcgo+ID4gdGhlIG5leHQgcG9sbCBldmVu
dCB0byBub3RpY2UgdGhlIHN0YXRlIGNoYW5nZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUGV0
ZXIgVWpmYWx1c2kgPHBldGVyLnVqZmFsdXNpQHRpLmNvbT4KPiA+IC0tLQo+ID4gCj4gPiAgZHJp
dmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL29tYXBkc3MuaCAgICB8IDE3ICsrKysrKysrKysrKysr
KysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9jb25uZWN0b3IuYyB8IDMyICsr
KysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29t
YXBfZHJ2LmMgICAgICAgfCAyOSArKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDMgZmls
ZXMgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL29tYXBkc3MuaAo+ID4gYi9kcml2
ZXJzL2dwdS9kcm0vb21hcGRybS9kc3Mvb21hcGRzcy5oIGluZGV4IGIxOWRhZTFmZDZjNS4uMWYw
MTY2OWViNjEwCj4gPiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rz
cy9vbWFwZHNzLmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rzcy9vbWFwZHNz
LmgKPiA+IEBAIC0yNSw2ICsyNSw3IEBACj4gPiAKPiA+ICAjaW5jbHVkZSA8dmlkZW8vdmlkZW9t
b2RlLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEvb21hcGRzcy5oPgo+ID4g
ICNpbmNsdWRlIDx1YXBpL2RybS9kcm1fbW9kZS5oPgo+ID4gCj4gPiArI2luY2x1ZGUgPGRybS9k
cm1fY3J0Yy5oPgo+ID4gCj4gPiAgI2RlZmluZSBESVNQQ19JUlFfRlJBTUVET05FCQkoMSA8PCAw
KQo+ID4gICNkZWZpbmUgRElTUENfSVJRX1ZTWU5DCQkJKDEgPDwgMSkKPiA+IAo+ID4gQEAgLTU1
NSw2ICs1NTYsMTQgQEAgc3RydWN0IG9tYXBkc3NfaGRtaV9vcHMgewo+ID4gCj4gPiAgCWludCAo
KnJlYWRfZWRpZCkoc3RydWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2LCB1OCAqYnVmLCBpbnQg
bGVuKTsKPiA+ICAJYm9vbCAoKmRldGVjdCkoc3RydWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2
KTsKPiA+IAo+ID4gKwlpbnQgKCpyZWdpc3Rlcl9ocGRfY2IpKHN0cnVjdCBvbWFwX2Rzc19kZXZp
Y2UgKmRzc2RldiwKPiA+ICsJCQkgICAgICAgdm9pZCAoKmNiKSh2b2lkICpjYl9kYXRhLAo+ID4g
KwkJCQkJICBlbnVtIGRybV9jb25uZWN0b3Jfc3RhdHVzIHN0YXR1cyksCj4gPiArCQkJICAgICAg
IHZvaWQgKmNiX2RhdGEpOwo+ID4gKwl2b2lkICgqdW5yZWdpc3Rlcl9ocGRfY2IpKHN0cnVjdCBv
bWFwX2Rzc19kZXZpY2UgKmRzc2Rldik7Cj4gPiArCXZvaWQgKCplbmFibGVfaHBkKShzdHJ1Y3Qg
b21hcF9kc3NfZGV2aWNlICpkc3NkZXYpOwo+ID4gKwl2b2lkICgqZGlzYWJsZV9ocGQpKHN0cnVj
dCBvbWFwX2Rzc19kZXZpY2UgKmRzc2Rldik7Cj4gPiArCj4gPiAKPiA+ICAJaW50ICgqc2V0X2hk
bWlfbW9kZSkoc3RydWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2LCBib29sIGhkbWlfbW9kZSk7
Cj4gPiAgCWludCAoKnNldF9pbmZvZnJhbWUpKHN0cnVjdCBvbWFwX2Rzc19kZXZpY2UgKmRzc2Rl
diwKPiA+ICAJCj4gPiAgCQljb25zdCBzdHJ1Y3QgaGRtaV9hdmlfaW5mb2ZyYW1lICphdmkpOwo+
ID4gCj4gPiBAQCAtNzYxLDYgKzc3MCwxNCBAQCBzdHJ1Y3Qgb21hcF9kc3NfZHJpdmVyIHsKPiA+
IAo+ID4gIAlpbnQgKCpyZWFkX2VkaWQpKHN0cnVjdCBvbWFwX2Rzc19kZXZpY2UgKmRzc2Rldiwg
dTggKmJ1ZiwgaW50IGxlbik7Cj4gPiAgCWJvb2wgKCpkZXRlY3QpKHN0cnVjdCBvbWFwX2Rzc19k
ZXZpY2UgKmRzc2Rldik7Cj4gPiAKPiA+ICsJaW50ICgqcmVnaXN0ZXJfaHBkX2NiKShzdHJ1Y3Qg
b21hcF9kc3NfZGV2aWNlICpkc3NkZXYsCj4gPiArCQkJICAgICAgIHZvaWQgKCpjYikodm9pZCAq
Y2JfZGF0YSwKPiA+ICsJCQkJCSAgZW51bSBkcm1fY29ubmVjdG9yX3N0YXR1cyBzdGF0dXMpLAo+
ID4gKwkJCSAgICAgICB2b2lkICpjYl9kYXRhKTsKPiA+ICsJdm9pZCAoKnVucmVnaXN0ZXJfaHBk
X2NiKShzdHJ1Y3Qgb21hcF9kc3NfZGV2aWNlICpkc3NkZXYpOwo+ID4gKwl2b2lkICgqZW5hYmxl
X2hwZCkoc3RydWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2KTsKPiA+ICsJdm9pZCAoKmRpc2Fi
bGVfaHBkKShzdHJ1Y3Qgb21hcF9kc3NfZGV2aWNlICpkc3NkZXYpOwo+ID4gKwo+ID4gCj4gPiAg
CWludCAoKnNldF9oZG1pX21vZGUpKHN0cnVjdCBvbWFwX2Rzc19kZXZpY2UgKmRzc2RldiwgYm9v
bCBoZG1pX21vZGUpOwo+ID4gIAlpbnQgKCpzZXRfaGRtaV9pbmZvZnJhbWUpKHN0cnVjdCBvbWFw
X2Rzc19kZXZpY2UgKmRzc2RldiwKPiA+ICAJCj4gPiAgCQljb25zdCBzdHJ1Y3QgaGRtaV9hdmlf
aW5mb2ZyYW1lICphdmkpOwo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29t
YXBkcm0vb21hcF9jb25uZWN0b3IuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFw
X2Nvbm5lY3Rvci5jIGluZGV4Cj4gPiBjMjRiNmI3ODNlOWEuLjUyMTllMzQwZWQ5ZCAxMDA2NDQK
PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY29ubmVjdG9yLmMKPiA+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY29ubmVjdG9yLmMKPiA+IEBAIC0zNSw2
ICszNSwxOCBAQCBzdHJ1Y3Qgb21hcF9jb25uZWN0b3Igewo+ID4gCj4gPiAgCWJvb2wgaGRtaV9t
b2RlOwo+ID4gIAo+ID4gIH07Cj4gPiAKPiA+ICtzdGF0aWMgdm9pZCBvbWFwX2Nvbm5lY3Rvcl9o
cGRfY2Iodm9pZCAqY2JfZGF0YSwKPiA+ICsJCQkJICBlbnVtIGRybV9jb25uZWN0b3Jfc3RhdHVz
IHN0YXR1cykKPiA+ICt7Cj4gPiArCXN0cnVjdCBvbWFwX2Nvbm5lY3RvciAqb21hcF9jb25uZWN0
b3IgPSBjYl9kYXRhOwo+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yID0gJm9t
YXBfY29ubmVjdG9yLT5iYXNlOwo+ID4gKwo+ID4gKwlpZiAoY29ubmVjdG9yLT5zdGF0dXMgIT0g
c3RhdHVzKSB7Cj4gPiArCQljb25uZWN0b3ItPnN0YXR1cyA9IHN0YXR1czsKPiA+ICsJCWRybV9r
bXNfaGVscGVyX2hvdHBsdWdfZXZlbnQob21hcF9jb25uZWN0b3ItPmJhc2UuZGV2KTsKPiA+ICsJ
fQo+ID4gK30KPiAKPiBJJ20gbm90IHN1cmUgaWYgdGhpcyBpcyByYWN5IG9yIG5vdC4uLiBkcm1f
a21zX2hlbHBlcl9ob3RwbHVnX2V2ZW50KCkKPiBzaG91bGQgYmUgY2FsbGVkIHdpdGhvdXQgbG9j
a3MgaGVsZCwgYnV0IGlzIGl0IHNhZmUgdG8gdG91Y2gKPiBjb25uZWN0b3ItPnN0YXR1cyB3aXRo
b3V0IGFueSBsb2Nrcz8KCldlIHNob3VsZCBhdCBsZWFzdCBwcm90ZWN0IGFnYWluc3QgaW50ZXJu
YWwgcmFjZSBjb25kaXRpb25zIGlmIHRoZSBocGQgCmNhbGxiYWNrIGNhbiBiZSBjYWxsZWQgY29u
Y3VycmVudGx5IChJIGhhdmVuJ3QgY2hlY2tlZCB0aGUgY2FsbGVycyB5ZXQpLiBJIAp0aGluayBp
dCB3b3VsZCBiZSBzYWZlciB0byB1c2UgdGhlIG1vZGVfY29uZmlnIG11dGV4IHRoZSBzYW1lIHdh
eSAKZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkgZG9lcy4gU29tZXRoaW5nIGxpa2UgdGhlIGZv
bGxvd2luZyBzaG91bGQgZG8uCgoJc3RydWN0IG9tYXBfY29ubmVjdG9yICpvbWFwX2Nvbm5lY3Rv
ciA9IGNiX2RhdGE7CglzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yID0gJm9tYXBfY29u
bmVjdG9yLT5iYXNlOwoJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+ZGV2OwoJ
ZW51bSBkcm1fY29ubmVjdG9yX3N0YXR1cyBvbGRfc3RhdHVzOwoKCW11dGV4X2xvY2soJmRldi0+
bW9kZV9jb25maWcubXV0ZXgpOwoJb2xkX3N0YXR1cyA9IGNvbm5lY3Rvci0+c3RhdHVzOwoJY29u
bmVjdG9yLT5zdGF0dXMgPSBzdGF0dXM7CgltdXRleF91bmxvY2soJmRldi0+bW9kZV9jb25maWcu
bXV0ZXgpOwoKCWlmIChvbGRfc3RhdHVzICE9IHN0YXR1cykKCQlkcm1fa21zX2hlbHBlcl9ob3Rw
bHVnX2V2ZW50KGRldik7Cgo+ID4gKwlpZiAoY29ubmVjdG9yLT5zdGF0dXMgIT0gc3RhdHVzKSB7
Cj4gPiArCQljb25uZWN0b3ItPnN0YXR1cyA9IHN0YXR1czsKPiA+ICsJCWRybV9rbXNfaGVscGVy
X2hvdHBsdWdfZXZlbnQob21hcF9jb25uZWN0b3ItPmJhc2UuZGV2KTsKPiA+ICsJfQo+ID4gKwo+
ID4gIGJvb2wgb21hcF9jb25uZWN0b3JfZ2V0X2hkbWlfbW9kZShzdHJ1Y3QgZHJtX2Nvbm5lY3Rv
ciAqY29ubmVjdG9yKQo+ID4gIHsKPiA+ICAJc3RydWN0IG9tYXBfY29ubmVjdG9yICpvbWFwX2Nv
bm5lY3RvciA9IHRvX29tYXBfY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gPiBAQCAtNzUsNiArODcs
MTAgQEAgc3RhdGljIHZvaWQgb21hcF9jb25uZWN0b3JfZGVzdHJveShzdHJ1Y3QgZHJtX2Nvbm5l
Y3Rvcgo+ID4gKmNvbm5lY3RvcikKPiA+ICAJc3RydWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2
ID0gb21hcF9jb25uZWN0b3ItPmRzc2RldjsKPiA+ICAJCj4gPiAgCURCRygiJXMiLCBvbWFwX2Nv
bm5lY3Rvci0+ZHNzZGV2LT5uYW1lKTsKPiA+ICsJaWYgKGNvbm5lY3Rvci0+cG9sbGVkID09IERS
TV9DT05ORUNUT1JfUE9MTF9IUEQgJiYKPiA+ICsJICAgIGRzc2Rldi0+ZHJpdmVyLT51bnJlZ2lz
dGVyX2hwZF9jYikgewo+ID4gKwkJZHNzZGV2LT5kcml2ZXItPnVucmVnaXN0ZXJfaHBkX2NiKGRz
c2Rldik7Cj4gPiArCX0KPiA+ICAJZHJtX2Nvbm5lY3Rvcl91bnJlZ2lzdGVyKGNvbm5lY3Rvcik7
Cj4gPiAgCWRybV9jb25uZWN0b3JfY2xlYW51cChjb25uZWN0b3IpOwo+ID4gIAlrZnJlZShvbWFw
X2Nvbm5lY3Rvcik7Cj4gPiBAQCAtMjE2LDYgKzIzMiw3IEBAIHN0cnVjdCBkcm1fY29ubmVjdG9y
ICpvbWFwX2Nvbm5lY3Rvcl9pbml0KHN0cnVjdAo+ID4gZHJtX2RldmljZSAqZGV2LAo+ID4gIHsK
PiA+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciA9IE5VTEw7Cj4gPiAgCXN0cnVj
dCBvbWFwX2Nvbm5lY3RvciAqb21hcF9jb25uZWN0b3I7Cj4gPiArCWJvb2wgaHBkX3N1cHBvcnRl
ZCA9IGZhbHNlOwo+ID4gCj4gPiAgCURCRygiJXMiLCBkc3NkZXYtPm5hbWUpOwo+ID4gCj4gPiBA
QCAtMjMzLDcgKzI1MCwyMCBAQCBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqb21hcF9jb25uZWN0b3Jf
aW5pdChzdHJ1Y3QKPiA+IGRybV9kZXZpY2UgKmRldiwKPiA+ICAJCQkJY29ubmVjdG9yX3R5cGUp
Owo+ID4gIAkKPiA+ICAJZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfYWRkKGNvbm5lY3RvciwgJm9tYXBf
Y29ubmVjdG9yX2hlbHBlcl9mdW5jcyk7Cj4gPiAKPiA+IC0JaWYgKGRzc2Rldi0+ZHJpdmVyLT5k
ZXRlY3QpCj4gPiArCWlmIChkc3NkZXYtPmRyaXZlci0+cmVnaXN0ZXJfaHBkX2NiKSB7Cj4gPiAr
CQlpbnQgcmV0ID0gZHNzZGV2LT5kcml2ZXItPnJlZ2lzdGVyX2hwZF9jYihkc3NkZXYsCj4gPiAr
CQkJCQkJCSAgCm9tYXBfY29ubmVjdG9yX2hwZF9jYiwKPiA+ICsJCQkJCQkJICBvbWFwX2Nvbm5l
Y3Rvcik7Cj4gPiArCQlpZiAoIXJldCkKPiA+ICsJCQlocGRfc3VwcG9ydGVkID0gdHJ1ZTsKPiA+
ICsJCWVsc2UgaWYgKHJldCAhPSAtRU5PVFNVUFApCj4gPiArCQkJREJHKCIlczogRmFpbGVkIHRv
IHJlZ2lzdGVyIEhQRCBjYWxsYmFjayAoJWQpLiIsCj4gPiArCQkJICAgIGRzc2Rldi0+bmFtZSwg
cmV0KTsKPiAKPiBUaGlzIHNob3VsZCBiZSBhbiBlcnJvciBwcmludCwgc2hvdWxkbid0IGl0PwoK
Q2FuIGl0IGFjdHVhbGx5IGhhcHBlbiA/IElmIGl0IGNhbid0LCBJIHdvdWxkbid0IGJvdGhlciB3
aXRoIGEgbWVzc2FnZSBhdCBhbGwuCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt
YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz
LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1030295AbdEWJfu (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 May 2017 05:35:50 -0400
Received: from galahad.ideasonboard.com ([185.26.127.97]:46214 "EHLO
        galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758581AbdEWJfp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 May 2017 05:35:45 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>, airlied@linux.ie,
        jsarha@ti.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/omap: Support for HDMI hot plug detection
Date: Tue, 23 May 2017 12:36 +0300
Message-ID: <1568350.O9b0OEWcFy@avalon>
User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.32; x86_64; ; )
In-Reply-To: <817d3ce9-f189-f8d3-1764-7701e8412af6@ti.com>
References: <20170515090312.32051-1-peter.ujfalusi@ti.com> <20170515090312.32051-2-peter.ujfalusi@ti.com> <817d3ce9-f189-f8d3-1764-7701e8412af6@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tomi,

On Monday 22 May 2017 14:59:09 Tomi Valkeinen wrote:
> On 15/05/17 12:03, Peter Ujfalusi wrote:
> > The HPD signal can be used for detecting HDMI cable plug and unplug event
> > without the need for polling the status of the line.
> > This will speed up detecting such event because we do not need to wait for
> > the next poll event to notice the state change.
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > ---
> > 
> >  drivers/gpu/drm/omapdrm/dss/omapdss.h    | 17 +++++++++++++++++
> >  drivers/gpu/drm/omapdrm/omap_connector.c | 32 ++++++++++++++++++++++++++-
> >  drivers/gpu/drm/omapdrm/omap_drv.c       | 29 ++++++++++++++++++++++++++
> >  3 files changed, 77 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> > b/drivers/gpu/drm/omapdrm/dss/omapdss.h index b19dae1fd6c5..1f01669eb610
> > 100644
> > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> > @@ -25,6 +25,7 @@
> > 
> >  #include <video/videomode.h>
> >  #include <linux/platform_data/omapdss.h>
> >  #include <uapi/drm/drm_mode.h>
> > 
> > +#include <drm/drm_crtc.h>
> > 
> >  #define DISPC_IRQ_FRAMEDONE		(1 << 0)
> >  #define DISPC_IRQ_VSYNC			(1 << 1)
> > 
> > @@ -555,6 +556,14 @@ struct omapdss_hdmi_ops {
> > 
> >  	int (*read_edid)(struct omap_dss_device *dssdev, u8 *buf, int len);
> >  	bool (*detect)(struct omap_dss_device *dssdev);
> > 
> > +	int (*register_hpd_cb)(struct omap_dss_device *dssdev,
> > +			       void (*cb)(void *cb_data,
> > +					  enum drm_connector_status status),
> > +			       void *cb_data);
> > +	void (*unregister_hpd_cb)(struct omap_dss_device *dssdev);
> > +	void (*enable_hpd)(struct omap_dss_device *dssdev);
> > +	void (*disable_hpd)(struct omap_dss_device *dssdev);
> > +
> > 
> >  	int (*set_hdmi_mode)(struct omap_dss_device *dssdev, bool hdmi_mode);
> >  	int (*set_infoframe)(struct omap_dss_device *dssdev,
> >  	
> >  		const struct hdmi_avi_infoframe *avi);
> > 
> > @@ -761,6 +770,14 @@ struct omap_dss_driver {
> > 
> >  	int (*read_edid)(struct omap_dss_device *dssdev, u8 *buf, int len);
> >  	bool (*detect)(struct omap_dss_device *dssdev);
> > 
> > +	int (*register_hpd_cb)(struct omap_dss_device *dssdev,
> > +			       void (*cb)(void *cb_data,
> > +					  enum drm_connector_status status),
> > +			       void *cb_data);
> > +	void (*unregister_hpd_cb)(struct omap_dss_device *dssdev);
> > +	void (*enable_hpd)(struct omap_dss_device *dssdev);
> > +	void (*disable_hpd)(struct omap_dss_device *dssdev);
> > +
> > 
> >  	int (*set_hdmi_mode)(struct omap_dss_device *dssdev, bool hdmi_mode);
> >  	int (*set_hdmi_infoframe)(struct omap_dss_device *dssdev,
> >  	
> >  		const struct hdmi_avi_infoframe *avi);
> > 
> > diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c
> > b/drivers/gpu/drm/omapdrm/omap_connector.c index
> > c24b6b783e9a..5219e340ed9d 100644
> > --- a/drivers/gpu/drm/omapdrm/omap_connector.c
> > +++ b/drivers/gpu/drm/omapdrm/omap_connector.c
> > @@ -35,6 +35,18 @@ struct omap_connector {
> > 
> >  	bool hdmi_mode;
> >  
> >  };
> > 
> > +static void omap_connector_hpd_cb(void *cb_data,
> > +				  enum drm_connector_status status)
> > +{
> > +	struct omap_connector *omap_connector = cb_data;
> > +	struct drm_connector *connector = &omap_connector->base;
> > +
> > +	if (connector->status != status) {
> > +		connector->status = status;
> > +		drm_kms_helper_hotplug_event(omap_connector->base.dev);
> > +	}
> > +}
> 
> I'm not sure if this is racy or not... drm_kms_helper_hotplug_event()
> should be called without locks held, but is it safe to touch
> connector->status without any locks?

We should at least protect against internal race conditions if the hpd 
callback can be called concurrently (I haven't checked the callers yet). I 
think it would be safer to use the mode_config mutex the same way 
drm_helper_hpd_irq_event() does. Something like the following should do.

	struct omap_connector *omap_connector = cb_data;
	struct drm_connector *connector = &omap_connector->base;
	struct drm_device *dev = connector->dev;
	enum drm_connector_status old_status;

	mutex_lock(&dev->mode_config.mutex);
	old_status = connector->status;
	connector->status = status;
	mutex_unlock(&dev->mode_config.mutex);

	if (old_status != status)
		drm_kms_helper_hotplug_event(dev);

> > +	if (connector->status != status) {
> > +		connector->status = status;
> > +		drm_kms_helper_hotplug_event(omap_connector->base.dev);
> > +	}
> > +
> >  bool omap_connector_get_hdmi_mode(struct drm_connector *connector)
> >  {
> >  	struct omap_connector *omap_connector = to_omap_connector(connector);
> > @@ -75,6 +87,10 @@ static void omap_connector_destroy(struct drm_connector
> > *connector)
> >  	struct omap_dss_device *dssdev = omap_connector->dssdev;
> >  	
> >  	DBG("%s", omap_connector->dssdev->name);
> > +	if (connector->polled == DRM_CONNECTOR_POLL_HPD &&
> > +	    dssdev->driver->unregister_hpd_cb) {
> > +		dssdev->driver->unregister_hpd_cb(dssdev);
> > +	}
> >  	drm_connector_unregister(connector);
> >  	drm_connector_cleanup(connector);
> >  	kfree(omap_connector);
> > @@ -216,6 +232,7 @@ struct drm_connector *omap_connector_init(struct
> > drm_device *dev,
> >  {
> >  	struct drm_connector *connector = NULL;
> >  	struct omap_connector *omap_connector;
> > +	bool hpd_supported = false;
> > 
> >  	DBG("%s", dssdev->name);
> > 
> > @@ -233,7 +250,20 @@ struct drm_connector *omap_connector_init(struct
> > drm_device *dev,
> >  				connector_type);
> >  	
> >  	drm_connector_helper_add(connector, &omap_connector_helper_funcs);
> > 
> > -	if (dssdev->driver->detect)
> > +	if (dssdev->driver->register_hpd_cb) {
> > +		int ret = dssdev->driver->register_hpd_cb(dssdev,
> > +							  
omap_connector_hpd_cb,
> > +							  omap_connector);
> > +		if (!ret)
> > +			hpd_supported = true;
> > +		else if (ret != -ENOTSUPP)
> > +			DBG("%s: Failed to register HPD callback (%d).",
> > +			    dssdev->name, ret);
> 
> This should be an error print, shouldn't it?

Can it actually happen ? If it can't, I wouldn't bother with a message at all.

-- 
Regards,

Laurent Pinchart