All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3] net/if-mtu-change.sh: set LTP_TIMEOUT
Date: Fri, 13 Sep 2019 12:00:12 +0200	[thread overview]
Message-ID: <1568368812.3306.7.camel@suse.de> (raw)
In-Reply-To: <20190912201318.30931-4-pvorel@suse.cz>

On Thu, 2019-09-12 at 22:13 +0200, Petr Vorel wrote:
> The default setup (100 * 5 seconds just for sleep) is longer than
> default timeout.
> 30 sec for each iteration should be more than enough as a default.
> 
> Fixes: fbea02ab5 ("lib/tst_test.sh: setup timeout per test run for
> the shell tests")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/stress/interface/if-mtu-change.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/network/stress/interface/if-mtu-change.sh
> b/testcases/network/stress/interface/if-mtu-change.sh
> index 30c013214..a1113f714 100755
> --- a/testcases/network/stress/interface/if-mtu-change.sh
> +++ b/testcases/network/stress/interface/if-mtu-change.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0-or-later
> -# Copyright (c) 2017-2018 Petr Vorel <pvorel@suse.cz>
> +# Copyright (c) 2017-2019 Petr Vorel <pvorel@suse.cz>
>  # Copyright (c) 2015-2017 Oracle and/or its affiliates. All Rights
> Reserved.
>  # Copyright (c) International Business Machines  Corp., 2005
>  # Author: Mitsuru Chinen <mitch@jp.ibm.com>
> @@ -13,6 +13,8 @@ TST_CLEANUP="do_cleanup"
>  # The interval of the mtu change [second]
>  CHANGE_INTERVAL=${CHANGE_INTERVAL:-5}
>  
> +LTP_TIMEOUT=$(((CHANGE_INTERVAL + 30) * MTU_CHANGE_TIMES))

   ^
   TST_TIMEOUT

At least I would go with TST_ instead of LTP_ as the prefix TST_ means
for me Libray and LTP_ user. This apply to some other places of this
patchset.


> +
>  # The array of the value which MTU is changed into sequentially
>  # 552 - net.ipv4.route.min_pmtu
>  CHANGE_VALUES="784 1142 552 1500 552 1500 552 748 552 1142 1500"

  reply	other threads:[~2019-09-13 10:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 20:13 [LTP] [PATCH 0/3] LTP_TIMEOUT for shell API Petr Vorel
2019-09-12 20:13 ` [LTP] [PATCH 1/3] shell: Add tst_is_num() Petr Vorel
2019-09-12 20:13 ` [LTP] [PATCH 2/3] shell: Introduce LTP_TIMEOUT variable Petr Vorel
2019-09-13 10:26   ` Cristian Marussi
2019-09-13 10:46     ` Petr Vorel
2019-09-12 20:13 ` [LTP] [PATCH 3/3] net/if-mtu-change.sh: set LTP_TIMEOUT Petr Vorel
2019-09-13 10:00   ` Clemens Famulla-Conrad [this message]
2019-09-13 10:41     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1568368812.3306.7.camel@suse.de \
    --to=cfamullaconrad@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.