From: Thomas Monjalon <thomas@monjalon.net>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: stable@dpdk.org, Rami Rosen <ramirose@gmail.com>,
dev <dev@dpdk.org>, "Rosen, Rami" <rami.rosen@intel.com>,
bruce.richardson@intel.com
Subject: Re: [dpdk-stable] [PATCH] test: fix build when pdump config is disabled
Date: Wed, 27 Mar 2019 01:08:58 +0100 [thread overview]
Message-ID: <1568544.Edi8VMo79k@xps> (raw)
In-Reply-To: <CAHLOa7QJrPCyp6mJAhLaMQF21pT86YTjbpVe8J8fzvJUHzb=kg@mail.gmail.com>
20/03/2019 16:17, Rami Rosen:
> pdump unit test has dependency on pthread code
> in test.c and process.h to run send_pkts(),
> this code should be enabled only when
> CONFIG_RTE_LIBRTE_PDUMP is enabled.
>
> Bugzilla ID: 222
>
> Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> +1
>
> Checked when CONFIG_RTE_LIBRTE_PDUMP=n
> with latest code from master, build completes succesfully
>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks
Note that such #ifdef will be removed when the "make build system"
will be removed from DPDK (far target).
prev parent reply other threads:[~2019-03-27 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 11:33 [PATCH] test: fix build when pdump config is disabled Reshma Pattan
2019-03-20 15:17 ` Rami Rosen
2019-03-27 0:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568544.Edi8VMo79k@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rami.rosen@intel.com \
--cc=ramirose@gmail.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.