From: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 0/3] LTP_TIMEOUT for shell API
Date: Mon, 16 Sep 2019 12:37:55 +0200 [thread overview]
Message-ID: <1568630275.3028.23.camel@suse.de> (raw)
In-Reply-To: <20190913125823.17314-1-pvorel@suse.cz>
On Fri, 2019-09-13 at 14:58 +0200, Petr Vorel wrote:
<snip>
> Questions:
> * I don't know how to detect TST_TIMEOUT settings made by user.
> That's
> the difference from C, where user cannot overwrite tst_test->test.
> Am I missing something or it's not possible to detect whether
> variable
> was set in code or by user?
> Maybe that was the reason TST_TIMEOUT wasn't set, but rather fixed.
Maybe we could initialize all variables in tst_test.sh. So we overwrite
values given by user/environment. But I in general I think, if someone
play with TST_* variables, it's up to him what happen.
And you already added this WARNING!
> * Code allowing $LTP_TIMEOUT_MUL being also float making code a bit
> complex. If you don't like it, I suggest to change $LTP_TIMEOUT_MUL
> being for both C and shell integer, but I'd prefer the possibility to
> be float.
> (it's might be handy being able to set timeout 1.33x which is far
> less
> than 2x for int).
I also don't see the need of such fine granular multiplier.
next prev parent reply other threads:[~2019-09-16 10:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 12:58 [LTP] [PATCH v2 0/3] LTP_TIMEOUT for shell API Petr Vorel
2019-09-13 12:58 ` [LTP] [PATCH v2 1/3] shell: Add tst_is_num() Petr Vorel
2019-09-13 12:58 ` [LTP] [PATCH v2 2/3] shell: Introduce TST_TIMEOUT variable Petr Vorel
2019-09-16 10:15 ` Li Wang
2019-09-17 16:55 ` Petr Vorel
2019-09-18 3:21 ` Li Wang
2019-09-18 8:24 ` Petr Vorel
2019-09-18 8:46 ` Li Wang
2019-09-18 9:50 ` Petr Vorel
2019-09-18 10:14 ` Li Wang
2019-09-18 13:53 ` Petr Vorel
2019-09-18 17:19 ` Clemens Famulla-Conrad
2019-09-16 10:26 ` Clemens Famulla-Conrad
2019-09-18 9:40 ` Petr Vorel
2019-09-18 17:16 ` Clemens Famulla-Conrad
2019-09-13 12:58 ` [LTP] [PATCH v2 3/3] net/if-mtu-change.sh: set TST_TIMEOUT Petr Vorel
2019-09-16 10:37 ` Clemens Famulla-Conrad [this message]
2019-09-17 11:22 ` [LTP] [PATCH v2 0/3] LTP_TIMEOUT for shell API Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568630275.3028.23.camel@suse.de \
--to=cfamullaconrad@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.