From: Derrick Stolee <derrickstolee@github.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 0/5] plugging some list-objects-filter leaks
Date: Fri, 9 Sep 2022 10:20:37 -0400 [thread overview]
Message-ID: <15688f6a-4757-e201-9106-663899e35fec@github.com> (raw)
In-Reply-To: <Yxl1BNQoy6Drf0Oe@coredump.intra.peff.net>
On 9/8/2022 12:52 AM, Jeff King wrote:
> The test I sent earlier in [1] fails the linux-leaks CI job, not because
> it introduces new leaks, but just because it runs existing leaks in a
> test marked as passing-leaks.
>
> Of course we can drop the passing flag, but I figured it would probably
> be an easy fix. Famous last words. It turned into quite a rabbit hole of
> actual leaks (albeit small and bounded per process) and some
> questionable memory ownership semantics.
Reading the patches, you make good arguments about the various trade-
offs in these sticky places. I agree with you in all cases, mostly
because the alternatives would not be any better unless we did a _lot_
of work to rewrite a lot more code than these patches. Even then, the
benefit is unclear.
> Here's the series I came up with. I'm cc-ing Stolee as the last person
> unfortunate enough to have touched this area. :)
Lucky me!
These patches look good. Thanks!
-Stolee
next prev parent reply other threads:[~2022-09-09 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 4:52 [PATCH 0/5] plugging some list-objects-filter leaks Jeff King
2022-09-08 4:54 ` [PATCH 1/5] list_objects_filter_copy(): deep-copy sparse_oid_name field Jeff King
2022-09-08 4:57 ` [PATCH 2/5] transport: deep-copy object-filter struct for fetch-pack Jeff King
2022-09-08 4:58 ` [PATCH 3/5] transport: free filter options in disconnect_git() Jeff King
2022-09-08 5:01 ` [PATCH 4/5] list_objects_filter_options: plug leak of filter_spec strings Jeff King
2022-09-08 5:02 ` [PATCH 5/5] prepare_repo_settings(): plug leak of config values Jeff King
2022-09-09 14:20 ` Derrick Stolee [this message]
2022-09-11 4:51 ` [PATCH 0/5] plugging some list-objects-filter leaks Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15688f6a-4757-e201-9106-663899e35fec@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.