From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Apelete Seketeli <apelete@seketeli.net>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-handheld][PATCH 2/2] ben-nanonote: add DEFAULTTUNE to machine configuration
Date: Fri, 05 Apr 2013 07:57:08 +0100 [thread overview]
Message-ID: <1569197.3RlpYsjGQj@helios> (raw)
In-Reply-To: <001217b18cb77bef28e080695cac129da1800937.1365116038.git.apelete@seketeli.net>
Hi Apelete,
On Friday 05 April 2013 07:37:55 Apelete Seketeli wrote:
> Add DEFAULTTUNE to machine configuration to ensure that the correct
> tune features are selected by default.
>
> Signed-off-by: Apelete Seketeli <apelete@seketeli.net>
> ---
> conf/machine/ben-nanonote.conf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/conf/machine/ben-nanonote.conf b/conf/machine/ben-nanonote.conf
> index 1ce5815..275dff9 100644
> --- a/conf/machine/ben-nanonote.conf
> +++ b/conf/machine/ben-nanonote.conf
> @@ -3,6 +3,7 @@
> #@DESCRIPTION: Machine configuration for the Qi-Hardware's Ben Nanonote
>
> require conf/machine/include/tune-mips32.inc
> +DEFAULTTUNE = "mips32el-nf"
>
> PREFERRED_PROVIDER_virtual/kernel = "linux-jlime-ben-nanonote"
There was a discussion just the other day on this mailing list; setting
DEFAULTTUNE is considered the province of distro configuration and thus
shouldn't be in the machine config:
http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-April/044719.html
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2013-04-05 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 5:37 [meta-handheld][PATCH 0/2] Pull request 20130405 Apelete Seketeli
2013-04-05 5:37 ` [meta-handheld][PATCH 1/2] linux-jlime-ben-nanonote: fix build errors Apelete Seketeli
2013-04-05 5:37 ` [meta-handheld][PATCH 2/2] ben-nanonote: add DEFAULTTUNE to machine configuration Apelete Seketeli
2013-04-05 6:57 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569197.3RlpYsjGQj@helios \
--to=paul.eggleton@linux.intel.com \
--cc=apelete@seketeli.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.