diff for duplicates of <1569751.q5lJmQcb3K@avalon> diff --git a/a/1.txt b/N1/1.txt index b1b97f3..a83b6c4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -78,7 +78,7 @@ There's one large missing piece here: the DT bindings documentation. I would declare the table as static const outside of this function. > + -> + if (strcmp(name, "pll") = 0) { +> + if (strcmp(name, "pll") == 0) { > + /* FIXME: cpg_mode should be read from GPIO. But no GPIO support yet */ > + unsigned cpg_mode = 0; /* hardcoded to EXTAL for now */ @@ -103,9 +103,9 @@ two parents). > + * and the constraint that always g <= i. To get the rz platform started, > + * let them run at fixed current speed and implement the details later. > + */ -> + if (strcmp(name, "i") = 0) +> + if (strcmp(name, "i") == 0) > + val = (clk_readl(cpg->reg + CPG_FRQCR) >> 8) & 3; -> + else if (strcmp(name, "g") = 0) +> + else if (strcmp(name, "g") == 0) > + val = clk_readl(cpg->reg + CPG_FRQCR2) & 3; The registers are 16 bits wide, are 32 bits accessed valid ? I suppose they @@ -133,7 +133,7 @@ unsigned int maybe ? I'm not sure what the preferred kernel coding style is. Do such failures really deserve a WARN ? Isn't a pr_err() enough ? -What if num_clks = 0 ? +What if num_clks == 0 ? > + goto out; > + diff --git a/a/content_digest b/N1/content_digest index 66e8ece..6519380 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01393621768-12568-1-git-send-email-wsa@the-dreams.de\0" "ref\01393621768-12568-4-git-send-email-wsa@the-dreams.de\0" - "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" - "Subject\0Re: [PATCH 3/4] clk: shmobile: add CPG driver for rz-platforms\0" - "Date\0Sun, 02 Mar 2014 22:15:40 +0000\0" + "From\0laurent.pinchart@ideasonboard.com (Laurent Pinchart)\0" + "Subject\0[PATCH 3/4] clk: shmobile: add CPG driver for rz-platforms\0" + "Date\0Sun, 02 Mar 2014 23:15:40 +0100\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -86,7 +86,7 @@ "I would declare the table as static const outside of this function.\n" "\n" "> +\n" - "> +\tif (strcmp(name, \"pll\") = 0) {\n" + "> +\tif (strcmp(name, \"pll\") == 0) {\n" "> +\t\t/* FIXME: cpg_mode should be read from GPIO. But no GPIO support yet \n" "*/\n" "> +\t\tunsigned cpg_mode = 0; /* hardcoded to EXTAL for now */\n" @@ -111,9 +111,9 @@ "> +\t * and the constraint that always g <= i. To get the rz platform started,\n" "> +\t * let them run at fixed current speed and implement the details later.\n" "> +\t */\n" - "> +\tif (strcmp(name, \"i\") = 0)\n" + "> +\tif (strcmp(name, \"i\") == 0)\n" "> +\t\tval = (clk_readl(cpg->reg + CPG_FRQCR) >> 8) & 3;\n" - "> +\telse if (strcmp(name, \"g\") = 0)\n" + "> +\telse if (strcmp(name, \"g\") == 0)\n" "> +\t\tval = clk_readl(cpg->reg + CPG_FRQCR2) & 3;\n" "\n" "The registers are 16 bits wide, are 32 bits accessed valid ? I suppose they \n" @@ -141,7 +141,7 @@ "\n" "Do such failures really deserve a WARN ? Isn't a pr_err() enough ?\n" "\n" - "What if num_clks = 0 ?\n" + "What if num_clks == 0 ?\n" "\n" "> +\t\tgoto out;\n" "> +\n" @@ -200,4 +200,4 @@ "\n" Laurent Pinchart -8f0886721934fcb5c20063cb1c7d8f1050fcd2dacf6d3e5c85036e23174eef0b +aa719c9649723f5a40049889acb0a55584bc0455a25796ec38234bc045a9b4e4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.