From: Edward Cree <ecree.xilinx@gmail.com>
To: Marcelo Leitner <mleitner@redhat.com>,
Tianyu Yuan <tianyu.yuan@corigine.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Simon Horman <simon.horman@corigine.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Davide Caratti <dcaratti@redhat.com>,
Edward Cree <edward.cree@amd.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>, Oz Shlomo <ozsh@nvidia.com>,
Paul Blakey <paulb@nvidia.com>, Vlad Buslov <vladbu@nvidia.com>,
"dev@openvswitch.org" <dev@openvswitch.org>,
oss-drivers <oss-drivers@corigine.com>,
Ziyang Chen <ziyang.chen@corigine.com>
Subject: Re: [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE when offloading
Date: Tue, 29 Nov 2022 08:43:07 +0000 [thread overview]
Message-ID: <156aaabc-a7f6-e7e6-eb0b-d8943f212c1f@gmail.com> (raw)
In-Reply-To: <CALnP8ZanoC6C6Xb-14fy6em8ZJaFnk+78ufOdb=gBfMn-ce2eA@mail.gmail.com>
On 28/11/2022 13:11, Marcelo Leitner wrote:
> Exactly. Then, when this patchset (or similar) come up, it won't
> update all actions with the same stats anymore. It will require a set
> of stats from hw for the gact with PIPE action here. But if drivers
> are ignoring this action, they can't have specific stats for it. Or am
> I missing something?
>
> So it is better for the drivers to reject the whole flow instead of
> simply ignoring it, and let vswitchd probe if it should or should not
> use this action.
I agree. Drivers should only accept a flow with a 'gact pipe' action
if they are able to perform the stats offload it requests.
Getting userland to autodiscover whether it can make use of this is a
SMOP, better than having it always try to use it and then sometimes
get confused that the resulting stats are wrong or meaningless.
-ed
next prev parent reply other threads:[~2022-11-29 8:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 11:20 [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE when offloading Simon Horman
2022-11-24 23:45 ` Jamal Hadi Salim
2022-11-25 3:10 ` Tianyu Yuan
2022-11-25 12:31 ` Vlad Buslov
2022-11-25 12:49 ` [PATCH] tc: allow gact pipe action offload Vlad Buslov
2022-11-25 14:19 ` [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE when offloading Marcelo Leitner
2022-11-25 14:32 ` Eelco Chaudron
2022-11-28 7:18 ` Tianyu Yuan
2022-11-28 9:11 ` Eelco Chaudron
2022-11-28 7:11 ` Tianyu Yuan
2022-11-28 13:11 ` Marcelo Leitner
2022-11-28 13:17 ` Eelco Chaudron
2022-11-28 13:33 ` Marcelo Leitner
2022-11-29 12:35 ` Eelco Chaudron
2022-11-30 3:36 ` Tianyu Yuan
2022-11-30 18:05 ` Marcelo Leitner
2022-12-01 3:52 ` Tianyu Yuan
2022-12-02 12:17 ` Eelco Chaudron
2022-12-02 12:33 ` Tianyu Yuan
2022-12-02 12:39 ` Eelco Chaudron
2023-01-29 8:16 ` Tianyu Yuan
2022-11-29 8:43 ` Edward Cree [this message]
[not found] ` <CAM0EoMnw57gVb+niRzZ-QYefey4TuhFZwnVs3P53_jo60d8Efg@mail.gmail.com>
[not found] ` <PH0PR13MB47931C1CBABDD4113275A2A994139@PH0PR13MB4793.namprd13.prod.outlook.com>
2022-11-28 11:35 ` Jamal Hadi Salim
2022-11-29 7:32 ` Tianyu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156aaabc-a7f6-e7e6-eb0b-d8943f212c1f@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=dcaratti@redhat.com \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edward.cree@amd.com \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=ozsh@nvidia.com \
--cc=paulb@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=tianyu.yuan@corigine.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
--cc=ziyang.chen@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.