From mboxrd@z Thu Jan 1 00:00:00 1970 From: Walter Wu Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y Date: Wed, 2 Oct 2019 20:15:13 +0800 Message-ID: <1570018513.19702.36.camel@mtksdccf07> References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1569818173.17361.19.camel@mtksdccf07> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Vyukov Cc: Andrey Ryabinin , Alexander Potapenko , Matthias Brugger , LKML , kasan-dev , Linux-MM , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream List-Id: linux-mediatek@lists.infradead.org On Mon, 2019-09-30 at 12:36 +0800, Walter Wu wrote: > On Fri, 2019-09-27 at 21:41 +0200, Dmitry Vyukov wrote: > > On Fri, Sep 27, 2019 at 4:22 PM Walter Wu wrote: > > > > > > On Fri, 2019-09-27 at 15:07 +0200, Dmitry Vyukov wrote: > > > > On Fri, Sep 27, 2019 at 5:43 AM Walter Wu wrote: > > > > > > > > > > memmove() and memcpy() have missing underflow issues. > > > > > When -7 <= size < 0, then KASAN will miss to catch the underflow issue. > > > > > It looks like shadow start address and shadow end address is the same, > > > > > so it does not actually check anything. > > > > > > > > > > The following test is indeed not caught by KASAN: > > > > > > > > > > char *p = kmalloc(64, GFP_KERNEL); > > > > > memset((char *)p, 0, 64); > > > > > memmove((char *)p, (char *)p + 4, -2); > > > > > kfree((char*)p); > > > > > > > > > > It should be checked here: > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > { > > > > > check_memory_region((unsigned long)src, len, false, _RET_IP_); > > > > > check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > > > > > > > > > return __memmove(dest, src, len); > > > > > } > > > > > > > > > > We fix the shadow end address which is calculated, then generic KASAN > > > > > get the right shadow end address and detect this underflow issue. > > > > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=199341 > > > > > > > > > > Signed-off-by: Walter Wu > > > > > Reported-by: Dmitry Vyukov > > > > > --- > > > > > lib/test_kasan.c | 36 ++++++++++++++++++++++++++++++++++++ > > > > > mm/kasan/generic.c | 8 ++++++-- > > > > > 2 files changed, 42 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > > > > index b63b367a94e8..8bd014852556 100644 > > > > > --- a/lib/test_kasan.c > > > > > +++ b/lib/test_kasan.c > > > > > @@ -280,6 +280,40 @@ static noinline void __init kmalloc_oob_in_memset(void) > > > > > kfree(ptr); > > > > > } > > > > > > > > > > +static noinline void __init kmalloc_oob_in_memmove_underflow(void) > > > > > +{ > > > > > + char *ptr; > > > > > + size_t size = 64; > > > > > + > > > > > + pr_info("underflow out-of-bounds in memmove\n"); > > > > > + ptr = kmalloc(size, GFP_KERNEL); > > > > > + if (!ptr) { > > > > > + pr_err("Allocation failed\n"); > > > > > + return; > > > > > + } > > > > > + > > > > > + memset((char *)ptr, 0, 64); > > > > > + memmove((char *)ptr, (char *)ptr + 4, -2); > > > > > + kfree(ptr); > > > > > +} > > > > > + > > > > > +static noinline void __init kmalloc_oob_in_memmove_overflow(void) > > > > > +{ > > > > > + char *ptr; > > > > > + size_t size = 64; > > > > > + > > > > > + pr_info("overflow out-of-bounds in memmove\n"); > > > > > + ptr = kmalloc(size, GFP_KERNEL); > > > > > + if (!ptr) { > > > > > + pr_err("Allocation failed\n"); > > > > > + return; > > > > > + } > > > > > + > > > > > + memset((char *)ptr, 0, 64); > > > > > + memmove((char *)ptr + size, (char *)ptr, 2); > > > > > + kfree(ptr); > > > > > +} > > > > > + > > > > > static noinline void __init kmalloc_uaf(void) > > > > > { > > > > > char *ptr; > > > > > @@ -734,6 +768,8 @@ static int __init kmalloc_tests_init(void) > > > > > kmalloc_oob_memset_4(); > > > > > kmalloc_oob_memset_8(); > > > > > kmalloc_oob_memset_16(); > > > > > + kmalloc_oob_in_memmove_underflow(); > > > > > + kmalloc_oob_in_memmove_overflow(); > > > > > kmalloc_uaf(); > > > > > kmalloc_uaf_memset(); > > > > > kmalloc_uaf2(); > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > index 616f9dd82d12..34ca23d59e67 100644 > > > > > --- a/mm/kasan/generic.c > > > > > +++ b/mm/kasan/generic.c > > > > > @@ -131,9 +131,13 @@ static __always_inline bool memory_is_poisoned_n(unsigned long addr, > > > > > size_t size) > > > > > { > > > > > unsigned long ret; > > > > > + void *shadow_start = kasan_mem_to_shadow((void *)addr); > > > > > + void *shadow_end = kasan_mem_to_shadow((void *)addr + size - 1) + 1; > > > > > > > > > > - ret = memory_is_nonzero(kasan_mem_to_shadow((void *)addr), > > > > > - kasan_mem_to_shadow((void *)addr + size - 1) + 1); > > > > > + if ((long)size < 0) > > > > > + shadow_end = kasan_mem_to_shadow((void *)addr + size); > > > > > > > > Hi Walter, > > > > > > > > Thanks for working on this. > > > > > > > > If size<0, does it make sense to continue at all? We will still check > > > > 1PB of shadow memory? What happens when we pass such huge range to > > > > memory_is_nonzero? > > > > Perhaps it's better to produce an error and bail out immediately if size<0? > > > > > > I agree with what you said. when size<0, it is indeed an unreasonable > > > behavior, it should be blocked from continuing to do. > > > > > > > > > > Also, what's the failure mode of the tests? Didn't they badly corrupt > > > > memory? We tried to keep tests such that they produce the KASAN > > > > reports, but don't badly corrupt memory b/c/ we need to run all of > > > > them. > > > > > > Maybe we should first produce KASAN reports and then go to execute > > > memmove() or do nothing? It looks like it’s doing the following.or? > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > { > > > + if (long(len) <= 0) > > > > /\/\/\/\/\/\ > > > > This check needs to be inside of check_memory_region, otherwise we > > will have similar problems in all other places that use > > check_memory_region. > Thanks for your reminder. > > bool check_memory_region(unsigned long addr, size_t size, bool write, > unsigned long ret_ip) > { > + if (long(size) < 0) { > + kasan_report_invalid_size(src, dest, len, _RET_IP_); > + return false; > + } > + > return check_memory_region_inline(addr, size, write, ret_ip); > } > > > But check_memory_region already returns a bool, so we could check that > > bool and return early. > > When size<0, we should only show one KASAN report, and should we only > limit to return when size<0 is true? If yse, then __memmove() will do > nothing. > > > void *memmove(void *dest, const void *src, size_t len) > { > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > + if(!check_memory_region((unsigned long)src, len, false, > _RET_IP_) > + && long(size) < 0) > + return; > + > check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > return __memmove(dest, src, len); > > > Hi Dmitry, What do you think the following code is better than the above one. In memmmove/memset/memcpy, they need to determine whether size < 0 is true. we directly determine whether size is negative in memmove and return early. it avoid to generate repeated KASAN report. Is it better? void *memmove(void *dest, const void *src, size_t len) { + if (long(size) < 0) { + kasan_report_invalid_size(src, dest, len, _RET_IP_); + return; + } + check_memory_region((unsigned long)src, len, false, _RET_IP_); check_memory_region((unsigned long)dest, len, true, _RET_IP_); check_memory_region() still has to check whether the size is negative. but memmove/memset/memcpy generate invalid size KASAN report will not be there. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F428C35280 for ; Wed, 2 Oct 2019 12:15:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 250C6218DE for ; Wed, 2 Oct 2019 12:15:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i2i64RFV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 250C6218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ll0MohDyTNDVksUP/QFYqK07tkgoB26XMLXIGGjsymo=; b=i2i64RFVNAfTKk usuKMEjtfGXgYtLL5G1tUzTYkGq/JmjQqQCdePLjECy+3H8iixjxCBE8+Q+77vJXtQayS/RKcOQ1R GN99Yhlz/j28G8f1cAWwVSSxl4roo+M+Wx9/y+DxKrVq9wtaQi0mjhWDBpW8Uh9bRPSEotg4zDaiN zh3l8H6pUdql791IPc6fTxpVBupMfONRAAzTN1uNy0GUU068htslv7ONFNIr22mTD6gq5xOekB4g5 FTGCCstjNcFlx5qiKoXptLGAlI8qv6pmGIoQQjCj9QMOlAnYBwq34qPa+e5cnrOlp2utmJDgGRu2a RPVEYwmsO6WjNv8hNLIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFdXQ-0005aG-Hu; Wed, 02 Oct 2019 12:15:24 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFdXN-0005Yy-CF; Wed, 02 Oct 2019 12:15:23 +0000 X-UUID: f8cdde02a956454086f34a8ef55b5ba2-20191002 X-UUID: f8cdde02a956454086f34a8ef55b5ba2-20191002 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1587389180; Wed, 02 Oct 2019 04:15:14 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 2 Oct 2019 05:15:13 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 2 Oct 2019 20:15:12 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 2 Oct 2019 20:15:11 +0800 Message-ID: <1570018513.19702.36.camel@mtksdccf07> Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y From: Walter Wu To: Dmitry Vyukov Date: Wed, 2 Oct 2019 20:15:13 +0800 In-Reply-To: <1569818173.17361.19.camel@mtksdccf07> References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191002_051521_422968_AD809480 X-CRM114-Status: GOOD ( 34.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream , linux-mediatek@lists.infradead.org, LKML , kasan-dev , Linux-MM , Alexander Potapenko , Matthias Brugger , Andrey Ryabinin , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMDE5LTA5LTMwIGF0IDEyOjM2ICswODAwLCBXYWx0ZXIgV3Ugd3JvdGU6Cj4gT24g RnJpLCAyMDE5LTA5LTI3IGF0IDIxOjQxICswMjAwLCBEbWl0cnkgVnl1a292IHdyb3RlOgo+ID4g T24gRnJpLCBTZXAgMjcsIDIwMTkgYXQgNDoyMiBQTSBXYWx0ZXIgV3UgPHdhbHRlci16aC53dUBt ZWRpYXRlay5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBGcmksIDIwMTktMDktMjcgYXQgMTU6 MDcgKzAyMDAsIERtaXRyeSBWeXVrb3Ygd3JvdGU6Cj4gPiA+ID4gT24gRnJpLCBTZXAgMjcsIDIw MTkgYXQgNTo0MyBBTSBXYWx0ZXIgV3UgPHdhbHRlci16aC53dUBtZWRpYXRlay5jb20+IHdyb3Rl Ogo+ID4gPiA+ID4KPiA+ID4gPiA+IG1lbW1vdmUoKSBhbmQgbWVtY3B5KCkgaGF2ZSBtaXNzaW5n IHVuZGVyZmxvdyBpc3N1ZXMuCj4gPiA+ID4gPiBXaGVuIC03IDw9IHNpemUgPCAwLCB0aGVuIEtB U0FOIHdpbGwgbWlzcyB0byBjYXRjaCB0aGUgdW5kZXJmbG93IGlzc3VlLgo+ID4gPiA+ID4gSXQg bG9va3MgbGlrZSBzaGFkb3cgc3RhcnQgYWRkcmVzcyBhbmQgc2hhZG93IGVuZCBhZGRyZXNzIGlz IHRoZSBzYW1lLAo+ID4gPiA+ID4gc28gaXQgZG9lcyBub3QgYWN0dWFsbHkgY2hlY2sgYW55dGhp bmcuCj4gPiA+ID4gPgo+ID4gPiA+ID4gVGhlIGZvbGxvd2luZyB0ZXN0IGlzIGluZGVlZCBub3Qg Y2F1Z2h0IGJ5IEtBU0FOOgo+ID4gPiA+ID4KPiA+ID4gPiA+ICAgICAgICAgY2hhciAqcCA9IGtt YWxsb2MoNjQsIEdGUF9LRVJORUwpOwo+ID4gPiA+ID4gICAgICAgICBtZW1zZXQoKGNoYXIgKilw LCAwLCA2NCk7Cj4gPiA+ID4gPiAgICAgICAgIG1lbW1vdmUoKGNoYXIgKilwLCAoY2hhciAqKXAg KyA0LCAtMik7Cj4gPiA+ID4gPiAgICAgICAgIGtmcmVlKChjaGFyKilwKTsKPiA+ID4gPiA+Cj4g PiA+ID4gPiBJdCBzaG91bGQgYmUgY2hlY2tlZCBoZXJlOgo+ID4gPiA+ID4KPiA+ID4gPiA+IHZv aWQgKm1lbW1vdmUodm9pZCAqZGVzdCwgY29uc3Qgdm9pZCAqc3JjLCBzaXplX3QgbGVuKQo+ID4g PiA+ID4gewo+ID4gPiA+ID4gICAgICAgICBjaGVja19tZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBs b25nKXNyYywgbGVuLCBmYWxzZSwgX1JFVF9JUF8pOwo+ID4gPiA+ID4gICAgICAgICBjaGVja19t ZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBsb25nKWRlc3QsIGxlbiwgdHJ1ZSwgX1JFVF9JUF8pOwo+ ID4gPiA+ID4KPiA+ID4gPiA+ICAgICAgICAgcmV0dXJuIF9fbWVtbW92ZShkZXN0LCBzcmMsIGxl bik7Cj4gPiA+ID4gPiB9Cj4gPiA+ID4gPgo+ID4gPiA+ID4gV2UgZml4IHRoZSBzaGFkb3cgZW5k IGFkZHJlc3Mgd2hpY2ggaXMgY2FsY3VsYXRlZCwgdGhlbiBnZW5lcmljIEtBU0FOCj4gPiA+ID4g PiBnZXQgdGhlIHJpZ2h0IHNoYWRvdyBlbmQgYWRkcmVzcyBhbmQgZGV0ZWN0IHRoaXMgdW5kZXJm bG93IGlzc3VlLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFsxXSBodHRwczovL2J1Z3ppbGxhLmtlcm5l bC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTM0MQo+ID4gPiA+ID4KPiA+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IFdhbHRlciBXdSA8d2FsdGVyLXpoLnd1QG1lZGlhdGVrLmNvbT4KPiA+ID4gPiA+IFJl cG9ydGVkLWJ5OiBEbWl0cnkgVnl1a292IDxkdnl1a292QGdvb2dsZS5jb20+Cj4gPiA+ID4gPiAt LS0KPiA+ID4gPiA+ICBsaWIvdGVzdF9rYXNhbi5jICAgfCAzNiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKPiA+ID4gPiA+ICBtbS9rYXNhbi9nZW5lcmljLmMgfCAgOCArKysr KystLQo+ID4gPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPiA+ID4gPiA+Cj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvbGliL3Rlc3Rfa2FzYW4u YyBiL2xpYi90ZXN0X2thc2FuLmMKPiA+ID4gPiA+IGluZGV4IGI2M2IzNjdhOTRlOC4uOGJkMDE0 ODUyNTU2IDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvbGliL3Rlc3Rfa2FzYW4uYwo+ID4gPiA+ID4g KysrIGIvbGliL3Rlc3Rfa2FzYW4uYwo+ID4gPiA+ID4gQEAgLTI4MCw2ICsyODAsNDAgQEAgc3Rh dGljIG5vaW5saW5lIHZvaWQgX19pbml0IGttYWxsb2Nfb29iX2luX21lbXNldCh2b2lkKQo+ID4g PiA+ID4gICAgICAgICBrZnJlZShwdHIpOwo+ID4gPiA+ID4gIH0KPiA+ID4gPiA+Cj4gPiA+ID4g PiArc3RhdGljIG5vaW5saW5lIHZvaWQgX19pbml0IGttYWxsb2Nfb29iX2luX21lbW1vdmVfdW5k ZXJmbG93KHZvaWQpCj4gPiA+ID4gPiArewo+ID4gPiA+ID4gKyAgICAgICBjaGFyICpwdHI7Cj4g PiA+ID4gPiArICAgICAgIHNpemVfdCBzaXplID0gNjQ7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiAr ICAgICAgIHByX2luZm8oInVuZGVyZmxvdyBvdXQtb2YtYm91bmRzIGluIG1lbW1vdmVcbiIpOwo+ ID4gPiA+ID4gKyAgICAgICBwdHIgPSBrbWFsbG9jKHNpemUsIEdGUF9LRVJORUwpOwo+ID4gPiA+ ID4gKyAgICAgICBpZiAoIXB0cikgewo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIHByX2Vycigi QWxsb2NhdGlvbiBmYWlsZWRcbiIpOwo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybjsK PiA+ID4gPiA+ICsgICAgICAgfQo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKyAgICAgICBtZW1zZXQo KGNoYXIgKilwdHIsIDAsIDY0KTsKPiA+ID4gPiA+ICsgICAgICAgbWVtbW92ZSgoY2hhciAqKXB0 ciwgKGNoYXIgKilwdHIgKyA0LCAtMik7Cj4gPiA+ID4gPiArICAgICAgIGtmcmVlKHB0cik7Cj4g PiA+ID4gPiArfQo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gK3N0YXRpYyBub2lubGluZSB2b2lkIF9f aW5pdCBrbWFsbG9jX29vYl9pbl9tZW1tb3ZlX292ZXJmbG93KHZvaWQpCj4gPiA+ID4gPiArewo+ ID4gPiA+ID4gKyAgICAgICBjaGFyICpwdHI7Cj4gPiA+ID4gPiArICAgICAgIHNpemVfdCBzaXpl ID0gNjQ7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArICAgICAgIHByX2luZm8oIm92ZXJmbG93IG91 dC1vZi1ib3VuZHMgaW4gbWVtbW92ZVxuIik7Cj4gPiA+ID4gPiArICAgICAgIHB0ciA9IGttYWxs b2Moc2l6ZSwgR0ZQX0tFUk5FTCk7Cj4gPiA+ID4gPiArICAgICAgIGlmICghcHRyKSB7Cj4gPiA+ ID4gPiArICAgICAgICAgICAgICAgcHJfZXJyKCJBbGxvY2F0aW9uIGZhaWxlZFxuIik7Cj4gPiA+ ID4gPiArICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4gPiA+ID4gKyAgICAgICB9Cj4gPiA+ID4g PiArCj4gPiA+ID4gPiArICAgICAgIG1lbXNldCgoY2hhciAqKXB0ciwgMCwgNjQpOwo+ID4gPiA+ ID4gKyAgICAgICBtZW1tb3ZlKChjaGFyICopcHRyICsgc2l6ZSwgKGNoYXIgKilwdHIsIDIpOwo+ ID4gPiA+ID4gKyAgICAgICBrZnJlZShwdHIpOwo+ID4gPiA+ID4gK30KPiA+ID4gPiA+ICsKPiA+ ID4gPiA+ICBzdGF0aWMgbm9pbmxpbmUgdm9pZCBfX2luaXQga21hbGxvY191YWYodm9pZCkKPiA+ ID4gPiA+ICB7Cj4gPiA+ID4gPiAgICAgICAgIGNoYXIgKnB0cjsKPiA+ID4gPiA+IEBAIC03MzQs NiArNzY4LDggQEAgc3RhdGljIGludCBfX2luaXQga21hbGxvY190ZXN0c19pbml0KHZvaWQpCj4g PiA+ID4gPiAgICAgICAgIGttYWxsb2Nfb29iX21lbXNldF80KCk7Cj4gPiA+ID4gPiAgICAgICAg IGttYWxsb2Nfb29iX21lbXNldF84KCk7Cj4gPiA+ID4gPiAgICAgICAgIGttYWxsb2Nfb29iX21l bXNldF8xNigpOwo+ID4gPiA+ID4gKyAgICAgICBrbWFsbG9jX29vYl9pbl9tZW1tb3ZlX3VuZGVy ZmxvdygpOwo+ID4gPiA+ID4gKyAgICAgICBrbWFsbG9jX29vYl9pbl9tZW1tb3ZlX292ZXJmbG93 KCk7Cj4gPiA+ID4gPiAgICAgICAgIGttYWxsb2NfdWFmKCk7Cj4gPiA+ID4gPiAgICAgICAgIGtt YWxsb2NfdWFmX21lbXNldCgpOwo+ID4gPiA+ID4gICAgICAgICBrbWFsbG9jX3VhZjIoKTsKPiA+ ID4gPiA+IGRpZmYgLS1naXQgYS9tbS9rYXNhbi9nZW5lcmljLmMgYi9tbS9rYXNhbi9nZW5lcmlj LmMKPiA+ID4gPiA+IGluZGV4IDYxNmY5ZGQ4MmQxMi4uMzRjYTIzZDU5ZTY3IDEwMDY0NAo+ID4g PiA+ID4gLS0tIGEvbW0va2FzYW4vZ2VuZXJpYy5jCj4gPiA+ID4gPiArKysgYi9tbS9rYXNhbi9n ZW5lcmljLmMKPiA+ID4gPiA+IEBAIC0xMzEsOSArMTMxLDEzIEBAIHN0YXRpYyBfX2Fsd2F5c19p bmxpbmUgYm9vbCBtZW1vcnlfaXNfcG9pc29uZWRfbih1bnNpZ25lZCBsb25nIGFkZHIsCj4gPiA+ ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaXpl X3Qgc2l6ZSkKPiA+ID4gPiA+ICB7Cj4gPiA+ID4gPiAgICAgICAgIHVuc2lnbmVkIGxvbmcgcmV0 Owo+ID4gPiA+ID4gKyAgICAgICB2b2lkICpzaGFkb3dfc3RhcnQgPSBrYXNhbl9tZW1fdG9fc2hh ZG93KCh2b2lkICopYWRkcik7Cj4gPiA+ID4gPiArICAgICAgIHZvaWQgKnNoYWRvd19lbmQgPSBr YXNhbl9tZW1fdG9fc2hhZG93KCh2b2lkICopYWRkciArIHNpemUgLSAxKSArIDE7Cj4gPiA+ID4g Pgo+ID4gPiA+ID4gLSAgICAgICByZXQgPSBtZW1vcnlfaXNfbm9uemVybyhrYXNhbl9tZW1fdG9f c2hhZG93KCh2b2lkICopYWRkciksCj4gPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICBr YXNhbl9tZW1fdG9fc2hhZG93KCh2b2lkICopYWRkciArIHNpemUgLSAxKSArIDEpOwo+ID4gPiA+ ID4gKyAgICAgICBpZiAoKGxvbmcpc2l6ZSA8IDApCj4gPiA+ID4gPiArICAgICAgICAgICAgICAg c2hhZG93X2VuZCA9IGthc2FuX21lbV90b19zaGFkb3coKHZvaWQgKilhZGRyICsgc2l6ZSk7Cj4g PiA+ID4KPiA+ID4gPiBIaSBXYWx0ZXIsCj4gPiA+ID4KPiA+ID4gPiBUaGFua3MgZm9yIHdvcmtp bmcgb24gdGhpcy4KPiA+ID4gPgo+ID4gPiA+IElmIHNpemU8MCwgZG9lcyBpdCBtYWtlIHNlbnNl IHRvIGNvbnRpbnVlIGF0IGFsbD8gV2Ugd2lsbCBzdGlsbCBjaGVjawo+ID4gPiA+IDFQQiBvZiBz aGFkb3cgbWVtb3J5PyBXaGF0IGhhcHBlbnMgd2hlbiB3ZSBwYXNzIHN1Y2ggaHVnZSByYW5nZSB0 bwo+ID4gPiA+IG1lbW9yeV9pc19ub256ZXJvPwo+ID4gPiA+IFBlcmhhcHMgaXQncyBiZXR0ZXIg dG8gcHJvZHVjZSBhbiBlcnJvciBhbmQgYmFpbCBvdXQgaW1tZWRpYXRlbHkgaWYgc2l6ZTwwPwo+ ID4gPgo+ID4gPiBJIGFncmVlIHdpdGggd2hhdCB5b3Ugc2FpZC4gd2hlbiBzaXplPDAsIGl0IGlz IGluZGVlZCBhbiB1bnJlYXNvbmFibGUKPiA+ID4gYmVoYXZpb3IsIGl0IHNob3VsZCBiZSBibG9j a2VkIGZyb20gY29udGludWluZyB0byBkby4KPiA+ID4KPiA+ID4KPiA+ID4gPiBBbHNvLCB3aGF0 J3MgdGhlIGZhaWx1cmUgbW9kZSBvZiB0aGUgdGVzdHM/IERpZG4ndCB0aGV5IGJhZGx5IGNvcnJ1 cHQKPiA+ID4gPiBtZW1vcnk/IFdlIHRyaWVkIHRvIGtlZXAgdGVzdHMgc3VjaCB0aGF0IHRoZXkg cHJvZHVjZSB0aGUgS0FTQU4KPiA+ID4gPiByZXBvcnRzLCBidXQgZG9uJ3QgYmFkbHkgY29ycnVw dCBtZW1vcnkgYi9jLyB3ZSBuZWVkIHRvIHJ1biBhbGwgb2YKPiA+ID4gPiB0aGVtLgo+ID4gPgo+ ID4gPiBNYXliZSB3ZSBzaG91bGQgZmlyc3QgcHJvZHVjZSBLQVNBTiByZXBvcnRzIGFuZCB0aGVu IGdvIHRvIGV4ZWN1dGUKPiA+ID4gbWVtbW92ZSgpIG9yIGRvIG5vdGhpbmc/IEl0IGxvb2tzIGxp a2UgaXTigJlzIGRvaW5nIHRoZSBmb2xsb3dpbmcub3I/Cj4gPiA+Cj4gPiA+IHZvaWQgKm1lbW1v dmUodm9pZCAqZGVzdCwgY29uc3Qgdm9pZCAqc3JjLCBzaXplX3QgbGVuKQo+ID4gPiAgewo+ID4g PiArICAgICAgIGlmIChsb25nKGxlbikgPD0gMCkKPiA+IAo+ID4gL1wvXC9cL1wvXC9cCj4gPiAK PiA+IFRoaXMgY2hlY2sgbmVlZHMgdG8gYmUgaW5zaWRlIG9mIGNoZWNrX21lbW9yeV9yZWdpb24s IG90aGVyd2lzZSB3ZQo+ID4gd2lsbCBoYXZlIHNpbWlsYXIgcHJvYmxlbXMgaW4gYWxsIG90aGVy IHBsYWNlcyB0aGF0IHVzZQo+ID4gY2hlY2tfbWVtb3J5X3JlZ2lvbi4KPiBUaGFua3MgZm9yIHlv dXIgcmVtaW5kZXIuCj4gCj4gIGJvb2wgY2hlY2tfbWVtb3J5X3JlZ2lvbih1bnNpZ25lZCBsb25n IGFkZHIsIHNpemVfdCBzaXplLCBib29sIHdyaXRlLAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgbG9uZyByZXRfaXApCj4gIHsKPiArICAgICAgIGlmIChsb25nKHNp emUpIDwgMCkgewo+ICsgICAgICAgICAgICAgICBrYXNhbl9yZXBvcnRfaW52YWxpZF9zaXplKHNy YywgZGVzdCwgbGVuLCBfUkVUX0lQXyk7Cj4gKyAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK PiArICAgICAgIH0KPiArCj4gICAgICAgICByZXR1cm4gY2hlY2tfbWVtb3J5X3JlZ2lvbl9pbmxp bmUoYWRkciwgc2l6ZSwgd3JpdGUsIHJldF9pcCk7Cj4gIH0KPiAKPiA+IEJ1dCBjaGVja19tZW1v cnlfcmVnaW9uIGFscmVhZHkgcmV0dXJucyBhIGJvb2wsIHNvIHdlIGNvdWxkIGNoZWNrIHRoYXQK PiA+IGJvb2wgYW5kIHJldHVybiBlYXJseS4KPiAKPiBXaGVuIHNpemU8MCwgd2Ugc2hvdWxkIG9u bHkgc2hvdyBvbmUgS0FTQU4gcmVwb3J0LCBhbmQgc2hvdWxkIHdlIG9ubHkKPiBsaW1pdCB0byBy ZXR1cm4gd2hlbiBzaXplPDAgaXMgdHJ1ZT8gSWYgeXNlLCB0aGVuIF9fbWVtbW92ZSgpIHdpbGwg ZG8KPiBub3RoaW5nLgo+IAo+IAo+ICB2b2lkICptZW1tb3ZlKHZvaWQgKmRlc3QsIGNvbnN0IHZv aWQgKnNyYywgc2l6ZV90IGxlbikKPiAgewo+IC0gICAgICAgY2hlY2tfbWVtb3J5X3JlZ2lvbigo dW5zaWduZWQgbG9uZylzcmMsIGxlbiwgZmFsc2UsIF9SRVRfSVBfKTsKPiArICAgICAgIGlmKCFj aGVja19tZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBsb25nKXNyYywgbGVuLCBmYWxzZSwKPiBfUkVU X0lQXykKPiArICAgICAgICAgICAgICAgJiYgbG9uZyhzaXplKSA8IDApCj4gKyAgICAgICAgICAg ICAgIHJldHVybjsKPiArCj4gICAgICAgICBjaGVja19tZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBs b25nKWRlc3QsIGxlbiwgdHJ1ZSwgX1JFVF9JUF8pOwo+IAo+ICAgICAgICAgcmV0dXJuIF9fbWVt bW92ZShkZXN0LCBzcmMsIGxlbik7Cj4gCj4gPiAKSGkgRG1pdHJ5LAoKV2hhdCBkbyB5b3UgdGhp bmsgdGhlIGZvbGxvd2luZyBjb2RlIGlzIGJldHRlciB0aGFuIHRoZSBhYm92ZSBvbmUuCkluIG1l bW1tb3ZlL21lbXNldC9tZW1jcHksIHRoZXkgbmVlZCB0byBkZXRlcm1pbmUgd2hldGhlciBzaXpl IDwgMCBpcwp0cnVlLiB3ZSBkaXJlY3RseSBkZXRlcm1pbmUgd2hldGhlciBzaXplIGlzIG5lZ2F0 aXZlIGluIG1lbW1vdmUgYW5kCnJldHVybiBlYXJseS4gaXQgYXZvaWQgdG8gZ2VuZXJhdGUgcmVw ZWF0ZWQgS0FTQU4gcmVwb3J0LiBJcyBpdCBiZXR0ZXI/Cgp2b2lkICptZW1tb3ZlKHZvaWQgKmRl c3QsIGNvbnN0IHZvaWQgKnNyYywgc2l6ZV90IGxlbikKeworICAgICAgIGlmIChsb25nKHNpemUp IDwgMCkgeworICAgICAgICAgICAgICAga2FzYW5fcmVwb3J0X2ludmFsaWRfc2l6ZShzcmMsIGRl c3QsIGxlbiwgX1JFVF9JUF8pOworICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgIH0KKwog ICAgICAgIGNoZWNrX21lbW9yeV9yZWdpb24oKHVuc2lnbmVkIGxvbmcpc3JjLCBsZW4sIGZhbHNl LCBfUkVUX0lQXyk7CiAgICAgICAgY2hlY2tfbWVtb3J5X3JlZ2lvbigodW5zaWduZWQgbG9uZylk ZXN0LCBsZW4sIHRydWUsIF9SRVRfSVBfKTsKCgpjaGVja19tZW1vcnlfcmVnaW9uKCkgc3RpbGwg aGFzIHRvIGNoZWNrIHdoZXRoZXIgdGhlIHNpemUgaXMgbmVnYXRpdmUuCmJ1dCBtZW1tb3ZlL21l bXNldC9tZW1jcHkgZ2VuZXJhdGUgaW52YWxpZCBzaXplIEtBU0FOIHJlcG9ydCB3aWxsIG5vdCBi ZQp0aGVyZS4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D8CECE58B for ; Wed, 2 Oct 2019 12:15:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3151B218DE for ; Wed, 2 Oct 2019 12:15:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3151B218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A63666B0007; Wed, 2 Oct 2019 08:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A13546B0008; Wed, 2 Oct 2019 08:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 901546B000A; Wed, 2 Oct 2019 08:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 6E0116B0007 for ; Wed, 2 Oct 2019 08:15:22 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 04F2F824CA36 for ; Wed, 2 Oct 2019 12:15:22 +0000 (UTC) X-FDA: 75998739684.29.tail32_4bc49b2b0df5c X-HE-Tag: tail32_4bc49b2b0df5c X-Filterd-Recvd-Size: 10046 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Oct 2019 12:15:20 +0000 (UTC) X-UUID: 187b45e8e86d4579955d053e51dadfd8-20191002 X-UUID: 187b45e8e86d4579955d053e51dadfd8-20191002 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 721684038; Wed, 02 Oct 2019 20:15:15 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 2 Oct 2019 20:15:12 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 2 Oct 2019 20:15:11 +0800 Message-ID: <1570018513.19702.36.camel@mtksdccf07> Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y From: Walter Wu To: Dmitry Vyukov CC: Andrey Ryabinin , Alexander Potapenko , Matthias Brugger , LKML , kasan-dev , Linux-MM , Linux ARM , , wsd_upstream Date: Wed, 2 Oct 2019 20:15:13 +0800 In-Reply-To: <1569818173.17361.19.camel@mtksdccf07> References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2019-09-30 at 12:36 +0800, Walter Wu wrote: > On Fri, 2019-09-27 at 21:41 +0200, Dmitry Vyukov wrote: > > On Fri, Sep 27, 2019 at 4:22 PM Walter Wu = wrote: > > > > > > On Fri, 2019-09-27 at 15:07 +0200, Dmitry Vyukov wrote: > > > > On Fri, Sep 27, 2019 at 5:43 AM Walter Wu wrote: > > > > > > > > > > memmove() and memcpy() have missing underflow issues. > > > > > When -7 <=3D size < 0, then KASAN will miss to catch the underf= low issue. > > > > > It looks like shadow start address and shadow end address is th= e same, > > > > > so it does not actually check anything. > > > > > > > > > > The following test is indeed not caught by KASAN: > > > > > > > > > > char *p =3D kmalloc(64, GFP_KERNEL); > > > > > memset((char *)p, 0, 64); > > > > > memmove((char *)p, (char *)p + 4, -2); > > > > > kfree((char*)p); > > > > > > > > > > It should be checked here: > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > { > > > > > check_memory_region((unsigned long)src, len, false, _RE= T_IP_); > > > > > check_memory_region((unsigned long)dest, len, true, _RE= T_IP_); > > > > > > > > > > return __memmove(dest, src, len); > > > > > } > > > > > > > > > > We fix the shadow end address which is calculated, then generic= KASAN > > > > > get the right shadow end address and detect this underflow issu= e. > > > > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D199341 > > > > > > > > > > Signed-off-by: Walter Wu > > > > > Reported-by: Dmitry Vyukov > > > > > --- > > > > > lib/test_kasan.c | 36 ++++++++++++++++++++++++++++++++++++ > > > > > mm/kasan/generic.c | 8 ++++++-- > > > > > 2 files changed, 42 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > > > > index b63b367a94e8..8bd014852556 100644 > > > > > --- a/lib/test_kasan.c > > > > > +++ b/lib/test_kasan.c > > > > > @@ -280,6 +280,40 @@ static noinline void __init kmalloc_oob_in= _memset(void) > > > > > kfree(ptr); > > > > > } > > > > > > > > > > +static noinline void __init kmalloc_oob_in_memmove_underflow(v= oid) > > > > > +{ > > > > > + char *ptr; > > > > > + size_t size =3D 64; > > > > > + > > > > > + pr_info("underflow out-of-bounds in memmove\n"); > > > > > + ptr =3D kmalloc(size, GFP_KERNEL); > > > > > + if (!ptr) { > > > > > + pr_err("Allocation failed\n"); > > > > > + return; > > > > > + } > > > > > + > > > > > + memset((char *)ptr, 0, 64); > > > > > + memmove((char *)ptr, (char *)ptr + 4, -2); > > > > > + kfree(ptr); > > > > > +} > > > > > + > > > > > +static noinline void __init kmalloc_oob_in_memmove_overflow(vo= id) > > > > > +{ > > > > > + char *ptr; > > > > > + size_t size =3D 64; > > > > > + > > > > > + pr_info("overflow out-of-bounds in memmove\n"); > > > > > + ptr =3D kmalloc(size, GFP_KERNEL); > > > > > + if (!ptr) { > > > > > + pr_err("Allocation failed\n"); > > > > > + return; > > > > > + } > > > > > + > > > > > + memset((char *)ptr, 0, 64); > > > > > + memmove((char *)ptr + size, (char *)ptr, 2); > > > > > + kfree(ptr); > > > > > +} > > > > > + > > > > > static noinline void __init kmalloc_uaf(void) > > > > > { > > > > > char *ptr; > > > > > @@ -734,6 +768,8 @@ static int __init kmalloc_tests_init(void) > > > > > kmalloc_oob_memset_4(); > > > > > kmalloc_oob_memset_8(); > > > > > kmalloc_oob_memset_16(); > > > > > + kmalloc_oob_in_memmove_underflow(); > > > > > + kmalloc_oob_in_memmove_overflow(); > > > > > kmalloc_uaf(); > > > > > kmalloc_uaf_memset(); > > > > > kmalloc_uaf2(); > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > index 616f9dd82d12..34ca23d59e67 100644 > > > > > --- a/mm/kasan/generic.c > > > > > +++ b/mm/kasan/generic.c > > > > > @@ -131,9 +131,13 @@ static __always_inline bool memory_is_pois= oned_n(unsigned long addr, > > > > > size_t size) > > > > > { > > > > > unsigned long ret; > > > > > + void *shadow_start =3D kasan_mem_to_shadow((void *)addr= ); > > > > > + void *shadow_end =3D kasan_mem_to_shadow((void *)addr += size - 1) + 1; > > > > > > > > > > - ret =3D memory_is_nonzero(kasan_mem_to_shadow((void *)a= ddr), > > > > > - kasan_mem_to_shadow((void *)addr + size= - 1) + 1); > > > > > + if ((long)size < 0) > > > > > + shadow_end =3D kasan_mem_to_shadow((void *)addr= + size); > > > > > > > > Hi Walter, > > > > > > > > Thanks for working on this. > > > > > > > > If size<0, does it make sense to continue at all? We will still c= heck > > > > 1PB of shadow memory? What happens when we pass such huge range t= o > > > > memory_is_nonzero? > > > > Perhaps it's better to produce an error and bail out immediately = if size<0? > > > > > > I agree with what you said. when size<0, it is indeed an unreasonab= le > > > behavior, it should be blocked from continuing to do. > > > > > > > > > > Also, what's the failure mode of the tests? Didn't they badly cor= rupt > > > > memory? We tried to keep tests such that they produce the KASAN > > > > reports, but don't badly corrupt memory b/c/ we need to run all o= f > > > > them. > > > > > > Maybe we should first produce KASAN reports and then go to execute > > > memmove() or do nothing? It looks like it=E2=80=99s doing the follo= wing.or? > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > { > > > + if (long(len) <=3D 0) > >=20 > > /\/\/\/\/\/\ > >=20 > > This check needs to be inside of check_memory_region, otherwise we > > will have similar problems in all other places that use > > check_memory_region. > Thanks for your reminder. >=20 > bool check_memory_region(unsigned long addr, size_t size, bool write, > unsigned long ret_ip) > { > + if (long(size) < 0) { > + kasan_report_invalid_size(src, dest, len, _RET_IP_); > + return false; > + } > + > return check_memory_region_inline(addr, size, write, ret_ip); > } >=20 > > But check_memory_region already returns a bool, so we could check tha= t > > bool and return early. >=20 > When size<0, we should only show one KASAN report, and should we only > limit to return when size<0 is true? If yse, then __memmove() will do > nothing. >=20 >=20 > void *memmove(void *dest, const void *src, size_t len) > { > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > + if(!check_memory_region((unsigned long)src, len, false, > _RET_IP_) > + && long(size) < 0) > + return; > + > check_memory_region((unsigned long)dest, len, true, _RET_IP_); >=20 > return __memmove(dest, src, len); >=20 > >=20 Hi Dmitry, What do you think the following code is better than the above one. In memmmove/memset/memcpy, they need to determine whether size < 0 is true. we directly determine whether size is negative in memmove and return early. it avoid to generate repeated KASAN report. Is it better? void *memmove(void *dest, const void *src, size_t len) { + if (long(size) < 0) { + kasan_report_invalid_size(src, dest, len, _RET_IP_); + return; + } + check_memory_region((unsigned long)src, len, false, _RET_IP_); check_memory_region((unsigned long)dest, len, true, _RET_IP_); check_memory_region() still has to check whether the size is negative. but memmove/memset/memcpy generate invalid size KASAN report will not be there.