From mboxrd@z Thu Jan 1 00:00:00 1970 From: Walter Wu Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y Date: Thu, 3 Oct 2019 21:51:21 +0800 Message-ID: <1570110681.19702.64.camel@mtksdccf07> References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> <1570018513.19702.36.camel@mtksdccf07> <1570069078.19702.57.camel@mtksdccf07> <1570095525.19702.59.camel@mtksdccf07> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1570095525.19702.59.camel@mtksdccf07> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Vyukov Cc: Andrey Ryabinin , Alexander Potapenko , Matthias Brugger , LKML , kasan-dev , Linux-MM , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream List-Id: linux-mediatek@lists.infradead.org On Thu, 2019-10-03 at 17:38 +0800, Walter Wu wrote: > On Thu, 2019-10-03 at 08:26 +0200, Dmitry Vyukov wrote: > > On Thu, Oct 3, 2019 at 4:18 AM Walter Wu wrote: > > > > > > On Wed, 2019-10-02 at 15:57 +0200, Dmitry Vyukov wrote: > > > > On Wed, Oct 2, 2019 at 2:15 PM Walter Wu wrote: > > > > > > > > > > On Mon, 2019-09-30 at 12:36 +0800, Walter Wu wrote: > > > > > > On Fri, 2019-09-27 at 21:41 +0200, Dmitry Vyukov wrote: > > > > > > > On Fri, Sep 27, 2019 at 4:22 PM Walter Wu wrote: > > > > > > > > > > > > > > > > On Fri, 2019-09-27 at 15:07 +0200, Dmitry Vyukov wrote: > > > > > > > > > On Fri, Sep 27, 2019 at 5:43 AM Walter Wu wrote: > > > > > > > > > > > > > > > > > > > > memmove() and memcpy() have missing underflow issues. > > > > > > > > > > When -7 <= size < 0, then KASAN will miss to catch the underflow issue. > > > > > > > > > > It looks like shadow start address and shadow end address is the same, > > > > > > > > > > so it does not actually check anything. > > > > > > > > > > > > > > > > > > > > The following test is indeed not caught by KASAN: > > > > > > > > > > > > > > > > > > > > char *p = kmalloc(64, GFP_KERNEL); > > > > > > > > > > memset((char *)p, 0, 64); > > > > > > > > > > memmove((char *)p, (char *)p + 4, -2); > > > > > > > > > > kfree((char*)p); > > > > > > > > > > > > > > > > > > > > It should be checked here: > > > > > > > > > > > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > > > > > > { > > > > > > > > > > check_memory_region((unsigned long)src, len, false, _RET_IP_); > > > > > > > > > > check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > > > > > > > > > > > > > > > > > > > return __memmove(dest, src, len); > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > We fix the shadow end address which is calculated, then generic KASAN > > > > > > > > > > get the right shadow end address and detect this underflow issue. > > > > > > > > > > > > > > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=199341 > > > > > > > > > > > > > > > > > > > > Signed-off-by: Walter Wu > > > > > > > > > > Reported-by: Dmitry Vyukov > > > > > > > > > > --- > > > > > > > > > > lib/test_kasan.c | 36 ++++++++++++++++++++++++++++++++++++ > > > > > > > > > > mm/kasan/generic.c | 8 ++++++-- > > > > > > > > > > 2 files changed, 42 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > > > > > > > > > index b63b367a94e8..8bd014852556 100644 > > > > > > > > > > --- a/lib/test_kasan.c > > > > > > > > > > +++ b/lib/test_kasan.c > > > > > > > > > > @@ -280,6 +280,40 @@ static noinline void __init kmalloc_oob_in_memset(void) > > > > > > > > > > kfree(ptr); > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > +static noinline void __init kmalloc_oob_in_memmove_underflow(void) > > > > > > > > > > +{ > > > > > > > > > > + char *ptr; > > > > > > > > > > + size_t size = 64; > > > > > > > > > > + > > > > > > > > > > + pr_info("underflow out-of-bounds in memmove\n"); > > > > > > > > > > + ptr = kmalloc(size, GFP_KERNEL); > > > > > > > > > > + if (!ptr) { > > > > > > > > > > + pr_err("Allocation failed\n"); > > > > > > > > > > + return; > > > > > > > > > > + } > > > > > > > > > > + > > > > > > > > > > + memset((char *)ptr, 0, 64); > > > > > > > > > > + memmove((char *)ptr, (char *)ptr + 4, -2); > > > > > > > > > > + kfree(ptr); > > > > > > > > > > +} > > > > > > > > > > + > > > > > > > > > > +static noinline void __init kmalloc_oob_in_memmove_overflow(void) > > > > > > > > > > +{ > > > > > > > > > > + char *ptr; > > > > > > > > > > + size_t size = 64; > > > > > > > > > > + > > > > > > > > > > + pr_info("overflow out-of-bounds in memmove\n"); > > > > > > > > > > + ptr = kmalloc(size, GFP_KERNEL); > > > > > > > > > > + if (!ptr) { > > > > > > > > > > + pr_err("Allocation failed\n"); > > > > > > > > > > + return; > > > > > > > > > > + } > > > > > > > > > > + > > > > > > > > > > + memset((char *)ptr, 0, 64); > > > > > > > > > > + memmove((char *)ptr + size, (char *)ptr, 2); > > > > > > > > > > + kfree(ptr); > > > > > > > > > > +} > > > > > > > > > > + > > > > > > > > > > static noinline void __init kmalloc_uaf(void) > > > > > > > > > > { > > > > > > > > > > char *ptr; > > > > > > > > > > @@ -734,6 +768,8 @@ static int __init kmalloc_tests_init(void) > > > > > > > > > > kmalloc_oob_memset_4(); > > > > > > > > > > kmalloc_oob_memset_8(); > > > > > > > > > > kmalloc_oob_memset_16(); > > > > > > > > > > + kmalloc_oob_in_memmove_underflow(); > > > > > > > > > > + kmalloc_oob_in_memmove_overflow(); > > > > > > > > > > kmalloc_uaf(); > > > > > > > > > > kmalloc_uaf_memset(); > > > > > > > > > > kmalloc_uaf2(); > > > > > > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > > > > > > index 616f9dd82d12..34ca23d59e67 100644 > > > > > > > > > > --- a/mm/kasan/generic.c > > > > > > > > > > +++ b/mm/kasan/generic.c > > > > > > > > > > @@ -131,9 +131,13 @@ static __always_inline bool memory_is_poisoned_n(unsigned long addr, > > > > > > > > > > size_t size) > > > > > > > > > > { > > > > > > > > > > unsigned long ret; > > > > > > > > > > + void *shadow_start = kasan_mem_to_shadow((void *)addr); > > > > > > > > > > + void *shadow_end = kasan_mem_to_shadow((void *)addr + size - 1) + 1; > > > > > > > > > > > > > > > > > > > > - ret = memory_is_nonzero(kasan_mem_to_shadow((void *)addr), > > > > > > > > > > - kasan_mem_to_shadow((void *)addr + size - 1) + 1); > > > > > > > > > > + if ((long)size < 0) > > > > > > > > > > + shadow_end = kasan_mem_to_shadow((void *)addr + size); > > > > > > > > > > > > > > > > > > Hi Walter, > > > > > > > > > > > > > > > > > > Thanks for working on this. > > > > > > > > > > > > > > > > > > If size<0, does it make sense to continue at all? We will still check > > > > > > > > > 1PB of shadow memory? What happens when we pass such huge range to > > > > > > > > > memory_is_nonzero? > > > > > > > > > Perhaps it's better to produce an error and bail out immediately if size<0? > > > > > > > > > > > > > > > > I agree with what you said. when size<0, it is indeed an unreasonable > > > > > > > > behavior, it should be blocked from continuing to do. > > > > > > > > > > > > > > > > > > > > > > > > > Also, what's the failure mode of the tests? Didn't they badly corrupt > > > > > > > > > memory? We tried to keep tests such that they produce the KASAN > > > > > > > > > reports, but don't badly corrupt memory b/c/ we need to run all of > > > > > > > > > them. > > > > > > > > > > > > > > > > Maybe we should first produce KASAN reports and then go to execute > > > > > > > > memmove() or do nothing? It looks like it’s doing the following.or? > > > > > > > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > > > > { > > > > > > > > + if (long(len) <= 0) > > > > > > > > > > > > > > /\/\/\/\/\/\ > > > > > > > > > > > > > > This check needs to be inside of check_memory_region, otherwise we > > > > > > > will have similar problems in all other places that use > > > > > > > check_memory_region. > > > > > > Thanks for your reminder. > > > > > > > > > > > > bool check_memory_region(unsigned long addr, size_t size, bool write, > > > > > > unsigned long ret_ip) > > > > > > { > > > > > > + if (long(size) < 0) { > > > > > > + kasan_report_invalid_size(src, dest, len, _RET_IP_); > > > > > > + return false; > > > > > > + } > > > > > > + > > > > > > return check_memory_region_inline(addr, size, write, ret_ip); > > > > > > } > > > > > > > > > > > > > But check_memory_region already returns a bool, so we could check that > > > > > > > bool and return early. > > > > > > > > > > > > When size<0, we should only show one KASAN report, and should we only > > > > > > limit to return when size<0 is true? If yse, then __memmove() will do > > > > > > nothing. > > > > > > > > > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > > { > > > > > > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > > > > > > + if(!check_memory_region((unsigned long)src, len, false, > > > > > > _RET_IP_) > > > > > > + && long(size) < 0) > > > > > > + return; > > > > > > + > > > > > > check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > > > > > > > > > > > return __memmove(dest, src, len); > > > > > > > > > > > > > > > > > > Hi Dmitry, > > > > > > > > > > What do you think the following code is better than the above one. > > > > > In memmmove/memset/memcpy, they need to determine whether size < 0 is > > > > > true. we directly determine whether size is negative in memmove and > > > > > return early. it avoid to generate repeated KASAN report. Is it better? > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > { > > > > > + if (long(size) < 0) { > > > > > + kasan_report_invalid_size(src, dest, len, _RET_IP_); > > > > > + return; > > > > > + } > > > > > + > > > > > check_memory_region((unsigned long)src, len, false, _RET_IP_); > > > > > check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > > > > > > > > > > > > > > check_memory_region() still has to check whether the size is negative. > > > > > but memmove/memset/memcpy generate invalid size KASAN report will not be > > > > > there. > > > > > > > > > > > > If check_memory_region() will do the check, why do we need to > > > > duplicate it inside of memmove and all other range functions? > > > > > > > Yes, I know it has duplication, but if we don't have to determine size<0 > > > in memmove, then all check_memory_region return false will do nothing, > > > > But they will produce a KASAN report, right? They are asked to check > > if 18446744073709551614 bytes are good. 18446744073709551614 bytes > > can't be good. > > > > > > > it includes other memory corruption behaviors, this is my original > > > concern. > > > > > > > I would do: > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > { > > > > if (check_memory_region((unsigned long)src, len, false, _RET_IP_)) > > > > return; > > > if check_memory_region return TRUE is to do nothing, but it is no memory > > > corruption? Should it return early when check_memory_region return a > > > FALSE? > > > > Maybe. I just meant the overall idea: check_memory_region should > > detect that 18446744073709551614 bytes are bad, print an error, return > > an indication that bytes were bad, memmove should return early if the > > range is bad. > > > ok, i will send new patch. > Thanks for your review. > how about this? commit fd64691026e7ccb8d2946d0804b0621ac177df38 Author: Walter Wu Date: Fri Sep 27 09:54:18 2019 +0800 kasan: detect invalid size in memory operation function It is an undefined behavior to pass a negative value to memset()/memcpy()/memmove() , so need to be detected by KASAN. KASAN report: BUG: KASAN: invalid size 18446744073709551614 in kmalloc_memmove_invalid_size+0x70/0xa0 CPU: 1 PID: 91 Comm: cat Not tainted 5.3.0-rc1ajb-00001-g31943bbc21ce-dirty #7 Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace+0x0/0x278 show_stack+0x14/0x20 dump_stack+0x108/0x15c print_address_description+0x64/0x368 __kasan_report+0x108/0x1a4 kasan_report+0xc/0x18 check_memory_region+0x15c/0x1b8 memmove+0x34/0x88 kmalloc_memmove_invalid_size+0x70/0xa0 [1] https://bugzilla.kernel.org/show_bug.cgi?id=199341 Signed-off-by: Walter Wu Reported-by: Dmitry Vyukov diff --git a/lib/test_kasan.c b/lib/test_kasan.c index b63b367a94e8..e4e517a51860 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -280,6 +280,23 @@ static noinline void __init kmalloc_oob_in_memset(void) kfree(ptr); } +static noinline void __init kmalloc_memmove_invalid_size(void) +{ + char *ptr; + size_t size = 64; + + pr_info("invalid size in memmove\n"); + ptr = kmalloc(size, GFP_KERNEL); + if (!ptr) { + pr_err("Allocation failed\n"); + return; + } + + memset((char *)ptr, 0, 64); + memmove((char *)ptr, (char *)ptr + 4, -2); + kfree(ptr); +} + static noinline void __init kmalloc_uaf(void) { char *ptr; @@ -734,6 +751,7 @@ static int __init kmalloc_tests_init(void) kmalloc_oob_memset_4(); kmalloc_oob_memset_8(); kmalloc_oob_memset_16(); + kmalloc_memmove_invalid_size; kmalloc_uaf(); kmalloc_uaf_memset(); kmalloc_uaf2(); diff --git a/mm/kasan/common.c b/mm/kasan/common.c index 2277b82902d8..5fd377af7457 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -102,7 +102,8 @@ EXPORT_SYMBOL(__kasan_check_write); #undef memset void *memset(void *addr, int c, size_t len) { - check_memory_region((unsigned long)addr, len, true, _RET_IP_); + if(!check_memory_region((unsigned long)addr, len, true, _RET_IP_)) + return NULL; return __memset(addr, c, len); } @@ -110,7 +111,8 @@ void *memset(void *addr, int c, size_t len) #undef memmove void *memmove(void *dest, const void *src, size_t len) { - check_memory_region((unsigned long)src, len, false, _RET_IP_); + if(!check_memory_region((unsigned long)src, len, false, _RET_IP_)) + return NULL; check_memory_region((unsigned long)dest, len, true, _RET_IP_); return __memmove(dest, src, len); @@ -119,7 +121,8 @@ void *memmove(void *dest, const void *src, size_t len) #undef memcpy void *memcpy(void *dest, const void *src, size_t len) { - check_memory_region((unsigned long)src, len, false, _RET_IP_); + if(!check_memory_region((unsigned long)src, len, false, _RET_IP_)) + return NULL; check_memory_region((unsigned long)dest, len, true, _RET_IP_); return __memcpy(dest, src, len); diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c index 616f9dd82d12..02148a317d27 100644 --- a/mm/kasan/generic.c +++ b/mm/kasan/generic.c @@ -173,6 +173,11 @@ static __always_inline bool check_memory_region_inline(unsigned long addr, if (unlikely(size == 0)) return true; + if (unlikely((long)size < 0)) { + kasan_report(addr, size, write, ret_ip); + return false; + } + if (unlikely((void *)addr < kasan_shadow_to_mem((void *)KASAN_SHADOW_START))) { kasan_report(addr, size, write, ret_ip); diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 0e5f965f1882..0cd317ef30f5 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -68,11 +68,16 @@ __setup("kasan_multi_shot", kasan_set_multi_shot); static void print_error_description(struct kasan_access_info *info) { - pr_err("BUG: KASAN: %s in %pS\n", - get_bug_type(info), (void *)info->ip); - pr_err("%s of size %zu at addr %px by task %s/%d\n", - info->is_write ? "Write" : "Read", info->access_size, - info->access_addr, current->comm, task_pid_nr(current)); + if ((long)info->access_size < 0) { + pr_err("BUG: KASAN: invalid size %zu in %pS\n", + info->access_size, (void *)info->ip); + } else { + pr_err("BUG: KASAN: %s in %pS\n", + get_bug_type(info), (void *)info->ip); + pr_err("%s of size %zu at addr %px by task %s/%d\n", + info->is_write ? "Write" : "Read", info->access_size, + info->access_addr, current->comm, task_pid_nr(current)); + } } static DEFINE_SPINLOCK(report_lock); diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c index 0e987c9ca052..b829535a3ad7 100644 --- a/mm/kasan/tags.c +++ b/mm/kasan/tags.c @@ -86,6 +86,11 @@ bool check_memory_region(unsigned long addr, size_t size, bool write, if (unlikely(size == 0)) return true; + if (unlikely((long)size < 0)) { + kasan_report(addr, size, write, ret_ip); + return false; + } + tag = get_tag((const void *)addr); /* From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E448C10F14 for ; Thu, 3 Oct 2019 14:06:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC7B0207FF for ; Thu, 3 Oct 2019 14:06:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tz5B3jVv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC7B0207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3Pie1vUoasmLNwkYT3p2wrUOlbzeRZyME9i6qbHpWFA=; b=tz5B3jVvDm8NJI lJUw117dqhI9DCPYmdwZykb3DWUv1sJe9OW9SgiNMogSDMgltTe0PyGxVNcH8P3IJPJYoKjLUKmhg iZI/LPpRoVNhlrJ20EuILRc9i65S08nejpVcoG8Wa/le2HyxOncV5u3WB3InW0KdYZI8m4KZQo1Xm LMlpcpjnepf+BwyzqFAif1b/9CsZJj0Ywlh3omDSJ85CXZuVjB54EEDx+Q7EJOm2PbQCIGfUv4ihL b+JDrDQon6QxLRzsEKqi90ZGnKUuBp+TAT6eWEmS5v1hb+XH/ZTW+0Hy4HaCsg2G7eiLrKiQbHerB F6pPsSGxDTdpO4Pbf7Bw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG1kb-0001BL-NS; Thu, 03 Oct 2019 14:06:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG1kW-0001AM-TR; Thu, 03 Oct 2019 14:06:35 +0000 X-UUID: 253bc5093fb7474f811b4e2a3bae3629-20191003 X-UUID: 253bc5093fb7474f811b4e2a3bae3629-20191003 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 783223254; Thu, 03 Oct 2019 06:06:25 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 3 Oct 2019 07:06:24 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 3 Oct 2019 21:51:21 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 3 Oct 2019 21:51:20 +0800 Message-ID: <1570110681.19702.64.camel@mtksdccf07> Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y From: Walter Wu To: Dmitry Vyukov Date: Thu, 3 Oct 2019 21:51:21 +0800 In-Reply-To: <1570095525.19702.59.camel@mtksdccf07> References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> <1570018513.19702.36.camel@mtksdccf07> <1570069078.19702.57.camel@mtksdccf07> <1570095525.19702.59.camel@mtksdccf07> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191003_070632_962541_56549AE1 X-CRM114-Status: GOOD ( 42.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream , linux-mediatek@lists.infradead.org, LKML , kasan-dev , Linux-MM , Alexander Potapenko , Matthias Brugger , Andrey Ryabinin , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMDE5LTEwLTAzIGF0IDE3OjM4ICswODAwLCBXYWx0ZXIgV3Ugd3JvdGU6Cj4gT24g VGh1LCAyMDE5LTEwLTAzIGF0IDA4OjI2ICswMjAwLCBEbWl0cnkgVnl1a292IHdyb3RlOgo+ID4g T24gVGh1LCBPY3QgMywgMjAxOSBhdCA0OjE4IEFNIFdhbHRlciBXdSA8d2FsdGVyLXpoLnd1QG1l ZGlhdGVrLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFdlZCwgMjAxOS0xMC0wMiBhdCAxNTo1 NyArMDIwMCwgRG1pdHJ5IFZ5dWtvdiB3cm90ZToKPiA+ID4gPiBPbiBXZWQsIE9jdCAyLCAyMDE5 IGF0IDI6MTUgUE0gV2FsdGVyIFd1IDx3YWx0ZXItemgud3VAbWVkaWF0ZWsuY29tPiB3cm90ZToK PiA+ID4gPiA+Cj4gPiA+ID4gPiBPbiBNb24sIDIwMTktMDktMzAgYXQgMTI6MzYgKzA4MDAsIFdh bHRlciBXdSB3cm90ZToKPiA+ID4gPiA+ID4gT24gRnJpLCAyMDE5LTA5LTI3IGF0IDIxOjQxICsw MjAwLCBEbWl0cnkgVnl1a292IHdyb3RlOgo+ID4gPiA+ID4gPiA+IE9uIEZyaSwgU2VwIDI3LCAy MDE5IGF0IDQ6MjIgUE0gV2FsdGVyIFd1IDx3YWx0ZXItemgud3VAbWVkaWF0ZWsuY29tPiB3cm90 ZToKPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiBPbiBGcmksIDIwMTktMDktMjcgYXQg MTU6MDcgKzAyMDAsIERtaXRyeSBWeXVrb3Ygd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiA+IE9uIEZy aSwgU2VwIDI3LCAyMDE5IGF0IDU6NDMgQU0gV2FsdGVyIFd1IDx3YWx0ZXItemgud3VAbWVkaWF0 ZWsuY29tPiB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiA+IG1l bW1vdmUoKSBhbmQgbWVtY3B5KCkgaGF2ZSBtaXNzaW5nIHVuZGVyZmxvdyBpc3N1ZXMuCj4gPiA+ ID4gPiA+ID4gPiA+ID4gV2hlbiAtNyA8PSBzaXplIDwgMCwgdGhlbiBLQVNBTiB3aWxsIG1pc3Mg dG8gY2F0Y2ggdGhlIHVuZGVyZmxvdyBpc3N1ZS4KPiA+ID4gPiA+ID4gPiA+ID4gPiBJdCBsb29r cyBsaWtlIHNoYWRvdyBzdGFydCBhZGRyZXNzIGFuZCBzaGFkb3cgZW5kIGFkZHJlc3MgaXMgdGhl IHNhbWUsCj4gPiA+ID4gPiA+ID4gPiA+ID4gc28gaXQgZG9lcyBub3QgYWN0dWFsbHkgY2hlY2sg YW55dGhpbmcuCj4gPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGUgZm9s bG93aW5nIHRlc3QgaXMgaW5kZWVkIG5vdCBjYXVnaHQgYnkgS0FTQU46Cj4gPiA+ID4gPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgIGNoYXIgKnAgPSBrbWFsbG9jKDY0LCBH RlBfS0VSTkVMKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgIG1lbXNldCgoY2hhciAqKXAs IDAsIDY0KTsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgIG1lbW1vdmUoKGNoYXIgKilwLCAo Y2hhciAqKXAgKyA0LCAtMik7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICBrZnJlZSgoY2hh ciopcCk7Cj4gPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gPiBJdCBzaG91bGQg YmUgY2hlY2tlZCBoZXJlOgo+ID4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+ID4g dm9pZCAqbWVtbW92ZSh2b2lkICpkZXN0LCBjb25zdCB2b2lkICpzcmMsIHNpemVfdCBsZW4pCj4g PiA+ID4gPiA+ID4gPiA+ID4gewo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgY2hlY2tfbWVt b3J5X3JlZ2lvbigodW5zaWduZWQgbG9uZylzcmMsIGxlbiwgZmFsc2UsIF9SRVRfSVBfKTsKPiA+ ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgIGNoZWNrX21lbW9yeV9yZWdpb24oKHVuc2lnbmVkIGxv bmcpZGVzdCwgbGVuLCB0cnVlLCBfUkVUX0lQXyk7Cj4gPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gPiA+ID4gPiAgICAgICAgIHJldHVybiBfX21lbW1vdmUoZGVzdCwgc3JjLCBsZW4pOwo+ ID4gPiA+ID4gPiA+ID4gPiA+IH0KPiA+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4g PiA+IFdlIGZpeCB0aGUgc2hhZG93IGVuZCBhZGRyZXNzIHdoaWNoIGlzIGNhbGN1bGF0ZWQsIHRo ZW4gZ2VuZXJpYyBLQVNBTgo+ID4gPiA+ID4gPiA+ID4gPiA+IGdldCB0aGUgcmlnaHQgc2hhZG93 IGVuZCBhZGRyZXNzIGFuZCBkZXRlY3QgdGhpcyB1bmRlcmZsb3cgaXNzdWUuCj4gPiA+ID4gPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gPiBbMV0gaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkzNDEKPiA+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFdhbHRlciBXdSA8d2FsdGVyLXpoLnd1QG1lZGlhdGVr LmNvbT4KPiA+ID4gPiA+ID4gPiA+ID4gPiBSZXBvcnRlZC1ieTogRG1pdHJ5IFZ5dWtvdiA8ZHZ5 dWtvdkBnb29nbGUuY29tPgo+ID4gPiA+ID4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiA+ID4g PiA+ICBsaWIvdGVzdF9rYXNhbi5jICAgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKPiA+ID4gPiA+ID4gPiA+ID4gPiAgbW0va2FzYW4vZ2VuZXJpYy5jIHwgIDggKysr KysrLS0KPiA+ID4gPiA+ID4gPiA+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+ ID4gZGlmZiAtLWdpdCBhL2xpYi90ZXN0X2thc2FuLmMgYi9saWIvdGVzdF9rYXNhbi5jCj4gPiA+ ID4gPiA+ID4gPiA+ID4gaW5kZXggYjYzYjM2N2E5NGU4Li44YmQwMTQ4NTI1NTYgMTAwNjQ0Cj4g PiA+ID4gPiA+ID4gPiA+ID4gLS0tIGEvbGliL3Rlc3Rfa2FzYW4uYwo+ID4gPiA+ID4gPiA+ID4g PiA+ICsrKyBiL2xpYi90ZXN0X2thc2FuLmMKPiA+ID4gPiA+ID4gPiA+ID4gPiBAQCAtMjgwLDYg KzI4MCw0MCBAQCBzdGF0aWMgbm9pbmxpbmUgdm9pZCBfX2luaXQga21hbGxvY19vb2JfaW5fbWVt c2V0KHZvaWQpCj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICBrZnJlZShwdHIpOwo+ID4gPiA+ ID4gPiA+ID4gPiA+ICB9Cj4gPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gPiAr c3RhdGljIG5vaW5saW5lIHZvaWQgX19pbml0IGttYWxsb2Nfb29iX2luX21lbW1vdmVfdW5kZXJm bG93KHZvaWQpCj4gPiA+ID4gPiA+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAg ICAgIGNoYXIgKnB0cjsKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIHNpemVfdCBzaXplID0g NjQ7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICAgICAgcHJf aW5mbygidW5kZXJmbG93IG91dC1vZi1ib3VuZHMgaW4gbWVtbW92ZVxuIik7Cj4gPiA+ID4gPiA+ ID4gPiA+ID4gKyAgICAgICBwdHIgPSBrbWFsbG9jKHNpemUsIEdGUF9LRVJORUwpOwo+ID4gPiA+ ID4gPiA+ID4gPiA+ICsgICAgICAgaWYgKCFwdHIpIHsKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAg ICAgICAgICAgICAgcHJfZXJyKCJBbGxvY2F0aW9uIGZhaWxlZFxuIik7Cj4gPiA+ID4gPiA+ID4g PiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybjsKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICAg IH0KPiA+ID4gPiA+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICBtZW1z ZXQoKGNoYXIgKilwdHIsIDAsIDY0KTsKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIG1lbW1v dmUoKGNoYXIgKilwdHIsIChjaGFyICopcHRyICsgNCwgLTIpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ ICsgICAgICAga2ZyZWUocHRyKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiArfQo+ID4gPiA+ID4gPiA+ ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gPiArc3RhdGljIG5vaW5saW5lIHZvaWQgX19pbml0 IGttYWxsb2Nfb29iX2luX21lbW1vdmVfb3ZlcmZsb3codm9pZCkKPiA+ID4gPiA+ID4gPiA+ID4g PiArewo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICAgICAgY2hhciAqcHRyOwo+ID4gPiA+ID4gPiA+ ID4gPiA+ICsgICAgICAgc2l6ZV90IHNpemUgPSA2NDsKPiA+ID4gPiA+ID4gPiA+ID4gPiArCj4g PiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICBwcl9pbmZvKCJvdmVyZmxvdyBvdXQtb2YtYm91bmRz IGluIG1lbW1vdmVcbiIpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICAgICAgcHRyID0ga21hbGxv YyhzaXplLCBHRlBfS0VSTkVMKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIGlmICghcHRy KSB7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIHByX2VycigiQWxsb2NhdGlv biBmYWlsZWRcbiIpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgICByZXR1cm47 Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICB9Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKwo+ID4g PiA+ID4gPiA+ID4gPiA+ICsgICAgICAgbWVtc2V0KChjaGFyICopcHRyLCAwLCA2NCk7Cj4gPiA+ ID4gPiA+ID4gPiA+ID4gKyAgICAgICBtZW1tb3ZlKChjaGFyICopcHRyICsgc2l6ZSwgKGNoYXIg KilwdHIsIDIpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICAgICAga2ZyZWUocHRyKTsKPiA+ID4g PiA+ID4gPiA+ID4gPiArfQo+ID4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4g PiAgc3RhdGljIG5vaW5saW5lIHZvaWQgX19pbml0IGttYWxsb2NfdWFmKHZvaWQpCj4gPiA+ID4g PiA+ID4gPiA+ID4gIHsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgIGNoYXIgKnB0cjsKPiA+ ID4gPiA+ID4gPiA+ID4gPiBAQCAtNzM0LDYgKzc2OCw4IEBAIHN0YXRpYyBpbnQgX19pbml0IGtt YWxsb2NfdGVzdHNfaW5pdCh2b2lkKQo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAga21hbGxv Y19vb2JfbWVtc2V0XzQoKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgIGttYWxsb2Nfb29i X21lbXNldF84KCk7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICBrbWFsbG9jX29vYl9tZW1z ZXRfMTYoKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIGttYWxsb2Nfb29iX2luX21lbW1v dmVfdW5kZXJmbG93KCk7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICBrbWFsbG9jX29vYl9p bl9tZW1tb3ZlX292ZXJmbG93KCk7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICBrbWFsbG9j X3VhZigpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAga21hbGxvY191YWZfbWVtc2V0KCk7 Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICBrbWFsbG9jX3VhZjIoKTsKPiA+ID4gPiA+ID4g PiA+ID4gPiBkaWZmIC0tZ2l0IGEvbW0va2FzYW4vZ2VuZXJpYy5jIGIvbW0va2FzYW4vZ2VuZXJp Yy5jCj4gPiA+ID4gPiA+ID4gPiA+ID4gaW5kZXggNjE2ZjlkZDgyZDEyLi4zNGNhMjNkNTllNjcg MTAwNjQ0Cj4gPiA+ID4gPiA+ID4gPiA+ID4gLS0tIGEvbW0va2FzYW4vZ2VuZXJpYy5jCj4gPiA+ ID4gPiA+ID4gPiA+ID4gKysrIGIvbW0va2FzYW4vZ2VuZXJpYy5jCj4gPiA+ID4gPiA+ID4gPiA+ ID4gQEAgLTEzMSw5ICsxMzEsMTMgQEAgc3RhdGljIF9fYWx3YXlzX2lubGluZSBib29sIG1lbW9y eV9pc19wb2lzb25lZF9uKHVuc2lnbmVkIGxvbmcgYWRkciwKPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaXplX3Qgc2l6 ZSkKPiA+ID4gPiA+ID4gPiA+ID4gPiAgewo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgdW5z aWduZWQgbG9uZyByZXQ7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICB2b2lkICpzaGFkb3df c3RhcnQgPSBrYXNhbl9tZW1fdG9fc2hhZG93KCh2b2lkICopYWRkcik7Cj4gPiA+ID4gPiA+ID4g PiA+ID4gKyAgICAgICB2b2lkICpzaGFkb3dfZW5kID0ga2FzYW5fbWVtX3RvX3NoYWRvdygodm9p ZCAqKWFkZHIgKyBzaXplIC0gMSkgKyAxOwo+ID4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ ID4gPiA+ID4gLSAgICAgICByZXQgPSBtZW1vcnlfaXNfbm9uemVybyhrYXNhbl9tZW1fdG9fc2hh ZG93KCh2b2lkICopYWRkciksCj4gPiA+ID4gPiA+ID4gPiA+ID4gLSAgICAgICAgICAgICAgICAg ICAgICAga2FzYW5fbWVtX3RvX3NoYWRvdygodm9pZCAqKWFkZHIgKyBzaXplIC0gMSkgKyAxKTsK PiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIGlmICgobG9uZylzaXplIDwgMCkKPiA+ID4gPiA+ ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgc2hhZG93X2VuZCA9IGthc2FuX21lbV90b19zaGFk b3coKHZvaWQgKilhZGRyICsgc2l6ZSk7Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4g PiA+IEhpIFdhbHRlciwKPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gVGhhbmtz IGZvciB3b3JraW5nIG9uIHRoaXMuCj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+ IElmIHNpemU8MCwgZG9lcyBpdCBtYWtlIHNlbnNlIHRvIGNvbnRpbnVlIGF0IGFsbD8gV2Ugd2ls bCBzdGlsbCBjaGVjawo+ID4gPiA+ID4gPiA+ID4gPiAxUEIgb2Ygc2hhZG93IG1lbW9yeT8gV2hh dCBoYXBwZW5zIHdoZW4gd2UgcGFzcyBzdWNoIGh1Z2UgcmFuZ2UgdG8KPiA+ID4gPiA+ID4gPiA+ ID4gbWVtb3J5X2lzX25vbnplcm8/Cj4gPiA+ID4gPiA+ID4gPiA+IFBlcmhhcHMgaXQncyBiZXR0 ZXIgdG8gcHJvZHVjZSBhbiBlcnJvciBhbmQgYmFpbCBvdXQgaW1tZWRpYXRlbHkgaWYgc2l6ZTww Pwo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IEkgYWdyZWUgd2l0aCB3aGF0IHlvdSBz YWlkLiB3aGVuIHNpemU8MCwgaXQgaXMgaW5kZWVkIGFuIHVucmVhc29uYWJsZQo+ID4gPiA+ID4g PiA+ID4gYmVoYXZpb3IsIGl0IHNob3VsZCBiZSBibG9ja2VkIGZyb20gY29udGludWluZyB0byBk by4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBBbHNv LCB3aGF0J3MgdGhlIGZhaWx1cmUgbW9kZSBvZiB0aGUgdGVzdHM/IERpZG4ndCB0aGV5IGJhZGx5 IGNvcnJ1cHQKPiA+ID4gPiA+ID4gPiA+ID4gbWVtb3J5PyBXZSB0cmllZCB0byBrZWVwIHRlc3Rz IHN1Y2ggdGhhdCB0aGV5IHByb2R1Y2UgdGhlIEtBU0FOCj4gPiA+ID4gPiA+ID4gPiA+IHJlcG9y dHMsIGJ1dCBkb24ndCBiYWRseSBjb3JydXB0IG1lbW9yeSBiL2MvIHdlIG5lZWQgdG8gcnVuIGFs bCBvZgo+ID4gPiA+ID4gPiA+ID4gPiB0aGVtLgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4g PiA+IE1heWJlIHdlIHNob3VsZCBmaXJzdCBwcm9kdWNlIEtBU0FOIHJlcG9ydHMgYW5kIHRoZW4g Z28gdG8gZXhlY3V0ZQo+ID4gPiA+ID4gPiA+ID4gbWVtbW92ZSgpIG9yIGRvIG5vdGhpbmc/IEl0 IGxvb2tzIGxpa2UgaXTigJlzIGRvaW5nIHRoZSBmb2xsb3dpbmcub3I/Cj4gPiA+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiA+ID4gdm9pZCAqbWVtbW92ZSh2b2lkICpkZXN0LCBjb25zdCB2b2lkICpz cmMsIHNpemVfdCBsZW4pCj4gPiA+ID4gPiA+ID4gPiAgewo+ID4gPiA+ID4gPiA+ID4gKyAgICAg ICBpZiAobG9uZyhsZW4pIDw9IDApCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiAvXC9cL1wv XC9cL1wKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IFRoaXMgY2hlY2sgbmVlZHMgdG8gYmUg aW5zaWRlIG9mIGNoZWNrX21lbW9yeV9yZWdpb24sIG90aGVyd2lzZSB3ZQo+ID4gPiA+ID4gPiA+ IHdpbGwgaGF2ZSBzaW1pbGFyIHByb2JsZW1zIGluIGFsbCBvdGhlciBwbGFjZXMgdGhhdCB1c2UK PiA+ID4gPiA+ID4gPiBjaGVja19tZW1vcnlfcmVnaW9uLgo+ID4gPiA+ID4gPiBUaGFua3MgZm9y IHlvdXIgcmVtaW5kZXIuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ICBib29sIGNoZWNrX21lbW9y eV9yZWdpb24odW5zaWduZWQgbG9uZyBhZGRyLCBzaXplX3Qgc2l6ZSwgYm9vbCB3cml0ZSwKPiA+ ID4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHJl dF9pcCkKPiA+ID4gPiA+ID4gIHsKPiA+ID4gPiA+ID4gKyAgICAgICBpZiAobG9uZyhzaXplKSA8 IDApIHsKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIGthc2FuX3JlcG9ydF9pbnZhbGlkX3Np emUoc3JjLCBkZXN0LCBsZW4sIF9SRVRfSVBfKTsKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKPiA+ID4gPiA+ID4gKyAgICAgICB9Cj4gPiA+ID4gPiA+ICsKPiA+ID4g PiA+ID4gICAgICAgICByZXR1cm4gY2hlY2tfbWVtb3J5X3JlZ2lvbl9pbmxpbmUoYWRkciwgc2l6 ZSwgd3JpdGUsIHJldF9pcCk7Cj4gPiA+ID4gPiA+ICB9Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ ID4gQnV0IGNoZWNrX21lbW9yeV9yZWdpb24gYWxyZWFkeSByZXR1cm5zIGEgYm9vbCwgc28gd2Ug Y291bGQgY2hlY2sgdGhhdAo+ID4gPiA+ID4gPiA+IGJvb2wgYW5kIHJldHVybiBlYXJseS4KPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4gV2hlbiBzaXplPDAsIHdlIHNob3VsZCBvbmx5IHNob3cgb25l IEtBU0FOIHJlcG9ydCwgYW5kIHNob3VsZCB3ZSBvbmx5Cj4gPiA+ID4gPiA+IGxpbWl0IHRvIHJl dHVybiB3aGVuIHNpemU8MCBpcyB0cnVlPyBJZiB5c2UsIHRoZW4gX19tZW1tb3ZlKCkgd2lsbCBk bwo+ID4gPiA+ID4gPiBub3RoaW5nLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiAgdm9pZCAqbWVtbW92ZSh2b2lkICpkZXN0LCBjb25zdCB2b2lkICpzcmMsIHNpemVfdCBsZW4p Cj4gPiA+ID4gPiA+ICB7Cj4gPiA+ID4gPiA+IC0gICAgICAgY2hlY2tfbWVtb3J5X3JlZ2lvbigo dW5zaWduZWQgbG9uZylzcmMsIGxlbiwgZmFsc2UsIF9SRVRfSVBfKTsKPiA+ID4gPiA+ID4gKyAg ICAgICBpZighY2hlY2tfbWVtb3J5X3JlZ2lvbigodW5zaWduZWQgbG9uZylzcmMsIGxlbiwgZmFs c2UsCj4gPiA+ID4gPiA+IF9SRVRfSVBfKQo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgJiYg bG9uZyhzaXplKSA8IDApCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgICByZXR1cm47Cj4gPiA+ ID4gPiA+ICsKPiA+ID4gPiA+ID4gICAgICAgICBjaGVja19tZW1vcnlfcmVnaW9uKCh1bnNpZ25l ZCBsb25nKWRlc3QsIGxlbiwgdHJ1ZSwgX1JFVF9JUF8pOwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiAgICAgICAgIHJldHVybiBfX21lbW1vdmUoZGVzdCwgc3JjLCBsZW4pOwo+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiBIaSBEbWl0cnksCj4gPiA+ID4gPgo+ID4gPiA+ID4gV2hh dCBkbyB5b3UgdGhpbmsgdGhlIGZvbGxvd2luZyBjb2RlIGlzIGJldHRlciB0aGFuIHRoZSBhYm92 ZSBvbmUuCj4gPiA+ID4gPiBJbiBtZW1tbW92ZS9tZW1zZXQvbWVtY3B5LCB0aGV5IG5lZWQgdG8g ZGV0ZXJtaW5lIHdoZXRoZXIgc2l6ZSA8IDAgaXMKPiA+ID4gPiA+IHRydWUuIHdlIGRpcmVjdGx5 IGRldGVybWluZSB3aGV0aGVyIHNpemUgaXMgbmVnYXRpdmUgaW4gbWVtbW92ZSBhbmQKPiA+ID4g PiA+IHJldHVybiBlYXJseS4gaXQgYXZvaWQgdG8gZ2VuZXJhdGUgcmVwZWF0ZWQgS0FTQU4gcmVw b3J0LiBJcyBpdCBiZXR0ZXI/Cj4gPiA+ID4gPgo+ID4gPiA+ID4gdm9pZCAqbWVtbW92ZSh2b2lk ICpkZXN0LCBjb25zdCB2b2lkICpzcmMsIHNpemVfdCBsZW4pCj4gPiA+ID4gPiB7Cj4gPiA+ID4g PiArICAgICAgIGlmIChsb25nKHNpemUpIDwgMCkgewo+ID4gPiA+ID4gKyAgICAgICAgICAgICAg IGthc2FuX3JlcG9ydF9pbnZhbGlkX3NpemUoc3JjLCBkZXN0LCBsZW4sIF9SRVRfSVBfKTsKPiA+ ID4gPiA+ICsgICAgICAgICAgICAgICByZXR1cm47Cj4gPiA+ID4gPiArICAgICAgIH0KPiA+ID4g PiA+ICsKPiA+ID4gPiA+ICAgICAgICAgY2hlY2tfbWVtb3J5X3JlZ2lvbigodW5zaWduZWQgbG9u ZylzcmMsIGxlbiwgZmFsc2UsIF9SRVRfSVBfKTsKPiA+ID4gPiA+ICAgICAgICAgY2hlY2tfbWVt b3J5X3JlZ2lvbigodW5zaWduZWQgbG9uZylkZXN0LCBsZW4sIHRydWUsIF9SRVRfSVBfKTsKPiA+ ID4gPiA+Cj4gPiA+ID4gPgo+ID4gPiA+ID4gY2hlY2tfbWVtb3J5X3JlZ2lvbigpIHN0aWxsIGhh cyB0byBjaGVjayB3aGV0aGVyIHRoZSBzaXplIGlzIG5lZ2F0aXZlLgo+ID4gPiA+ID4gYnV0IG1l bW1vdmUvbWVtc2V0L21lbWNweSBnZW5lcmF0ZSBpbnZhbGlkIHNpemUgS0FTQU4gcmVwb3J0IHdp bGwgbm90IGJlCj4gPiA+ID4gPiB0aGVyZS4KPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gSWYgY2hl Y2tfbWVtb3J5X3JlZ2lvbigpIHdpbGwgZG8gdGhlIGNoZWNrLCB3aHkgZG8gd2UgbmVlZCB0bwo+ ID4gPiA+IGR1cGxpY2F0ZSBpdCBpbnNpZGUgb2YgbWVtbW92ZSBhbmQgYWxsIG90aGVyIHJhbmdl IGZ1bmN0aW9ucz8KPiA+ID4gPgo+ID4gPiBZZXMsIEkga25vdyBpdCBoYXMgZHVwbGljYXRpb24s IGJ1dCBpZiB3ZSBkb24ndCBoYXZlIHRvIGRldGVybWluZSBzaXplPDAKPiA+ID4gaW4gbWVtbW92 ZSwgdGhlbiBhbGwgY2hlY2tfbWVtb3J5X3JlZ2lvbiByZXR1cm4gZmFsc2Ugd2lsbCBkbyBub3Ro aW5nLAo+ID4gCj4gPiBCdXQgdGhleSB3aWxsIHByb2R1Y2UgYSBLQVNBTiByZXBvcnQsIHJpZ2h0 PyBUaGV5IGFyZSBhc2tlZCB0byBjaGVjawo+ID4gaWYgMTg0NDY3NDQwNzM3MDk1NTE2MTQgYnl0 ZXMgYXJlIGdvb2QuIDE4NDQ2NzQ0MDczNzA5NTUxNjE0IGJ5dGVzCj4gPiBjYW4ndCBiZSBnb29k Lgo+ID4gCj4gPiAKPiA+ID4gaXQgaW5jbHVkZXMgb3RoZXIgbWVtb3J5IGNvcnJ1cHRpb24gYmVo YXZpb3JzLCB0aGlzIGlzIG15IG9yaWdpbmFsCj4gPiA+IGNvbmNlcm4uCj4gPiA+Cj4gPiA+ID4g SSB3b3VsZCBkbzoKPiA+ID4gPgo+ID4gPiA+IHZvaWQgKm1lbW1vdmUodm9pZCAqZGVzdCwgY29u c3Qgdm9pZCAqc3JjLCBzaXplX3QgbGVuKQo+ID4gPiA+IHsKPiA+ID4gPiAgICAgICAgIGlmIChj aGVja19tZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBsb25nKXNyYywgbGVuLCBmYWxzZSwgX1JFVF9J UF8pKQo+ID4gPiA+ICAgICAgICAgICAgICAgICByZXR1cm47Cj4gPiA+IGlmIGNoZWNrX21lbW9y eV9yZWdpb24gcmV0dXJuIFRSVUUgaXMgdG8gZG8gbm90aGluZywgYnV0IGl0IGlzIG5vIG1lbW9y eQo+ID4gPiBjb3JydXB0aW9uPyBTaG91bGQgaXQgcmV0dXJuIGVhcmx5IHdoZW4gY2hlY2tfbWVt b3J5X3JlZ2lvbiByZXR1cm4gYQo+ID4gPiBGQUxTRT8KPiA+IAo+ID4gTWF5YmUuIEkganVzdCBt ZWFudCB0aGUgb3ZlcmFsbCBpZGVhOiBjaGVja19tZW1vcnlfcmVnaW9uIHNob3VsZAo+ID4gZGV0 ZWN0IHRoYXQgMTg0NDY3NDQwNzM3MDk1NTE2MTQgYnl0ZXMgYXJlIGJhZCwgcHJpbnQgYW4gZXJy b3IsIHJldHVybgo+ID4gYW4gaW5kaWNhdGlvbiB0aGF0IGJ5dGVzIHdlcmUgYmFkLCBtZW1tb3Zl IHNob3VsZCByZXR1cm4gZWFybHkgaWYgdGhlCj4gPiByYW5nZSBpcyBiYWQuCj4gPiAKPiBvaywg aSB3aWxsIHNlbmQgbmV3IHBhdGNoLgo+IFRoYW5rcyBmb3IgeW91ciByZXZpZXcuCj4gCmhvdyBh Ym91dCB0aGlzPwoKY29tbWl0IGZkNjQ2OTEwMjZlN2NjYjhkMjk0NmQwODA0YjA2MjFhYzE3N2Rm MzgKQXV0aG9yOiBXYWx0ZXIgV3UgPHdhbHRlci16aC53dUBtZWRpYXRlay5jb20+CkRhdGU6ICAg RnJpIFNlcCAyNyAwOTo1NDoxOCAyMDE5ICswODAwCgogICAga2FzYW46IGRldGVjdCBpbnZhbGlk IHNpemUgaW4gbWVtb3J5IG9wZXJhdGlvbiBmdW5jdGlvbgogICAgCiAgICBJdCBpcyBhbiB1bmRl ZmluZWQgYmVoYXZpb3IgdG8gcGFzcyBhIG5lZ2F0aXZlIHZhbHVlIHRvCm1lbXNldCgpL21lbWNw eSgpL21lbW1vdmUoKQogICAgLCBzbyBuZWVkIHRvIGJlIGRldGVjdGVkIGJ5IEtBU0FOLgogICAg CiAgICBLQVNBTiByZXBvcnQ6CiAgICAKICAgICBCVUc6IEtBU0FOOiBpbnZhbGlkIHNpemUgMTg0 NDY3NDQwNzM3MDk1NTE2MTQgaW4Ka21hbGxvY19tZW1tb3ZlX2ludmFsaWRfc2l6ZSsweDcwLzB4 YTAKICAgIAogICAgIENQVTogMSBQSUQ6IDkxIENvbW06IGNhdCBOb3QgdGFpbnRlZAo1LjMuMC1y YzFhamItMDAwMDEtZzMxOTQzYmJjMjFjZS1kaXJ0eSAjNwogICAgIEhhcmR3YXJlIG5hbWU6IGxp bnV4LGR1bW15LXZpcnQgKERUKQogICAgIENhbGwgdHJhY2U6CiAgICAgIGR1bXBfYmFja3RyYWNl KzB4MC8weDI3OAogICAgICBzaG93X3N0YWNrKzB4MTQvMHgyMAogICAgICBkdW1wX3N0YWNrKzB4 MTA4LzB4MTVjCiAgICAgIHByaW50X2FkZHJlc3NfZGVzY3JpcHRpb24rMHg2NC8weDM2OAogICAg ICBfX2thc2FuX3JlcG9ydCsweDEwOC8weDFhNAogICAgICBrYXNhbl9yZXBvcnQrMHhjLzB4MTgK ICAgICAgY2hlY2tfbWVtb3J5X3JlZ2lvbisweDE1Yy8weDFiOAogICAgICBtZW1tb3ZlKzB4MzQv MHg4OAogICAgICBrbWFsbG9jX21lbW1vdmVfaW52YWxpZF9zaXplKzB4NzAvMHhhMAogICAgCiAg ICBbMV0gaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkzNDEK ICAgIAogICAgU2lnbmVkLW9mZi1ieTogV2FsdGVyIFd1IDx3YWx0ZXItemgud3VAbWVkaWF0ZWsu Y29tPgogICAgUmVwb3J0ZWQtYnk6IERtaXRyeSBWeXVrb3YgPGR2eXVrb3ZAZ29vZ2xlLmNvbT4K CmRpZmYgLS1naXQgYS9saWIvdGVzdF9rYXNhbi5jIGIvbGliL3Rlc3Rfa2FzYW4uYwppbmRleCBi NjNiMzY3YTk0ZTguLmU0ZTUxN2E1MTg2MCAxMDA2NDQKLS0tIGEvbGliL3Rlc3Rfa2FzYW4uYwor KysgYi9saWIvdGVzdF9rYXNhbi5jCkBAIC0yODAsNiArMjgwLDIzIEBAIHN0YXRpYyBub2lubGlu ZSB2b2lkIF9faW5pdAprbWFsbG9jX29vYl9pbl9tZW1zZXQodm9pZCkKIAlrZnJlZShwdHIpOwog fQogCitzdGF0aWMgbm9pbmxpbmUgdm9pZCBfX2luaXQga21hbGxvY19tZW1tb3ZlX2ludmFsaWRf c2l6ZSh2b2lkKQoreworCWNoYXIgKnB0cjsKKwlzaXplX3Qgc2l6ZSA9IDY0OworCisJcHJfaW5m bygiaW52YWxpZCBzaXplIGluIG1lbW1vdmVcbiIpOworCXB0ciA9IGttYWxsb2Moc2l6ZSwgR0ZQ X0tFUk5FTCk7CisJaWYgKCFwdHIpIHsKKwkJcHJfZXJyKCJBbGxvY2F0aW9uIGZhaWxlZFxuIik7 CisJCXJldHVybjsKKwl9CisKKwltZW1zZXQoKGNoYXIgKilwdHIsIDAsIDY0KTsKKwltZW1tb3Zl KChjaGFyICopcHRyLCAoY2hhciAqKXB0ciArIDQsIC0yKTsKKwlrZnJlZShwdHIpOworfQorCiBz dGF0aWMgbm9pbmxpbmUgdm9pZCBfX2luaXQga21hbGxvY191YWYodm9pZCkKIHsKIAljaGFyICpw dHI7CkBAIC03MzQsNiArNzUxLDcgQEAgc3RhdGljIGludCBfX2luaXQga21hbGxvY190ZXN0c19p bml0KHZvaWQpCiAJa21hbGxvY19vb2JfbWVtc2V0XzQoKTsKIAlrbWFsbG9jX29vYl9tZW1zZXRf OCgpOwogCWttYWxsb2Nfb29iX21lbXNldF8xNigpOworCWttYWxsb2NfbWVtbW92ZV9pbnZhbGlk X3NpemU7CiAJa21hbGxvY191YWYoKTsKIAlrbWFsbG9jX3VhZl9tZW1zZXQoKTsKIAlrbWFsbG9j X3VhZjIoKTsKZGlmZiAtLWdpdCBhL21tL2thc2FuL2NvbW1vbi5jIGIvbW0va2FzYW4vY29tbW9u LmMKaW5kZXggMjI3N2I4MjkwMmQ4Li41ZmQzNzdhZjc0NTcgMTAwNjQ0Ci0tLSBhL21tL2thc2Fu L2NvbW1vbi5jCisrKyBiL21tL2thc2FuL2NvbW1vbi5jCkBAIC0xMDIsNyArMTAyLDggQEAgRVhQ T1JUX1NZTUJPTChfX2thc2FuX2NoZWNrX3dyaXRlKTsKICN1bmRlZiBtZW1zZXQKIHZvaWQgKm1l bXNldCh2b2lkICphZGRyLCBpbnQgYywgc2l6ZV90IGxlbikKIHsKLQljaGVja19tZW1vcnlfcmVn aW9uKCh1bnNpZ25lZCBsb25nKWFkZHIsIGxlbiwgdHJ1ZSwgX1JFVF9JUF8pOworCWlmKCFjaGVj a19tZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBsb25nKWFkZHIsIGxlbiwgdHJ1ZSwgX1JFVF9JUF8p KQorCQlyZXR1cm4gTlVMTDsKIAogCXJldHVybiBfX21lbXNldChhZGRyLCBjLCBsZW4pOwogfQpA QCAtMTEwLDcgKzExMSw4IEBAIHZvaWQgKm1lbXNldCh2b2lkICphZGRyLCBpbnQgYywgc2l6ZV90 IGxlbikKICN1bmRlZiBtZW1tb3ZlCiB2b2lkICptZW1tb3ZlKHZvaWQgKmRlc3QsIGNvbnN0IHZv aWQgKnNyYywgc2l6ZV90IGxlbikKIHsKLQljaGVja19tZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBs b25nKXNyYywgbGVuLCBmYWxzZSwgX1JFVF9JUF8pOworCWlmKCFjaGVja19tZW1vcnlfcmVnaW9u KCh1bnNpZ25lZCBsb25nKXNyYywgbGVuLCBmYWxzZSwgX1JFVF9JUF8pKQorCQlyZXR1cm4gTlVM TDsKIAljaGVja19tZW1vcnlfcmVnaW9uKCh1bnNpZ25lZCBsb25nKWRlc3QsIGxlbiwgdHJ1ZSwg X1JFVF9JUF8pOwogCiAJcmV0dXJuIF9fbWVtbW92ZShkZXN0LCBzcmMsIGxlbik7CkBAIC0xMTks NyArMTIxLDggQEAgdm9pZCAqbWVtbW92ZSh2b2lkICpkZXN0LCBjb25zdCB2b2lkICpzcmMsIHNp emVfdApsZW4pCiAjdW5kZWYgbWVtY3B5CiB2b2lkICptZW1jcHkodm9pZCAqZGVzdCwgY29uc3Qg dm9pZCAqc3JjLCBzaXplX3QgbGVuKQogewotCWNoZWNrX21lbW9yeV9yZWdpb24oKHVuc2lnbmVk IGxvbmcpc3JjLCBsZW4sIGZhbHNlLCBfUkVUX0lQXyk7CisJaWYoIWNoZWNrX21lbW9yeV9yZWdp b24oKHVuc2lnbmVkIGxvbmcpc3JjLCBsZW4sIGZhbHNlLCBfUkVUX0lQXykpCisJCXJldHVybiBO VUxMOwogCWNoZWNrX21lbW9yeV9yZWdpb24oKHVuc2lnbmVkIGxvbmcpZGVzdCwgbGVuLCB0cnVl LCBfUkVUX0lQXyk7CiAKIAlyZXR1cm4gX19tZW1jcHkoZGVzdCwgc3JjLCBsZW4pOwpkaWZmIC0t Z2l0IGEvbW0va2FzYW4vZ2VuZXJpYy5jIGIvbW0va2FzYW4vZ2VuZXJpYy5jCmluZGV4IDYxNmY5 ZGQ4MmQxMi4uMDIxNDhhMzE3ZDI3IDEwMDY0NAotLS0gYS9tbS9rYXNhbi9nZW5lcmljLmMKKysr IGIvbW0va2FzYW4vZ2VuZXJpYy5jCkBAIC0xNzMsNiArMTczLDExIEBAIHN0YXRpYyBfX2Fsd2F5 c19pbmxpbmUgYm9vbApjaGVja19tZW1vcnlfcmVnaW9uX2lubGluZSh1bnNpZ25lZCBsb25nIGFk ZHIsCiAJaWYgKHVubGlrZWx5KHNpemUgPT0gMCkpCiAJCXJldHVybiB0cnVlOwogCisJaWYgKHVu bGlrZWx5KChsb25nKXNpemUgPCAwKSkgeworCQlrYXNhbl9yZXBvcnQoYWRkciwgc2l6ZSwgd3Jp dGUsIHJldF9pcCk7CisJCXJldHVybiBmYWxzZTsKKwl9CisKIAlpZiAodW5saWtlbHkoKHZvaWQg KilhZGRyIDwKIAkJa2FzYW5fc2hhZG93X3RvX21lbSgodm9pZCAqKUtBU0FOX1NIQURPV19TVEFS VCkpKSB7CiAJCWthc2FuX3JlcG9ydChhZGRyLCBzaXplLCB3cml0ZSwgcmV0X2lwKTsKZGlmZiAt LWdpdCBhL21tL2thc2FuL3JlcG9ydC5jIGIvbW0va2FzYW4vcmVwb3J0LmMKaW5kZXggMGU1Zjk2 NWYxODgyLi4wY2QzMTdlZjMwZjUgMTAwNjQ0Ci0tLSBhL21tL2thc2FuL3JlcG9ydC5jCisrKyBi L21tL2thc2FuL3JlcG9ydC5jCkBAIC02OCwxMSArNjgsMTYgQEAgX19zZXR1cCgia2FzYW5fbXVs dGlfc2hvdCIsIGthc2FuX3NldF9tdWx0aV9zaG90KTsKIAogc3RhdGljIHZvaWQgcHJpbnRfZXJy b3JfZGVzY3JpcHRpb24oc3RydWN0IGthc2FuX2FjY2Vzc19pbmZvICppbmZvKQogewotCXByX2Vy cigiQlVHOiBLQVNBTjogJXMgaW4gJXBTXG4iLAotCQlnZXRfYnVnX3R5cGUoaW5mbyksICh2b2lk ICopaW5mby0+aXApOwotCXByX2VycigiJXMgb2Ygc2l6ZSAlenUgYXQgYWRkciAlcHggYnkgdGFz ayAlcy8lZFxuIiwKLQkJaW5mby0+aXNfd3JpdGUgPyAiV3JpdGUiIDogIlJlYWQiLCBpbmZvLT5h Y2Nlc3Nfc2l6ZSwKLQkJaW5mby0+YWNjZXNzX2FkZHIsIGN1cnJlbnQtPmNvbW0sIHRhc2tfcGlk X25yKGN1cnJlbnQpKTsKKwlpZiAoKGxvbmcpaW5mby0+YWNjZXNzX3NpemUgPCAwKSB7CisJCXBy X2VycigiQlVHOiBLQVNBTjogaW52YWxpZCBzaXplICV6dSBpbiAlcFNcbiIsCisJCQlpbmZvLT5h Y2Nlc3Nfc2l6ZSwgKHZvaWQgKilpbmZvLT5pcCk7CisJfSBlbHNlIHsKKwkJcHJfZXJyKCJCVUc6 IEtBU0FOOiAlcyBpbiAlcFNcbiIsCisJCQlnZXRfYnVnX3R5cGUoaW5mbyksICh2b2lkICopaW5m by0+aXApOworCQlwcl9lcnIoIiVzIG9mIHNpemUgJXp1IGF0IGFkZHIgJXB4IGJ5IHRhc2sgJXMv JWRcbiIsCisJCQlpbmZvLT5pc193cml0ZSA/ICJXcml0ZSIgOiAiUmVhZCIsIGluZm8tPmFjY2Vz c19zaXplLAorCQkJaW5mby0+YWNjZXNzX2FkZHIsIGN1cnJlbnQtPmNvbW0sIHRhc2tfcGlkX25y KGN1cnJlbnQpKTsKKwl9CiB9CiAKIHN0YXRpYyBERUZJTkVfU1BJTkxPQ0socmVwb3J0X2xvY2sp OwpkaWZmIC0tZ2l0IGEvbW0va2FzYW4vdGFncy5jIGIvbW0va2FzYW4vdGFncy5jCmluZGV4IDBl OTg3YzljYTA1Mi4uYjgyOTUzNWEzYWQ3IDEwMDY0NAotLS0gYS9tbS9rYXNhbi90YWdzLmMKKysr IGIvbW0va2FzYW4vdGFncy5jCkBAIC04Niw2ICs4NiwxMSBAQCBib29sIGNoZWNrX21lbW9yeV9y ZWdpb24odW5zaWduZWQgbG9uZyBhZGRyLCBzaXplX3QKc2l6ZSwgYm9vbCB3cml0ZSwKIAlpZiAo dW5saWtlbHkoc2l6ZSA9PSAwKSkKIAkJcmV0dXJuIHRydWU7CiAKKwlpZiAodW5saWtlbHkoKGxv bmcpc2l6ZSA8IDApKSB7CisJCWthc2FuX3JlcG9ydChhZGRyLCBzaXplLCB3cml0ZSwgcmV0X2lw KTsKKwkJcmV0dXJuIGZhbHNlOworCX0KKwogCXRhZyA9IGdldF90YWcoKGNvbnN0IHZvaWQgKilh ZGRyKTsKIAogCS8qCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94B8CC10F14 for ; Thu, 3 Oct 2019 13:51:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4216220865 for ; Thu, 3 Oct 2019 13:51:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4216220865 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BAF1D6B0005; Thu, 3 Oct 2019 09:51:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B60866B0006; Thu, 3 Oct 2019 09:51:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A268B8E0003; Thu, 3 Oct 2019 09:51:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 7A5B76B0005 for ; Thu, 3 Oct 2019 09:51:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 0F538180AD7C3 for ; Thu, 3 Oct 2019 13:51:32 +0000 (UTC) X-FDA: 76002610824.15.badge41_647022d80c552 X-HE-Tag: badge41_647022d80c552 X-Filterd-Recvd-Size: 19194 Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Oct 2019 13:51:29 +0000 (UTC) X-UUID: 3d904f6d175441b6a8b24f17d6deb2bc-20191003 X-UUID: 3d904f6d175441b6a8b24f17d6deb2bc-20191003 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1733192920; Thu, 03 Oct 2019 21:51:23 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 3 Oct 2019 21:51:21 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 3 Oct 2019 21:51:20 +0800 Message-ID: <1570110681.19702.64.camel@mtksdccf07> Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y From: Walter Wu To: Dmitry Vyukov CC: Andrey Ryabinin , Alexander Potapenko , Matthias Brugger , LKML , kasan-dev , Linux-MM , Linux ARM , , wsd_upstream Date: Thu, 3 Oct 2019 21:51:21 +0800 In-Reply-To: <1570095525.19702.59.camel@mtksdccf07> References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> <1570018513.19702.36.camel@mtksdccf07> <1570069078.19702.57.camel@mtksdccf07> <1570095525.19702.59.camel@mtksdccf07> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2019-10-03 at 17:38 +0800, Walter Wu wrote: > On Thu, 2019-10-03 at 08:26 +0200, Dmitry Vyukov wrote: > > On Thu, Oct 3, 2019 at 4:18 AM Walter Wu = wrote: > > > > > > On Wed, 2019-10-02 at 15:57 +0200, Dmitry Vyukov wrote: > > > > On Wed, Oct 2, 2019 at 2:15 PM Walter Wu wrote: > > > > > > > > > > On Mon, 2019-09-30 at 12:36 +0800, Walter Wu wrote: > > > > > > On Fri, 2019-09-27 at 21:41 +0200, Dmitry Vyukov wrote: > > > > > > > On Fri, Sep 27, 2019 at 4:22 PM Walter Wu wrote: > > > > > > > > > > > > > > > > On Fri, 2019-09-27 at 15:07 +0200, Dmitry Vyukov wrote: > > > > > > > > > On Fri, Sep 27, 2019 at 5:43 AM Walter Wu wrote: > > > > > > > > > > > > > > > > > > > > memmove() and memcpy() have missing underflow issues. > > > > > > > > > > When -7 <=3D size < 0, then KASAN will miss to catch = the underflow issue. > > > > > > > > > > It looks like shadow start address and shadow end add= ress is the same, > > > > > > > > > > so it does not actually check anything. > > > > > > > > > > > > > > > > > > > > The following test is indeed not caught by KASAN: > > > > > > > > > > > > > > > > > > > > char *p =3D kmalloc(64, GFP_KERNEL); > > > > > > > > > > memset((char *)p, 0, 64); > > > > > > > > > > memmove((char *)p, (char *)p + 4, -2); > > > > > > > > > > kfree((char*)p); > > > > > > > > > > > > > > > > > > > > It should be checked here: > > > > > > > > > > > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len= ) > > > > > > > > > > { > > > > > > > > > > check_memory_region((unsigned long)src, len, = false, _RET_IP_); > > > > > > > > > > check_memory_region((unsigned long)dest, len,= true, _RET_IP_); > > > > > > > > > > > > > > > > > > > > return __memmove(dest, src, len); > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > We fix the shadow end address which is calculated, th= en generic KASAN > > > > > > > > > > get the right shadow end address and detect this unde= rflow issue. > > > > > > > > > > > > > > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D199= 341 > > > > > > > > > > > > > > > > > > > > Signed-off-by: Walter Wu > > > > > > > > > > Reported-by: Dmitry Vyukov > > > > > > > > > > --- > > > > > > > > > > lib/test_kasan.c | 36 ++++++++++++++++++++++++++++= ++++++++ > > > > > > > > > > mm/kasan/generic.c | 8 ++++++-- > > > > > > > > > > 2 files changed, 42 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > > > > > > > > > index b63b367a94e8..8bd014852556 100644 > > > > > > > > > > --- a/lib/test_kasan.c > > > > > > > > > > +++ b/lib/test_kasan.c > > > > > > > > > > @@ -280,6 +280,40 @@ static noinline void __init kmal= loc_oob_in_memset(void) > > > > > > > > > > kfree(ptr); > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > +static noinline void __init kmalloc_oob_in_memmove_u= nderflow(void) > > > > > > > > > > +{ > > > > > > > > > > + char *ptr; > > > > > > > > > > + size_t size =3D 64; > > > > > > > > > > + > > > > > > > > > > + pr_info("underflow out-of-bounds in memmove\n= "); > > > > > > > > > > + ptr =3D kmalloc(size, GFP_KERNEL); > > > > > > > > > > + if (!ptr) { > > > > > > > > > > + pr_err("Allocation failed\n"); > > > > > > > > > > + return; > > > > > > > > > > + } > > > > > > > > > > + > > > > > > > > > > + memset((char *)ptr, 0, 64); > > > > > > > > > > + memmove((char *)ptr, (char *)ptr + 4, -2); > > > > > > > > > > + kfree(ptr); > > > > > > > > > > +} > > > > > > > > > > + > > > > > > > > > > +static noinline void __init kmalloc_oob_in_memmove_o= verflow(void) > > > > > > > > > > +{ > > > > > > > > > > + char *ptr; > > > > > > > > > > + size_t size =3D 64; > > > > > > > > > > + > > > > > > > > > > + pr_info("overflow out-of-bounds in memmove\n"= ); > > > > > > > > > > + ptr =3D kmalloc(size, GFP_KERNEL); > > > > > > > > > > + if (!ptr) { > > > > > > > > > > + pr_err("Allocation failed\n"); > > > > > > > > > > + return; > > > > > > > > > > + } > > > > > > > > > > + > > > > > > > > > > + memset((char *)ptr, 0, 64); > > > > > > > > > > + memmove((char *)ptr + size, (char *)ptr, 2); > > > > > > > > > > + kfree(ptr); > > > > > > > > > > +} > > > > > > > > > > + > > > > > > > > > > static noinline void __init kmalloc_uaf(void) > > > > > > > > > > { > > > > > > > > > > char *ptr; > > > > > > > > > > @@ -734,6 +768,8 @@ static int __init kmalloc_tests_i= nit(void) > > > > > > > > > > kmalloc_oob_memset_4(); > > > > > > > > > > kmalloc_oob_memset_8(); > > > > > > > > > > kmalloc_oob_memset_16(); > > > > > > > > > > + kmalloc_oob_in_memmove_underflow(); > > > > > > > > > > + kmalloc_oob_in_memmove_overflow(); > > > > > > > > > > kmalloc_uaf(); > > > > > > > > > > kmalloc_uaf_memset(); > > > > > > > > > > kmalloc_uaf2(); > > > > > > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > > > > > > index 616f9dd82d12..34ca23d59e67 100644 > > > > > > > > > > --- a/mm/kasan/generic.c > > > > > > > > > > +++ b/mm/kasan/generic.c > > > > > > > > > > @@ -131,9 +131,13 @@ static __always_inline bool memo= ry_is_poisoned_n(unsigned long addr, > > > > > > > > > > size_= t size) > > > > > > > > > > { > > > > > > > > > > unsigned long ret; > > > > > > > > > > + void *shadow_start =3D kasan_mem_to_shadow((v= oid *)addr); > > > > > > > > > > + void *shadow_end =3D kasan_mem_to_shadow((voi= d *)addr + size - 1) + 1; > > > > > > > > > > > > > > > > > > > > - ret =3D memory_is_nonzero(kasan_mem_to_shadow= ((void *)addr), > > > > > > > > > > - kasan_mem_to_shadow((void *)a= ddr + size - 1) + 1); > > > > > > > > > > + if ((long)size < 0) > > > > > > > > > > + shadow_end =3D kasan_mem_to_shadow((v= oid *)addr + size); > > > > > > > > > > > > > > > > > > Hi Walter, > > > > > > > > > > > > > > > > > > Thanks for working on this. > > > > > > > > > > > > > > > > > > If size<0, does it make sense to continue at all? We wi= ll still check > > > > > > > > > 1PB of shadow memory? What happens when we pass such hu= ge range to > > > > > > > > > memory_is_nonzero? > > > > > > > > > Perhaps it's better to produce an error and bail out im= mediately if size<0? > > > > > > > > > > > > > > > > I agree with what you said. when size<0, it is indeed an = unreasonable > > > > > > > > behavior, it should be blocked from continuing to do. > > > > > > > > > > > > > > > > > > > > > > > > > Also, what's the failure mode of the tests? Didn't they= badly corrupt > > > > > > > > > memory? We tried to keep tests such that they produce t= he KASAN > > > > > > > > > reports, but don't badly corrupt memory b/c/ we need to= run all of > > > > > > > > > them. > > > > > > > > > > > > > > > > Maybe we should first produce KASAN reports and then go t= o execute > > > > > > > > memmove() or do nothing? It looks like it=E2=80=99s doing= the following.or? > > > > > > > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > > > > { > > > > > > > > + if (long(len) <=3D 0) > > > > > > > > > > > > > > /\/\/\/\/\/\ > > > > > > > > > > > > > > This check needs to be inside of check_memory_region, other= wise we > > > > > > > will have similar problems in all other places that use > > > > > > > check_memory_region. > > > > > > Thanks for your reminder. > > > > > > > > > > > > bool check_memory_region(unsigned long addr, size_t size, bo= ol write, > > > > > > unsigned long ret_ip) > > > > > > { > > > > > > + if (long(size) < 0) { > > > > > > + kasan_report_invalid_size(src, dest, len, _RE= T_IP_); > > > > > > + return false; > > > > > > + } > > > > > > + > > > > > > return check_memory_region_inline(addr, size, write, = ret_ip); > > > > > > } > > > > > > > > > > > > > But check_memory_region already returns a bool, so we could= check that > > > > > > > bool and return early. > > > > > > > > > > > > When size<0, we should only show one KASAN report, and should= we only > > > > > > limit to return when size<0 is true? If yse, then __memmove()= will do > > > > > > nothing. > > > > > > > > > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > > { > > > > > > - check_memory_region((unsigned long)src, len, false, _= RET_IP_); > > > > > > + if(!check_memory_region((unsigned long)src, len, fals= e, > > > > > > _RET_IP_) > > > > > > + && long(size) < 0) > > > > > > + return; > > > > > > + > > > > > > check_memory_region((unsigned long)dest, len, true, _= RET_IP_); > > > > > > > > > > > > return __memmove(dest, src, len); > > > > > > > > > > > > > > > > > > Hi Dmitry, > > > > > > > > > > What do you think the following code is better than the above o= ne. > > > > > In memmmove/memset/memcpy, they need to determine whether size = < 0 is > > > > > true. we directly determine whether size is negative in memmove= and > > > > > return early. it avoid to generate repeated KASAN report. Is it= better? > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > { > > > > > + if (long(size) < 0) { > > > > > + kasan_report_invalid_size(src, dest, len, _RET_= IP_); > > > > > + return; > > > > > + } > > > > > + > > > > > check_memory_region((unsigned long)src, len, false, _RE= T_IP_); > > > > > check_memory_region((unsigned long)dest, len, true, _RE= T_IP_); > > > > > > > > > > > > > > > check_memory_region() still has to check whether the size is ne= gative. > > > > > but memmove/memset/memcpy generate invalid size KASAN report wi= ll not be > > > > > there. > > > > > > > > > > > > If check_memory_region() will do the check, why do we need to > > > > duplicate it inside of memmove and all other range functions? > > > > > > > Yes, I know it has duplication, but if we don't have to determine s= ize<0 > > > in memmove, then all check_memory_region return false will do nothi= ng, > >=20 > > But they will produce a KASAN report, right? They are asked to check > > if 18446744073709551614 bytes are good. 18446744073709551614 bytes > > can't be good. > >=20 > >=20 > > > it includes other memory corruption behaviors, this is my original > > > concern. > > > > > > > I would do: > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > { > > > > if (check_memory_region((unsigned long)src, len, false, _= RET_IP_)) > > > > return; > > > if check_memory_region return TRUE is to do nothing, but it is no m= emory > > > corruption? Should it return early when check_memory_region return = a > > > FALSE? > >=20 > > Maybe. I just meant the overall idea: check_memory_region should > > detect that 18446744073709551614 bytes are bad, print an error, retur= n > > an indication that bytes were bad, memmove should return early if the > > range is bad. > >=20 > ok, i will send new patch. > Thanks for your review. >=20 how about this? commit fd64691026e7ccb8d2946d0804b0621ac177df38 Author: Walter Wu Date: Fri Sep 27 09:54:18 2019 +0800 kasan: detect invalid size in memory operation function =20 It is an undefined behavior to pass a negative value to memset()/memcpy()/memmove() , so need to be detected by KASAN. =20 KASAN report: =20 BUG: KASAN: invalid size 18446744073709551614 in kmalloc_memmove_invalid_size+0x70/0xa0 =20 CPU: 1 PID: 91 Comm: cat Not tainted 5.3.0-rc1ajb-00001-g31943bbc21ce-dirty #7 Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace+0x0/0x278 show_stack+0x14/0x20 dump_stack+0x108/0x15c print_address_description+0x64/0x368 __kasan_report+0x108/0x1a4 kasan_report+0xc/0x18 check_memory_region+0x15c/0x1b8 memmove+0x34/0x88 kmalloc_memmove_invalid_size+0x70/0xa0 =20 [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D199341 =20 Signed-off-by: Walter Wu Reported-by: Dmitry Vyukov diff --git a/lib/test_kasan.c b/lib/test_kasan.c index b63b367a94e8..e4e517a51860 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -280,6 +280,23 @@ static noinline void __init kmalloc_oob_in_memset(void) kfree(ptr); } =20 +static noinline void __init kmalloc_memmove_invalid_size(void) +{ + char *ptr; + size_t size =3D 64; + + pr_info("invalid size in memmove\n"); + ptr =3D kmalloc(size, GFP_KERNEL); + if (!ptr) { + pr_err("Allocation failed\n"); + return; + } + + memset((char *)ptr, 0, 64); + memmove((char *)ptr, (char *)ptr + 4, -2); + kfree(ptr); +} + static noinline void __init kmalloc_uaf(void) { char *ptr; @@ -734,6 +751,7 @@ static int __init kmalloc_tests_init(void) kmalloc_oob_memset_4(); kmalloc_oob_memset_8(); kmalloc_oob_memset_16(); + kmalloc_memmove_invalid_size; kmalloc_uaf(); kmalloc_uaf_memset(); kmalloc_uaf2(); diff --git a/mm/kasan/common.c b/mm/kasan/common.c index 2277b82902d8..5fd377af7457 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -102,7 +102,8 @@ EXPORT_SYMBOL(__kasan_check_write); #undef memset void *memset(void *addr, int c, size_t len) { - check_memory_region((unsigned long)addr, len, true, _RET_IP_); + if(!check_memory_region((unsigned long)addr, len, true, _RET_IP_)) + return NULL; =20 return __memset(addr, c, len); } @@ -110,7 +111,8 @@ void *memset(void *addr, int c, size_t len) #undef memmove void *memmove(void *dest, const void *src, size_t len) { - check_memory_region((unsigned long)src, len, false, _RET_IP_); + if(!check_memory_region((unsigned long)src, len, false, _RET_IP_)) + return NULL; check_memory_region((unsigned long)dest, len, true, _RET_IP_); =20 return __memmove(dest, src, len); @@ -119,7 +121,8 @@ void *memmove(void *dest, const void *src, size_t len) #undef memcpy void *memcpy(void *dest, const void *src, size_t len) { - check_memory_region((unsigned long)src, len, false, _RET_IP_); + if(!check_memory_region((unsigned long)src, len, false, _RET_IP_)) + return NULL; check_memory_region((unsigned long)dest, len, true, _RET_IP_); =20 return __memcpy(dest, src, len); diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c index 616f9dd82d12..02148a317d27 100644 --- a/mm/kasan/generic.c +++ b/mm/kasan/generic.c @@ -173,6 +173,11 @@ static __always_inline bool check_memory_region_inline(unsigned long addr, if (unlikely(size =3D=3D 0)) return true; =20 + if (unlikely((long)size < 0)) { + kasan_report(addr, size, write, ret_ip); + return false; + } + if (unlikely((void *)addr < kasan_shadow_to_mem((void *)KASAN_SHADOW_START))) { kasan_report(addr, size, write, ret_ip); diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 0e5f965f1882..0cd317ef30f5 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -68,11 +68,16 @@ __setup("kasan_multi_shot", kasan_set_multi_shot); =20 static void print_error_description(struct kasan_access_info *info) { - pr_err("BUG: KASAN: %s in %pS\n", - get_bug_type(info), (void *)info->ip); - pr_err("%s of size %zu at addr %px by task %s/%d\n", - info->is_write ? "Write" : "Read", info->access_size, - info->access_addr, current->comm, task_pid_nr(current)); + if ((long)info->access_size < 0) { + pr_err("BUG: KASAN: invalid size %zu in %pS\n", + info->access_size, (void *)info->ip); + } else { + pr_err("BUG: KASAN: %s in %pS\n", + get_bug_type(info), (void *)info->ip); + pr_err("%s of size %zu at addr %px by task %s/%d\n", + info->is_write ? "Write" : "Read", info->access_size, + info->access_addr, current->comm, task_pid_nr(current)); + } } =20 static DEFINE_SPINLOCK(report_lock); diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c index 0e987c9ca052..b829535a3ad7 100644 --- a/mm/kasan/tags.c +++ b/mm/kasan/tags.c @@ -86,6 +86,11 @@ bool check_memory_region(unsigned long addr, size_t size, bool write, if (unlikely(size =3D=3D 0)) return true; =20 + if (unlikely((long)size < 0)) { + kasan_report(addr, size, write, ret_ip); + return false; + } + tag =3D get_tag((const void *)addr); =20 /*