From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qian Cai Date: Tue, 15 Oct 2019 18:09:42 +0000 Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers Message-Id: <1571162982.5937.42.camel@lca.pw> List-Id: References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> In-Reply-To: <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Anshuman Khandual , linux-mm@kvack.org Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: > +static unsigned long __init get_random_vaddr(void) > +{ > + unsigned long random_vaddr, random_pages, total_user_pages; > + > + total_user_pages = (TASK_SIZE - FIRST_USER_ADDRESS) / PAGE_SIZE; > + > + random_pages = get_random_long() % total_user_pages; > + random_vaddr = FIRST_USER_ADDRESS + random_pages * PAGE_SIZE; > + > + WARN_ON(random_vaddr > TASK_SIZE); > + WARN_ON(random_vaddr < FIRST_USER_ADDRESS); It would be nice if this patch does not introduce a new W=1 GCC warning here on x86 because FIRST_USER_ADDRESS is 0, and GCC think the code is dumb because "random_vaddr" is unsigned, In file included from ./arch/x86/include/asm/bug.h:83,                  from ./include/linux/bug.h:5,                  from ./include/linux/mmdebug.h:5,                  from ./include/linux/gfp.h:5,                  from mm/debug_vm_pgtable.c:13: mm/debug_vm_pgtable.c: In function ‘get_random_vaddr’: mm/debug_vm_pgtable.c:359:23: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]   WARN_ON(random_vaddr < FIRST_USER_ADDRESS);                        ^ ./include/asm-generic/bug.h:113:25: note: in definition of macro ‘WARN_ON’   int __ret_warn_on = !!(condition);    \                          ^~~~~~~~~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE918C10F14 for ; Tue, 15 Oct 2019 18:09:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BD3F20873 for ; Tue, 15 Oct 2019 18:09:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="OnJVDC5h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730688AbfJOSJr (ORCPT ); Tue, 15 Oct 2019 14:09:47 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:46861 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728272AbfJOSJr (ORCPT ); Tue, 15 Oct 2019 14:09:47 -0400 Received: by mail-qt1-f193.google.com with SMTP id u22so31896336qtq.13 for ; Tue, 15 Oct 2019 11:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=OnJVDC5hcrBKYzJ0aaZLxRkdp1U3qCbQgu81veLGc4CM3Zb6t5hcOJCBpTdvyBdixF VWur9qZ4L56kK+G5lLndae4M48fKcE348SEdyWD92O4lDLHkfxe5ub5wW2//gFbMdbTi iE/SuY24OOqYt++fDwkOv1/GwgIUIlLUQjLQSRUD9o8GbrJtA9JJHM6yNqLJ6MTwQsp1 dfxkcvx1nTD9OtgmSDJrI8pHgij5k8GqR5jvJV2yqTmJQajvA0gKezgdBIJXSTBKmtgD Bn30ldSgF22fHm04r+hQGzlUE6CW7jcqmMjIT04sV5F04SskgoCcXMGW7VfjZDMID4ld SbxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=KkwFpSvaav/26JvTogYQAc20qNS4NpRsbef8tOOtnx9BxsS+LIw4UcKXQOkmm3YbJf vbjTaOczzpIPhyhQ9OdRL97FAPE0/CULmmfN3TWX2YF5A5vabaNXVPhOAFDEG5l1R1XG M/8ESkAvmnV+7LSdTleavDcQU/X9q794Xhp1+X5wWl7p8EVDjwY4d0LOoJ5GUTdtNVET qqYfBrAXW6wtbax+yV07Uf30u4QQtbNNRxO7Fz/rKuaG83T1VFjZWwYiuW3dTz76cN0X X3Z+uD5kuvLBTHl/C2S40rjRIyNafaKl5y9kyEww+79oEywo12P7TRt24WFdNWe8fZHZ wrgg== X-Gm-Message-State: APjAAAXVeHu/Fr5gdqXpLHAgxh+eccf4n5KERscaBqODgA52cB+bds0S IZCzEyCh1ezWAXaeW8yM7aZYDw== X-Google-Smtp-Source: APXvYqyVLYUWTIAK6GzhvgdzZLJE6+q5wD4mjw+q975FciP9rpwUqd4etcurLcTJHzy5ZkDdOjbnKA== X-Received: by 2002:ac8:7289:: with SMTP id v9mr39571710qto.139.1571162985818; Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k54sm15559033qtf.28.2019.10.15.11.09.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Message-ID: <1571162982.5937.42.camel@lca.pw> Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Date: Tue, 15 Oct 2019 14:09:42 -0400 In-Reply-To: <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: > +static unsigned long __init get_random_vaddr(void) > +{ > + unsigned long random_vaddr, random_pages, total_user_pages; > + > + total_user_pages = (TASK_SIZE - FIRST_USER_ADDRESS) / PAGE_SIZE; > + > + random_pages = get_random_long() % total_user_pages; > + random_vaddr = FIRST_USER_ADDRESS + random_pages * PAGE_SIZE; > + > + WARN_ON(random_vaddr > TASK_SIZE); > + WARN_ON(random_vaddr < FIRST_USER_ADDRESS); It would be nice if this patch does not introduce a new W=1 GCC warning here on x86 because FIRST_USER_ADDRESS is 0, and GCC think the code is dumb because "random_vaddr" is unsigned, In file included from ./arch/x86/include/asm/bug.h:83,                  from ./include/linux/bug.h:5,                  from ./include/linux/mmdebug.h:5,                  from ./include/linux/gfp.h:5,                  from mm/debug_vm_pgtable.c:13: mm/debug_vm_pgtable.c: In function ‘get_random_vaddr’: mm/debug_vm_pgtable.c:359:23: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]   WARN_ON(random_vaddr < FIRST_USER_ADDRESS);                        ^ ./include/asm-generic/bug.h:113:25: note: in definition of macro ‘WARN_ON’   int __ret_warn_on = !!(condition);    \                          ^~~~~~~~~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A62C10F14 for ; Tue, 15 Oct 2019 18:09:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE66F2086A for ; Tue, 15 Oct 2019 18:09:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AUusja6N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="OnJVDC5h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE66F2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6N7OqE3rX9zJhkvSiWhasIrtsrHhFMRx8wAQX0nYTbE=; b=AUusja6NvovL7F h6eaM9uAjj45cctJwnHhx5+YLnmTiirdYU1RbZRJrirsz2ZluDfuuPcBCfsqujEtzeWocTguxPtuR SZxmAf3fkJjAYOw52syQEr2ixYWJqKnnzjq5pOdPCpxrmA1SzABDC16llmL6jLImwQoObd5IAAAE5 EfwfDE8Pl+6KDU6FXk9qtLI/VOygS12+BPTLYdA1U5OnwDjg4lXeYy3y1PiqpN3NG9H2iL1rUlENd 1jekMj+m13PmZryFK3bf/8dpQHIhRrCtCzdMldu//iXzJXiuM2j3/BE6XPff8wUb5rtEDkaeL9Jaj nxvfXCNBILAh6SqVzFYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKRGY-0005M6-Ux; Tue, 15 Oct 2019 18:09:50 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKRGW-0005JO-11 for linux-snps-arc@lists.infradead.org; Tue, 15 Oct 2019 18:09:49 +0000 Received: by mail-qt1-x842.google.com with SMTP id t20so26570410qtr.10 for ; Tue, 15 Oct 2019 11:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=OnJVDC5hcrBKYzJ0aaZLxRkdp1U3qCbQgu81veLGc4CM3Zb6t5hcOJCBpTdvyBdixF VWur9qZ4L56kK+G5lLndae4M48fKcE348SEdyWD92O4lDLHkfxe5ub5wW2//gFbMdbTi iE/SuY24OOqYt++fDwkOv1/GwgIUIlLUQjLQSRUD9o8GbrJtA9JJHM6yNqLJ6MTwQsp1 dfxkcvx1nTD9OtgmSDJrI8pHgij5k8GqR5jvJV2yqTmJQajvA0gKezgdBIJXSTBKmtgD Bn30ldSgF22fHm04r+hQGzlUE6CW7jcqmMjIT04sV5F04SskgoCcXMGW7VfjZDMID4ld SbxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=k8eegCiTOxro0QFK8nLcaNysmivT1J/nq4ZTBgB5zEewRTzKM9BN9l6NBRsudAJd2E 3pPE7N00bPQSAvrhZuO6RUvPojgXp1WDu/XamW8BntoVBTiIuwTWeS7+rvn+o6b5mpiv KfZdkWXiYbb6Yw4Vi2NuIAbt/vCWg2PRLM5dtusriGHdhfRdUlkv/UJaXamGN7+0+W+B 9JMJk05j2etiCN0ODwq6BP9RLd8gwEWrYLMehWjmSlNAL1lCm+JwSChe15D9msfDLzif KjqUURhHSNELu313Re4mdXmV8x5H9ucX7rS6nEpQDWW8sN577BY+FO3KLdMtdL1ogAb5 +9/Q== X-Gm-Message-State: APjAAAXM9SlWQEQk4ig2LiwqBa3rItCHuKg93p2CwKB1YwQmVHTa+l1L E/a5sOu2L6rUuWY3fNz5SesRPQ== X-Google-Smtp-Source: APXvYqyVLYUWTIAK6GzhvgdzZLJE6+q5wD4mjw+q975FciP9rpwUqd4etcurLcTJHzy5ZkDdOjbnKA== X-Received: by 2002:ac8:7289:: with SMTP id v9mr39571710qto.139.1571162985818; Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k54sm15559033qtf.28.2019.10.15.11.09.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Message-ID: <1571162982.5937.42.camel@lca.pw> Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Anshuman Khandual , linux-mm@kvack.org Date: Tue, 15 Oct 2019 14:09:42 -0400 In-Reply-To: <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_110948_100433_11FF6029 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMDE5LTEwLTE1IGF0IDE0OjUxICswNTMwLCBBbnNodW1hbiBLaGFuZHVhbCB3cm90 ZToKPiArc3RhdGljIHVuc2lnbmVkIGxvbmcgX19pbml0IGdldF9yYW5kb21fdmFkZHIodm9pZCkK PiArewo+ICsJdW5zaWduZWQgbG9uZyByYW5kb21fdmFkZHIsIHJhbmRvbV9wYWdlcywgdG90YWxf dXNlcl9wYWdlczsKPiArCj4gKwl0b3RhbF91c2VyX3BhZ2VzID0gKFRBU0tfU0laRSAtIEZJUlNU X1VTRVJfQUREUkVTUykgLyBQQUdFX1NJWkU7Cj4gKwo+ICsJcmFuZG9tX3BhZ2VzID0gZ2V0X3Jh bmRvbV9sb25nKCkgJSB0b3RhbF91c2VyX3BhZ2VzOwo+ICsJcmFuZG9tX3ZhZGRyID0gRklSU1Rf VVNFUl9BRERSRVNTICsgcmFuZG9tX3BhZ2VzICogUEFHRV9TSVpFOwo+ICsKPiArCVdBUk5fT04o cmFuZG9tX3ZhZGRyID4gVEFTS19TSVpFKTsKPiArCVdBUk5fT04ocmFuZG9tX3ZhZGRyIDwgRklS U1RfVVNFUl9BRERSRVNTKTsKCkl0IHdvdWxkIGJlIG5pY2UgaWYgdGhpcyBwYXRjaCBkb2VzIG5v dCBpbnRyb2R1Y2UgYSBuZXcgVz0xIEdDQyB3YXJuaW5nIGhlcmUgb24KeDg2IGJlY2F1c2UgRklS U1RfVVNFUl9BRERSRVNTIGlzIDAsIGFuZCBHQ0MgdGhpbmsgdGhlIGNvZGUgaXMgZHVtYiBiZWNh dXNlCiJyYW5kb21fdmFkZHIiIGlzIHVuc2lnbmVkLAoKSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4v YXJjaC94ODYvaW5jbHVkZS9hc20vYnVnLmg6ODMsCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9idWcuaDo1LArCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgZnJvbSAuL2luY2x1ZGUvbGludXgvbW1kZWJ1Zy5oOjUsCsKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9nZnAuaDo1LArC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnJvbSBtbS9kZWJ1Z192bV9wZ3RhYmxl LmM6MTM6Cm1tL2RlYnVnX3ZtX3BndGFibGUuYzogSW4gZnVuY3Rpb24g4oCYZ2V0X3JhbmRvbV92 YWRkcuKAmToKbW0vZGVidWdfdm1fcGd0YWJsZS5jOjM1OToyMzogd2FybmluZzogY29tcGFyaXNv biBvZiB1bnNpZ25lZCBleHByZXNzaW9uIDwgMCBpcwphbHdheXMgZmFsc2UgWy1XdHlwZS1saW1p dHNdCsKgIFdBUk5fT04ocmFuZG9tX3ZhZGRyIDwgRklSU1RfVVNFUl9BRERSRVNTKTsKwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoF4KLi9pbmNsdWRlL2FzbS1n ZW5lcmljL2J1Zy5oOjExMzoyNTogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyDigJhXQVJO X09O4oCZCsKgIGludCBfX3JldF93YXJuX29uID0gISEoY29uZGl0aW9uKTvCoMKgwqDCoFwKwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBefn5+fn5+fn4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXNu cHMtYXJjIG1haWxpbmcgbGlzdApsaW51eC1zbnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtc25wcy1hcmMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B5EC10F14 for ; Tue, 15 Oct 2019 18:18:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A23120663 for ; Tue, 15 Oct 2019 18:18:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="OnJVDC5h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A23120663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46t3b6254xzDqDc for ; Wed, 16 Oct 2019 05:18:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lca.pw (client-ip=2607:f8b0:4864:20::841; helo=mail-qt1-x841.google.com; envelope-from=cai@lca.pw; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lca.pw header.i=@lca.pw header.b="OnJVDC5h"; dkim-atps=neutral Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46t3Nr6qNLzDr4D for ; Wed, 16 Oct 2019 05:09:48 +1100 (AEDT) Received: by mail-qt1-x841.google.com with SMTP id u40so31866892qth.11 for ; Tue, 15 Oct 2019 11:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=OnJVDC5hcrBKYzJ0aaZLxRkdp1U3qCbQgu81veLGc4CM3Zb6t5hcOJCBpTdvyBdixF VWur9qZ4L56kK+G5lLndae4M48fKcE348SEdyWD92O4lDLHkfxe5ub5wW2//gFbMdbTi iE/SuY24OOqYt++fDwkOv1/GwgIUIlLUQjLQSRUD9o8GbrJtA9JJHM6yNqLJ6MTwQsp1 dfxkcvx1nTD9OtgmSDJrI8pHgij5k8GqR5jvJV2yqTmJQajvA0gKezgdBIJXSTBKmtgD Bn30ldSgF22fHm04r+hQGzlUE6CW7jcqmMjIT04sV5F04SskgoCcXMGW7VfjZDMID4ld SbxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=r1HXjbQfpzL9edZt3Z6WNSjxFRVEUp3V7AGiGRs59X4ICv35UoMXd1uktMBOy5fcCS EKiebeLreOzq8iX81nJf5DTkKOgIaoYm6J/Zd0n/ZDfy5iswPsim6Pm5Lr/JoRXZrZo+ INfNsCquqNeSZVGH57u7t2AVL3SeLUAhQ9gm8Bfoer6jLO7pCtHGR42LBr2ZQYpGotui g5+DcdWqWdzixQc5T2iR6Gb6qbODen1xnQx0ElTJjeVK5zgaRX5SEHBP3rxp5X99/FrF sZ2afvEzalSLt3OD32KLN3PPdMyBoRgS+RrkyFlqsab7R4J9ltgY19VbNsWiEZzsrbG3 a19g== X-Gm-Message-State: APjAAAVJ9YkJQBdYlwXTUL2GCJhqQZGoQMffziup6zopfxnCUObNXgfJ yvfs5+ZgJKfnZ4pVG1/AVxg+S+DBYS0= X-Google-Smtp-Source: APXvYqyVLYUWTIAK6GzhvgdzZLJE6+q5wD4mjw+q975FciP9rpwUqd4etcurLcTJHzy5ZkDdOjbnKA== X-Received: by 2002:ac8:7289:: with SMTP id v9mr39571710qto.139.1571162985818; Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k54sm15559033qtf.28.2019.10.15.11.09.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Message-ID: <1571162982.5937.42.camel@lca.pw> Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Anshuman Khandual , linux-mm@kvack.org Date: Tue, 15 Oct 2019 14:09:42 -0400 In-Reply-To: <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: > +static unsigned long __init get_random_vaddr(void) > +{ > + unsigned long random_vaddr, random_pages, total_user_pages; > + > + total_user_pages = (TASK_SIZE - FIRST_USER_ADDRESS) / PAGE_SIZE; > + > + random_pages = get_random_long() % total_user_pages; > + random_vaddr = FIRST_USER_ADDRESS + random_pages * PAGE_SIZE; > + > + WARN_ON(random_vaddr > TASK_SIZE); > + WARN_ON(random_vaddr < FIRST_USER_ADDRESS); It would be nice if this patch does not introduce a new W=1 GCC warning here on x86 because FIRST_USER_ADDRESS is 0, and GCC think the code is dumb because "random_vaddr" is unsigned, In file included from ./arch/x86/include/asm/bug.h:83,                  from ./include/linux/bug.h:5,                  from ./include/linux/mmdebug.h:5,                  from ./include/linux/gfp.h:5,                  from mm/debug_vm_pgtable.c:13: mm/debug_vm_pgtable.c: In function ‘get_random_vaddr’: mm/debug_vm_pgtable.c:359:23: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]   WARN_ON(random_vaddr < FIRST_USER_ADDRESS);                        ^ ./include/asm-generic/bug.h:113:25: note: in definition of macro ‘WARN_ON’   int __ret_warn_on = !!(condition);    \                          ^~~~~~~~~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8436C10F14 for ; Tue, 15 Oct 2019 18:09:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F80620659 for ; Tue, 15 Oct 2019 18:09:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oBWUJiG7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="OnJVDC5h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F80620659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JjNL7LtGN2WpRVz3memepKZsNJJpA8nhyLlzJ9sDfXU=; b=oBWUJiG7XfOm0J ZM844Mn5wWgkk4mSqXDjamKNZeINrXlPjwju/ynsHvtMz69Kvt40bt0KUiK8RfqTdcmKGgA/bjSQp xo6zEzBQcHGdrkOOMHWP3dMb0//uFVQT70eD2mvB1FI8peksixYfxLSiIh6l32HBiBxgpfnkG9GNa NbRLAn9tv3t/dseLUwBv6hn278EEaz3TPIJGlikKtMB9NVDzQws54JBcU7LdOPO0YdZ7yDvVgUbFa J7f2T2vz9Ng7e/j6yO7LOzTqUWQNaEiOLy8SEabBsoSMf+6Ka5LAt6ic1SyxFcPQ5GWKaq1LNs4ec ZMUlHFkSF1VcHd62Is2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKRGZ-0005MH-Ff; Tue, 15 Oct 2019 18:09:51 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKRGW-0005JP-10 for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 18:09:49 +0000 Received: by mail-qt1-x842.google.com with SMTP id u40so31866894qth.11 for ; Tue, 15 Oct 2019 11:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=OnJVDC5hcrBKYzJ0aaZLxRkdp1U3qCbQgu81veLGc4CM3Zb6t5hcOJCBpTdvyBdixF VWur9qZ4L56kK+G5lLndae4M48fKcE348SEdyWD92O4lDLHkfxe5ub5wW2//gFbMdbTi iE/SuY24OOqYt++fDwkOv1/GwgIUIlLUQjLQSRUD9o8GbrJtA9JJHM6yNqLJ6MTwQsp1 dfxkcvx1nTD9OtgmSDJrI8pHgij5k8GqR5jvJV2yqTmJQajvA0gKezgdBIJXSTBKmtgD Bn30ldSgF22fHm04r+hQGzlUE6CW7jcqmMjIT04sV5F04SskgoCcXMGW7VfjZDMID4ld SbxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=N0FOPCTgwiGlGoDUCj+tobZuwPkXgeX0pTzaAKQ2ORtoRmqjJtaduyh3f8HEiqnqVj Y9V5Hf1xzjyxuPtdUq1YeHMb30rjNvEPoRUR5QSLyt1LU4FN78y0Znb1hLcc70AsXXMV QEqrzi1szq9V6GgryWnQao8KjrD7yjUiA5fojUytRHHI/3E39ggeWeDeuOA8fUniKxCf J0vw23loF9kYCUfj9PcDKEPLFNorZ6c9lfynDgqbndOguGU403fkFv0vmZ3UW35LJyT0 OUQ+ws1hQHfSXeDq5QXe6ZBZgiybtsdxd30CgbTKwHEn0JC4EUVYLbmaQ1K8axWEp9Hl m7YQ== X-Gm-Message-State: APjAAAXBGCanqk2aoLm+0pEswvC0H9SBPYR/Trxw7bSriLTgi+elIbGf EzuL43Zdlg9JQDchBPvjKCzYxA== X-Google-Smtp-Source: APXvYqyVLYUWTIAK6GzhvgdzZLJE6+q5wD4mjw+q975FciP9rpwUqd4etcurLcTJHzy5ZkDdOjbnKA== X-Received: by 2002:ac8:7289:: with SMTP id v9mr39571710qto.139.1571162985818; Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k54sm15559033qtf.28.2019.10.15.11.09.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Message-ID: <1571162982.5937.42.camel@lca.pw> Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Anshuman Khandual , linux-mm@kvack.org Date: Tue, 15 Oct 2019 14:09:42 -0400 In-Reply-To: <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_110948_098723_AC151F5E X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMDE5LTEwLTE1IGF0IDE0OjUxICswNTMwLCBBbnNodW1hbiBLaGFuZHVhbCB3cm90 ZToKPiArc3RhdGljIHVuc2lnbmVkIGxvbmcgX19pbml0IGdldF9yYW5kb21fdmFkZHIodm9pZCkK PiArewo+ICsJdW5zaWduZWQgbG9uZyByYW5kb21fdmFkZHIsIHJhbmRvbV9wYWdlcywgdG90YWxf dXNlcl9wYWdlczsKPiArCj4gKwl0b3RhbF91c2VyX3BhZ2VzID0gKFRBU0tfU0laRSAtIEZJUlNU X1VTRVJfQUREUkVTUykgLyBQQUdFX1NJWkU7Cj4gKwo+ICsJcmFuZG9tX3BhZ2VzID0gZ2V0X3Jh bmRvbV9sb25nKCkgJSB0b3RhbF91c2VyX3BhZ2VzOwo+ICsJcmFuZG9tX3ZhZGRyID0gRklSU1Rf VVNFUl9BRERSRVNTICsgcmFuZG9tX3BhZ2VzICogUEFHRV9TSVpFOwo+ICsKPiArCVdBUk5fT04o cmFuZG9tX3ZhZGRyID4gVEFTS19TSVpFKTsKPiArCVdBUk5fT04ocmFuZG9tX3ZhZGRyIDwgRklS U1RfVVNFUl9BRERSRVNTKTsKCkl0IHdvdWxkIGJlIG5pY2UgaWYgdGhpcyBwYXRjaCBkb2VzIG5v dCBpbnRyb2R1Y2UgYSBuZXcgVz0xIEdDQyB3YXJuaW5nIGhlcmUgb24KeDg2IGJlY2F1c2UgRklS U1RfVVNFUl9BRERSRVNTIGlzIDAsIGFuZCBHQ0MgdGhpbmsgdGhlIGNvZGUgaXMgZHVtYiBiZWNh dXNlCiJyYW5kb21fdmFkZHIiIGlzIHVuc2lnbmVkLAoKSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4v YXJjaC94ODYvaW5jbHVkZS9hc20vYnVnLmg6ODMsCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9idWcuaDo1LArCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgZnJvbSAuL2luY2x1ZGUvbGludXgvbW1kZWJ1Zy5oOjUsCsKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9nZnAuaDo1LArC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnJvbSBtbS9kZWJ1Z192bV9wZ3RhYmxl LmM6MTM6Cm1tL2RlYnVnX3ZtX3BndGFibGUuYzogSW4gZnVuY3Rpb24g4oCYZ2V0X3JhbmRvbV92 YWRkcuKAmToKbW0vZGVidWdfdm1fcGd0YWJsZS5jOjM1OToyMzogd2FybmluZzogY29tcGFyaXNv biBvZiB1bnNpZ25lZCBleHByZXNzaW9uIDwgMCBpcwphbHdheXMgZmFsc2UgWy1XdHlwZS1saW1p dHNdCsKgIFdBUk5fT04ocmFuZG9tX3ZhZGRyIDwgRklSU1RfVVNFUl9BRERSRVNTKTsKwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoF4KLi9pbmNsdWRlL2FzbS1n ZW5lcmljL2J1Zy5oOjExMzoyNTogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyDigJhXQVJO X09O4oCZCsKgIGludCBfX3JldF93YXJuX29uID0gISEoY29uZGl0aW9uKTvCoMKgwqDCoFwKwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBefn5+fn5+fn4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK