From: Oliver Neukum <oneukum@suse.com>
To: David Miller <davem@davemloft.net>
Cc: johan@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] usb: hso: obey DMA rules in tiocmget
Date: Thu, 17 Oct 2019 22:35:10 +0200 [thread overview]
Message-ID: <1571344510.5264.18.camel@suse.com> (raw)
In-Reply-To: <20191017.142055.130965767343659716.davem@davemloft.net>
Am Donnerstag, den 17.10.2019, 14:20 -0400 schrieb David Miller:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 17 Oct 2019 14:19:55 -0400 (EDT)
>
> > From: Oliver Neukum <oneukum@suse.com>
> > Date: Thu, 17 Oct 2019 11:53:38 +0200
> >
> > > The serial state information must not be embedded into another
> > > data structure, as this interferes with cache handling for DMA
> > > on architectures without cache coherence..
> > > That would result in data corruption on some architectures
> > > Allocating it separately.
> > >
> > > Signed-off-by: Oliver Neukum <oneukum@suse.com>
> >
> > Applied, thanks Oliver.
>
> Ugh, Oliver did you even build test this?
>
> drivers/net/usb/hso.c:189:9: error: expected ‘{’ before ‘*’ token
> 189 | struct *hso_serial_state_notification serial_state_notification;
>
> Seriously, I expect better from an experienced developer such as
> yourself.
Sorry, that is why I sent a v2. I built it, but not alone. I have
a cleanup series for that driver in the works.
Sorry
Oliver
prev parent reply other threads:[~2019-10-17 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:53 [PATCH] usb: hso: obey DMA rules in tiocmget Oliver Neukum
2019-10-17 18:19 ` David Miller
2019-10-17 18:20 ` David Miller
2019-10-17 20:35 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571344510.5264.18.camel@suse.com \
--to=oneukum@suse.com \
--cc=davem@davemloft.net \
--cc=johan@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.