From: Masami Hiramatsu <mhiramat@kernel.org>
To: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
jaswinder.singh@linaro.org, Alexey Dobriyan <adobriyan@gmail.com>
Subject: [BUGFIX PATCH v3 1/5] selftests: proc: Make va_max 1MB
Date: Wed, 23 Oct 2019 13:57:40 +0900 [thread overview]
Message-ID: <157180666053.17298.15273701201071089765.stgit@devnote2> (raw)
In-Reply-To: <157180665007.17298.907392422924029261.stgit@devnote2>
Currently proc-self-map-files-002.c sets va_max (max test address
of user virtual address) to 4GB, but it is too big for 32bit
arch and 1UL << 32 is overflow on 32bit long.
Also since this value should be enough bigger than vm.mmap_min_addr
(64KB or 32KB by default), 1MB should be enough.
Make va_max 1MB unconditionally.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
---
Changes in v3:
- Make the va_max 1MB unconditionally, according to Alexey's comment.
Changes in v2:
- Make the va_max 1GB according to Alexey's comment.
---
.../selftests/proc/proc-self-map-files-002.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/proc/proc-self-map-files-002.c b/tools/testing/selftests/proc/proc-self-map-files-002.c
index 47b7473dedef..e6aa00a183bc 100644
--- a/tools/testing/selftests/proc/proc-self-map-files-002.c
+++ b/tools/testing/selftests/proc/proc-self-map-files-002.c
@@ -47,7 +47,11 @@ static void fail(const char *fmt, unsigned long a, unsigned long b)
int main(void)
{
const int PAGE_SIZE = sysconf(_SC_PAGESIZE);
- const unsigned long va_max = 1UL << 32;
+ /*
+ * va_max must be enough bigger than vm.mmap_min_addr, which is
+ * 64KB/32KB by default. (depends on CONFIG_LSM_MMAP_MIN_ADDR)
+ */
+ const unsigned long va_max = 1UL << 20;
unsigned long va;
void *p;
int fd;
next prev parent reply other threads:[~2019-10-23 4:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 4:57 [BUGFIX PATCH v3 0/5] selftests: Fixes for 32bit arch Masami Hiramatsu
2019-10-23 4:57 ` Masami Hiramatsu [this message]
2019-10-23 4:57 ` [BUGFIX PATCH v3 2/5] selftests: vm: Build/Run 64bit tests only on 64bit arch Masami Hiramatsu
2019-10-23 4:57 ` [BUGFIX PATCH v3 3/5] selftests: net: Use size_t and ssize_t for counting file size Masami Hiramatsu
2019-10-23 4:58 ` [BUGFIX PATCH v3 4/5] selftests: net: Fix printf format warnings on arm Masami Hiramatsu
2019-10-23 4:58 ` [BUGFIX PATCH v3 5/5] selftests: sync: Fix cast " Masami Hiramatsu
2019-10-31 11:23 ` [BUGFIX PATCH v3 0/5] selftests: Fixes for 32bit arch Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157180666053.17298.15273701201071089765.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=adobriyan@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.