From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7770FCA9EAF for ; Thu, 24 Oct 2019 07:03:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44E6C21655 for ; Thu, 24 Oct 2019 07:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WbPHnQpd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44E6C21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nNowubvAglDxX+faaGY/X9Ry1p4p8RDHs3HShVotICg=; b=WbPHnQpdxELmCD wjKs3iu19IsN+klfF8x9KR8e7IVV1oZ/iTxhciz52Q4qCa+Ke1KjIAvQ6ebZnEfJViFxsEoljTBYx SdO4qBcWtuHNTybxqVKm8Co/JJsCfzfTAUQVQjHNmpOqZ6Ia/naHPRgdKjbiqiPJ+XwN0IvGrte+r 175DDHU1j4eMWkIRUpYechvbgkebOuObzjVxNshuFGYEH6cj1ZfKgag+Y5P82gmCfLdR8YsC5Cctb 9N2HpSDM+3WXPyXnpk06vxqmmfx7z090fuO2/kU1V45bQvqgdUKW0hy+b4hExLrPgeEFrSz/gOHhs ZI13k9sV80uiInqFwJog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNX9k-0004U5-NE; Thu, 24 Oct 2019 07:03:36 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNX9g-0004Su-N9; Thu, 24 Oct 2019 07:03:34 +0000 X-UUID: cd076735d9bc46259b261d3ecc0aa8af-20191023 X-UUID: cd076735d9bc46259b261d3ecc0aa8af-20191023 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1085928592; Wed, 23 Oct 2019 23:03:11 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Oct 2019 00:03:03 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Oct 2019 15:02:56 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 24 Oct 2019 15:02:56 +0800 Message-ID: <1571900577.27203.6.camel@mtksdaap41> Subject: Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers From: CK Hu To: Rob Herring Date: Thu, 24 Oct 2019 15:02:57 +0800 In-Reply-To: References: <20191021214550.1461-1-robh@kernel.org> <20191021214550.1461-6-robh@kernel.org> <1cbca96c-19dd-1d15-949c-7fbcc15369b4@gmail.com> <1571864784.19128.8.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191024_000332_759610_4C6FAB57 X-CRM114-Status: GOOD ( 27.11 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?ISO-8859-1?Q?St=FCbner?= , Neil Armstrong , David Airlie , Liviu Dudau , Sandy Huang , Laurent Pinchart , Benjamin Gaignard , Yannick Fertre , Nicolas Boichat , Kevin Hilman , Xinwei Kong , Xinliang Liu , "open list:ARM/Rockchip SoC..." , Chen-Yu Tsai , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , "James \(Qian\) Wang" , Philipp Zabel , Ulrich Hecht , Alexandre Torgue , Chen Feng , Maarten Lankhorst , Maxime Ripard , "moderated list:ARM/Mediatek SoC support" , dri-devel , Matthias Brugger , Daniel Vetter , Sean Paul , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Philippe Cornu , Vincent Abriou , Kieran Bingham , Maxime Coquelin , Rongrong Zou Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Rob: On Wed, 2019-10-23 at 17:56 -0500, Rob Herring wrote: > On Wed, Oct 23, 2019 at 4:06 PM CK Hu wrote: > > > > Hi, Rob: > > > > On Wed, 2019-10-23 at 12:42 -0500, Rob Herring wrote: > > > On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger > > > wrote: > > > > > > > > Hi Rob, > > > > > > > > On 21/10/2019 23:45, Rob Herring wrote: > > > > > The only reason the Mediatek driver doesn't use the CMA helpers is it > > > > > sets DMA_ATTR_NO_KERNEL_MAPPING and does a vmap() on demand. Using > > > > > vmap() is not even guaranteed to work as DMA buffers may not have a > > > > > struct page. Now that the CMA helpers support setting > > > > > DMA_ATTR_NO_KERNEL_MAPPING as needed or not, convert Mediatek driver to > > > > > use CMA helpers. > > > > > > > > > > Cc: CK Hu > > > > > Cc: Philipp Zabel > > > > > Cc: David Airlie > > > > > Cc: Daniel Vetter > > > > > Cc: Matthias Brugger > > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > > Cc: linux-mediatek@lists.infradead.org > > > > > Signed-off-by: Rob Herring > > > > > --- > > > > > > > > I tested this on my Chromebook with some patches on top of v5.4-rc1 [1], which > > > > work. If I add your patches on top of that, the system does not boot up. > > > > Unfortunately I don't have a serial console, so I wasn't able to see if there is > > > > any error message. > > > > > > Thanks for testing. I'm based on drm-misc-next, but don't see anything > > > obvious there that would matter. There are some mmap changes, but I > > > think they shouldn't matter. > > > > > > Did you have fbcon enabled? That may give more clues about where the problem is. > > > > There are priv->dma_dev for dma device, but it is not drm device. In > > mt8173.dtsi [1], there are mmsys device and ovl device, mmsys device is > > drm device and ovl device is mmsys's sub device which provide dma > > function, so ovl is the priv->dma_dev. I think your patch directly use > > drm device for dma operation and this would cause dma function fail. > > Please use priv->dma_dev for dma operation. > > Right, thanks for catching that. Either we'll need to make CMA GEM > object have a struct device ptr or adjust the drm_device.dev to have > the necessary DMA setup. > > One question though, why do you use CMA when you have an IOMMU? That's > not optimal as CMA size may be limited. Or you don't always have an > IOMMU? For all upstreamed mediatek SoC, all has IOMMU, so it does not need CMA. I think we use CMA just because we refer to other drm driver to implement mediatek drm driver and we misused CMA helper function but it works. I think we should change to more accurate implementation. If you want, you could modify it in this series. Regards, CK > > Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers Date: Thu, 24 Oct 2019 15:02:57 +0800 Message-ID: <1571900577.27203.6.camel@mtksdaap41> References: <20191021214550.1461-1-robh@kernel.org> <20191021214550.1461-6-robh@kernel.org> <1cbca96c-19dd-1d15-949c-7fbcc15369b4@gmail.com> <1571864784.19128.8.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Neil Armstrong , David Airlie , Liviu Dudau , Laurent Pinchart , Yannick Fertre , Nicolas Boichat , Kevin Hilman , Xinwei Kong , Xinliang Liu , "open list:ARM/Rockchip SoC..." , Chen-Yu Tsai , "James (Qian) Wang" , Ulrich Hecht , Alexandre Torgue , Chen Feng , "moderated list:ARM/Mediatek SoC support" , dri-devel , Matthias Brugger , Sean Paul , moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTUR List-Id: linux-rockchip.vger.kernel.org SGksIFJvYjoKCk9uIFdlZCwgMjAxOS0xMC0yMyBhdCAxNzo1NiAtMDUwMCwgUm9iIEhlcnJpbmcg d3JvdGU6Cj4gT24gV2VkLCBPY3QgMjMsIDIwMTkgYXQgNDowNiBQTSBDSyBIdSA8Y2suaHVAbWVk aWF0ZWsuY29tPiB3cm90ZToKPiA+Cj4gPiBIaSwgUm9iOgo+ID4KPiA+IE9uIFdlZCwgMjAxOS0x MC0yMyBhdCAxMjo0MiAtMDUwMCwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgT2N0 IDIyLCAyMDE5IGF0IDEyOjA3IFBNIE1hdHRoaWFzIEJydWdnZXIKPiA+ID4gPG1hdHRoaWFzLmJn Z0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gSGkgUm9iLAo+ID4gPiA+Cj4gPiA+ ID4gT24gMjEvMTAvMjAxOSAyMzo0NSwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiA+ID4gPiBUaGUg b25seSByZWFzb24gdGhlIE1lZGlhdGVrIGRyaXZlciBkb2Vzbid0IHVzZSB0aGUgQ01BIGhlbHBl cnMgaXMgaXQKPiA+ID4gPiA+IHNldHMgRE1BX0FUVFJfTk9fS0VSTkVMX01BUFBJTkcgYW5kIGRv ZXMgYSB2bWFwKCkgb24gZGVtYW5kLiBVc2luZwo+ID4gPiA+ID4gdm1hcCgpIGlzIG5vdCBldmVu IGd1YXJhbnRlZWQgdG8gd29yayBhcyBETUEgYnVmZmVycyBtYXkgbm90IGhhdmUgYQo+ID4gPiA+ ID4gc3RydWN0IHBhZ2UuIE5vdyB0aGF0IHRoZSBDTUEgaGVscGVycyBzdXBwb3J0IHNldHRpbmcK PiA+ID4gPiA+IERNQV9BVFRSX05PX0tFUk5FTF9NQVBQSU5HIGFzIG5lZWRlZCBvciBub3QsIGNv bnZlcnQgTWVkaWF0ZWsgZHJpdmVyIHRvCj4gPiA+ID4gPiB1c2UgQ01BIGhlbHBlcnMuCj4gPiA+ ID4gPgo+ID4gPiA+ID4gQ2M6IENLIEh1IDxjay5odUBtZWRpYXRlay5jb20+Cj4gPiA+ID4gPiBD YzogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4KPiA+ID4gPiA+IENjOiBE YXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiA+ID4gPiBDYzogRGFuaWVsIFZldHRl ciA8ZGFuaWVsQGZmd2xsLmNoPgo+ID4gPiA+ID4gQ2M6IE1hdHRoaWFzIEJydWdnZXIgPG1hdHRo aWFzLmJnZ0BnbWFpbC5jb20+Cj4gPiA+ID4gPiBDYzogbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCj4gPiA+ID4gPiBDYzogbGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFk Lm9yZwo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9y Zz4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+Cj4gPiA+ID4gSSB0ZXN0ZWQgdGhpcyBvbiBteSBDaHJv bWVib29rIHdpdGggc29tZSBwYXRjaGVzIG9uIHRvcCBvZiB2NS40LXJjMSBbMV0sIHdoaWNoCj4g PiA+ID4gd29yay4gSWYgSSBhZGQgeW91ciBwYXRjaGVzIG9uIHRvcCBvZiB0aGF0LCB0aGUgc3lz dGVtIGRvZXMgbm90IGJvb3QgdXAuCj4gPiA+ID4gVW5mb3J0dW5hdGVseSBJIGRvbid0IGhhdmUg YSBzZXJpYWwgY29uc29sZSwgc28gSSB3YXNuJ3QgYWJsZSB0byBzZWUgaWYgdGhlcmUgaXMKPiA+ ID4gPiBhbnkgZXJyb3IgbWVzc2FnZS4KPiA+ID4KPiA+ID4gVGhhbmtzIGZvciB0ZXN0aW5nLiBJ J20gYmFzZWQgb24gZHJtLW1pc2MtbmV4dCwgYnV0IGRvbid0IHNlZSBhbnl0aGluZwo+ID4gPiBv YnZpb3VzIHRoZXJlIHRoYXQgd291bGQgbWF0dGVyLiBUaGVyZSBhcmUgc29tZSBtbWFwIGNoYW5n ZXMsIGJ1dCBJCj4gPiA+IHRoaW5rIHRoZXkgc2hvdWxkbid0IG1hdHRlci4KPiA+ID4KPiA+ID4g RGlkIHlvdSBoYXZlIGZiY29uIGVuYWJsZWQ/IFRoYXQgbWF5IGdpdmUgbW9yZSBjbHVlcyBhYm91 dCB3aGVyZSB0aGUgcHJvYmxlbSBpcy4KPiA+Cj4gPiBUaGVyZSBhcmUgcHJpdi0+ZG1hX2RldiBm b3IgZG1hIGRldmljZSwgYnV0IGl0IGlzIG5vdCBkcm0gZGV2aWNlLiBJbgo+ID4gbXQ4MTczLmR0 c2kgWzFdLCB0aGVyZSBhcmUgbW1zeXMgZGV2aWNlIGFuZCBvdmwgZGV2aWNlLCBtbXN5cyBkZXZp Y2UgaXMKPiA+IGRybSBkZXZpY2UgYW5kIG92bCBkZXZpY2UgaXMgbW1zeXMncyBzdWIgZGV2aWNl IHdoaWNoIHByb3ZpZGUgZG1hCj4gPiBmdW5jdGlvbiwgc28gb3ZsIGlzIHRoZSBwcml2LT5kbWFf ZGV2LiBJIHRoaW5rIHlvdXIgcGF0Y2ggZGlyZWN0bHkgdXNlCj4gPiBkcm0gZGV2aWNlIGZvciBk bWEgb3BlcmF0aW9uIGFuZCB0aGlzIHdvdWxkIGNhdXNlIGRtYSBmdW5jdGlvbiBmYWlsLgo+ID4g UGxlYXNlIHVzZSBwcml2LT5kbWFfZGV2IGZvciBkbWEgb3BlcmF0aW9uLgo+IAo+IFJpZ2h0LCB0 aGFua3MgZm9yIGNhdGNoaW5nIHRoYXQuIEVpdGhlciB3ZSdsbCBuZWVkIHRvIG1ha2UgQ01BIEdF TQo+IG9iamVjdCBoYXZlIGEgc3RydWN0IGRldmljZSBwdHIgb3IgYWRqdXN0IHRoZSBkcm1fZGV2 aWNlLmRldiB0byBoYXZlCj4gdGhlIG5lY2Vzc2FyeSBETUEgc2V0dXAuCj4gCj4gT25lIHF1ZXN0 aW9uIHRob3VnaCwgd2h5IGRvIHlvdSB1c2UgQ01BIHdoZW4geW91IGhhdmUgYW4gSU9NTVU/IFRo YXQncwo+IG5vdCBvcHRpbWFsIGFzIENNQSBzaXplIG1heSBiZSBsaW1pdGVkLiBPciB5b3UgZG9u J3QgYWx3YXlzIGhhdmUgYW4KPiBJT01NVT8KCkZvciBhbGwgdXBzdHJlYW1lZCBtZWRpYXRlayBT b0MsIGFsbCBoYXMgSU9NTVUsIHNvIGl0IGRvZXMgbm90IG5lZWQgQ01BLgpJIHRoaW5rIHdlIHVz ZSBDTUEganVzdCBiZWNhdXNlIHdlIHJlZmVyIHRvIG90aGVyIGRybSBkcml2ZXIgdG8KaW1wbGVt ZW50IG1lZGlhdGVrIGRybSBkcml2ZXIgYW5kIHdlIG1pc3VzZWQgQ01BIGhlbHBlciBmdW5jdGlv biBidXQgaXQKd29ya3MuIEkgdGhpbmsgd2Ugc2hvdWxkIGNoYW5nZSB0byBtb3JlIGFjY3VyYXRl IGltcGxlbWVudGF0aW9uLiBJZiB5b3UKd2FudCwgeW91IGNvdWxkIG1vZGlmeSBpdCBpbiB0aGlz IHNlcmllcy4KClJlZ2FyZHMsCkNLCgo+IAo+IFJvYgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84850CA9EAF for ; Thu, 24 Oct 2019 07:03:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45D932166E for ; Thu, 24 Oct 2019 07:03:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OAA96X0c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45D932166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cxtu6nb6NTEcSadaUvPgnaergcDDiFliICF+jdjzXAA=; b=OAA96X0c83Dd3j wlWr2WBOU3QSkMGm13UH36jQOi/Stdm4WYsacfXKogJtGDggsxFaCmpwjVaUtC739CxvUzs7xJJla /Spi7veop+4T+1qUvJT/X1tgEvFbJGbF1m9qmFCgFmRRStKHlwxGgS0lEEKLZq/LyQ9aTVRsVFwhs M9ADZxZELHFDh2k1Qn/MZjjglHuVgtTU53TNO6s/8+1jSe3nfi/0/pqFpBBuPtfT3PVLbOKjPhayZ 2Tzu4wHqqF7QXb5lK/QaI0vT2XIw8Enfp54SCuQq3i9bL5J41XhRk/d7KgTWSGMuxIlNMPlT+yjrR 3KRlzR7BIPGYUgWW8VTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNX9l-0004Up-OE; Thu, 24 Oct 2019 07:03:37 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNX9g-0004Su-N9; Thu, 24 Oct 2019 07:03:34 +0000 X-UUID: cd076735d9bc46259b261d3ecc0aa8af-20191023 X-UUID: cd076735d9bc46259b261d3ecc0aa8af-20191023 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1085928592; Wed, 23 Oct 2019 23:03:11 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Oct 2019 00:03:03 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Oct 2019 15:02:56 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 24 Oct 2019 15:02:56 +0800 Message-ID: <1571900577.27203.6.camel@mtksdaap41> Subject: Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers From: CK Hu To: Rob Herring Date: Thu, 24 Oct 2019 15:02:57 +0800 In-Reply-To: References: <20191021214550.1461-1-robh@kernel.org> <20191021214550.1461-6-robh@kernel.org> <1cbca96c-19dd-1d15-949c-7fbcc15369b4@gmail.com> <1571864784.19128.8.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191024_000332_759610_4C6FAB57 X-CRM114-Status: GOOD ( 27.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?ISO-8859-1?Q?St=FCbner?= , Neil Armstrong , David Airlie , Liviu Dudau , Daniel Kurtz , Sandy Huang , Laurent Pinchart , Benjamin Gaignard , Yannick Fertre , Nicolas Boichat , Kevin Hilman , Xinwei Kong , Xinliang Liu , "open list:ARM/Rockchip SoC..." , Chen-Yu Tsai , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , "James \(Qian\) Wang" , Philipp Zabel , Ulrich Hecht , Alexandre Torgue , Chen Feng , Maarten Lankhorst , Maxime Ripard , "moderated list:ARM/Mediatek SoC support" , dri-devel , Matthias Brugger , Daniel Vetter , Sean Paul , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Philippe Cornu , Vincent Abriou , Kieran Bingham , Maxime Coquelin , Rongrong Zou Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Rob: On Wed, 2019-10-23 at 17:56 -0500, Rob Herring wrote: > On Wed, Oct 23, 2019 at 4:06 PM CK Hu wrote: > > > > Hi, Rob: > > > > On Wed, 2019-10-23 at 12:42 -0500, Rob Herring wrote: > > > On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger > > > wrote: > > > > > > > > Hi Rob, > > > > > > > > On 21/10/2019 23:45, Rob Herring wrote: > > > > > The only reason the Mediatek driver doesn't use the CMA helpers is it > > > > > sets DMA_ATTR_NO_KERNEL_MAPPING and does a vmap() on demand. Using > > > > > vmap() is not even guaranteed to work as DMA buffers may not have a > > > > > struct page. Now that the CMA helpers support setting > > > > > DMA_ATTR_NO_KERNEL_MAPPING as needed or not, convert Mediatek driver to > > > > > use CMA helpers. > > > > > > > > > > Cc: CK Hu > > > > > Cc: Philipp Zabel > > > > > Cc: David Airlie > > > > > Cc: Daniel Vetter > > > > > Cc: Matthias Brugger > > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > > Cc: linux-mediatek@lists.infradead.org > > > > > Signed-off-by: Rob Herring > > > > > --- > > > > > > > > I tested this on my Chromebook with some patches on top of v5.4-rc1 [1], which > > > > work. If I add your patches on top of that, the system does not boot up. > > > > Unfortunately I don't have a serial console, so I wasn't able to see if there is > > > > any error message. > > > > > > Thanks for testing. I'm based on drm-misc-next, but don't see anything > > > obvious there that would matter. There are some mmap changes, but I > > > think they shouldn't matter. > > > > > > Did you have fbcon enabled? That may give more clues about where the problem is. > > > > There are priv->dma_dev for dma device, but it is not drm device. In > > mt8173.dtsi [1], there are mmsys device and ovl device, mmsys device is > > drm device and ovl device is mmsys's sub device which provide dma > > function, so ovl is the priv->dma_dev. I think your patch directly use > > drm device for dma operation and this would cause dma function fail. > > Please use priv->dma_dev for dma operation. > > Right, thanks for catching that. Either we'll need to make CMA GEM > object have a struct device ptr or adjust the drm_device.dev to have > the necessary DMA setup. > > One question though, why do you use CMA when you have an IOMMU? That's > not optimal as CMA size may be limited. Or you don't always have an > IOMMU? For all upstreamed mediatek SoC, all has IOMMU, so it does not need CMA. I think we use CMA just because we refer to other drm driver to implement mediatek drm driver and we misused CMA helper function but it works. I think we should change to more accurate implementation. If you want, you could modify it in this series. Regards, CK > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BDBCA9EAF for ; Thu, 24 Oct 2019 07:03:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A8D921655 for ; Thu, 24 Oct 2019 07:03:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A8D921655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C36916E0F7; Thu, 24 Oct 2019 07:03:04 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 8513A6E0F7 for ; Thu, 24 Oct 2019 07:03:03 +0000 (UTC) X-UUID: e387ee1ae50643aaade758f71eeed972-20191024 X-UUID: e387ee1ae50643aaade758f71eeed972-20191024 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1934104947; Thu, 24 Oct 2019 15:02:59 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Oct 2019 15:02:56 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 24 Oct 2019 15:02:56 +0800 Message-ID: <1571900577.27203.6.camel@mtksdaap41> Subject: Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers From: CK Hu To: Rob Herring Date: Thu, 24 Oct 2019 15:02:57 +0800 In-Reply-To: References: <20191021214550.1461-1-robh@kernel.org> <20191021214550.1461-6-robh@kernel.org> <1cbca96c-19dd-1d15-949c-7fbcc15369b4@gmail.com> <1571864784.19128.8.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Liviu Dudau , Laurent Pinchart , Yannick Fertre , Nicolas Boichat , Kevin Hilman , Xinwei Kong , Xinliang Liu , "open list:ARM/Rockchip SoC..." , Chen-Yu Tsai , "James \(Qian\) Wang" , Ulrich Hecht , Alexandre Torgue , Chen Feng , "moderated list:ARM/Mediatek SoC support" , dri-devel , Matthias Brugger , Sean Paul , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Philippe Cornu , Vincent Abriou , Kieran Bingham , Maxime Coquelin , Rongrong Zou Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191024070257.wq_2z8s504LsOwA76igQYOs6If_E4Uu1H-YoLI13mK8@z> SGksIFJvYjoKCk9uIFdlZCwgMjAxOS0xMC0yMyBhdCAxNzo1NiAtMDUwMCwgUm9iIEhlcnJpbmcg d3JvdGU6Cj4gT24gV2VkLCBPY3QgMjMsIDIwMTkgYXQgNDowNiBQTSBDSyBIdSA8Y2suaHVAbWVk aWF0ZWsuY29tPiB3cm90ZToKPiA+Cj4gPiBIaSwgUm9iOgo+ID4KPiA+IE9uIFdlZCwgMjAxOS0x MC0yMyBhdCAxMjo0MiAtMDUwMCwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgT2N0 IDIyLCAyMDE5IGF0IDEyOjA3IFBNIE1hdHRoaWFzIEJydWdnZXIKPiA+ID4gPG1hdHRoaWFzLmJn Z0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gSGkgUm9iLAo+ID4gPiA+Cj4gPiA+ ID4gT24gMjEvMTAvMjAxOSAyMzo0NSwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiA+ID4gPiBUaGUg b25seSByZWFzb24gdGhlIE1lZGlhdGVrIGRyaXZlciBkb2Vzbid0IHVzZSB0aGUgQ01BIGhlbHBl cnMgaXMgaXQKPiA+ID4gPiA+IHNldHMgRE1BX0FUVFJfTk9fS0VSTkVMX01BUFBJTkcgYW5kIGRv ZXMgYSB2bWFwKCkgb24gZGVtYW5kLiBVc2luZwo+ID4gPiA+ID4gdm1hcCgpIGlzIG5vdCBldmVu IGd1YXJhbnRlZWQgdG8gd29yayBhcyBETUEgYnVmZmVycyBtYXkgbm90IGhhdmUgYQo+ID4gPiA+ ID4gc3RydWN0IHBhZ2UuIE5vdyB0aGF0IHRoZSBDTUEgaGVscGVycyBzdXBwb3J0IHNldHRpbmcK PiA+ID4gPiA+IERNQV9BVFRSX05PX0tFUk5FTF9NQVBQSU5HIGFzIG5lZWRlZCBvciBub3QsIGNv bnZlcnQgTWVkaWF0ZWsgZHJpdmVyIHRvCj4gPiA+ID4gPiB1c2UgQ01BIGhlbHBlcnMuCj4gPiA+ ID4gPgo+ID4gPiA+ID4gQ2M6IENLIEh1IDxjay5odUBtZWRpYXRlay5jb20+Cj4gPiA+ID4gPiBD YzogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4KPiA+ID4gPiA+IENjOiBE YXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiA+ID4gPiBDYzogRGFuaWVsIFZldHRl ciA8ZGFuaWVsQGZmd2xsLmNoPgo+ID4gPiA+ID4gQ2M6IE1hdHRoaWFzIEJydWdnZXIgPG1hdHRo aWFzLmJnZ0BnbWFpbC5jb20+Cj4gPiA+ID4gPiBDYzogbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCj4gPiA+ID4gPiBDYzogbGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFk Lm9yZwo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9y Zz4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+Cj4gPiA+ID4gSSB0ZXN0ZWQgdGhpcyBvbiBteSBDaHJv bWVib29rIHdpdGggc29tZSBwYXRjaGVzIG9uIHRvcCBvZiB2NS40LXJjMSBbMV0sIHdoaWNoCj4g PiA+ID4gd29yay4gSWYgSSBhZGQgeW91ciBwYXRjaGVzIG9uIHRvcCBvZiB0aGF0LCB0aGUgc3lz dGVtIGRvZXMgbm90IGJvb3QgdXAuCj4gPiA+ID4gVW5mb3J0dW5hdGVseSBJIGRvbid0IGhhdmUg YSBzZXJpYWwgY29uc29sZSwgc28gSSB3YXNuJ3QgYWJsZSB0byBzZWUgaWYgdGhlcmUgaXMKPiA+ ID4gPiBhbnkgZXJyb3IgbWVzc2FnZS4KPiA+ID4KPiA+ID4gVGhhbmtzIGZvciB0ZXN0aW5nLiBJ J20gYmFzZWQgb24gZHJtLW1pc2MtbmV4dCwgYnV0IGRvbid0IHNlZSBhbnl0aGluZwo+ID4gPiBv YnZpb3VzIHRoZXJlIHRoYXQgd291bGQgbWF0dGVyLiBUaGVyZSBhcmUgc29tZSBtbWFwIGNoYW5n ZXMsIGJ1dCBJCj4gPiA+IHRoaW5rIHRoZXkgc2hvdWxkbid0IG1hdHRlci4KPiA+ID4KPiA+ID4g RGlkIHlvdSBoYXZlIGZiY29uIGVuYWJsZWQ/IFRoYXQgbWF5IGdpdmUgbW9yZSBjbHVlcyBhYm91 dCB3aGVyZSB0aGUgcHJvYmxlbSBpcy4KPiA+Cj4gPiBUaGVyZSBhcmUgcHJpdi0+ZG1hX2RldiBm b3IgZG1hIGRldmljZSwgYnV0IGl0IGlzIG5vdCBkcm0gZGV2aWNlLiBJbgo+ID4gbXQ4MTczLmR0 c2kgWzFdLCB0aGVyZSBhcmUgbW1zeXMgZGV2aWNlIGFuZCBvdmwgZGV2aWNlLCBtbXN5cyBkZXZp Y2UgaXMKPiA+IGRybSBkZXZpY2UgYW5kIG92bCBkZXZpY2UgaXMgbW1zeXMncyBzdWIgZGV2aWNl IHdoaWNoIHByb3ZpZGUgZG1hCj4gPiBmdW5jdGlvbiwgc28gb3ZsIGlzIHRoZSBwcml2LT5kbWFf ZGV2LiBJIHRoaW5rIHlvdXIgcGF0Y2ggZGlyZWN0bHkgdXNlCj4gPiBkcm0gZGV2aWNlIGZvciBk bWEgb3BlcmF0aW9uIGFuZCB0aGlzIHdvdWxkIGNhdXNlIGRtYSBmdW5jdGlvbiBmYWlsLgo+ID4g UGxlYXNlIHVzZSBwcml2LT5kbWFfZGV2IGZvciBkbWEgb3BlcmF0aW9uLgo+IAo+IFJpZ2h0LCB0 aGFua3MgZm9yIGNhdGNoaW5nIHRoYXQuIEVpdGhlciB3ZSdsbCBuZWVkIHRvIG1ha2UgQ01BIEdF TQo+IG9iamVjdCBoYXZlIGEgc3RydWN0IGRldmljZSBwdHIgb3IgYWRqdXN0IHRoZSBkcm1fZGV2 aWNlLmRldiB0byBoYXZlCj4gdGhlIG5lY2Vzc2FyeSBETUEgc2V0dXAuCj4gCj4gT25lIHF1ZXN0 aW9uIHRob3VnaCwgd2h5IGRvIHlvdSB1c2UgQ01BIHdoZW4geW91IGhhdmUgYW4gSU9NTVU/IFRo YXQncwo+IG5vdCBvcHRpbWFsIGFzIENNQSBzaXplIG1heSBiZSBsaW1pdGVkLiBPciB5b3UgZG9u J3QgYWx3YXlzIGhhdmUgYW4KPiBJT01NVT8KCkZvciBhbGwgdXBzdHJlYW1lZCBtZWRpYXRlayBT b0MsIGFsbCBoYXMgSU9NTVUsIHNvIGl0IGRvZXMgbm90IG5lZWQgQ01BLgpJIHRoaW5rIHdlIHVz ZSBDTUEganVzdCBiZWNhdXNlIHdlIHJlZmVyIHRvIG90aGVyIGRybSBkcml2ZXIgdG8KaW1wbGVt ZW50IG1lZGlhdGVrIGRybSBkcml2ZXIgYW5kIHdlIG1pc3VzZWQgQ01BIGhlbHBlciBmdW5jdGlv biBidXQgaXQKd29ya3MuIEkgdGhpbmsgd2Ugc2hvdWxkIGNoYW5nZSB0byBtb3JlIGFjY3VyYXRl IGltcGxlbWVudGF0aW9uLiBJZiB5b3UKd2FudCwgeW91IGNvdWxkIG1vZGlmeSBpdCBpbiB0aGlz IHNlcmllcy4KClJlZ2FyZHMsCkNLCgo+IAo+IFJvYgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==