From: Mimi Zohar <zohar@linux.ibm.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: Add major_version sysfs file
Date: Fri, 25 Oct 2019 15:15:28 -0400 [thread overview]
Message-ID: <1572030928.4532.57.camel@linux.ibm.com> (raw)
In-Reply-To: <20191025184522.5txabdikcrn2dgvj@cantor>
On Fri, 2019-10-25 at 11:45 -0700, Jerry Snitselaar wrote:
> On Fri Oct 25 19, Mimi Zohar wrote:
> >On Fri, 2019-10-25 at 07:28 -0700, Jerry Snitselaar wrote:
> >> Easily determining what TCG version a tpm device implements
> >> has been a pain point for userspace for a long time, so
> >> add a sysfs file to report the tcg version of a tpm device.
> >
> >Use "TCG" uppercase consistently.
And "TPM"
> >
> >>
> >> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >> Cc: Peter Huewe <peterhuewe@gmx.de>
> >> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> >> Cc: linux-integrity@vger.kernel.org
> >> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
> >
> >thanks!
> >
> >Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> >
> >FYI, on my system(s) the new file is accessible as
> >/sys/class/tpm/tpm0/version_major. Does this need to be documented
> >anywhere?
> >
> >
>
> Yes, there should be an entry added to
> Documentation/ABI/stable/sysfs-class-tpm.
> I will fix that up and the TCG not being uppercase in a v2.
>
> Should Documentation/ABI/stable/sysfs-class-tpm updated in
> some way to reflect that those are all links under device
> now and not actually there.
The importance is that there is a common file that can be used by
userspace applications, instead of having to search for it, not that
it is a link per-se.
Mimi
next prev parent reply other threads:[~2019-10-25 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 14:28 [PATCH] tpm: Add major_version sysfs file Jerry Snitselaar
2019-10-25 18:18 ` Mimi Zohar
2019-10-25 18:45 ` Jerry Snitselaar
2019-10-25 19:15 ` Mimi Zohar [this message]
2019-10-25 19:32 ` Jason Gunthorpe
2019-10-25 19:42 ` Mimi Zohar
2019-10-27 23:01 ` Jason Gunthorpe
2019-10-27 15:35 ` Jarkko Sakkinen
2019-10-27 23:00 ` Jason Gunthorpe
2019-10-29 9:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572030928.4532.57.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.