All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] eal: check coremask against detected lcores
Date: Fri, 18 Apr 2014 00:43:16 +0200	[thread overview]
Message-ID: <15724496.jrcSWAV12m@xps13> (raw)
In-Reply-To: <20140415135754.GC3557-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>

> > lcores that are set in coremask should be checked against lcores detected
> > on system. This way, we won't need to check them later.
> > 
> > Besides, if specifying an unavailable lcore, we currently panic in
> > eal_thread_loop() because pthread_setaffinity_np fails.
> > So this check will return an error with a more explicit message in
> > eal_parse_coremask().
> > 
> > "EAL: pthread_setaffinity_np failed
> > 
> >  PANIC in eal_thread_loop():
> >  cannot set affinity"
> > 
> > becomes :
> > 
> > "EAL: lcore 4 unavailable
> > 
> >  EAL: invalid coremask"
> > 
> > Signed-off-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> 
> Acked-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>

Applied for version 1.6.0r2.

Thanks for this nice usability improvement
-- 
Thomas

      parent reply	other threads:[~2014-04-17 22:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 13:50 [PATCH] eal: check coremask against detected lcores David Marchand
     [not found] ` <1397569842-12562-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-04-15 13:57   ` Neil Horman
     [not found]     ` <20140415135754.GC3557-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-04-17 22:43       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15724496.jrcSWAV12m@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.