From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A78CA9ED0 for ; Sun, 3 Nov 2019 18:00:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6A282086D for ; Sun, 3 Nov 2019 18:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572804047; bh=fuZcMmpeuIikNWe8r7pP1x8lsrt3C4BeJgwKAW+LKS4=; h=Subject:To:Cc:From:Date:List-ID:From; b=VzVC8+srv49Q6+CJDcFyIAQMAfftoyG5uish9xwWOfCYS+eU3R+K6z6glqgFuSF3P IJfzIW+v3tWLLv/0voyE60Ahk5JZfhEd7hW4+zgi4McvJlYzrA0NGwChXn4ojlbYlo Tx9ZUFACzlh7DoWbsVwmhLYqfvWQkLZa5clVwMq8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727322AbfKCSAq (ORCPT ); Sun, 3 Nov 2019 13:00:46 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45195 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbfKCSAq (ORCPT ); Sun, 3 Nov 2019 13:00:46 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E055C21B8C; Sun, 3 Nov 2019 13:00:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 03 Nov 2019 13:00:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gce6e5 JFEVJmPIR+1LWY2d9OGxJGb8eiogZNmDnaur4=; b=rL/IQrLfglAlU7jo63PlzJ 1cijtQR48Httfjyjh+Yv/+yEOxUSzcdKO1HzghRmY5pyExxCFA6ig5+XRZo3jVBL jk6SX6OhE6hB/ROCv4aHs4ji4Ylh7KGJKAFmo9kEHcptuhwsw4mGVvxVtO1JBLUa dIwkYdFYuqDz1Mi1HRUYBvEytga6SEI6z2Iq3VRJWd8ebVCWCFltsg5Cr7ZiJ0zS ezz46v9seef573b1QpeWIX5q7JSlhTJTPB4ua3CsskP9OuR7YMWZGtiTeD/mnO/3 U41J0AdefTXnPRyMOT/ZsgjPa8d9QKp2el1e/Km3ZnUCqJ1uAjpKsq5XLabqWpdQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudduuddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepuffvhfffkfggtgfgsehtkeertd dttdflnecuhfhrohhmpeeoghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdho rhhgqeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppeekfedrkeeirdekle druddtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm necuvehluhhsthgvrhfuihiivgepvd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 649958005A; Sun, 3 Nov 2019 13:00:45 -0500 (EST) Subject: FAILED: patch "[PATCH] nl80211: fix validation of mesh path nexthop" failed to apply to 4.14-stable tree To: markus.theil@tu-ilmenau.de, johannes.berg@intel.com Cc: From: Date: Sun, 03 Nov 2019 19:00:33 +0100 Message-ID: <157280403380@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 1fab1b89e2e8f01204a9c05a39fd0b6411a48593 Mon Sep 17 00:00:00 2001 From: Markus Theil Date: Tue, 29 Oct 2019 10:30:03 +0100 Subject: [PATCH] nl80211: fix validation of mesh path nexthop Mesh path nexthop should be a ethernet address, but current validation checks against 4 byte integers. Cc: stable@vger.kernel.org Fixes: 2ec600d672e74 ("nl80211/cfg80211: support for mesh, sta dumping") Signed-off-by: Markus Theil Link: https://lore.kernel.org/r/20191029093003.10355-1-markus.theil@tu-ilmenau.de Signed-off-by: Johannes Berg diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 4453dd375de9..7b72286922f7 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -393,7 +393,7 @@ const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = { [NL80211_ATTR_MNTR_FLAGS] = { /* NLA_NESTED can't be empty */ }, [NL80211_ATTR_MESH_ID] = { .type = NLA_BINARY, .len = IEEE80211_MAX_MESH_ID_LEN }, - [NL80211_ATTR_MPATH_NEXT_HOP] = { .type = NLA_U32 }, + [NL80211_ATTR_MPATH_NEXT_HOP] = NLA_POLICY_ETH_ADDR_COMPAT, [NL80211_ATTR_REG_ALPHA2] = { .type = NLA_STRING, .len = 2 }, [NL80211_ATTR_REG_RULES] = { .type = NLA_NESTED },