diff for duplicates of <1573018214.10368.1.camel@harmonicinc.com> diff --git a/a/1.txt b/N1/1.txt index 9466242..4271e38 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On Tue, 2019-11-05 at 16:55 +0000, Creeley, Brett wrote: > > -----Original Message----- > > From: Arkady Gilinsky <arkady.gilinsky@harmonicinc.com> > > Sent: Monday, November 4, 2019 9:24 PM -> > To: Creeley, Brett <brett.creeley@intel.com>; intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; Kirsher, +> > To: Creeley, Brett <brett.creeley@intel.com>; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Kirsher, > > Jeffrey T > > <jeffrey.t.kirsher@intel.com> > > Cc: Arkady Gilinsky <arcadyg@gmail.com> @@ -11,7 +11,7 @@ On Tue, 2019-11-05 at 16:55 +0000, Creeley, Brett wrote: > > > { > > > /* this will catch any changes made to the virtchnl_queue_select bitmap */ > > > if (sizeof(vqs->rx_queues) != sizeof(u32) || -> > > ?????sizeof(vqs->tx_queues) != sizeof(u32)) +> > > sizeof(vqs->tx_queues) != sizeof(u32)) > > > return false; > > > > If so, then is it better to check the type of the fields in compile-time rather than in runtime ? @@ -26,16 +26,16 @@ If other code in driver not need to be adjusted/verified, then this check is not > > > > > > > if ((vqs->rx_queues == 0 && vqs->tx_queues == 0) || -> > > ??????hweight32(vqs->rx_queues) > I40E_MAX_VF_QUEUES || -> > > ??????hweight32(vqs->tx_queues) > I40E_MAX_VF_QUEUES) +> > > hweight32(vqs->rx_queues) > I40E_MAX_VF_QUEUES || +> > > hweight32(vqs->tx_queues) > I40E_MAX_VF_QUEUES) > > > return false; > > > > Again, from optimization POV it is better to have constant changed than variable, > > since it is compile time and not run time action: > > if ((vqs->rx_queues == 0 && vqs->tx_queues == 0) || -> > ??????vqs->rx_queues >= (BIT(I40E_MAX_VF_QUEUES)) || +> > vqs->rx_queues >= (BIT(I40E_MAX_VF_QUEUES)) || > > -> > ??????vqs->tx_queues >= (BIT(I40E_MAX_VF_QUEUES))) +> > vqs->tx_queues >= (BIT(I40E_MAX_VF_QUEUES))) > > return false; > > This seems much better than my solution. It fixes the original issue, handles if the diff --git a/a/content_digest b/N1/content_digest index 0bbab96..b3e0f73 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,16 +3,22 @@ "ref\01572931430.13810.227.camel@harmonicinc.com\0" "ref\03508A0C5D531054DBDD98909F6FA64FA11B39863@ORSMSX113.amr.corp.intel.com\0" "From\0Arkady Gilinsky <arkady.gilinsky@harmonicinc.com>\0" - "Subject\0[Intel-wired-lan] [EXTERNAL] RE: [PATCH net] i40e/iavf: Fix msg interface between VF and PF\0" + "Subject\0Re: [EXTERNAL] RE: [PATCH net] i40e/iavf: Fix msg interface between VF and PF\0" "Date\0Wed, 6 Nov 2019 05:30:20 +0000\0" - "To\0intel-wired-lan@osuosl.org\0" + "To\0Creeley" + Brett <brett.creeley@intel.com> + intel-wired-lan@lists.osuosl.org <intel-wired-lan@lists.osuosl.org> + netdev@vger.kernel.org <netdev@vger.kernel.org> + Kirsher + " Jeffrey T <jeffrey.t.kirsher@intel.com>\0" + "Cc\0Arkady Gilinsky <arcadyg@gmail.com>\0" "\00:1\0" "b\0" "On Tue, 2019-11-05 at 16:55 +0000, Creeley, Brett wrote:\n" "> > -----Original Message-----\n" "> > From: Arkady Gilinsky <arkady.gilinsky@harmonicinc.com>\n" "> > Sent: Monday, November 4, 2019 9:24 PM\n" - "> > To: Creeley, Brett <brett.creeley@intel.com>; intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; Kirsher,\n" + "> > To: Creeley, Brett <brett.creeley@intel.com>; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Kirsher,\n" "> > Jeffrey T\n" "> > <jeffrey.t.kirsher@intel.com>\n" "> > Cc: Arkady Gilinsky <arcadyg@gmail.com>\n" @@ -21,7 +27,7 @@ "> > > {\n" "> > > \t/* this will catch any changes made to the virtchnl_queue_select bitmap */\n" "> > > \tif (sizeof(vqs->rx_queues) != sizeof(u32) ||\n" - "> > > \t?????sizeof(vqs->tx_queues) != sizeof(u32))\n" + "> > > \t\302\240\302\240\302\240\302\240\302\240sizeof(vqs->tx_queues) != sizeof(u32))\n" "> > > \t\treturn false;\n" "> > \n" "> > If so, then is it better to check the type of the fields in compile-time rather than in runtime ?\n" @@ -36,16 +42,16 @@ "> \n" "> > > \n" "> > > \tif ((vqs->rx_queues == 0 && vqs->tx_queues == 0) ||\n" - "> > > \t??????hweight32(vqs->rx_queues) > I40E_MAX_VF_QUEUES ||\n" - "> > > \t??????hweight32(vqs->tx_queues) > I40E_MAX_VF_QUEUES)\n" + "> > > \t\302\240\302\240\302\240\302\240\302\240\302\240hweight32(vqs->rx_queues) > I40E_MAX_VF_QUEUES ||\n" + "> > > \t\302\240\302\240\302\240\302\240\302\240\302\240hweight32(vqs->tx_queues) > I40E_MAX_VF_QUEUES)\n" "> > > \t\treturn false;\n" "> > \n" "> > Again, from optimization POV it is better to have constant changed than variable,\n" "> > since it is compile time and not run time action:\n" "> > \tif ((vqs->rx_queues == 0 && vqs->tx_queues == 0) ||\n" - "> > \t??????vqs->rx_queues >= (BIT(I40E_MAX_VF_QUEUES)) ||\n" + "> > \t\302\240\302\240\302\240\302\240\302\240\302\240vqs->rx_queues >= (BIT(I40E_MAX_VF_QUEUES)) ||\n" "> > \n" - "> > ??????vqs->tx_queues >= (BIT(I40E_MAX_VF_QUEUES)))\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240vqs->tx_queues >= (BIT(I40E_MAX_VF_QUEUES)))\n" "> > \t\treturn false;\n" "> \n" "> This seems much better than my solution. It fixes the original issue, handles if the\n" @@ -68,4 +74,4 @@ "\n" ------------------------------------------ -7afddf52c74d3cd4c179b976b6837382a7eaf4ad04b01f9887fcb19549113f98 +169a071ec29d5a67e8ecb58a95908e81a50e4241b71c5278ce4b34c38b4ebb83
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.