From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Wed, 06 Nov 2019 22:43:09 +0000 Subject: Re: [PATCH v4 01/10] IMA: Defined an IMA hook to measure keys on key create or update Message-Id: <1573080189.5028.313.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="maccentraleurope" Content-Transfer-Encoding: base64 List-Id: References: <20191106190116.2578-1-nramas@linux.microsoft.com> <20191106190116.2578-2-nramas@linux.microsoft.com> In-Reply-To: <20191106190116.2578-2-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org T24gV2VkLCAyMDE5LTExLTA2IGF0IDExOjAxIC0wODAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlh biB3cm90ZToKPiBBc3ltbWV0cmljIGtleXMgdXNlZCBmb3IgdmVyaWZ5aW5nIGZpbGUgc2lnbmF0 dXJlcyBvciBjZXJ0aWZpY2F0ZXMKPiBhcmUgY3VycmVudGx5IG5vdCBpbmNsdWRlZCBpbiB0aGUg SU1BIG1lYXN1cmVtZW50IGxpc3QuCj4gCj4gVGhpcyBwYXRjaCBkZWZpbmVzIGEgbmV3IElNQSBo b29rIG5hbWVseSBpbWFfcG9zdF9rZXlfY3JlYXRlX29yX3VwZGF0ZSgpCj4gdG8gbWVhc3VyZSBh c3ltbWV0cmljIGtleXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogTGFrc2htaSBSYW1hc3VicmFtYW5p YW4gPG5yYW1hc0BsaW51eC5taWNyb3NvZnQuY29tPgo+IC0tLQo+ICBzZWN1cml0eS9pbnRlZ3Jp dHkvaW1hL2ltYV9tYWluLmMgfCAxNiArKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2Vk LCAxNiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL3NlY3VyaXR5L2ludGVncml0eS9p bWEvaW1hX21haW4uYyBiL3NlY3VyaXR5L2ludGVncml0eS9pbWEvaW1hX21haW4uYwo+IGluZGV4 IGQ3ZTk4N2JhZjEyNy4uYTBlMjMzYWZlODc2IDEwMDY0NAo+IC0tLSBhL3NlY3VyaXR5L2ludGVn cml0eS9pbWEvaW1hX21haW4uYwo+ICsrKyBiL3NlY3VyaXR5L2ludGVncml0eS9pbWEvaW1hX21h aW4uYwo+IEBAIC03MjEsNiArNzIxLDIyIEBAIHZvaWQgaW1hX2tleGVjX2NtZGxpbmUoY29uc3Qg dm9pZCAqYnVmLCBpbnQgc2l6ZSkKPiAgCQkJCQkgICBLRVhFQ19DTURMSU5FLCAwKTsKPiAgfQo+ ICAKPiArLyoqCj4gKyAqIGltYV9wb3N0X2tleV9jcmVhdGVfb3JfdXBkYXRlIC0gbWVhc3VyZSBh c3ltbWV0cmljIGtleXMKPiArICogQGtleXJpbmc6IGtleXJpbmcgdG8gd2hpY2ggdGhlIGtleSBp cyBsaW5rZWQgdG8KPiArICogQGtleTogY3JlYXRlZCBvciB1cGRhdGVkIGtleQo+ICsgKiBAZmxh Z3M6IGtleSBmbGFncwo+ICsgKiBAY3JlYXRlOiBmbGFnIGluZGljYXRpbmcgd2hldGhlciB0aGUg a2V5IHdhcyBjcmVhdGVkIG9yIHVwZGF0ZWQKPiArICoKPiArICogS2V5cyBjYW4gb25seSBiZSBt ZWFzdXJlZCwgbm90IGFwcHJhaXNlZC4KPiArICovCj4gK3ZvaWQgaW1hX3Bvc3Rfa2V5X2NyZWF0 ZV9vcl91cGRhdGUoc3RydWN0IGtleSAqa2V5cmluZywgc3RydWN0IGtleSAqa2V5LAo+ICsJCQkJ ICAgdW5zaWduZWQgbG9uZyBmbGFncywgYm9vbCBjcmVhdGUpCj4gK3sKPiArCWlmICgoa2V5cmlu ZyAhPSBOVUxMKSAmJiAoa2V5ICE9IE5VTEwpKQo+ICsJCXJldHVybjsKCkkgd291bGQgbW92ZSB0 aGUgcGF0Y2ggdGhhdCBkZWZpbmVzIHRoZSAia2V5cmluZz0iIHBvbGljeSBvcHRpb24gcHJpb3IK dG8gdGhpcyBvbmUuIMKgSW5jbHVkZSB0aGUgY2FsbCB0byBwcm9jZXNzX2J1ZmZlcl9tZWFzdXJl bWVudCgpIGluIHRoaXMKcGF0Y2guIMKgQSBzdWJzZXF1ZW50IHBhdGNoIHdvdWxkIGFkZCBzdXBw b3J0IHRvIGRlZmVyIG1lYXN1cmluZyB0aGUKa2V5LCBieSBjYWxsaW5nIGEgZnVuY3Rpb24gbmFt ZWQgc29tZXRoaW5nIGxpa2UKaW1hX3F1ZXVlX2tleV9tZWFzdXJlbWVudCgpLgoKTWltaQoKPiAr fQo+ICsKPiAgc3RhdGljIGludCBfX2luaXQgaW5pdF9pbWEodm9pZCkKPiAgewo+ICAJaW50IGVy cm9yOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB2DFC6194 for ; Wed, 6 Nov 2019 22:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 137A02173E for ; Wed, 6 Nov 2019 22:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbfKFWpG (ORCPT ); Wed, 6 Nov 2019 17:45:06 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:20716 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726912AbfKFWpG (ORCPT ); Wed, 6 Nov 2019 17:45:06 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA6MggJq073572 for ; Wed, 6 Nov 2019 17:45:05 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w44wjcmy0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 06 Nov 2019 17:45:05 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Nov 2019 22:45:02 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 6 Nov 2019 22:45:00 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA6MixhP55640138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Nov 2019 22:44:59 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4F376A4076; Wed, 6 Nov 2019 22:44:59 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55B85A406F; Wed, 6 Nov 2019 22:44:58 +0000 (GMT) Received: from dhcp-9-31-102-173.watson.ibm.com (unknown [9.31.102.173]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 6 Nov 2019 22:44:58 +0000 (GMT) Subject: Re: [PATCH v4 01/10] IMA: Defined an IMA hook to measure keys on key create or update From: Mimi Zohar To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20191106190116.2578-2-nramas@linux.microsoft.com> References: <20191106190116.2578-1-nramas@linux.microsoft.com> <20191106190116.2578-2-nramas@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 06 Nov 2019 17:43:09 -0500 Mime-Version: 1.0 X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19110622-0012-0000-0000-000003615CB7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110622-0013-0000-0000-0000219CBB65 Message-Id: <1573080189.5028.313.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-06_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911060218 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, 2019-11-06 at 11:01 -0800, Lakshmi Ramasubramanian wrote: > Asymmetric keys used for verifying file signatures or certificates > are currently not included in the IMA measurement list. > > This patch defines a new IMA hook namely ima_post_key_create_or_update() > to measure asymmetric keys. > > Signed-off-by: Lakshmi Ramasubramanian > --- > security/integrity/ima/ima_main.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c > index d7e987baf127..a0e233afe876 100644 > --- a/security/integrity/ima/ima_main.c > +++ b/security/integrity/ima/ima_main.c > @@ -721,6 +721,22 @@ void ima_kexec_cmdline(const void *buf, int size) > KEXEC_CMDLINE, 0); > } > > +/** > + * ima_post_key_create_or_update - measure asymmetric keys > + * @keyring: keyring to which the key is linked to > + * @key: created or updated key > + * @flags: key flags > + * @create: flag indicating whether the key was created or updated > + * > + * Keys can only be measured, not appraised. > + */ > +void ima_post_key_create_or_update(struct key *keyring, struct key *key, > + unsigned long flags, bool create) > +{ > + if ((keyring != NULL) && (key != NULL)) > + return; I would move the patch that defines the "keyring=" policy option prior to this one.  Include the call to process_buffer_measurement() in this patch.  A subsequent patch would add support to defer measuring the key, by calling a function named something like ima_queue_key_measurement(). Mimi > +} > + > static int __init init_ima(void) > { > int error;