From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Tue, 12 Nov 2019 17:04:56 +0000 Subject: Re: [PATCH v5 01/10] IMA: Added KEYRING_CHECK func in IMA policy to measure keys Message-Id: <1573578296.17949.41.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20191111193303.12781-1-nramas@linux.microsoft.com> <20191111193303.12781-2-nramas@linux.microsoft.com> In-Reply-To: <20191111193303.12781-2-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org T24gTW9uLCAyMDE5LTExLTExIGF0IDExOjMyIC0wODAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlh biB3cm90ZToKPiBJTUEgcG9saWN5IG5lZWRzIHRvIHN1cHBvcnQgYSBmdW5jIHRvIGVuYWJsZSBt ZWFzdXJlbWVudCBvZgo+IGFzeW1tZXRyaWMga2V5cy4KPiAKPiBUaGlzIHBhdGNoIGRlZmluZXMg YSBuZXcgSU1BIHBvbGljeSBmdW5jIG5hbWVseSBLRVlSSU5HX0NIRUNLIHRvCj4gbWVhc3VyZSBh c3ltbWV0cmljIGtleXMuCgpUaGlzIG5ldyBmZWF0dXJlIG1lYXN1cmVzICJrZXlzIiBiYXNlZCBv biBwb2xpY3ksIG5vdCAia2V5cmluZ3MiLgrCoFBsZWFzZSBjaGFuZ2UgdGhlIG5hbWUgdG8gS0VZ X0NIRUNLLgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBMYWtzaG1pIFJhbWFzdWJyYW1hbmlhbiA8bnJh bWFzQGxpbnV4Lm1pY3Jvc29mdC5jb20+Cj4gLS0tCj4gIERvY3VtZW50YXRpb24vQUJJL3Rlc3Rp bmcvaW1hX3BvbGljeSB8IDYgKysrKysrCj4gIHNlY3VyaXR5L2ludGVncml0eS9pbWEvaW1hLmgg ICAgICAgICB8IDEgKwo+ICBzZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYyAgfCA0 ICsrKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vQUJJL3Rlc3RpbmcvaW1hX3BvbGljeSBi L0RvY3VtZW50YXRpb24vQUJJL3Rlc3RpbmcvaW1hX3BvbGljeQo+IGluZGV4IDI5YWFlZGYzMzI0 Ni4uMzQxZGY0OWI1YWQxIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vQUJJL3Rlc3Rpbmcv aW1hX3BvbGljeQo+ICsrKyBiL0RvY3VtZW50YXRpb24vQUJJL3Rlc3RpbmcvaW1hX3BvbGljeQo+ IEBAIC0zMCw2ICszMCw3IEBAIERlc2NyaXB0aW9uOgo+ICAJCQkJW0ZJUk1XQVJFX0NIRUNLXQo+ ICAJCQkJW0tFWEVDX0tFUk5FTF9DSEVDS10gW0tFWEVDX0lOSVRSQU1GU19DSEVDS10KPiAgCQkJ CVtLRVhFQ19DTURMSU5FXQo+ICsJCQkJW0tFWVJJTkdfQ0hFQ0tdCj4gIAkJCW1hc2s6PSBbW15d TUFZX1JFQURdIFtbXl1NQVlfV1JJVEVdIFtbXl1NQVlfQVBQRU5EXQo+ICAJCQkgICAgICAgW1te XU1BWV9FWEVDXQo+ICAJCQlmc21hZ2ljOj0gaGV4IHZhbHVlCj4gQEAgLTExMywzICsxMTQsOCBA QCBEZXNjcmlwdGlvbjoKPiAgCQlFeGFtcGxlIG9mIGFwcHJhaXNlIHJ1bGUgYWxsb3dpbmcgbW9k c2lnIGFwcGVuZGVkIHNpZ25hdHVyZXM6Cj4gIAo+ICAJCQlhcHByYWlzZSBmdW5jPUtFWEVDX0tF Uk5FTF9DSEVDSyBhcHByYWlzZV90eXBlPWltYXNpZ3xtb2RzaWcKPiArCj4gKwkJRXhhbXBsZSBv ZiBtZWFzdXJlIHJ1bGUgdXNpbmcgS0VZUklOR19DSEVDSyB0byBtZWFzdXJlCj4gKwkJYWxsIGtl eXM6Cj4gKwo+ICsJCQltZWFzdXJlIGZ1bmM9S0VZUklOR19DSEVDSwo+IGRpZmYgLS1naXQgYS9z ZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYS5oIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWEu aAo+IGluZGV4IGRmNGNhNDgyZmI1My4uN2YyMzQwNWIyNzE4IDEwMDY0NAo+IC0tLSBhL3NlY3Vy aXR5L2ludGVncml0eS9pbWEvaW1hLmgKPiArKysgYi9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2lt YS5oCj4gQEAgLTE5Myw2ICsxOTMsNyBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGxvbmcgaW1h X2hhc2hfa2V5KHU4ICpkaWdlc3QpCj4gIAlob29rKEtFWEVDX0lOSVRSQU1GU19DSEVDSykJXAo+ ICAJaG9vayhQT0xJQ1lfQ0hFQ0spCQlcCj4gIAlob29rKEtFWEVDX0NNRExJTkUpCQlcCj4gKwlo b29rKEtFWVJJTkdfQ0hFQ0spCQlcCj4gIAlob29rKE1BWF9DSEVDSykKPiAgI2RlZmluZSBfX2lt YV9ob29rX2VudW1pZnkoRU5VTSkJRU5VTSwKPiAgCj4gZGlmZiAtLWdpdCBhL3NlY3VyaXR5L2lu dGVncml0eS9pbWEvaW1hX3BvbGljeS5jIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfcG9s aWN5LmMKPiBpbmRleCBmMTlhODk1YWQ3Y2QuLjljYTMyZmZhYWE5ZCAxMDA2NDQKPiAtLS0gYS9z ZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYwo+ICsrKyBiL3NlY3VyaXR5L2ludGVn cml0eS9pbWEvaW1hX3BvbGljeS5jCj4gQEAgLTM3Myw3ICszNzMsNyBAQCBzdGF0aWMgYm9vbCBp bWFfbWF0Y2hfcnVsZXMoc3RydWN0IGltYV9ydWxlX2VudHJ5ICpydWxlLCBzdHJ1Y3QgaW5vZGUg Kmlub2RlLAo+ICB7Cj4gIAlpbnQgaTsKPiAgCj4gLQlpZiAoZnVuYyA9IEtFWEVDX0NNRExJTkUp IHsKPiArCWlmICgoZnVuYyA9IEtFWEVDX0NNRExJTkUpIHx8IChmdW5jID0gS0VZUklOR19DSEVD SykpIHsKPiAgCQlpZiAoKHJ1bGUtPmZsYWdzICYgSU1BX0ZVTkMpICYmIChydWxlLT5mdW5jID0g ZnVuYykpCj4gIAkJCXJldHVybiB0cnVlOwo+ICAJCXJldHVybiBmYWxzZTsKPiBAQCAtOTk3LDYg Kzk5Nyw4IEBAIHN0YXRpYyBpbnQgaW1hX3BhcnNlX3J1bGUoY2hhciAqcnVsZSwgc3RydWN0IGlt YV9ydWxlX2VudHJ5ICplbnRyeSkKPiAgCQkJCWVudHJ5LT5mdW5jID0gUE9MSUNZX0NIRUNLOwo+ ICAJCQllbHNlIGlmIChzdHJjbXAoYXJnc1swXS5mcm9tLCAiS0VYRUNfQ01ETElORSIpID0gMCkK PiAgCQkJCWVudHJ5LT5mdW5jID0gS0VYRUNfQ01ETElORTsKPiArCQkJZWxzZSBpZiAoc3RyY21w KGFyZ3NbMF0uZnJvbSwgIktFWVJJTkdfQ0hFQ0siKSA9IDApCj4gKwkJCQllbnRyeS0+ZnVuYyA9 IEtFWVJJTkdfQ0hFQ0s7Cj4gIAkJCWVsc2UKPiAgCQkJCXJlc3VsdCA9IC1FSU5WQUw7Cj4gIAkJ CWlmICghcmVzdWx0KQoKCgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4A0C17440 for ; Tue, 12 Nov 2019 17:05:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBBDC21A49 for ; Tue, 12 Nov 2019 17:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726718AbfKLRFH (ORCPT ); Tue, 12 Nov 2019 12:05:07 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:25176 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726896AbfKLRFH (ORCPT ); Tue, 12 Nov 2019 12:05:07 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xACGvjH6127765 for ; Tue, 12 Nov 2019 12:05:05 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w7xmrnn85-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 12 Nov 2019 12:05:04 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 Nov 2019 17:05:01 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 12 Nov 2019 17:04:58 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xACH4wwf40960480 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Nov 2019 17:04:58 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E9F5111C050; Tue, 12 Nov 2019 17:04:57 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9898311C04A; Tue, 12 Nov 2019 17:04:56 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.194.252]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 12 Nov 2019 17:04:56 +0000 (GMT) Subject: Re: [PATCH v5 01/10] IMA: Added KEYRING_CHECK func in IMA policy to measure keys From: Mimi Zohar To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 Nov 2019 12:04:56 -0500 In-Reply-To: <20191111193303.12781-2-nramas@linux.microsoft.com> References: <20191111193303.12781-1-nramas@linux.microsoft.com> <20191111193303.12781-2-nramas@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19111217-0012-0000-0000-000003630ADF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19111217-0013-0000-0000-0000219E7C21 Message-Id: <1573578296.17949.41.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-12_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911120145 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, 2019-11-11 at 11:32 -0800, Lakshmi Ramasubramanian wrote: > IMA policy needs to support a func to enable measurement of > asymmetric keys. > > This patch defines a new IMA policy func namely KEYRING_CHECK to > measure asymmetric keys. This new feature measures "keys" based on policy, not "keyrings".  Please change the name to KEY_CHECK. > > Signed-off-by: Lakshmi Ramasubramanian > --- > Documentation/ABI/testing/ima_policy | 6 ++++++ > security/integrity/ima/ima.h | 1 + > security/integrity/ima/ima_policy.c | 4 +++- > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/ima_policy b/Documentation/ABI/testing/ima_policy > index 29aaedf33246..341df49b5ad1 100644 > --- a/Documentation/ABI/testing/ima_policy > +++ b/Documentation/ABI/testing/ima_policy > @@ -30,6 +30,7 @@ Description: > [FIRMWARE_CHECK] > [KEXEC_KERNEL_CHECK] [KEXEC_INITRAMFS_CHECK] > [KEXEC_CMDLINE] > + [KEYRING_CHECK] > mask:= [[^]MAY_READ] [[^]MAY_WRITE] [[^]MAY_APPEND] > [[^]MAY_EXEC] > fsmagic:= hex value > @@ -113,3 +114,8 @@ Description: > Example of appraise rule allowing modsig appended signatures: > > appraise func=KEXEC_KERNEL_CHECK appraise_type=imasig|modsig > + > + Example of measure rule using KEYRING_CHECK to measure > + all keys: > + > + measure func=KEYRING_CHECK > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > index df4ca482fb53..7f23405b2718 100644 > --- a/security/integrity/ima/ima.h > +++ b/security/integrity/ima/ima.h > @@ -193,6 +193,7 @@ static inline unsigned long ima_hash_key(u8 *digest) > hook(KEXEC_INITRAMFS_CHECK) \ > hook(POLICY_CHECK) \ > hook(KEXEC_CMDLINE) \ > + hook(KEYRING_CHECK) \ > hook(MAX_CHECK) > #define __ima_hook_enumify(ENUM) ENUM, > > diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c > index f19a895ad7cd..9ca32ffaaa9d 100644 > --- a/security/integrity/ima/ima_policy.c > +++ b/security/integrity/ima/ima_policy.c > @@ -373,7 +373,7 @@ static bool ima_match_rules(struct ima_rule_entry *rule, struct inode *inode, > { > int i; > > - if (func == KEXEC_CMDLINE) { > + if ((func == KEXEC_CMDLINE) || (func == KEYRING_CHECK)) { > if ((rule->flags & IMA_FUNC) && (rule->func == func)) > return true; > return false; > @@ -997,6 +997,8 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry) > entry->func = POLICY_CHECK; > else if (strcmp(args[0].from, "KEXEC_CMDLINE") == 0) > entry->func = KEXEC_CMDLINE; > + else if (strcmp(args[0].from, "KEYRING_CHECK") == 0) > + entry->func = KEYRING_CHECK; > else > result = -EINVAL; > if (!result)