From: Christoph Fritz <chf.fritz@googlemail.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] regulator: da9062: refactor buck modes into header
Date: Wed, 13 Nov 2019 12:04:51 +0100 [thread overview]
Message-ID: <1573643091.2357.5.camel@googlemail.com> (raw)
In-Reply-To: <AM5PR1001MB099402F860196D82601BC264807B0@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM>
Hi Adam
On Fri, 2019-11-08 at 10:37 +0000, Adam Thomson wrote:
> > --- a/drivers/regulator/da9062-regulator.c
> > +++ b/drivers/regulator/da9062-regulator.c
> > @@ -16,6 +16,7 @@
> > #include <linux/regulator/of_regulator.h>
> > #include <linux/mfd/da9062/core.h>
> > #include <linux/mfd/da9062/registers.h>
> > +#include <dt-bindings/regulator/dlg,da906x-regulator.h>
>
> Can we please rename this file to use da9063 instead of da906x
[..]
sure
> > @@ -145,15 +138,14 @@ static unsigned da9062_buck_get_mode(struct
> > regulator_dev *rdev)
> >
> > switch (val) {
> > default:
> > - case BUCK_MODE_MANUAL:
> > mode = REGULATOR_MODE_FAST |
> > REGULATOR_MODE_STANDBY;
> > /* Sleep flag bit decides the mode */
> > break;
>
> I'm not sure your code is based on the latest regulator updates as I believe
> Axel Lin made some improvements to this bit of code. Checkout Mark's regulator
> fork of the kernel.
yes, the line
mode = REGULATOR_MODE_FAST | REGULATOR_MODE_STANDBY;
is now gone by commit
be446f183ae35a8c76
regulator: da9062: Simplify da9062_buck_set_mode for BUCK_MODE_MANUAL case
it's already in linux-next, I'll rebase this patchset
> > diff --git a/include/dt-bindings/regulator/dlg,da906x-regulator.h b/include/dt-
> > bindings/regulator/dlg,da906x-regulator.h
> > new file mode 100644
> > index 00000000..848a4df
> > --- /dev/null
> > +++ b/include/dt-bindings/regulator/dlg,da906x-regulator.h
> > @@ -0,0 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +
> > +#ifndef __DLG_DA906X_REGULATOR_H
> > +#define __DLG_DA906X_REGULATOR_H
>
> Just to echo previous comment, rename from DA906X to DA9063
ok
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Fritz <chf.fritz@googlemail.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] regulator: da9062: refactor buck modes into header
Date: Wed, 13 Nov 2019 12:04:51 +0100 [thread overview]
Message-ID: <1573643091.2357.5.camel@googlemail.com> (raw)
In-Reply-To: <AM5PR1001MB099402F860196D82601BC264807B0@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM>
Hi Adam
On Fri, 2019-11-08 at 10:37 +0000, Adam Thomson wrote:
> > --- a/drivers/regulator/da9062-regulator.c
> > +++ b/drivers/regulator/da9062-regulator.c
> > @@ -16,6 +16,7 @@
> > #include <linux/regulator/of_regulator.h>
> > #include <linux/mfd/da9062/core.h>
> > #include <linux/mfd/da9062/registers.h>
> > +#include <dt-bindings/regulator/dlg,da906x-regulator.h>
>
> Can we please rename this file to use da9063 instead of da906x
[..]
sure
> > @@ -145,15 +138,14 @@ static unsigned da9062_buck_get_mode(struct
> > regulator_dev *rdev)
> >
> > switch (val) {
> > default:
> > - case BUCK_MODE_MANUAL:
> > mode = REGULATOR_MODE_FAST |
> > REGULATOR_MODE_STANDBY;
> > /* Sleep flag bit decides the mode */
> > break;
>
> I'm not sure your code is based on the latest regulator updates as I believe
> Axel Lin made some improvements to this bit of code. Checkout Mark's regulator
> fork of the kernel.
yes, the line
mode = REGULATOR_MODE_FAST | REGULATOR_MODE_STANDBY;
is now gone by commit
be446f183ae35a8c76
regulator: da9062: Simplify da9062_buck_set_mode for BUCK_MODE_MANUAL case
it's already in linux-next, I'll rebase this patchset
> > diff --git a/include/dt-bindings/regulator/dlg,da906x-regulator.h b/include/dt-
> > bindings/regulator/dlg,da906x-regulator.h
> > new file mode 100644
> > index 00000000..848a4df
> > --- /dev/null
> > +++ b/include/dt-bindings/regulator/dlg,da906x-regulator.h
> > @@ -0,0 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +
> > +#ifndef __DLG_DA906X_REGULATOR_H
> > +#define __DLG_DA906X_REGULATOR_H
>
> Just to echo previous comment, rename from DA906X to DA9063
ok
next prev parent reply other threads:[~2019-11-13 11:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 10:04 [PATCH 0/4] regulator da9062: support setting buck modes Christoph Fritz
2019-11-07 10:04 ` Christoph Fritz
2019-11-07 10:04 ` [PATCH 1/4] regulator: da9062: refactor buck modes into header Christoph Fritz
2019-11-07 10:04 ` Christoph Fritz
2019-11-08 10:37 ` Adam Thomson
2019-11-08 10:37 ` Adam Thomson
2019-11-13 11:04 ` Christoph Fritz [this message]
2019-11-13 11:04 ` Christoph Fritz
2019-11-07 10:04 ` [PATCH 2/4] regulator: da9062: add of_map_mode support for bucks Christoph Fritz
2019-11-07 10:04 ` Christoph Fritz
2019-11-08 10:42 ` Adam Thomson
2019-11-08 10:42 ` Adam Thomson
2019-11-07 10:04 ` [PATCH 3/4] dt-bindings: regulator: describe da906x buck regulator modes Christoph Fritz
2019-11-07 10:04 ` Christoph Fritz
2019-11-07 11:55 ` Mark Brown
2019-11-07 11:55 ` Mark Brown
2019-11-08 10:44 ` Adam Thomson
2019-11-08 10:44 ` Adam Thomson
2019-11-13 13:32 ` Rob Herring
2019-11-13 13:32 ` Rob Herring
2019-11-07 10:04 ` [PATCH 4/4] ARM: dts: phycore-imx6: set buck regulator modes explicitly Christoph Fritz
2019-11-07 10:04 ` Christoph Fritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573643091.2357.5.camel@googlemail.com \
--to=chf.fritz@googlemail.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.