From: Stephen Boyd <sboyd@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, upstream@airoha.com
Cc: Christian Marangi <ansuelsmth@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 2/4] dt-bindings: clock: drop NUM_CLOCKS define for EN7581
Date: Mon, 13 Jan 2025 13:33:35 -0800 [thread overview]
Message-ID: <15742b3ea7b5ee1cfdeb78657e9dc4c5.sboyd@kernel.org> (raw)
In-Reply-To: <20250112133953.10404-2-ansuelsmth@gmail.com>
Subject says EN7581....
Quoting Christian Marangi (2025-01-12 05:39:38)
> Drop NUM_CLOCKS define for EN7581 include. This is not a binding and
> should not be placed here. Value is derived internally in the user
> driver.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes v5:
> - Add ack tag
> Changes v4:
> - Move to patch 2 (improves bisectability)
> Changes v3:
> - Add this patch
>
> include/dt-bindings/clock/en7523-clk.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h
> index 717d23a5e5ae..28e56745ccff 100644
> --- a/include/dt-bindings/clock/en7523-clk.h
> +++ b/include/dt-bindings/clock/en7523-clk.h
> @@ -12,6 +12,4 @@
> #define EN7523_CLK_CRYPTO 6
> #define EN7523_CLK_PCIE 7
>
> -#define EN7523_NUM_CLOCKS 8
But this is EN7523
drivers/clk/clk-en7523.c:539:25: error: ‘EN7523_NUM_CLOCKS’ undeclared (first use in this function)
539 | clk_data->num = EN7523_NUM_CLOCKS;
| ^~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2025-01-13 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 13:39 [PATCH v5 1/4] clk: en7523: Rework clock handling for different clock numbers Christian Marangi
2025-01-12 13:39 ` [PATCH v5 2/4] dt-bindings: clock: drop NUM_CLOCKS define for EN7581 Christian Marangi
2025-01-13 21:31 ` Stephen Boyd
2025-01-13 21:33 ` Stephen Boyd [this message]
2025-01-13 21:37 ` Christian Marangi
2025-01-13 21:53 ` Stephen Boyd
2025-01-13 22:17 ` Christian Marangi
2025-01-13 22:45 ` Stephen Boyd
2025-01-13 23:12 ` Christian Marangi
2025-01-12 13:39 ` [PATCH v5 3/4] dt-bindings: clock: add ID for eMMC " Christian Marangi
2025-01-13 21:31 ` Stephen Boyd
2025-01-12 13:39 ` [PATCH v5 4/4] clk: en7523: Add clock " Christian Marangi
2025-01-13 21:31 ` Stephen Boyd
2025-01-13 21:31 ` [PATCH v5 1/4] clk: en7523: Rework clock handling for different clock numbers Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15742b3ea7b5ee1cfdeb78657e9dc4c5.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.