From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com (zimbra.linbit.com [212.69.161.123]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id C1D2D1028A59 for ; Fri, 31 Jul 2015 14:51:05 +0200 (CEST) From: Philipp Reisner To: Nick Wang Date: Fri, 31 Jul 2015 14:50:53 +0200 Message-ID: <1574351.c1nomEfrHy@fat-tyre> In-Reply-To: <1436776744-3135-3-git-send-email-nwang@suse.com> References: <1436776744-3135-1-git-send-email-nwang@suse.com> <1436776744-3135-3-git-send-email-nwang@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: Lars Ellenberg , linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Nick, When introducing new fields alsways mark them as optional. Otherwise a new kernel/module code would refuse netlink messages from older drbd-utils: > + __flg_field(2, DRBD_GENLA_F_MANDATORY, zap_devices) __flg_field(2, /* OPTIONAL */ 0, zap_devices) best regards, Phil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbbGaMvJ (ORCPT ); Fri, 31 Jul 2015 08:51:09 -0400 Received: from zimbra13.linbit.com ([212.69.166.240]:42050 "EHLO zimbra13.linbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbbGaMvH (ORCPT ); Fri, 31 Jul 2015 08:51:07 -0400 From: Philipp Reisner To: Nick Wang Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg Subject: Re: [Drbd-dev] [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid Date: Fri, 31 Jul 2015 14:50:53 +0200 Message-ID: <1574351.c1nomEfrHy@fat-tyre> User-Agent: KMail/4.13.3 (Linux/3.16.0-30-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1436776744-3135-3-git-send-email-nwang@suse.com> References: <1436776744-3135-1-git-send-email-nwang@suse.com> <1436776744-3135-3-git-send-email-nwang@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nick, When introducing new fields alsways mark them as optional. Otherwise a new kernel/module code would refuse netlink messages from older drbd-utils: > + __flg_field(2, DRBD_GENLA_F_MANDATORY, zap_devices) __flg_field(2, /* OPTIONAL */ 0, zap_devices) best regards, Phil