From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2635EC432C0 for ; Fri, 22 Nov 2019 08:41:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF0F62070E for ; Fri, 22 Nov 2019 08:41:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nL1kD/ku"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="t2/RfkKI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF0F62070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZGtMhJvQ4YmXiZjQluitlCveZ3gZRgKKAdxJKWvxWnk=; b=nL1kD/kuKdfufA dFPfqUiA1WhXgK9orV4YTalC/q445Ro9KI8kEijUPQzLdVQnXErzt7S+/0yhkXFSpNVNp7HEsiwKQ jdO+SN9wk5UnpQAhiqJZbEykClCGEZl/FWBjO/4lw6pl7qGPEjKYzyB75+N4PFSdt6IknuKhVgBet Ax6ug/OYslTyq+5t326GTw1Yr5pBkWG+EWstbKoFaqDjsWVbK7v3kfLv0WodpC1+truQhVJ0jozh1 nAZnB1T2ZdUAIG2/RQuIgeQ1x2+gNKPbiAbwcyDRxGAYu15jNE9EG13/O8itL/H4OmbghyDWQB+T+ J2sdniqNQyE3PNZVBoUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY4Ux-0001Na-OP; Fri, 22 Nov 2019 08:41:03 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY4UX-0000yC-SU; Fri, 22 Nov 2019 08:40:39 +0000 X-UUID: b9632fadb5ed4044b1bf1e9b97cdd0b9-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zKQOxirmySYcxcZXIgTVjcOzLInsWmu/tj21UeF5XGk=; b=t2/RfkKI/ox3+OPPbvtlWkJsEST3bSklC1Y7G9DihP67Nlery+fKYhCTTZLXirZEMZje1Mhji1e+tnHUKCqCaEK3hEPvVWsrVw95mnpIs521VUNVqZddIwHzofjur2v65POm9ru7heNr5wCaVyPU5ITPVZYMsFJ5G/qNYu7wyrU=; X-UUID: b9632fadb5ed4044b1bf1e9b97cdd0b9-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1619727334; Fri, 22 Nov 2019 00:40:33 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 00:30:54 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 16:30:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 16:30:03 +0800 Message-ID: <1574411430.19450.5.camel@mtksdaap41> Subject: Re: [PATCH v17 3/6] soc: mediatek: cmdq: define the instruction struct From: CK Hu To: Bibby Hsieh Date: Fri, 22 Nov 2019 16:30:30 +0800 In-Reply-To: <20191121015410.18852-4-bibby.hsieh@mediatek.com> References: <20191121015410.18852-1-bibby.hsieh@mediatek.com> <20191121015410.18852-4-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_004037_930741_F2F9432B X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Dennis-YC Hsieh , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-11-21 at 09:54 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. Even though I do not like pass struct parameter by value, but struct cmdq_instruction is just a 64 bits integer and would not be modified in cmdq_pkt_append_command(), so Reviewed-by: CK Hu > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 73 ++++++++++++++++-------- > include/linux/mailbox/mtk-cmdq-mailbox.h | 10 ++++ > 2 files changed, 59 insertions(+), 24 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index c8fb69787649..11bfcc150ebd 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -9,12 +9,24 @@ > #include > #include > > -#define CMDQ_ARG_A_WRITE_MASK 0xffff > #define CMDQ_WRITE_ENABLE_MASK BIT(0) > #define CMDQ_EOC_IRQ_EN BIT(0) > #define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ > << 32 | CMDQ_EOC_IRQ_EN) > > +struct cmdq_instruction { > + union { > + u32 value; > + u32 mask; > + }; > + union { > + u16 offset; > + u16 event; > + }; > + u8 subsys; > + u8 op; > +}; > + > static void cmdq_client_timeout(struct timer_list *t) > { > struct cmdq_client *client = from_timer(client, t, timer); > @@ -110,10 +122,10 @@ void cmdq_pkt_destroy(struct cmdq_pkt *pkt) > } > EXPORT_SYMBOL(cmdq_pkt_destroy); > > -static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > - u32 arg_a, u32 arg_b) > +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, > + struct cmdq_instruction inst) > { > - u64 *cmd_ptr; > + struct cmdq_instruction *cmd_ptr; > > if (unlikely(pkt->cmd_buf_size + CMDQ_INST_SIZE > pkt->buf_size)) { > /* > @@ -129,8 +141,9 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > __func__, (u32)pkt->buf_size); > return -ENOMEM; > } > + > cmd_ptr = pkt->va_base + pkt->cmd_buf_size; > - (*cmd_ptr) = (u64)((code << CMDQ_OP_CODE_SHIFT) | arg_a) << 32 | arg_b; > + *cmd_ptr = inst; > pkt->cmd_buf_size += CMDQ_INST_SIZE; > > return 0; > @@ -138,21 +151,28 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > > int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) > { > - u32 arg_a = (offset & CMDQ_ARG_A_WRITE_MASK) | > - (subsys << CMDQ_SUBSYS_SHIFT); > + struct cmdq_instruction inst; > > - return cmdq_pkt_append_command(pkt, CMDQ_CODE_WRITE, arg_a, value); > + inst.op = CMDQ_CODE_WRITE; > + inst.value = value; > + inst.offset = offset; > + inst.subsys = subsys; > + > + return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_write); > > int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > u16 offset, u32 value, u32 mask) > { > - u32 offset_mask = offset; > + struct cmdq_instruction inst = { {0} }; > + u16 offset_mask = offset; > int err; > > if (mask != 0xffffffff) { > - err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask); > + inst.op = CMDQ_CODE_MASK; > + inst.mask = ~mask; > + err = cmdq_pkt_append_command(pkt, inst); > if (err < 0) > return err; > > @@ -166,45 +186,50 @@ EXPORT_SYMBOL(cmdq_pkt_write_mask); > > int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) > { > - u32 arg_b; > + struct cmdq_instruction inst = { {0} }; > > if (event >= CMDQ_MAX_EVENT) > return -EINVAL; > > - /* > - * WFE arg_b > - * bit 0-11: wait value > - * bit 15: 1 - wait, 0 - no wait > - * bit 16-27: update value > - * bit 31: 1 - update, 0 - no update > - */ > - arg_b = CMDQ_WFE_UPDATE | CMDQ_WFE_WAIT | CMDQ_WFE_WAIT_VALUE; > + inst.op = CMDQ_CODE_WFE; > + inst.value = CMDQ_WFE_OPTION; > + inst.event = event; > > - return cmdq_pkt_append_command(pkt, CMDQ_CODE_WFE, event, arg_b); > + return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_wfe); > > int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u16 event) > { > + struct cmdq_instruction inst = { {0} }; > + > if (event >= CMDQ_MAX_EVENT) > return -EINVAL; > > - return cmdq_pkt_append_command(pkt, CMDQ_CODE_WFE, event, > - CMDQ_WFE_UPDATE); > + inst.op = CMDQ_CODE_WFE; > + inst.value = CMDQ_WFE_UPDATE; > + inst.event = event; > + > + return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_clear_event); > > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > + struct cmdq_instruction inst = { {0} }; > int err; > > /* insert EOC and generate IRQ for each command iteration */ > - err = cmdq_pkt_append_command(pkt, CMDQ_CODE_EOC, 0, CMDQ_EOC_IRQ_EN); > + inst.op = CMDQ_CODE_EOC; > + inst.value = CMDQ_EOC_IRQ_EN; > + err = cmdq_pkt_append_command(pkt, inst); > if (err < 0) > return err; > > /* JUMP to end */ > - err = cmdq_pkt_append_command(pkt, CMDQ_CODE_JUMP, 0, CMDQ_JUMP_PASS); > + inst.op = CMDQ_CODE_JUMP; > + inst.value = CMDQ_JUMP_PASS; > + err = cmdq_pkt_append_command(pkt, inst); > > return err; > } > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h > index e6f54ef6698b..678760548791 100644 > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > @@ -20,6 +20,16 @@ > #define CMDQ_WFE_WAIT BIT(15) > #define CMDQ_WFE_WAIT_VALUE 0x1 > > +/* > + * WFE arg_b > + * bit 0-11: wait value > + * bit 15: 1 - wait, 0 - no wait > + * bit 16-27: update value > + * bit 31: 1 - update, 0 - no update > + */ > +#define CMDQ_WFE_OPTION (CMDQ_WFE_UPDATE | CMDQ_WFE_WAIT | \ > + CMDQ_WFE_WAIT_VALUE) > + > /** cmdq event maximum */ > #define CMDQ_MAX_EVENT 0x3ff > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D01DC432C0 for ; Fri, 22 Nov 2019 08:40:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 523D02070E for ; Fri, 22 Nov 2019 08:40:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oeH1vPvG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="t2/RfkKI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 523D02070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nc648a6HY2Gzq3rvXHWnO2vSu5yT9YwUEQi0dQGH4zI=; b=oeH1vPvG8Sc5jd mgIo0OnlfEA+FkADCVvfoXDDUUzmvLSdT7lPbFw/ruWPpxgl52qH/2p1MGhF91ab8jiIYOxk7CQiR 5KT8+9nijyz6vssm5xgj+Jb5frbhotMxR8iISA2KLJDD5OcmDxvpU4t6SeQkToFTxIWrDPQJ9dOQ4 YvuqjkVEt8g5ph9+OPjtSQpCz581JzIU58Oa6q1xuu1nDxVsI1KyVn+y7AMh/Vz6bfErkazRfuyYQ 9VlJGnFa86My+Xn+jvX7cf1ZbgGdKhZ0V9LFgODjByEvMPFL2+DvYIK8CFz+rz6LLwWn+HK9Wp1CI yCAMX1JgzVt+jWn20cDg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY4Uh-00015Z-4Y; Fri, 22 Nov 2019 08:40:47 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY4UX-0000yC-SU; Fri, 22 Nov 2019 08:40:39 +0000 X-UUID: b9632fadb5ed4044b1bf1e9b97cdd0b9-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zKQOxirmySYcxcZXIgTVjcOzLInsWmu/tj21UeF5XGk=; b=t2/RfkKI/ox3+OPPbvtlWkJsEST3bSklC1Y7G9DihP67Nlery+fKYhCTTZLXirZEMZje1Mhji1e+tnHUKCqCaEK3hEPvVWsrVw95mnpIs521VUNVqZddIwHzofjur2v65POm9ru7heNr5wCaVyPU5ITPVZYMsFJ5G/qNYu7wyrU=; X-UUID: b9632fadb5ed4044b1bf1e9b97cdd0b9-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1619727334; Fri, 22 Nov 2019 00:40:33 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 00:30:54 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 16:30:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 16:30:03 +0800 Message-ID: <1574411430.19450.5.camel@mtksdaap41> Subject: Re: [PATCH v17 3/6] soc: mediatek: cmdq: define the instruction struct From: CK Hu To: Bibby Hsieh Date: Fri, 22 Nov 2019 16:30:30 +0800 In-Reply-To: <20191121015410.18852-4-bibby.hsieh@mediatek.com> References: <20191121015410.18852-1-bibby.hsieh@mediatek.com> <20191121015410.18852-4-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_004037_930741_F2F9432B X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Dennis-YC Hsieh , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-11-21 at 09:54 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. Even though I do not like pass struct parameter by value, but struct cmdq_instruction is just a 64 bits integer and would not be modified in cmdq_pkt_append_command(), so Reviewed-by: CK Hu > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 73 ++++++++++++++++-------- > include/linux/mailbox/mtk-cmdq-mailbox.h | 10 ++++ > 2 files changed, 59 insertions(+), 24 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index c8fb69787649..11bfcc150ebd 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -9,12 +9,24 @@ > #include > #include > > -#define CMDQ_ARG_A_WRITE_MASK 0xffff > #define CMDQ_WRITE_ENABLE_MASK BIT(0) > #define CMDQ_EOC_IRQ_EN BIT(0) > #define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ > << 32 | CMDQ_EOC_IRQ_EN) > > +struct cmdq_instruction { > + union { > + u32 value; > + u32 mask; > + }; > + union { > + u16 offset; > + u16 event; > + }; > + u8 subsys; > + u8 op; > +}; > + > static void cmdq_client_timeout(struct timer_list *t) > { > struct cmdq_client *client = from_timer(client, t, timer); > @@ -110,10 +122,10 @@ void cmdq_pkt_destroy(struct cmdq_pkt *pkt) > } > EXPORT_SYMBOL(cmdq_pkt_destroy); > > -static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > - u32 arg_a, u32 arg_b) > +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, > + struct cmdq_instruction inst) > { > - u64 *cmd_ptr; > + struct cmdq_instruction *cmd_ptr; > > if (unlikely(pkt->cmd_buf_size + CMDQ_INST_SIZE > pkt->buf_size)) { > /* > @@ -129,8 +141,9 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > __func__, (u32)pkt->buf_size); > return -ENOMEM; > } > + > cmd_ptr = pkt->va_base + pkt->cmd_buf_size; > - (*cmd_ptr) = (u64)((code << CMDQ_OP_CODE_SHIFT) | arg_a) << 32 | arg_b; > + *cmd_ptr = inst; > pkt->cmd_buf_size += CMDQ_INST_SIZE; > > return 0; > @@ -138,21 +151,28 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > > int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) > { > - u32 arg_a = (offset & CMDQ_ARG_A_WRITE_MASK) | > - (subsys << CMDQ_SUBSYS_SHIFT); > + struct cmdq_instruction inst; > > - return cmdq_pkt_append_command(pkt, CMDQ_CODE_WRITE, arg_a, value); > + inst.op = CMDQ_CODE_WRITE; > + inst.value = value; > + inst.offset = offset; > + inst.subsys = subsys; > + > + return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_write); > > int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > u16 offset, u32 value, u32 mask) > { > - u32 offset_mask = offset; > + struct cmdq_instruction inst = { {0} }; > + u16 offset_mask = offset; > int err; > > if (mask != 0xffffffff) { > - err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask); > + inst.op = CMDQ_CODE_MASK; > + inst.mask = ~mask; > + err = cmdq_pkt_append_command(pkt, inst); > if (err < 0) > return err; > > @@ -166,45 +186,50 @@ EXPORT_SYMBOL(cmdq_pkt_write_mask); > > int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) > { > - u32 arg_b; > + struct cmdq_instruction inst = { {0} }; > > if (event >= CMDQ_MAX_EVENT) > return -EINVAL; > > - /* > - * WFE arg_b > - * bit 0-11: wait value > - * bit 15: 1 - wait, 0 - no wait > - * bit 16-27: update value > - * bit 31: 1 - update, 0 - no update > - */ > - arg_b = CMDQ_WFE_UPDATE | CMDQ_WFE_WAIT | CMDQ_WFE_WAIT_VALUE; > + inst.op = CMDQ_CODE_WFE; > + inst.value = CMDQ_WFE_OPTION; > + inst.event = event; > > - return cmdq_pkt_append_command(pkt, CMDQ_CODE_WFE, event, arg_b); > + return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_wfe); > > int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u16 event) > { > + struct cmdq_instruction inst = { {0} }; > + > if (event >= CMDQ_MAX_EVENT) > return -EINVAL; > > - return cmdq_pkt_append_command(pkt, CMDQ_CODE_WFE, event, > - CMDQ_WFE_UPDATE); > + inst.op = CMDQ_CODE_WFE; > + inst.value = CMDQ_WFE_UPDATE; > + inst.event = event; > + > + return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_clear_event); > > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > + struct cmdq_instruction inst = { {0} }; > int err; > > /* insert EOC and generate IRQ for each command iteration */ > - err = cmdq_pkt_append_command(pkt, CMDQ_CODE_EOC, 0, CMDQ_EOC_IRQ_EN); > + inst.op = CMDQ_CODE_EOC; > + inst.value = CMDQ_EOC_IRQ_EN; > + err = cmdq_pkt_append_command(pkt, inst); > if (err < 0) > return err; > > /* JUMP to end */ > - err = cmdq_pkt_append_command(pkt, CMDQ_CODE_JUMP, 0, CMDQ_JUMP_PASS); > + inst.op = CMDQ_CODE_JUMP; > + inst.value = CMDQ_JUMP_PASS; > + err = cmdq_pkt_append_command(pkt, inst); > > return err; > } > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h > index e6f54ef6698b..678760548791 100644 > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > @@ -20,6 +20,16 @@ > #define CMDQ_WFE_WAIT BIT(15) > #define CMDQ_WFE_WAIT_VALUE 0x1 > > +/* > + * WFE arg_b > + * bit 0-11: wait value > + * bit 15: 1 - wait, 0 - no wait > + * bit 16-27: update value > + * bit 31: 1 - update, 0 - no update > + */ > +#define CMDQ_WFE_OPTION (CMDQ_WFE_UPDATE | CMDQ_WFE_WAIT | \ > + CMDQ_WFE_WAIT_VALUE) > + > /** cmdq event maximum */ > #define CMDQ_MAX_EVENT 0x3ff > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4B6C432C0 for ; Fri, 22 Nov 2019 08:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCB1A20672 for ; Fri, 22 Nov 2019 08:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="t2/RfkKI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726248AbfKVIai (ORCPT ); Fri, 22 Nov 2019 03:30:38 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:27135 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726018AbfKVIai (ORCPT ); Fri, 22 Nov 2019 03:30:38 -0500 X-UUID: f6eec23ec8f74fedaaa4374a57dbb3fc-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zKQOxirmySYcxcZXIgTVjcOzLInsWmu/tj21UeF5XGk=; b=t2/RfkKI/ox3+OPPbvtlWkJsEST3bSklC1Y7G9DihP67Nlery+fKYhCTTZLXirZEMZje1Mhji1e+tnHUKCqCaEK3hEPvVWsrVw95mnpIs521VUNVqZddIwHzofjur2v65POm9ru7heNr5wCaVyPU5ITPVZYMsFJ5G/qNYu7wyrU=; X-UUID: f6eec23ec8f74fedaaa4374a57dbb3fc-20191122 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 356741794; Fri, 22 Nov 2019 16:30:31 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 16:30:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 16:30:03 +0800 Message-ID: <1574411430.19450.5.camel@mtksdaap41> Subject: Re: [PATCH v17 3/6] soc: mediatek: cmdq: define the instruction struct From: CK Hu To: Bibby Hsieh CC: Matthias Brugger , Rob Herring , , , , , , "Nicolas Boichat" , Dennis-YC Hsieh Date: Fri, 22 Nov 2019 16:30:30 +0800 In-Reply-To: <20191121015410.18852-4-bibby.hsieh@mediatek.com> References: <20191121015410.18852-1-bibby.hsieh@mediatek.com> <20191121015410.18852-4-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGksIEJpYmJ5Og0KDQpPbiBUaHUsIDIwMTktMTEtMjEgYXQgMDk6NTQgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBEZWZpbmUgYW4gaW5zdHJ1Y3Rpb24gc3RydWN0dXJlIGZvciBnY2UgZHJp dmVyIHRvIGFwcGVuZCBjb21tYW5kLg0KPiBUaGlzIHN0cnVjdHVyZSBjYW4gbWFrZSB0aGUgY2xp ZW50J3MgY29kZSBtb3JlIHJlYWRhYmlsaXR5Lg0KDQpFdmVuIHRob3VnaCBJIGRvIG5vdCBsaWtl IHBhc3Mgc3RydWN0IHBhcmFtZXRlciBieSB2YWx1ZSwgYnV0IHN0cnVjdA0KY21kcV9pbnN0cnVj dGlvbiBpcyBqdXN0IGEgNjQgYml0cyBpbnRlZ2VyIGFuZCB3b3VsZCBub3QgYmUgbW9kaWZpZWQg aW4NCmNtZHFfcGt0X2FwcGVuZF9jb21tYW5kKCksIHNvDQoNClJldmlld2VkLWJ5OiBDSyBIdSA8 Y2suaHVAbWVkaWF0ZWsuY29tPg0KDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBCaWJieSBIc2llaCA8 YmliYnkuaHNpZWhAbWVkaWF0ZWsuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvc29jL21lZGlhdGVr L210ay1jbWRxLWhlbHBlci5jICAgfCA3MyArKysrKysrKysrKysrKysrLS0tLS0tLS0NCj4gIGlu Y2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWlsYm94LmggfCAxMCArKysrDQo+ICAyIGZp bGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5jIGIvZHJpdmVy cy9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEtaGVscGVyLmMNCj4gaW5kZXggYzhmYjY5Nzg3NjQ5Li4x MWJmY2MxNTBlYmQgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRx LWhlbHBlci5jDQo+ICsrKyBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5j DQo+IEBAIC05LDEyICs5LDI0IEBADQo+ICAjaW5jbHVkZSA8bGludXgvbWFpbGJveF9jb250cm9s bGVyLmg+DQo+ICAjaW5jbHVkZSA8bGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmg+DQo+ICAN Cj4gLSNkZWZpbmUgQ01EUV9BUkdfQV9XUklURV9NQVNLCTB4ZmZmZg0KPiAgI2RlZmluZSBDTURR X1dSSVRFX0VOQUJMRV9NQVNLCUJJVCgwKQ0KPiAgI2RlZmluZSBDTURRX0VPQ19JUlFfRU4JCUJJ VCgwKQ0KPiAgI2RlZmluZSBDTURRX0VPQ19DTUQJCSgodTY0KSgoQ01EUV9DT0RFX0VPQyA8PCBD TURRX09QX0NPREVfU0hJRlQpKSBcDQo+ICAJCQkJPDwgMzIgfCBDTURRX0VPQ19JUlFfRU4pDQo+ ICANCj4gK3N0cnVjdCBjbWRxX2luc3RydWN0aW9uIHsNCj4gKwl1bmlvbiB7DQo+ICsJCXUzMiB2 YWx1ZTsNCj4gKwkJdTMyIG1hc2s7DQo+ICsJfTsNCj4gKwl1bmlvbiB7DQo+ICsJCXUxNiBvZmZz ZXQ7DQo+ICsJCXUxNiBldmVudDsNCj4gKwl9Ow0KPiArCXU4IHN1YnN5czsNCj4gKwl1OCBvcDsN Cj4gK307DQo+ICsNCj4gIHN0YXRpYyB2b2lkIGNtZHFfY2xpZW50X3RpbWVvdXQoc3RydWN0IHRp bWVyX2xpc3QgKnQpDQo+ICB7DQo+ICAJc3RydWN0IGNtZHFfY2xpZW50ICpjbGllbnQgPSBmcm9t X3RpbWVyKGNsaWVudCwgdCwgdGltZXIpOw0KPiBAQCAtMTEwLDEwICsxMjIsMTAgQEAgdm9pZCBj bWRxX3BrdF9kZXN0cm95KHN0cnVjdCBjbWRxX3BrdCAqcGt0KQ0KPiAgfQ0KPiAgRVhQT1JUX1NZ TUJPTChjbWRxX3BrdF9kZXN0cm95KTsNCj4gIA0KPiAtc3RhdGljIGludCBjbWRxX3BrdF9hcHBl bmRfY29tbWFuZChzdHJ1Y3QgY21kcV9wa3QgKnBrdCwgZW51bSBjbWRxX2NvZGUgY29kZSwNCj4g LQkJCQkgICB1MzIgYXJnX2EsIHUzMiBhcmdfYikNCj4gK3N0YXRpYyBpbnQgY21kcV9wa3RfYXBw ZW5kX2NvbW1hbmQoc3RydWN0IGNtZHFfcGt0ICpwa3QsDQo+ICsJCQkJICAgc3RydWN0IGNtZHFf aW5zdHJ1Y3Rpb24gaW5zdCkNCj4gIHsNCj4gLQl1NjQgKmNtZF9wdHI7DQo+ICsJc3RydWN0IGNt ZHFfaW5zdHJ1Y3Rpb24gKmNtZF9wdHI7DQo+ICANCj4gIAlpZiAodW5saWtlbHkocGt0LT5jbWRf YnVmX3NpemUgKyBDTURRX0lOU1RfU0laRSA+IHBrdC0+YnVmX3NpemUpKSB7DQo+ICAJCS8qDQo+ IEBAIC0xMjksOCArMTQxLDkgQEAgc3RhdGljIGludCBjbWRxX3BrdF9hcHBlbmRfY29tbWFuZChz dHJ1Y3QgY21kcV9wa3QgKnBrdCwgZW51bSBjbWRxX2NvZGUgY29kZSwNCj4gIAkJCV9fZnVuY19f LCAodTMyKXBrdC0+YnVmX3NpemUpOw0KPiAgCQlyZXR1cm4gLUVOT01FTTsNCj4gIAl9DQo+ICsN Cj4gIAljbWRfcHRyID0gcGt0LT52YV9iYXNlICsgcGt0LT5jbWRfYnVmX3NpemU7DQo+IC0JKCpj bWRfcHRyKSA9ICh1NjQpKChjb2RlIDw8IENNRFFfT1BfQ09ERV9TSElGVCkgfCBhcmdfYSkgPDwg MzIgfCBhcmdfYjsNCj4gKwkqY21kX3B0ciA9IGluc3Q7DQo+ICAJcGt0LT5jbWRfYnVmX3NpemUg Kz0gQ01EUV9JTlNUX1NJWkU7DQo+ICANCj4gIAlyZXR1cm4gMDsNCj4gQEAgLTEzOCwyMSArMTUx LDI4IEBAIHN0YXRpYyBpbnQgY21kcV9wa3RfYXBwZW5kX2NvbW1hbmQoc3RydWN0IGNtZHFfcGt0 ICpwa3QsIGVudW0gY21kcV9jb2RlIGNvZGUsDQo+ICANCj4gIGludCBjbWRxX3BrdF93cml0ZShz dHJ1Y3QgY21kcV9wa3QgKnBrdCwgdTggc3Vic3lzLCB1MTYgb2Zmc2V0LCB1MzIgdmFsdWUpDQo+ ICB7DQo+IC0JdTMyIGFyZ19hID0gKG9mZnNldCAmIENNRFFfQVJHX0FfV1JJVEVfTUFTSykgfA0K PiAtCQkgICAgKHN1YnN5cyA8PCBDTURRX1NVQlNZU19TSElGVCk7DQo+ICsJc3RydWN0IGNtZHFf aW5zdHJ1Y3Rpb24gaW5zdDsNCj4gIA0KPiAtCXJldHVybiBjbWRxX3BrdF9hcHBlbmRfY29tbWFu ZChwa3QsIENNRFFfQ09ERV9XUklURSwgYXJnX2EsIHZhbHVlKTsNCj4gKwlpbnN0Lm9wID0gQ01E UV9DT0RFX1dSSVRFOw0KPiArCWluc3QudmFsdWUgPSB2YWx1ZTsNCj4gKwlpbnN0Lm9mZnNldCA9 IG9mZnNldDsNCj4gKwlpbnN0LnN1YnN5cyA9IHN1YnN5czsNCj4gKw0KPiArCXJldHVybiBjbWRx X3BrdF9hcHBlbmRfY29tbWFuZChwa3QsIGluc3QpOw0KPiAgfQ0KPiAgRVhQT1JUX1NZTUJPTChj bWRxX3BrdF93cml0ZSk7DQo+ICANCj4gIGludCBjbWRxX3BrdF93cml0ZV9tYXNrKHN0cnVjdCBj bWRxX3BrdCAqcGt0LCB1OCBzdWJzeXMsDQo+ICAJCQl1MTYgb2Zmc2V0LCB1MzIgdmFsdWUsIHUz MiBtYXNrKQ0KPiAgew0KPiAtCXUzMiBvZmZzZXRfbWFzayA9IG9mZnNldDsNCj4gKwlzdHJ1Y3Qg Y21kcV9pbnN0cnVjdGlvbiBpbnN0ID0geyB7MH0gfTsNCj4gKwl1MTYgb2Zmc2V0X21hc2sgPSBv ZmZzZXQ7DQo+ICAJaW50IGVycjsNCj4gIA0KPiAgCWlmIChtYXNrICE9IDB4ZmZmZmZmZmYpIHsN Cj4gLQkJZXJyID0gY21kcV9wa3RfYXBwZW5kX2NvbW1hbmQocGt0LCBDTURRX0NPREVfTUFTSywg MCwgfm1hc2spOw0KPiArCQlpbnN0Lm9wID0gQ01EUV9DT0RFX01BU0s7DQo+ICsJCWluc3QubWFz ayA9IH5tYXNrOw0KPiArCQllcnIgPSBjbWRxX3BrdF9hcHBlbmRfY29tbWFuZChwa3QsIGluc3Qp Ow0KPiAgCQlpZiAoZXJyIDwgMCkNCj4gIAkJCXJldHVybiBlcnI7DQo+ICANCj4gQEAgLTE2Niw0 NSArMTg2LDUwIEBAIEVYUE9SVF9TWU1CT0woY21kcV9wa3Rfd3JpdGVfbWFzayk7DQo+ICANCj4g IGludCBjbWRxX3BrdF93ZmUoc3RydWN0IGNtZHFfcGt0ICpwa3QsIHUxNiBldmVudCkNCj4gIHsN Cj4gLQl1MzIgYXJnX2I7DQo+ICsJc3RydWN0IGNtZHFfaW5zdHJ1Y3Rpb24gaW5zdCA9IHsgezB9 IH07DQo+ICANCj4gIAlpZiAoZXZlbnQgPj0gQ01EUV9NQVhfRVZFTlQpDQo+ICAJCXJldHVybiAt RUlOVkFMOw0KPiAgDQo+IC0JLyoNCj4gLQkgKiBXRkUgYXJnX2INCj4gLQkgKiBiaXQgMC0xMTog d2FpdCB2YWx1ZQ0KPiAtCSAqIGJpdCAxNTogMSAtIHdhaXQsIDAgLSBubyB3YWl0DQo+IC0JICog Yml0IDE2LTI3OiB1cGRhdGUgdmFsdWUNCj4gLQkgKiBiaXQgMzE6IDEgLSB1cGRhdGUsIDAgLSBu byB1cGRhdGUNCj4gLQkgKi8NCj4gLQlhcmdfYiA9IENNRFFfV0ZFX1VQREFURSB8IENNRFFfV0ZF X1dBSVQgfCBDTURRX1dGRV9XQUlUX1ZBTFVFOw0KPiArCWluc3Qub3AgPSBDTURRX0NPREVfV0ZF Ow0KPiArCWluc3QudmFsdWUgPSBDTURRX1dGRV9PUFRJT047DQo+ICsJaW5zdC5ldmVudCA9IGV2 ZW50Ow0KPiAgDQo+IC0JcmV0dXJuIGNtZHFfcGt0X2FwcGVuZF9jb21tYW5kKHBrdCwgQ01EUV9D T0RFX1dGRSwgZXZlbnQsIGFyZ19iKTsNCj4gKwlyZXR1cm4gY21kcV9wa3RfYXBwZW5kX2NvbW1h bmQocGt0LCBpbnN0KTsNCj4gIH0NCj4gIEVYUE9SVF9TWU1CT0woY21kcV9wa3Rfd2ZlKTsNCj4g IA0KPiAgaW50IGNtZHFfcGt0X2NsZWFyX2V2ZW50KHN0cnVjdCBjbWRxX3BrdCAqcGt0LCB1MTYg ZXZlbnQpDQo+ICB7DQo+ICsJc3RydWN0IGNtZHFfaW5zdHJ1Y3Rpb24gaW5zdCA9IHsgezB9IH07 DQo+ICsNCj4gIAlpZiAoZXZlbnQgPj0gQ01EUV9NQVhfRVZFTlQpDQo+ICAJCXJldHVybiAtRUlO VkFMOw0KPiAgDQo+IC0JcmV0dXJuIGNtZHFfcGt0X2FwcGVuZF9jb21tYW5kKHBrdCwgQ01EUV9D T0RFX1dGRSwgZXZlbnQsDQo+IC0JCQkJICAgICAgIENNRFFfV0ZFX1VQREFURSk7DQo+ICsJaW5z dC5vcCA9IENNRFFfQ09ERV9XRkU7DQo+ICsJaW5zdC52YWx1ZSA9IENNRFFfV0ZFX1VQREFURTsN Cj4gKwlpbnN0LmV2ZW50ID0gZXZlbnQ7DQo+ICsNCj4gKwlyZXR1cm4gY21kcV9wa3RfYXBwZW5k X2NvbW1hbmQocGt0LCBpbnN0KTsNCj4gIH0NCj4gIEVYUE9SVF9TWU1CT0woY21kcV9wa3RfY2xl YXJfZXZlbnQpOw0KPiAgDQo+ICBzdGF0aWMgaW50IGNtZHFfcGt0X2ZpbmFsaXplKHN0cnVjdCBj bWRxX3BrdCAqcGt0KQ0KPiAgew0KPiArCXN0cnVjdCBjbWRxX2luc3RydWN0aW9uIGluc3QgPSB7 IHswfSB9Ow0KPiAgCWludCBlcnI7DQo+ICANCj4gIAkvKiBpbnNlcnQgRU9DIGFuZCBnZW5lcmF0 ZSBJUlEgZm9yIGVhY2ggY29tbWFuZCBpdGVyYXRpb24gKi8NCj4gLQllcnIgPSBjbWRxX3BrdF9h cHBlbmRfY29tbWFuZChwa3QsIENNRFFfQ09ERV9FT0MsIDAsIENNRFFfRU9DX0lSUV9FTik7DQo+ ICsJaW5zdC5vcCA9IENNRFFfQ09ERV9FT0M7DQo+ICsJaW5zdC52YWx1ZSA9IENNRFFfRU9DX0lS UV9FTjsNCj4gKwllcnIgPSBjbWRxX3BrdF9hcHBlbmRfY29tbWFuZChwa3QsIGluc3QpOw0KPiAg CWlmIChlcnIgPCAwKQ0KPiAgCQlyZXR1cm4gZXJyOw0KPiAgDQo+ICAJLyogSlVNUCB0byBlbmQg Ki8NCj4gLQllcnIgPSBjbWRxX3BrdF9hcHBlbmRfY29tbWFuZChwa3QsIENNRFFfQ09ERV9KVU1Q LCAwLCBDTURRX0pVTVBfUEFTUyk7DQo+ICsJaW5zdC5vcCA9IENNRFFfQ09ERV9KVU1QOw0KPiAr CWluc3QudmFsdWUgPSBDTURRX0pVTVBfUEFTUzsNCj4gKwllcnIgPSBjbWRxX3BrdF9hcHBlbmRf Y29tbWFuZChwa3QsIGluc3QpOw0KPiAgDQo+ICAJcmV0dXJuIGVycjsNCj4gIH0NCj4gZGlmZiAt LWdpdCBhL2luY2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWlsYm94LmggYi9pbmNsdWRl L2xpbnV4L21haWxib3gvbXRrLWNtZHEtbWFpbGJveC5oDQo+IGluZGV4IGU2ZjU0ZWY2Njk4Yi4u Njc4NzYwNTQ4NzkxIDEwMDY0NA0KPiAtLS0gYS9pbmNsdWRlL2xpbnV4L21haWxib3gvbXRrLWNt ZHEtbWFpbGJveC5oDQo+ICsrKyBiL2luY2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWls Ym94LmgNCj4gQEAgLTIwLDYgKzIwLDE2IEBADQo+ICAjZGVmaW5lIENNRFFfV0ZFX1dBSVQJCQlC SVQoMTUpDQo+ICAjZGVmaW5lIENNRFFfV0ZFX1dBSVRfVkFMVUUJCTB4MQ0KPiAgDQo+ICsvKg0K PiArICogV0ZFIGFyZ19iDQo+ICsgKiBiaXQgMC0xMTogd2FpdCB2YWx1ZQ0KPiArICogYml0IDE1 OiAxIC0gd2FpdCwgMCAtIG5vIHdhaXQNCj4gKyAqIGJpdCAxNi0yNzogdXBkYXRlIHZhbHVlDQo+ ICsgKiBiaXQgMzE6IDEgLSB1cGRhdGUsIDAgLSBubyB1cGRhdGUNCj4gKyAqLw0KPiArI2RlZmlu ZSBDTURRX1dGRV9PUFRJT04JCQkoQ01EUV9XRkVfVVBEQVRFIHwgQ01EUV9XRkVfV0FJVCB8IFwN Cj4gKwkJCQkJQ01EUV9XRkVfV0FJVF9WQUxVRSkNCj4gKw0KPiAgLyoqIGNtZHEgZXZlbnQgbWF4 aW11bSAqLw0KPiAgI2RlZmluZSBDTURRX01BWF9FVkVOVAkJCTB4M2ZmDQo+ICANCg0K