From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Laurent Pinchart To: Jose Abreu Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, Andy Yan , Archit Taneja , Fabio Estevam , Heiko Stuebner , Kieran Bingham , Mark Yao , Philipp Zabel , Russell King , Ulrich Hecht , Vladimir Zapolskiy , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 12/22] drm: bridge: dw-hdmi: Abstract the platform PHY configuration Date: Fri, 02 Dec 2016 16:09:34 +0200 Message-ID: <1574414.1AHBzqbLxV@avalon> In-Reply-To: <1658cf45-17e0-58cf-13c9-63e6d78a9725@synopsys.com> References: <1480635817-1258-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1480635817-1258-13-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1658cf45-17e0-58cf-13c9-63e6d78a9725@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-ID: Hi Jose, On Friday 02 Dec 2016 11:15:19 Jose Abreu wrote: > On 01-12-2016 23:43, Laurent Pinchart wrote: > > From: Kieran Bingham > > > > Platforms implement the dw-hdmi with a separate PHY entity. It is > > configured over it's own I2C bus. To allow for different PHY's to be > > configured from the dw-hdmi driver, abstract the actual programming of > > the PHY to its own functions, as configured by the platform. > > > > Signed-off-by: Kieran Bingham > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpu/drm/bridge/dw-hdmi.c | 79 +++++++++++++++--------- > > drivers/gpu/drm/imx/dw_hdmi-imx.c | 2 + > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 + > > include/drm/bridge/dw_hdmi.h | 12 +++++ > > 4 files changed, 63 insertions(+), 31 deletions(-) [snip] > > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > > index e551b457c100..fa7655836c81 100644 > > --- a/include/drm/bridge/dw_hdmi.h > > +++ b/include/drm/bridge/dw_hdmi.h > > @@ -52,6 +52,10 @@ struct dw_hdmi_plat_data { > > const struct dw_hdmi_mpll_config *mpll_cfg; > > const struct dw_hdmi_curr_ctrl *cur_ctr; > > const struct dw_hdmi_phy_config *phy_config; > > + int (*configure_phy)(struct dw_hdmi *hdmi, > > + const struct dw_hdmi_plat_data *pdata, > > + unsigned long mpixelclock, > > + enum dw_hdmi_resolution resolution); > > I think the name of this callback here is a little bit misleading > because you are only configuring the phy pll. Maybe > .configure_phy_pll() would be more suitable. Isn't there more than the PLL ? For instance register TXTERM configures the transmission line termination. > > enum drm_mode_status (*mode_valid)(struct drm_connector *connector, > > > > struct drm_display_mode *mode); > > > > }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 12/22] drm: bridge: dw-hdmi: Abstract the platform PHY configuration Date: Fri, 02 Dec 2016 16:09:34 +0200 Message-ID: <1574414.1AHBzqbLxV@avalon> References: <1480635817-1258-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1480635817-1258-13-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1658cf45-17e0-58cf-13c9-63e6d78a9725@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ABA56E995 for ; Fri, 2 Dec 2016 14:09:18 +0000 (UTC) In-Reply-To: <1658cf45-17e0-58cf-13c9-63e6d78a9725@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jose Abreu Cc: Fabio Estevam , Laurent Pinchart , Ulrich Hecht , Kieran Bingham , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Russell King , Andy Yan , Vladimir Zapolskiy List-Id: dri-devel@lists.freedesktop.org SGkgSm9zZSwKCk9uIEZyaWRheSAwMiBEZWMgMjAxNiAxMToxNToxOSBKb3NlIEFicmV1IHdyb3Rl Ogo+IE9uIDAxLTEyLTIwMTYgMjM6NDMsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBGcm9t OiBLaWVyYW4gQmluZ2hhbSA8a2llcmFuLmJpbmdoYW0rcmVuZXNhc0BpZGVhc29uYm9hcmQuY29t Pgo+ID4gCj4gPiBQbGF0Zm9ybXMgaW1wbGVtZW50IHRoZSBkdy1oZG1pIHdpdGggYSBzZXBhcmF0 ZSBQSFkgZW50aXR5LiBJdCBpcwo+ID4gY29uZmlndXJlZCBvdmVyIGl0J3Mgb3duIEkyQyBidXMu IFRvIGFsbG93IGZvciBkaWZmZXJlbnQgUEhZJ3MgdG8gYmUKPiA+IGNvbmZpZ3VyZWQgZnJvbSB0 aGUgZHctaGRtaSBkcml2ZXIsIGFic3RyYWN0IHRoZSBhY3R1YWwgcHJvZ3JhbW1pbmcgb2YKPiA+ IHRoZSBQSFkgdG8gaXRzIG93biBmdW5jdGlvbnMsIGFzIGNvbmZpZ3VyZWQgYnkgdGhlIHBsYXRm b3JtLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBLaWVyYW4gQmluZ2hhbSA8a2llcmFuLmJpbmdo YW0rcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQ aW5jaGFydAo+ID4gPGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+ ID4gLS0tCj4gPiAKPiA+IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHctaGRtaS5jICAgICAgICAg ICAgfCA3OSArKysrKysrKysrKysrKystLS0tLS0tLS0KPiA+IGRyaXZlcnMvZ3B1L2RybS9pbXgv ZHdfaGRtaS1pbXguYyAgICAgICAgICAgfCAgMiArCj4gPiBkcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvZHdfaGRtaS1yb2NrY2hpcC5jIHwgIDEgKwo+ID4gaW5jbHVkZS9kcm0vYnJpZGdlL2R3X2hk bWkuaCAgICAgICAgICAgICAgICB8IDEyICsrKysrCj4gPiA0IGZpbGVzIGNoYW5nZWQsIDYzIGlu c2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQoKW3NuaXBdCgo+ID4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvZHJtL2JyaWRnZS9kd19oZG1pLmggYi9pbmNsdWRlL2RybS9icmlkZ2UvZHdfaGRtaS5o Cj4gPiBpbmRleCBlNTUxYjQ1N2MxMDAuLmZhNzY1NTgzNmM4MSAxMDA2NDQKPiA+IC0tLSBhL2lu Y2x1ZGUvZHJtL2JyaWRnZS9kd19oZG1pLmgKPiA+ICsrKyBiL2luY2x1ZGUvZHJtL2JyaWRnZS9k d19oZG1pLmgKPiA+IEBAIC01Miw2ICs1MiwxMCBAQCBzdHJ1Y3QgZHdfaGRtaV9wbGF0X2RhdGEg ewo+ID4gIAljb25zdCBzdHJ1Y3QgZHdfaGRtaV9tcGxsX2NvbmZpZyAqbXBsbF9jZmc7Cj4gPiAg CWNvbnN0IHN0cnVjdCBkd19oZG1pX2N1cnJfY3RybCAqY3VyX2N0cjsKPiA+ICAJY29uc3Qgc3Ry dWN0IGR3X2hkbWlfcGh5X2NvbmZpZyAqcGh5X2NvbmZpZzsKPiA+ICsJaW50ICgqY29uZmlndXJl X3BoeSkoc3RydWN0IGR3X2hkbWkgKmhkbWksCj4gPiArCQkJICAgICBjb25zdCBzdHJ1Y3QgZHdf aGRtaV9wbGF0X2RhdGEgKnBkYXRhLAo+ID4gKwkJCSAgICAgdW5zaWduZWQgbG9uZyBtcGl4ZWxj bG9jaywKPiA+ICsJCQkgICAgIGVudW0gZHdfaGRtaV9yZXNvbHV0aW9uIHJlc29sdXRpb24pOwo+ IAo+IEkgdGhpbmsgdGhlIG5hbWUgb2YgdGhpcyBjYWxsYmFjayBoZXJlIGlzIGEgbGl0dGxlIGJp dCBtaXNsZWFkaW5nCj4gYmVjYXVzZSB5b3UgYXJlIG9ubHkgY29uZmlndXJpbmcgdGhlIHBoeSBw bGwuIE1heWJlCj4gLmNvbmZpZ3VyZV9waHlfcGxsKCkgd291bGQgYmUgbW9yZSBzdWl0YWJsZS4K Cklzbid0IHRoZXJlIG1vcmUgdGhhbiB0aGUgUExMID8gRm9yIGluc3RhbmNlIHJlZ2lzdGVyIFRY VEVSTSBjb25maWd1cmVzIHRoZSAKdHJhbnNtaXNzaW9uIGxpbmUgdGVybWluYXRpb24uCgo+ID4g IAllbnVtIGRybV9tb2RlX3N0YXR1cyAoKm1vZGVfdmFsaWQpKHN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uZWN0b3IsCj4gPiAgCQo+ID4gIAkJCQkJICAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUg Km1vZGUpOwo+ID4gIAo+ID4gIH07CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=