From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D14C43215 for ; Fri, 22 Nov 2019 10:39:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 082E72071C for ; Fri, 22 Nov 2019 10:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WfBRHq+t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LQfNUKYH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 082E72071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5iFV8lfKZTBGE1ti7/tkPWPb8/Mv8xjG3WNmCbVc42s=; b=WfBRHq+tyGaUeJ xloEWkjoZuv+/R9KMkDdVHbZdDT59ieiC/eBMEt6iHBeBlSMafOjuNxK3i/F3SIdTUg+87W32I5hy bydwOOvjrWFa7HMOUdaCaXFrkmiPFODiA8gX7bnQQERjeQoGnfQnUR+SCK4nP2Sswb2IOin4T0uGn HOFJjxkEvnBa+AR+Tjik/MN+eZy3suZ/jdb0722nkY0NoyMLqFa9/HJtjedowQtrwJiYxJuLKrg8L pi6T8PE8NIbC7GpXsnT98NeRGGjv1RtIWycFTG9IhFoCDQKR5dqEOIKwXpkXEAkEM4mote7n62LNm 7ddYRVd6/9GnBWJ1+big==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY6LO-00038h-1t; Fri, 22 Nov 2019 10:39:18 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY6LC-0002zE-Od; Fri, 22 Nov 2019 10:39:08 +0000 X-UUID: a950aebb9abc40e3a62bf2ddb35795d8-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ofn5YL5zLXO06e+0l5pAe6Qs84VAqzgdrrkyFWlZp5s=; b=LQfNUKYHNBeXaej6wynzY9sIuVxeXH3y3sJY9xUw/w2ZjaIEJFSJ3m/Gf9mqm2AlRTjviM4RGsm3K7lSHV7ZfmRcFQzgzNtLglqXALTwBo3UnmagSW0IaEVhhV+IAUwfkgFGFTMMSFRALg8IBQUCfI+ASn6qFsjVXRdrmpKu+B0=; X-UUID: a950aebb9abc40e3a62bf2ddb35795d8-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1227959352; Fri, 22 Nov 2019 02:39:03 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 02:29:23 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 18:28:55 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 18:29:23 +0800 Message-ID: <1574418540.11977.19.camel@mtkswgap22> Subject: Re: [PATCH v1 10/12] soc: mediatek: cmdq: add loop function From: Dennis-YC Hsieh To: CK Hu Date: Fri, 22 Nov 2019 18:29:00 +0800 In-Reply-To: <1574415960.19450.23.camel@mtksdaap41> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> <1574415960.19450.23.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_023906_807239_1C6FDC2E X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi CK, On Fri, 2019-11-22 at 17:46 +0800, CK Hu wrote: > Hi, Dennis: > > On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > > Add finalize loop function in cmdq helper functions which loop whole pkt > > in gce hardware thread without cpu operation. > > > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 41 ++++++++++++++++++++++++++++++++ > > include/linux/soc/mediatek/mtk-cmdq.h | 8 +++++++ > > 2 files changed, 49 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index 4235cf8..3b10241 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -385,12 +385,27 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > > } > > EXPORT_SYMBOL(cmdq_pkt_assign); > > > > +static bool cmdq_pkt_finalized(struct cmdq_pkt *pkt) > > +{ > > + struct cmdq_instruction *inst; > > + > > + if (pkt->cmd_buf_size < 2 * CMDQ_INST_SIZE) > > + return false; > > + > > + inst = pkt->va_base + pkt->cmd_buf_size - 2 * CMDQ_INST_SIZE; > > + return inst->op == CMDQ_CODE_EOC; > > +} > > + > > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > > { > > struct cmdq_client *cl = pkt->cl; > > struct cmdq_instruction inst = { {0} }; > > int err; > > > > + /* do not finalize twice */ > > + if (cmdq_pkt_finalized(pkt)) > > + return 0; > > + > > /* insert EOC and generate IRQ for each command iteration */ > > inst.op = CMDQ_CODE_EOC; > > inst.value = CMDQ_EOC_IRQ_EN; > > @@ -406,6 +421,32 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > > return err; > > } > > > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt) > > +{ > > + struct cmdq_client *cl = pkt->cl; > > + struct cmdq_instruction inst = { {0} }; > > + int err; > > + > > + /* do not finalize twice */ > > + if (cmdq_pkt_finalized(pkt)) > > + return 0; > > Why not just export cmdq_pkt_finalize() for user and do not call > cmdq_pkt_finalize() in cmdq_pkt_flush_async(), so you don't need to > check this. > > I would be more like to export API such as cmdq_pkt_eoc(), > cmdq_pkt_jump(), this would provide more flexibility for user to > assemble the command it want. > > Regards, > CK Thanks for your comment. Should we backward compatible with existing clients? Remove finalize in flush will cause existing client flush without IRQ. Regards, Dennis > > > + > > + /* insert EOC and generate IRQ for each command iteration */ > > + inst.op = CMDQ_CODE_EOC; > > + err = cmdq_pkt_append_command(pkt, inst); > > + if (err < 0) > > + return err; > > + > > + /* JUMP abaolute to begin */ > > + inst.op = CMDQ_CODE_JUMP; > > + inst.offset = 1; > > + inst.value = pkt->pa_base >> cmdq_mbox_shift(cl->chan); > > + err = cmdq_pkt_append_command(pkt, inst); > > + > > + return err; > > +} > > +EXPORT_SYMBOL(cmdq_pkt_finalize_loop); > > + > > static void cmdq_pkt_flush_async_cb(struct cmdq_cb_data data) > > { > > struct cmdq_pkt *pkt = (struct cmdq_pkt *)data.data; > > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > > index b3474f2..77e8944 100644 > > --- a/include/linux/soc/mediatek/mtk-cmdq.h > > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > > @@ -203,6 +203,14 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > > int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > > > /** > > + * cmdq_pkt_finalize_loop() - Append EOC and jump command to loop pkt. > > + * @pkt: the CMDQ packet > > + * > > + * Return: 0 for success; else the error code is returned > > + */ > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt); > > + > > +/** > > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > > * packet and call back at the end of done packet > > * @pkt: the CMDQ packet > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 370B2C432C0 for ; Fri, 22 Nov 2019 10:39:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 059B92071F for ; Fri, 22 Nov 2019 10:39:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n3lijE9l"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LQfNUKYH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 059B92071F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JTwZr9J+RRCxLH12QfN3EsBqgWiTDxCBnz7Qg8xD9/0=; b=n3lijE9lI4+rmn o+VGhUVCrBaq76pWgYxakpxdZih02dlMHYDn1M/FCSs4yZPxAWGSeVBM17Re7iPOpEKpvFtbkcwg9 c0gXvSg2G0L0CPtya/xAizahck1VnO/U8jurP7vnMhqmIO1C22KzNlmd5uXJqJ5sbDADz8MRdSeva ufa1PKrp4c9liq2dCmV7/eEHVYSV+y8aoPrqgcjXjPerfRyV8DgwrHhklFTUX7QrevzxYzH1T4bAn JxESPqUJ53FJw4k27u/c65w1QDFIfn0wzXm0jFUmzQCdu58b8jb0Y6ox6EBseV66sOpKkMkQDcXiF ICKKUkFGIq3SIyHmVtdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY6LF-000303-E0; Fri, 22 Nov 2019 10:39:09 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY6LC-0002zE-Od; Fri, 22 Nov 2019 10:39:08 +0000 X-UUID: a950aebb9abc40e3a62bf2ddb35795d8-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ofn5YL5zLXO06e+0l5pAe6Qs84VAqzgdrrkyFWlZp5s=; b=LQfNUKYHNBeXaej6wynzY9sIuVxeXH3y3sJY9xUw/w2ZjaIEJFSJ3m/Gf9mqm2AlRTjviM4RGsm3K7lSHV7ZfmRcFQzgzNtLglqXALTwBo3UnmagSW0IaEVhhV+IAUwfkgFGFTMMSFRALg8IBQUCfI+ASn6qFsjVXRdrmpKu+B0=; X-UUID: a950aebb9abc40e3a62bf2ddb35795d8-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1227959352; Fri, 22 Nov 2019 02:39:03 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 02:29:23 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 18:28:55 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 18:29:23 +0800 Message-ID: <1574418540.11977.19.camel@mtkswgap22> Subject: Re: [PATCH v1 10/12] soc: mediatek: cmdq: add loop function From: Dennis-YC Hsieh To: CK Hu Date: Fri, 22 Nov 2019 18:29:00 +0800 In-Reply-To: <1574415960.19450.23.camel@mtksdaap41> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> <1574415960.19450.23.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_023906_807239_1C6FDC2E X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi CK, On Fri, 2019-11-22 at 17:46 +0800, CK Hu wrote: > Hi, Dennis: > > On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > > Add finalize loop function in cmdq helper functions which loop whole pkt > > in gce hardware thread without cpu operation. > > > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 41 ++++++++++++++++++++++++++++++++ > > include/linux/soc/mediatek/mtk-cmdq.h | 8 +++++++ > > 2 files changed, 49 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index 4235cf8..3b10241 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -385,12 +385,27 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > > } > > EXPORT_SYMBOL(cmdq_pkt_assign); > > > > +static bool cmdq_pkt_finalized(struct cmdq_pkt *pkt) > > +{ > > + struct cmdq_instruction *inst; > > + > > + if (pkt->cmd_buf_size < 2 * CMDQ_INST_SIZE) > > + return false; > > + > > + inst = pkt->va_base + pkt->cmd_buf_size - 2 * CMDQ_INST_SIZE; > > + return inst->op == CMDQ_CODE_EOC; > > +} > > + > > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > > { > > struct cmdq_client *cl = pkt->cl; > > struct cmdq_instruction inst = { {0} }; > > int err; > > > > + /* do not finalize twice */ > > + if (cmdq_pkt_finalized(pkt)) > > + return 0; > > + > > /* insert EOC and generate IRQ for each command iteration */ > > inst.op = CMDQ_CODE_EOC; > > inst.value = CMDQ_EOC_IRQ_EN; > > @@ -406,6 +421,32 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > > return err; > > } > > > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt) > > +{ > > + struct cmdq_client *cl = pkt->cl; > > + struct cmdq_instruction inst = { {0} }; > > + int err; > > + > > + /* do not finalize twice */ > > + if (cmdq_pkt_finalized(pkt)) > > + return 0; > > Why not just export cmdq_pkt_finalize() for user and do not call > cmdq_pkt_finalize() in cmdq_pkt_flush_async(), so you don't need to > check this. > > I would be more like to export API such as cmdq_pkt_eoc(), > cmdq_pkt_jump(), this would provide more flexibility for user to > assemble the command it want. > > Regards, > CK Thanks for your comment. Should we backward compatible with existing clients? Remove finalize in flush will cause existing client flush without IRQ. Regards, Dennis > > > + > > + /* insert EOC and generate IRQ for each command iteration */ > > + inst.op = CMDQ_CODE_EOC; > > + err = cmdq_pkt_append_command(pkt, inst); > > + if (err < 0) > > + return err; > > + > > + /* JUMP abaolute to begin */ > > + inst.op = CMDQ_CODE_JUMP; > > + inst.offset = 1; > > + inst.value = pkt->pa_base >> cmdq_mbox_shift(cl->chan); > > + err = cmdq_pkt_append_command(pkt, inst); > > + > > + return err; > > +} > > +EXPORT_SYMBOL(cmdq_pkt_finalize_loop); > > + > > static void cmdq_pkt_flush_async_cb(struct cmdq_cb_data data) > > { > > struct cmdq_pkt *pkt = (struct cmdq_pkt *)data.data; > > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > > index b3474f2..77e8944 100644 > > --- a/include/linux/soc/mediatek/mtk-cmdq.h > > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > > @@ -203,6 +203,14 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > > int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > > > /** > > + * cmdq_pkt_finalize_loop() - Append EOC and jump command to loop pkt. > > + * @pkt: the CMDQ packet > > + * > > + * Return: 0 for success; else the error code is returned > > + */ > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt); > > + > > +/** > > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > > * packet and call back at the end of done packet > > * @pkt: the CMDQ packet > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F03C432C0 for ; Fri, 22 Nov 2019 10:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B367920714 for ; Fri, 22 Nov 2019 10:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LQfNUKYH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbfKVK3J (ORCPT ); Fri, 22 Nov 2019 05:29:09 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:64361 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726722AbfKVK3J (ORCPT ); Fri, 22 Nov 2019 05:29:09 -0500 X-UUID: bd03a4824b2a405aa53f79f1e975962d-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ofn5YL5zLXO06e+0l5pAe6Qs84VAqzgdrrkyFWlZp5s=; b=LQfNUKYHNBeXaej6wynzY9sIuVxeXH3y3sJY9xUw/w2ZjaIEJFSJ3m/Gf9mqm2AlRTjviM4RGsm3K7lSHV7ZfmRcFQzgzNtLglqXALTwBo3UnmagSW0IaEVhhV+IAUwfkgFGFTMMSFRALg8IBQUCfI+ASn6qFsjVXRdrmpKu+B0=; X-UUID: bd03a4824b2a405aa53f79f1e975962d-20191122 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 2144609166; Fri, 22 Nov 2019 18:29:02 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 18:28:55 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 18:29:23 +0800 Message-ID: <1574418540.11977.19.camel@mtkswgap22> Subject: Re: [PATCH v1 10/12] soc: mediatek: cmdq: add loop function From: Dennis-YC Hsieh To: CK Hu CC: Rob Herring , Matthias Brugger , Jassi Brar , , , , , Bibby Hsieh , Houlong Wei , Date: Fri, 22 Nov 2019 18:29:00 +0800 In-Reply-To: <1574415960.19450.23.camel@mtksdaap41> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> <1574415960.19450.23.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgQ0ssDQoNCk9uIEZyaSwgMjAxOS0xMS0yMiBhdCAxNzo0NiArMDgwMCwgQ0sgSHUgd3JvdGU6 DQo+IEhpLCBEZW5uaXM6DQo+IA0KPiBPbiBUaHUsIDIwMTktMTEtMjEgYXQgMTc6MTIgKzA4MDAs IERlbm5pcyBZQyBIc2llaCB3cm90ZToNCj4gPiBBZGQgZmluYWxpemUgbG9vcCBmdW5jdGlvbiBp biBjbWRxIGhlbHBlciBmdW5jdGlvbnMgd2hpY2ggbG9vcCB3aG9sZSBwa3QNCj4gPiBpbiBnY2Ug aGFyZHdhcmUgdGhyZWFkIHdpdGhvdXQgY3B1IG9wZXJhdGlvbi4NCj4gPiANCj4gPiBTaWduZWQt b2ZmLWJ5OiBEZW5uaXMgWUMgSHNpZWggPGRlbm5pcy15Yy5oc2llaEBtZWRpYXRlay5jb20+DQo+ ID4gLS0tDQo+ID4gIGRyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5jIHwgICA0 MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiA+ICBpbmNsdWRlL2xpbnV4L3Nv Yy9tZWRpYXRlay9tdGstY21kcS5oICB8ICAgIDggKysrKysrKw0KPiA+ICAyIGZpbGVzIGNoYW5n ZWQsIDQ5IGluc2VydGlvbnMoKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2Mv bWVkaWF0ZWsvbXRrLWNtZHEtaGVscGVyLmMgYi9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21k cS1oZWxwZXIuYw0KPiA+IGluZGV4IDQyMzVjZjguLjNiMTAyNDEgMTAwNjQ0DQo+ID4gLS0tIGEv ZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEtaGVscGVyLmMNCj4gPiArKysgYi9kcml2ZXJz L3NvYy9tZWRpYXRlay9tdGstY21kcS1oZWxwZXIuYw0KPiA+IEBAIC0zODUsMTIgKzM4NSwyNyBA QCBpbnQgY21kcV9wa3RfYXNzaWduKHN0cnVjdCBjbWRxX3BrdCAqcGt0LCB1MTYgcmVnX2lkeCwg dTMyIHZhbHVlKQ0KPiA+ICB9DQo+ID4gIEVYUE9SVF9TWU1CT0woY21kcV9wa3RfYXNzaWduKTsN Cj4gPiAgDQo+ID4gK3N0YXRpYyBib29sIGNtZHFfcGt0X2ZpbmFsaXplZChzdHJ1Y3QgY21kcV9w a3QgKnBrdCkNCj4gPiArew0KPiA+ICsJc3RydWN0IGNtZHFfaW5zdHJ1Y3Rpb24gKmluc3Q7DQo+ ID4gKw0KPiA+ICsJaWYgKHBrdC0+Y21kX2J1Zl9zaXplIDwgMiAqIENNRFFfSU5TVF9TSVpFKQ0K PiA+ICsJCXJldHVybiBmYWxzZTsNCj4gPiArDQo+ID4gKwlpbnN0ID0gcGt0LT52YV9iYXNlICsg cGt0LT5jbWRfYnVmX3NpemUgLSAyICogQ01EUV9JTlNUX1NJWkU7DQo+ID4gKwlyZXR1cm4gaW5z dC0+b3AgPT0gQ01EUV9DT0RFX0VPQzsNCj4gPiArfQ0KPiA+ICsNCj4gPiAgc3RhdGljIGludCBj bWRxX3BrdF9maW5hbGl6ZShzdHJ1Y3QgY21kcV9wa3QgKnBrdCkNCj4gPiAgew0KPiA+ICAJc3Ry dWN0IGNtZHFfY2xpZW50ICpjbCA9IHBrdC0+Y2w7DQo+ID4gIAlzdHJ1Y3QgY21kcV9pbnN0cnVj dGlvbiBpbnN0ID0geyB7MH0gfTsNCj4gPiAgCWludCBlcnI7DQo+ID4gIA0KPiA+ICsJLyogZG8g bm90IGZpbmFsaXplIHR3aWNlICovDQo+ID4gKwlpZiAoY21kcV9wa3RfZmluYWxpemVkKHBrdCkp DQo+ID4gKwkJcmV0dXJuIDA7DQo+ID4gKw0KPiA+ICAJLyogaW5zZXJ0IEVPQyBhbmQgZ2VuZXJh dGUgSVJRIGZvciBlYWNoIGNvbW1hbmQgaXRlcmF0aW9uICovDQo+ID4gIAlpbnN0Lm9wID0gQ01E UV9DT0RFX0VPQzsNCj4gPiAgCWluc3QudmFsdWUgPSBDTURRX0VPQ19JUlFfRU47DQo+ID4gQEAg LTQwNiw2ICs0MjEsMzIgQEAgc3RhdGljIGludCBjbWRxX3BrdF9maW5hbGl6ZShzdHJ1Y3QgY21k cV9wa3QgKnBrdCkNCj4gPiAgCXJldHVybiBlcnI7DQo+ID4gIH0NCj4gPiAgDQo+ID4gK2ludCBj bWRxX3BrdF9maW5hbGl6ZV9sb29wKHN0cnVjdCBjbWRxX3BrdCAqcGt0KQ0KPiA+ICt7DQo+ID4g KwlzdHJ1Y3QgY21kcV9jbGllbnQgKmNsID0gcGt0LT5jbDsNCj4gPiArCXN0cnVjdCBjbWRxX2lu c3RydWN0aW9uIGluc3QgPSB7IHswfSB9Ow0KPiA+ICsJaW50IGVycjsNCj4gPiArDQo+ID4gKwkv KiBkbyBub3QgZmluYWxpemUgdHdpY2UgKi8NCj4gPiArCWlmIChjbWRxX3BrdF9maW5hbGl6ZWQo cGt0KSkNCj4gPiArCQlyZXR1cm4gMDsNCj4gDQo+IFdoeSBub3QganVzdCBleHBvcnQgY21kcV9w a3RfZmluYWxpemUoKSBmb3IgdXNlciBhbmQgZG8gbm90IGNhbGwNCj4gY21kcV9wa3RfZmluYWxp emUoKSBpbiBjbWRxX3BrdF9mbHVzaF9hc3luYygpLCBzbyB5b3UgZG9uJ3QgbmVlZCB0bw0KPiBj aGVjayB0aGlzLg0KPiANCj4gSSB3b3VsZCBiZSBtb3JlIGxpa2UgdG8gZXhwb3J0IEFQSSBzdWNo IGFzIGNtZHFfcGt0X2VvYygpLA0KPiBjbWRxX3BrdF9qdW1wKCksIHRoaXMgd291bGQgcHJvdmlk ZSBtb3JlIGZsZXhpYmlsaXR5IGZvciB1c2VyIHRvDQo+IGFzc2VtYmxlIHRoZSBjb21tYW5kIGl0 IHdhbnQuDQo+IA0KPiBSZWdhcmRzLA0KPiBDSw0KDQpUaGFua3MgZm9yIHlvdXIgY29tbWVudC4N Cg0KU2hvdWxkIHdlIGJhY2t3YXJkIGNvbXBhdGlibGUgd2l0aCBleGlzdGluZyBjbGllbnRzPyBS ZW1vdmUgZmluYWxpemUgaW4NCmZsdXNoIHdpbGwgY2F1c2UgZXhpc3RpbmcgY2xpZW50IGZsdXNo IHdpdGhvdXQgSVJRLg0KDQoNClJlZ2FyZHMsDQpEZW5uaXMNCg0KPiANCj4gPiArDQo+ID4gKwkv KiBpbnNlcnQgRU9DIGFuZCBnZW5lcmF0ZSBJUlEgZm9yIGVhY2ggY29tbWFuZCBpdGVyYXRpb24g Ki8NCj4gPiArCWluc3Qub3AgPSBDTURRX0NPREVfRU9DOw0KPiA+ICsJZXJyID0gY21kcV9wa3Rf YXBwZW5kX2NvbW1hbmQocGt0LCBpbnN0KTsNCj4gPiArCWlmIChlcnIgPCAwKQ0KPiA+ICsJCXJl dHVybiBlcnI7DQo+ID4gKw0KPiA+ICsJLyogSlVNUCBhYmFvbHV0ZSB0byBiZWdpbiAqLw0KPiA+ ICsJaW5zdC5vcCA9IENNRFFfQ09ERV9KVU1QOw0KPiA+ICsJaW5zdC5vZmZzZXQgPSAxOw0KPiA+ ICsJaW5zdC52YWx1ZSA9IHBrdC0+cGFfYmFzZSA+PiBjbWRxX21ib3hfc2hpZnQoY2wtPmNoYW4p Ow0KPiA+ICsJZXJyID0gY21kcV9wa3RfYXBwZW5kX2NvbW1hbmQocGt0LCBpbnN0KTsNCj4gPiAr DQo+ID4gKwlyZXR1cm4gZXJyOw0KPiA+ICt9DQo+ID4gK0VYUE9SVF9TWU1CT0woY21kcV9wa3Rf ZmluYWxpemVfbG9vcCk7DQo+ID4gKw0KPiA+ICBzdGF0aWMgdm9pZCBjbWRxX3BrdF9mbHVzaF9h c3luY19jYihzdHJ1Y3QgY21kcV9jYl9kYXRhIGRhdGEpDQo+ID4gIHsNCj4gPiAgCXN0cnVjdCBj bWRxX3BrdCAqcGt0ID0gKHN0cnVjdCBjbWRxX3BrdCAqKWRhdGEuZGF0YTsNCj4gPiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS9saW51eC9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEuaCBiL2luY2x1ZGUvbGlu dXgvc29jL21lZGlhdGVrL210ay1jbWRxLmgNCj4gPiBpbmRleCBiMzQ3NGYyLi43N2U4OTQ0IDEw MDY0NA0KPiA+IC0tLSBhL2luY2x1ZGUvbGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmgNCj4g PiArKysgYi9pbmNsdWRlL2xpbnV4L3NvYy9tZWRpYXRlay9tdGstY21kcS5oDQo+ID4gQEAgLTIw Myw2ICsyMDMsMTQgQEAgaW50IGNtZHFfcGt0X3BvbGxfbWFzayhzdHJ1Y3QgY21kcV9wa3QgKnBr dCwgdTggc3Vic3lzLA0KPiA+ICBpbnQgY21kcV9wa3RfYXNzaWduKHN0cnVjdCBjbWRxX3BrdCAq cGt0LCB1MTYgcmVnX2lkeCwgdTMyIHZhbHVlKTsNCj4gPiAgDQo+ID4gIC8qKg0KPiA+ICsgKiBj bWRxX3BrdF9maW5hbGl6ZV9sb29wKCkgLSBBcHBlbmQgRU9DIGFuZCBqdW1wIGNvbW1hbmQgdG8g bG9vcCBwa3QuDQo+ID4gKyAqIEBwa3Q6CXRoZSBDTURRIHBhY2tldA0KPiA+ICsgKg0KPiA+ICsg KiBSZXR1cm46IDAgZm9yIHN1Y2Nlc3M7IGVsc2UgdGhlIGVycm9yIGNvZGUgaXMgcmV0dXJuZWQN Cj4gPiArICovDQo+ID4gK2ludCBjbWRxX3BrdF9maW5hbGl6ZV9sb29wKHN0cnVjdCBjbWRxX3Br dCAqcGt0KTsNCj4gPiArDQo+ID4gKy8qKg0KPiA+ICAgKiBjbWRxX3BrdF9mbHVzaF9hc3luYygp IC0gdHJpZ2dlciBDTURRIHRvIGFzeW5jaHJvbm91c2x5IGV4ZWN1dGUgdGhlIENNRFENCj4gPiAg ICogICAgICAgICAgICAgICAgICAgICAgICAgIHBhY2tldCBhbmQgY2FsbCBiYWNrIGF0IHRoZSBl bmQgb2YgZG9uZSBwYWNrZXQNCj4gPiAgICogQHBrdDoJdGhlIENNRFEgcGFja2V0DQo+IA0KPiAN Cg0K