From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF6AC432C0 for ; Wed, 27 Nov 2019 06:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E94BB20674 for ; Wed, 27 Nov 2019 06:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574837338; bh=hfFnGdEYySdgTYb7Ksr/Q/zt8gpeE5gOIN2aXy6/j60=; h=Subject:To:From:Date:List-ID:From; b=x7smiHEKyZ2Ez8yiqm2MznNHAtEaxyIXCMeKu77qP0ynhMSr+EIAVH7oGxkKAgZOz ySwv+9yuit/08++21p3WTwWxVCR4BGXEyui6RPrsZL2uqa5M+M6qE/SN5xCsiKni1e l1fU0T7SYeF/IGHOeYwHZnqhWIW9rQhApsvom3kY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726136AbfK0Gs5 (ORCPT ); Wed, 27 Nov 2019 01:48:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:44934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbfK0Gs5 (ORCPT ); Wed, 27 Nov 2019 01:48:57 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C29C20665; Wed, 27 Nov 2019 06:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574837336; bh=hfFnGdEYySdgTYb7Ksr/Q/zt8gpeE5gOIN2aXy6/j60=; h=Subject:To:From:Date:From; b=h7IIgXjo6JxlJQf+gjmIOIQgJmC1g2YBBUqELyinEkjr8NM35KXW6Wu4a3ETDxrU3 3TYhRY42tlCLh1to1C1OLMxaVyajddCZZ1tiZvN25ZcAS1zzRunDkyQCLbDWxYU7jI YJFI7kZeurtbhTaMxhdeTuNoRshagKJ/4J4Z1Jzg= Subject: patch "vcs: prevent write access to vcsu devices" added to tty-testing To: nico@fluxnic.net, gregkh@linuxfoundation.org, jslaby@suse.com, npitre@baylibre.com, orcohen@paloaltonetworks.com, stable@vger.kernel.org From: Date: Wed, 27 Nov 2019 07:48:54 +0100 Message-ID: <15748373348144@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is a note to let you know that I've just added the patch titled vcs: prevent write access to vcsu devices to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the tty-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 0c9acb1af77a3cb8707e43f45b72c95266903cee Mon Sep 17 00:00:00 2001 From: Nicolas Pitre Date: Tue, 5 Nov 2019 10:33:16 +0100 Subject: vcs: prevent write access to vcsu devices Commit d21b0be246bf ("vt: introduce unicode mode for /dev/vcs") guarded against using devices containing attributes as this is not yet implemented. It however failed to guard against writes to any devices as this is also unimplemented. Reported-by: Or Cohen Signed-off-by: Nicolas Pitre Cc: # v4.19+ Cc: Jiri Slaby Fixes: d21b0be246bf ("vt: introduce unicode mode for /dev/vcs") Link: https://lore.kernel.org/r/nycvar.YSQ.7.76.1911051030580.30289@knanqh.ubzr Signed-off-by: Greg Kroah-Hartman --- drivers/tty/vt/vc_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/vt/vc_screen.c b/drivers/tty/vt/vc_screen.c index 1f042346e722..778f83ea2249 100644 --- a/drivers/tty/vt/vc_screen.c +++ b/drivers/tty/vt/vc_screen.c @@ -456,6 +456,9 @@ vcs_write(struct file *file, const char __user *buf, size_t count, loff_t *ppos) size_t ret; char *con_buf; + if (use_unicode(inode)) + return -EOPNOTSUPP; + con_buf = (char *) __get_free_page(GFP_KERNEL); if (!con_buf) return -ENOMEM; -- 2.24.0