All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] acct02: relax ac_btime checks
Date: Tue, 12 Nov 2019 07:52:37 -0500 (EST)	[thread overview]
Message-ID: <1574856631.11670519.1573563157342.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20191112123744.GA760@dell5510>



----- Original Message -----
> Hi Jan,
> 
> > ac_btime is calculated back from current time and isn't accurate.
> > Problems include nanoseconds accumulation (lags behind gettimeofday),
> > suspend/resume isn't taken into account and any adjtime() (like DST
> > change) will cause ac_btime to jump as well.
> 
> > Relax the condition to ~2h around gettimeofday value at start of
> > the test. That should be enough to cover usual DST time jumps.
> 
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Tested-by: Petr Vorel <pvorel@suse.cz>
> on both 390x and intel.
> 
> LGTM, although on in intel I got quite a lot of entries:
> 
> acct02.c:202: INFO: Number of accounting file entries tested: 159

That could be normal if there was something running in the background.
Do you have full output? What was the ac_comm string in those entries?


  reply	other threads:[~2019-11-12 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  9:15 [LTP] [PATCH] acct02: relax ac_btime checks Jan Stancek
2019-11-12 12:37 ` Petr Vorel
2019-11-12 12:52   ` Jan Stancek [this message]
2019-11-12 13:30     ` Petr Vorel
2019-11-13  9:25 ` Cyril Hrubis
2019-11-13 20:08   ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1574856631.11670519.1573563157342.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.