From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F4AC43215 for ; Mon, 2 Dec 2019 06:17:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5597220833 for ; Mon, 2 Dec 2019 06:17:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pYotT1Nu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="ooyr+wvN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5597220833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9tGwYsiW0pQBMes/j2yhhuwMMpeJdMg5+yiV0dyjmIQ=; b=pYotT1NuLGpHdX qfOyvaSkSWAiaxSe4uD4AZFL5TE2j4+goLKgOkNIr0+9mdoyCVulsClFwAK4h8YZrbSJ5j2NXr22R LCCvDFjdXcMiwY2tnZlwqmer2q/cegaSnAiJjCK3zB/E58HVDG8mOIhWB0quwA1XqYXCQ+vYuwWXw DL9ceWZZwZs0pmwdbcYU4yKRajiLcfJMhoT+NKT8Mqpck+prVTDa3I4GnLfX6eP0TZWKo8unMMeCq 4NPJ96Z+K2M1KwPRb8az4We0Uw/xxC8iMGuAf9LwjmCvO/qIzNkWWtyrEPN9MkZP9gNy9tp+bAA9A 2AF8ru1xxtbXLd9PT2fg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibf1Y-0007Ex-Tb; Mon, 02 Dec 2019 06:17:32 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibf1R-00077d-Ec; Mon, 02 Dec 2019 06:17:26 +0000 X-UUID: eeacded1eedf4a4dbefe19808dbcf50a-20191201 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=1hVDXQnEXhl488d24pN92x7M9sMocqCpXtujHufwujQ=; b=ooyr+wvN/CzaisrsNJylXVzjAIEBxbERIjGlZFXs3PQSGD6omi/ffFnUUpG5neWtC+6adlVo584rAScqbQPgjzXshoUDXIDiYJ0OJDDSwiScpJfiZnFr6IASIO6eV6E5pRw01Lh32bWmSkvM/lDgEuBy6h4XDlQwvGP/8b1u+/I=; X-UUID: eeacded1eedf4a4dbefe19808dbcf50a-20191201 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 202567880; Sun, 01 Dec 2019 22:16:59 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 1 Dec 2019 22:08:01 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 14:07:07 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 2 Dec 2019 14:07:03 +0800 Message-ID: <1575266838.26513.0.camel@mtksdaap41> Subject: Re: [PATCH v1 2/6] drm/mediatek: use DRM core's atomic commit helper From: CK Hu To: Bibby Hsieh Date: Mon, 2 Dec 2019 14:07:18 +0800 In-Reply-To: <20191128024238.9399-3-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-3-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191201_221725_501348_9E8C9476 X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > The DRM core atomic helper now supports asynchronous commits natively. > The custom drm implementation isn't needed anymore, remove it. Reviewed-by: CK Hu Regards, CK > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++------------------------ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7 --- > 2 files changed, 5 insertions(+), 88 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 6588dc6dd5e3..16e5771d182e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -36,89 +36,14 @@ > #define DRIVER_MAJOR 1 > #define DRIVER_MINOR 0 > > -static void mtk_atomic_schedule(struct mtk_drm_private *private, > - struct drm_atomic_state *state) > -{ > - private->commit.state = state; > - schedule_work(&private->commit.work); > -} > - > -static void mtk_atomic_complete(struct mtk_drm_private *private, > - struct drm_atomic_state *state) > -{ > - struct drm_device *drm = private->drm; > - > - drm_atomic_helper_wait_for_fences(drm, state, false); > - > - /* > - * Mediatek drm supports runtime PM, so plane registers cannot be > - * written when their crtc is disabled. > - * > - * The comment for drm_atomic_helper_commit states: > - * For drivers supporting runtime PM the recommended sequence is > - * > - * drm_atomic_helper_commit_modeset_disables(dev, state); > - * drm_atomic_helper_commit_modeset_enables(dev, state); > - * drm_atomic_helper_commit_planes(dev, state, > - * DRM_PLANE_COMMIT_ACTIVE_ONLY); > - * > - * See the kerneldoc entries for these three functions for more details. > - */ > - drm_atomic_helper_commit_modeset_disables(drm, state); > - drm_atomic_helper_commit_modeset_enables(drm, state); > - drm_atomic_helper_commit_planes(drm, state, > - DRM_PLANE_COMMIT_ACTIVE_ONLY); > - > - drm_atomic_helper_wait_for_vblanks(drm, state); > - > - drm_atomic_helper_cleanup_planes(drm, state); > - drm_atomic_state_put(state); > -} > - > -static void mtk_atomic_work(struct work_struct *work) > -{ > - struct mtk_drm_private *private = container_of(work, > - struct mtk_drm_private, commit.work); > - > - mtk_atomic_complete(private, private->commit.state); > -} > - > -static int mtk_atomic_commit(struct drm_device *drm, > - struct drm_atomic_state *state, > - bool async) > -{ > - struct mtk_drm_private *private = drm->dev_private; > - int ret; > - > - ret = drm_atomic_helper_prepare_planes(drm, state); > - if (ret) > - return ret; > - > - mutex_lock(&private->commit.lock); > - flush_work(&private->commit.work); > - > - ret = drm_atomic_helper_swap_state(state, true); > - if (ret) { > - mutex_unlock(&private->commit.lock); > - drm_atomic_helper_cleanup_planes(drm, state); > - return ret; > - } > - > - drm_atomic_state_get(state); > - if (async) > - mtk_atomic_schedule(private, state); > - else > - mtk_atomic_complete(private, state); > - > - mutex_unlock(&private->commit.lock); > - > - return 0; > -} > +static const struct drm_mode_config_helper_funcs mtk_drm_mode_config_helpers = { > + .atomic_commit_tail = drm_atomic_helper_commit_tail_rpm, > +}; > > static const struct drm_mode_config_funcs mtk_drm_mode_config_funcs = { > .fb_create = mtk_drm_mode_fb_create, > .atomic_check = drm_atomic_helper_check, > - .atomic_commit = mtk_atomic_commit, > + .atomic_commit = drm_atomic_helper_commit, > }; > > static const enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = { > @@ -265,6 +190,7 @@ static int mtk_drm_kms_init(struct drm_device *drm) > drm->mode_config.max_width = 4096; > drm->mode_config.max_height = 4096; > drm->mode_config.funcs = &mtk_drm_mode_config_funcs; > + drm->mode_config.helper_private = &mtk_drm_mode_config_helpers; > > ret = component_bind_all(drm->dev, drm); > if (ret) > @@ -540,8 +466,6 @@ static int mtk_drm_probe(struct platform_device *pdev) > if (!private) > return -ENOMEM; > > - mutex_init(&private->commit.lock); > - INIT_WORK(&private->commit.work, mtk_atomic_work); > private->data = of_device_get_match_data(dev); > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > index b6a82728d563..9f4ce60174f6 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > @@ -46,13 +46,6 @@ struct mtk_drm_private { > struct device_node *comp_node[DDP_COMPONENT_ID_MAX]; > struct mtk_ddp_comp *ddp_comp[DDP_COMPONENT_ID_MAX]; > const struct mtk_mmsys_driver_data *data; > - > - struct { > - struct drm_atomic_state *state; > - struct work_struct work; > - struct mutex lock; > - } commit; > - > struct drm_atomic_state *suspend_state; > > bool dma_parms_allocated; _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790A5C432C0 for ; Mon, 2 Dec 2019 06:17:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4382120833 for ; Mon, 2 Dec 2019 06:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WwYp8oyd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="ooyr+wvN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4382120833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cXfgqBGjAxTYBQTuyVUFaqsP8iQv+737BskD+QgUfts=; b=WwYp8oydwyHY+o RvyCKZifv6mMlCX9Okdc/eDoAg5yRA6YbaURLnpTjsDGdSBnHTShp+PBlCqo0Wbi+XqQTuCX5JemY h28Xf8+7lXsxIrnVDxqslcK7E8IG/y8BhiaplDp6YSdr19clayqMxgQhOvwDI7yahjDNTWnR9xBi6 Wz4C8S/VIyaumUAoV3hJfsOjD6tPG7HgBziplNiHBbmPuMpHqPQXUzSjavijtwmWE5HEjGrG6EYZV QpjWPFR42sVbDYRtwRMf8sDQfiJ4I+uIQsBOtHMFU/XVSHSkfevB0J3WSj95XS+zhMNLSq91VYPyj 2x5T9+v9m4x3izn6mX1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibf1U-000789-HS; Mon, 02 Dec 2019 06:17:28 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibf1R-00077d-Ec; Mon, 02 Dec 2019 06:17:26 +0000 X-UUID: eeacded1eedf4a4dbefe19808dbcf50a-20191201 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=1hVDXQnEXhl488d24pN92x7M9sMocqCpXtujHufwujQ=; b=ooyr+wvN/CzaisrsNJylXVzjAIEBxbERIjGlZFXs3PQSGD6omi/ffFnUUpG5neWtC+6adlVo584rAScqbQPgjzXshoUDXIDiYJ0OJDDSwiScpJfiZnFr6IASIO6eV6E5pRw01Lh32bWmSkvM/lDgEuBy6h4XDlQwvGP/8b1u+/I=; X-UUID: eeacded1eedf4a4dbefe19808dbcf50a-20191201 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 202567880; Sun, 01 Dec 2019 22:16:59 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 1 Dec 2019 22:08:01 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 14:07:07 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 2 Dec 2019 14:07:03 +0800 Message-ID: <1575266838.26513.0.camel@mtksdaap41> Subject: Re: [PATCH v1 2/6] drm/mediatek: use DRM core's atomic commit helper From: CK Hu To: Bibby Hsieh Date: Mon, 2 Dec 2019 14:07:18 +0800 In-Reply-To: <20191128024238.9399-3-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-3-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191201_221725_501348_9E8C9476 X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, YT Shen , Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > The DRM core atomic helper now supports asynchronous commits natively. > The custom drm implementation isn't needed anymore, remove it. Reviewed-by: CK Hu Regards, CK > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++------------------------ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7 --- > 2 files changed, 5 insertions(+), 88 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 6588dc6dd5e3..16e5771d182e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -36,89 +36,14 @@ > #define DRIVER_MAJOR 1 > #define DRIVER_MINOR 0 > > -static void mtk_atomic_schedule(struct mtk_drm_private *private, > - struct drm_atomic_state *state) > -{ > - private->commit.state = state; > - schedule_work(&private->commit.work); > -} > - > -static void mtk_atomic_complete(struct mtk_drm_private *private, > - struct drm_atomic_state *state) > -{ > - struct drm_device *drm = private->drm; > - > - drm_atomic_helper_wait_for_fences(drm, state, false); > - > - /* > - * Mediatek drm supports runtime PM, so plane registers cannot be > - * written when their crtc is disabled. > - * > - * The comment for drm_atomic_helper_commit states: > - * For drivers supporting runtime PM the recommended sequence is > - * > - * drm_atomic_helper_commit_modeset_disables(dev, state); > - * drm_atomic_helper_commit_modeset_enables(dev, state); > - * drm_atomic_helper_commit_planes(dev, state, > - * DRM_PLANE_COMMIT_ACTIVE_ONLY); > - * > - * See the kerneldoc entries for these three functions for more details. > - */ > - drm_atomic_helper_commit_modeset_disables(drm, state); > - drm_atomic_helper_commit_modeset_enables(drm, state); > - drm_atomic_helper_commit_planes(drm, state, > - DRM_PLANE_COMMIT_ACTIVE_ONLY); > - > - drm_atomic_helper_wait_for_vblanks(drm, state); > - > - drm_atomic_helper_cleanup_planes(drm, state); > - drm_atomic_state_put(state); > -} > - > -static void mtk_atomic_work(struct work_struct *work) > -{ > - struct mtk_drm_private *private = container_of(work, > - struct mtk_drm_private, commit.work); > - > - mtk_atomic_complete(private, private->commit.state); > -} > - > -static int mtk_atomic_commit(struct drm_device *drm, > - struct drm_atomic_state *state, > - bool async) > -{ > - struct mtk_drm_private *private = drm->dev_private; > - int ret; > - > - ret = drm_atomic_helper_prepare_planes(drm, state); > - if (ret) > - return ret; > - > - mutex_lock(&private->commit.lock); > - flush_work(&private->commit.work); > - > - ret = drm_atomic_helper_swap_state(state, true); > - if (ret) { > - mutex_unlock(&private->commit.lock); > - drm_atomic_helper_cleanup_planes(drm, state); > - return ret; > - } > - > - drm_atomic_state_get(state); > - if (async) > - mtk_atomic_schedule(private, state); > - else > - mtk_atomic_complete(private, state); > - > - mutex_unlock(&private->commit.lock); > - > - return 0; > -} > +static const struct drm_mode_config_helper_funcs mtk_drm_mode_config_helpers = { > + .atomic_commit_tail = drm_atomic_helper_commit_tail_rpm, > +}; > > static const struct drm_mode_config_funcs mtk_drm_mode_config_funcs = { > .fb_create = mtk_drm_mode_fb_create, > .atomic_check = drm_atomic_helper_check, > - .atomic_commit = mtk_atomic_commit, > + .atomic_commit = drm_atomic_helper_commit, > }; > > static const enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = { > @@ -265,6 +190,7 @@ static int mtk_drm_kms_init(struct drm_device *drm) > drm->mode_config.max_width = 4096; > drm->mode_config.max_height = 4096; > drm->mode_config.funcs = &mtk_drm_mode_config_funcs; > + drm->mode_config.helper_private = &mtk_drm_mode_config_helpers; > > ret = component_bind_all(drm->dev, drm); > if (ret) > @@ -540,8 +466,6 @@ static int mtk_drm_probe(struct platform_device *pdev) > if (!private) > return -ENOMEM; > > - mutex_init(&private->commit.lock); > - INIT_WORK(&private->commit.work, mtk_atomic_work); > private->data = of_device_get_match_data(dev); > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > index b6a82728d563..9f4ce60174f6 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > @@ -46,13 +46,6 @@ struct mtk_drm_private { > struct device_node *comp_node[DDP_COMPONENT_ID_MAX]; > struct mtk_ddp_comp *ddp_comp[DDP_COMPONENT_ID_MAX]; > const struct mtk_mmsys_driver_data *data; > - > - struct { > - struct drm_atomic_state *state; > - struct work_struct work; > - struct mutex lock; > - } commit; > - > struct drm_atomic_state *suspend_state; > > bool dma_parms_allocated; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v1 2/6] drm/mediatek: use DRM core's atomic commit helper Date: Mon, 2 Dec 2019 14:07:18 +0800 Message-ID: <1575266838.26513.0.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-3-bibby.hsieh@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A5B789F3C for ; Mon, 2 Dec 2019 06:07:25 +0000 (UTC) In-Reply-To: <20191128024238.9399-3-bibby.hsieh@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bibby Hsieh Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGksIEJpYmJ5Og0KDQpPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBUaGUgRFJNIGNvcmUgYXRvbWljIGhlbHBlciBub3cgc3VwcG9ydHMgYXN5 bmNocm9ub3VzIGNvbW1pdHMgbmF0aXZlbHkuDQo+IFRoZSBjdXN0b20gZHJtIGltcGxlbWVudGF0 aW9uIGlzbid0IG5lZWRlZCBhbnltb3JlLCByZW1vdmUgaXQuDQoNClJldmlld2VkLWJ5OiBDSyBI dSA8Y2suaHVAbWVkaWF0ZWsuY29tPg0KDQpSZWdhcmRzLA0KQ0sNCg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4NCj4gLS0tDQo+ICBk cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyB8IDg2ICsrLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuaCB8 ICA3IC0tLQ0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDg4IGRlbGV0aW9u cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMNCj4gaW5kZXgg NjU4OGRjNmRkNWUzLi4xNmU1NzcxZDE4MmUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRl ay9tdGtfZHJtX2Rydi5jDQo+IEBAIC0zNiw4OSArMzYsMTQgQEANCj4gICNkZWZpbmUgRFJJVkVS X01BSk9SIDENCj4gICNkZWZpbmUgRFJJVkVSX01JTk9SIDANCj4gIA0KPiAtc3RhdGljIHZvaWQg bXRrX2F0b21pY19zY2hlZHVsZShzdHJ1Y3QgbXRrX2RybV9wcml2YXRlICpwcml2YXRlLA0KPiAt CQkJCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkNCj4gLXsNCj4gLQlwcml2YXRlLT5j b21taXQuc3RhdGUgPSBzdGF0ZTsNCj4gLQlzY2hlZHVsZV93b3JrKCZwcml2YXRlLT5jb21taXQu d29yayk7DQo+IC19DQo+IC0NCj4gLXN0YXRpYyB2b2lkIG10a19hdG9taWNfY29tcGxldGUoc3Ry dWN0IG10a19kcm1fcHJpdmF0ZSAqcHJpdmF0ZSwNCj4gLQkJCQlzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUpDQo+IC17DQo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRybSA9IHByaXZhdGUt PmRybTsNCj4gLQ0KPiAtCWRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZlbmNlcyhkcm0sIHN0 YXRlLCBmYWxzZSk7DQo+IC0NCj4gLQkvKg0KPiAtCSAqIE1lZGlhdGVrIGRybSBzdXBwb3J0cyBy dW50aW1lIFBNLCBzbyBwbGFuZSByZWdpc3RlcnMgY2Fubm90IGJlDQo+IC0JICogd3JpdHRlbiB3 aGVuIHRoZWlyIGNydGMgaXMgZGlzYWJsZWQuDQo+IC0JICoNCj4gLQkgKiBUaGUgY29tbWVudCBm b3IgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0IHN0YXRlczoNCj4gLQkgKiAgICAgRm9yIGRyaXZl cnMgc3VwcG9ydGluZyBydW50aW1lIFBNIHRoZSByZWNvbW1lbmRlZCBzZXF1ZW5jZSBpcw0KPiAt CSAqDQo+IC0JICogICAgIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVz KGRldiwgc3RhdGUpOw0KPiAtCSAqICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNl dF9lbmFibGVzKGRldiwgc3RhdGUpOw0KPiAtCSAqICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21t aXRfcGxhbmVzKGRldiwgc3RhdGUsDQo+IC0JICogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgRFJNX1BMQU5FX0NPTU1JVF9BQ1RJVkVfT05MWSk7DQo+IC0JICoNCj4gLQkgKiBT ZWUgdGhlIGtlcm5lbGRvYyBlbnRyaWVzIGZvciB0aGVzZSB0aHJlZSBmdW5jdGlvbnMgZm9yIG1v cmUgZGV0YWlscy4NCj4gLQkgKi8NCj4gLQlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNl dF9kaXNhYmxlcyhkcm0sIHN0YXRlKTsNCj4gLQlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9k ZXNldF9lbmFibGVzKGRybSwgc3RhdGUpOw0KPiAtCWRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9w bGFuZXMoZHJtLCBzdGF0ZSwNCj4gLQkJCQkJRFJNX1BMQU5FX0NPTU1JVF9BQ1RJVkVfT05MWSk7 DQo+IC0NCj4gLQlkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl92YmxhbmtzKGRybSwgc3RhdGUp Ow0KPiAtDQo+IC0JZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoZHJtLCBzdGF0ZSk7 DQo+IC0JZHJtX2F0b21pY19zdGF0ZV9wdXQoc3RhdGUpOw0KPiAtfQ0KPiAtDQo+IC1zdGF0aWMg dm9pZCBtdGtfYXRvbWljX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KPiAtew0KPiAt CXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUgKnByaXZhdGUgPSBjb250YWluZXJfb2Yod29yaywNCj4g LQkJCXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUsIGNvbW1pdC53b3JrKTsNCj4gLQ0KPiAtCW10a19h dG9taWNfY29tcGxldGUocHJpdmF0ZSwgcHJpdmF0ZS0+Y29tbWl0LnN0YXRlKTsNCj4gLX0NCj4g LQ0KPiAtc3RhdGljIGludCBtdGtfYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJt LA0KPiAtCQkJICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsDQo+IC0JCQkgICAg IGJvb2wgYXN5bmMpDQo+IC17DQo+IC0Jc3RydWN0IG10a19kcm1fcHJpdmF0ZSAqcHJpdmF0ZSA9 IGRybS0+ZGV2X3ByaXZhdGU7DQo+IC0JaW50IHJldDsNCj4gLQ0KPiAtCXJldCA9IGRybV9hdG9t aWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzKGRybSwgc3RhdGUpOw0KPiAtCWlmIChyZXQpDQo+IC0J CXJldHVybiByZXQ7DQo+IC0NCj4gLQltdXRleF9sb2NrKCZwcml2YXRlLT5jb21taXQubG9jayk7 DQo+IC0JZmx1c2hfd29yaygmcHJpdmF0ZS0+Y29tbWl0LndvcmspOw0KPiAtDQo+IC0JcmV0ID0g ZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdGF0ZSwgdHJ1ZSk7DQo+IC0JaWYgKHJldCkg ew0KPiAtCQltdXRleF91bmxvY2soJnByaXZhdGUtPmNvbW1pdC5sb2NrKTsNCj4gLQkJZHJtX2F0 b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoZHJtLCBzdGF0ZSk7DQo+IC0JCXJldHVybiByZXQ7 DQo+IC0JfQ0KPiAtDQo+IC0JZHJtX2F0b21pY19zdGF0ZV9nZXQoc3RhdGUpOw0KPiAtCWlmIChh c3luYykNCj4gLQkJbXRrX2F0b21pY19zY2hlZHVsZShwcml2YXRlLCBzdGF0ZSk7DQo+IC0JZWxz ZQ0KPiAtCQltdGtfYXRvbWljX2NvbXBsZXRlKHByaXZhdGUsIHN0YXRlKTsNCj4gLQ0KPiAtCW11 dGV4X3VubG9jaygmcHJpdmF0ZS0+Y29tbWl0LmxvY2spOw0KPiAtDQo+IC0JcmV0dXJuIDA7DQo+ IC19DQo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfZnVuY3Mg bXRrX2RybV9tb2RlX2NvbmZpZ19oZWxwZXJzID0gew0KPiArCS5hdG9taWNfY29tbWl0X3RhaWwg PSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfdGFpbF9ycG0sDQo+ICt9Ow0KPiAgDQo+ICBzdGF0 aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBtdGtfZHJtX21vZGVfY29uZmln X2Z1bmNzID0gew0KPiAgCS5mYl9jcmVhdGUgPSBtdGtfZHJtX21vZGVfZmJfY3JlYXRlLA0KPiAg CS5hdG9taWNfY2hlY2sgPSBkcm1fYXRvbWljX2hlbHBlcl9jaGVjaywNCj4gLQkuYXRvbWljX2Nv bW1pdCA9IG10a19hdG9taWNfY29tbWl0LA0KPiArCS5hdG9taWNfY29tbWl0ID0gZHJtX2F0b21p Y19oZWxwZXJfY29tbWl0LA0KPiAgfTsNCj4gIA0KPiAgc3RhdGljIGNvbnN0IGVudW0gbXRrX2Rk cF9jb21wX2lkIG10MjcwMV9tdGtfZGRwX21haW5bXSA9IHsNCj4gQEAgLTI2NSw2ICsxOTAsNyBA QCBzdGF0aWMgaW50IG10a19kcm1fa21zX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRybSkNCj4g IAlkcm0tPm1vZGVfY29uZmlnLm1heF93aWR0aCA9IDQwOTY7DQo+ICAJZHJtLT5tb2RlX2NvbmZp Zy5tYXhfaGVpZ2h0ID0gNDA5NjsNCj4gIAlkcm0tPm1vZGVfY29uZmlnLmZ1bmNzID0gJm10a19k cm1fbW9kZV9jb25maWdfZnVuY3M7DQo+ICsJZHJtLT5tb2RlX2NvbmZpZy5oZWxwZXJfcHJpdmF0 ZSA9ICZtdGtfZHJtX21vZGVfY29uZmlnX2hlbHBlcnM7DQo+ICANCj4gIAlyZXQgPSBjb21wb25l bnRfYmluZF9hbGwoZHJtLT5kZXYsIGRybSk7DQo+ICAJaWYgKHJldCkNCj4gQEAgLTU0MCw4ICs0 NjYsNiBAQCBzdGF0aWMgaW50IG10a19kcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikNCj4gIAlpZiAoIXByaXZhdGUpDQo+ICAJCXJldHVybiAtRU5PTUVNOw0KPiAgDQo+IC0J bXV0ZXhfaW5pdCgmcHJpdmF0ZS0+Y29tbWl0LmxvY2spOw0KPiAtCUlOSVRfV09SSygmcHJpdmF0 ZS0+Y29tbWl0LndvcmssIG10a19hdG9taWNfd29yayk7DQo+ICAJcHJpdmF0ZS0+ZGF0YSA9IG9m X2RldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYpOw0KPiAgDQo+ICAJbWVtID0gcGxhdGZvcm1fZ2V0 X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsNCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kcm1fZHJ2LmgNCj4gaW5kZXggYjZhODI3MjhkNTYzLi45ZjRjZTYwMTc0ZjYgMTAw NjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oDQo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oDQo+IEBAIC00NiwxMyAr NDYsNiBAQCBzdHJ1Y3QgbXRrX2RybV9wcml2YXRlIHsNCj4gIAlzdHJ1Y3QgZGV2aWNlX25vZGUg KmNvbXBfbm9kZVtERFBfQ09NUE9ORU5UX0lEX01BWF07DQo+ICAJc3RydWN0IG10a19kZHBfY29t cCAqZGRwX2NvbXBbRERQX0NPTVBPTkVOVF9JRF9NQVhdOw0KPiAgCWNvbnN0IHN0cnVjdCBtdGtf bW1zeXNfZHJpdmVyX2RhdGEgKmRhdGE7DQo+IC0NCj4gLQlzdHJ1Y3Qgew0KPiAtCQlzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7DQo+IC0JCXN0cnVjdCB3b3JrX3N0cnVjdCB3b3JrOw0K PiAtCQlzdHJ1Y3QgbXV0ZXggbG9jazsNCj4gLQl9IGNvbW1pdDsNCj4gLQ0KPiAgCXN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdXNwZW5kX3N0YXRlOw0KPiAgDQo+ICAJYm9vbCBkbWFfcGFybXNf YWxsb2NhdGVkOw0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F097C432C0 for ; Mon, 2 Dec 2019 06:07:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53D9B20705 for ; Mon, 2 Dec 2019 06:07:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="ooyr+wvN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726079AbfLBGH0 (ORCPT ); Mon, 2 Dec 2019 01:07:26 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:45366 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725852AbfLBGH0 (ORCPT ); Mon, 2 Dec 2019 01:07:26 -0500 X-UUID: ad48ffc2b44a4ade856538f4f7f5309c-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=1hVDXQnEXhl488d24pN92x7M9sMocqCpXtujHufwujQ=; b=ooyr+wvN/CzaisrsNJylXVzjAIEBxbERIjGlZFXs3PQSGD6omi/ffFnUUpG5neWtC+6adlVo584rAScqbQPgjzXshoUDXIDiYJ0OJDDSwiScpJfiZnFr6IASIO6eV6E5pRw01Lh32bWmSkvM/lDgEuBy6h4XDlQwvGP/8b1u+/I=; X-UUID: ad48ffc2b44a4ade856538f4f7f5309c-20191202 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1110865870; Mon, 02 Dec 2019 14:07:19 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 14:07:07 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 2 Dec 2019 14:07:03 +0800 Message-ID: <1575266838.26513.0.camel@mtksdaap41> Subject: Re: [PATCH v1 2/6] drm/mediatek: use DRM core's atomic commit helper From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Philipp Zabel , YT Shen , Thierry Reding , , , , , Date: Mon, 2 Dec 2019 14:07:18 +0800 In-Reply-To: <20191128024238.9399-3-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-3-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIEJpYmJ5Og0KDQpPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBUaGUgRFJNIGNvcmUgYXRvbWljIGhlbHBlciBub3cgc3VwcG9ydHMgYXN5 bmNocm9ub3VzIGNvbW1pdHMgbmF0aXZlbHkuDQo+IFRoZSBjdXN0b20gZHJtIGltcGxlbWVudGF0 aW9uIGlzbid0IG5lZWRlZCBhbnltb3JlLCByZW1vdmUgaXQuDQoNClJldmlld2VkLWJ5OiBDSyBI dSA8Y2suaHVAbWVkaWF0ZWsuY29tPg0KDQpSZWdhcmRzLA0KQ0sNCg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4NCj4gLS0tDQo+ICBk cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyB8IDg2ICsrLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuaCB8 ICA3IC0tLQ0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDg4IGRlbGV0aW9u cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMNCj4gaW5kZXgg NjU4OGRjNmRkNWUzLi4xNmU1NzcxZDE4MmUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRl ay9tdGtfZHJtX2Rydi5jDQo+IEBAIC0zNiw4OSArMzYsMTQgQEANCj4gICNkZWZpbmUgRFJJVkVS X01BSk9SIDENCj4gICNkZWZpbmUgRFJJVkVSX01JTk9SIDANCj4gIA0KPiAtc3RhdGljIHZvaWQg bXRrX2F0b21pY19zY2hlZHVsZShzdHJ1Y3QgbXRrX2RybV9wcml2YXRlICpwcml2YXRlLA0KPiAt CQkJCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkNCj4gLXsNCj4gLQlwcml2YXRlLT5j b21taXQuc3RhdGUgPSBzdGF0ZTsNCj4gLQlzY2hlZHVsZV93b3JrKCZwcml2YXRlLT5jb21taXQu d29yayk7DQo+IC19DQo+IC0NCj4gLXN0YXRpYyB2b2lkIG10a19hdG9taWNfY29tcGxldGUoc3Ry dWN0IG10a19kcm1fcHJpdmF0ZSAqcHJpdmF0ZSwNCj4gLQkJCQlzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUpDQo+IC17DQo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRybSA9IHByaXZhdGUt PmRybTsNCj4gLQ0KPiAtCWRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZlbmNlcyhkcm0sIHN0 YXRlLCBmYWxzZSk7DQo+IC0NCj4gLQkvKg0KPiAtCSAqIE1lZGlhdGVrIGRybSBzdXBwb3J0cyBy dW50aW1lIFBNLCBzbyBwbGFuZSByZWdpc3RlcnMgY2Fubm90IGJlDQo+IC0JICogd3JpdHRlbiB3 aGVuIHRoZWlyIGNydGMgaXMgZGlzYWJsZWQuDQo+IC0JICoNCj4gLQkgKiBUaGUgY29tbWVudCBm b3IgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0IHN0YXRlczoNCj4gLQkgKiAgICAgRm9yIGRyaXZl cnMgc3VwcG9ydGluZyBydW50aW1lIFBNIHRoZSByZWNvbW1lbmRlZCBzZXF1ZW5jZSBpcw0KPiAt CSAqDQo+IC0JICogICAgIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVz KGRldiwgc3RhdGUpOw0KPiAtCSAqICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNl dF9lbmFibGVzKGRldiwgc3RhdGUpOw0KPiAtCSAqICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21t aXRfcGxhbmVzKGRldiwgc3RhdGUsDQo+IC0JICogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgRFJNX1BMQU5FX0NPTU1JVF9BQ1RJVkVfT05MWSk7DQo+IC0JICoNCj4gLQkgKiBT ZWUgdGhlIGtlcm5lbGRvYyBlbnRyaWVzIGZvciB0aGVzZSB0aHJlZSBmdW5jdGlvbnMgZm9yIG1v cmUgZGV0YWlscy4NCj4gLQkgKi8NCj4gLQlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNl dF9kaXNhYmxlcyhkcm0sIHN0YXRlKTsNCj4gLQlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9k ZXNldF9lbmFibGVzKGRybSwgc3RhdGUpOw0KPiAtCWRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9w bGFuZXMoZHJtLCBzdGF0ZSwNCj4gLQkJCQkJRFJNX1BMQU5FX0NPTU1JVF9BQ1RJVkVfT05MWSk7 DQo+IC0NCj4gLQlkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl92YmxhbmtzKGRybSwgc3RhdGUp Ow0KPiAtDQo+IC0JZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoZHJtLCBzdGF0ZSk7 DQo+IC0JZHJtX2F0b21pY19zdGF0ZV9wdXQoc3RhdGUpOw0KPiAtfQ0KPiAtDQo+IC1zdGF0aWMg dm9pZCBtdGtfYXRvbWljX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KPiAtew0KPiAt CXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUgKnByaXZhdGUgPSBjb250YWluZXJfb2Yod29yaywNCj4g LQkJCXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUsIGNvbW1pdC53b3JrKTsNCj4gLQ0KPiAtCW10a19h dG9taWNfY29tcGxldGUocHJpdmF0ZSwgcHJpdmF0ZS0+Y29tbWl0LnN0YXRlKTsNCj4gLX0NCj4g LQ0KPiAtc3RhdGljIGludCBtdGtfYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJt LA0KPiAtCQkJICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsDQo+IC0JCQkgICAg IGJvb2wgYXN5bmMpDQo+IC17DQo+IC0Jc3RydWN0IG10a19kcm1fcHJpdmF0ZSAqcHJpdmF0ZSA9 IGRybS0+ZGV2X3ByaXZhdGU7DQo+IC0JaW50IHJldDsNCj4gLQ0KPiAtCXJldCA9IGRybV9hdG9t aWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzKGRybSwgc3RhdGUpOw0KPiAtCWlmIChyZXQpDQo+IC0J CXJldHVybiByZXQ7DQo+IC0NCj4gLQltdXRleF9sb2NrKCZwcml2YXRlLT5jb21taXQubG9jayk7 DQo+IC0JZmx1c2hfd29yaygmcHJpdmF0ZS0+Y29tbWl0LndvcmspOw0KPiAtDQo+IC0JcmV0ID0g ZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdGF0ZSwgdHJ1ZSk7DQo+IC0JaWYgKHJldCkg ew0KPiAtCQltdXRleF91bmxvY2soJnByaXZhdGUtPmNvbW1pdC5sb2NrKTsNCj4gLQkJZHJtX2F0 b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoZHJtLCBzdGF0ZSk7DQo+IC0JCXJldHVybiByZXQ7 DQo+IC0JfQ0KPiAtDQo+IC0JZHJtX2F0b21pY19zdGF0ZV9nZXQoc3RhdGUpOw0KPiAtCWlmIChh c3luYykNCj4gLQkJbXRrX2F0b21pY19zY2hlZHVsZShwcml2YXRlLCBzdGF0ZSk7DQo+IC0JZWxz ZQ0KPiAtCQltdGtfYXRvbWljX2NvbXBsZXRlKHByaXZhdGUsIHN0YXRlKTsNCj4gLQ0KPiAtCW11 dGV4X3VubG9jaygmcHJpdmF0ZS0+Y29tbWl0LmxvY2spOw0KPiAtDQo+IC0JcmV0dXJuIDA7DQo+ IC19DQo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfZnVuY3Mg bXRrX2RybV9tb2RlX2NvbmZpZ19oZWxwZXJzID0gew0KPiArCS5hdG9taWNfY29tbWl0X3RhaWwg PSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfdGFpbF9ycG0sDQo+ICt9Ow0KPiAgDQo+ICBzdGF0 aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBtdGtfZHJtX21vZGVfY29uZmln X2Z1bmNzID0gew0KPiAgCS5mYl9jcmVhdGUgPSBtdGtfZHJtX21vZGVfZmJfY3JlYXRlLA0KPiAg CS5hdG9taWNfY2hlY2sgPSBkcm1fYXRvbWljX2hlbHBlcl9jaGVjaywNCj4gLQkuYXRvbWljX2Nv bW1pdCA9IG10a19hdG9taWNfY29tbWl0LA0KPiArCS5hdG9taWNfY29tbWl0ID0gZHJtX2F0b21p Y19oZWxwZXJfY29tbWl0LA0KPiAgfTsNCj4gIA0KPiAgc3RhdGljIGNvbnN0IGVudW0gbXRrX2Rk cF9jb21wX2lkIG10MjcwMV9tdGtfZGRwX21haW5bXSA9IHsNCj4gQEAgLTI2NSw2ICsxOTAsNyBA QCBzdGF0aWMgaW50IG10a19kcm1fa21zX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRybSkNCj4g IAlkcm0tPm1vZGVfY29uZmlnLm1heF93aWR0aCA9IDQwOTY7DQo+ICAJZHJtLT5tb2RlX2NvbmZp Zy5tYXhfaGVpZ2h0ID0gNDA5NjsNCj4gIAlkcm0tPm1vZGVfY29uZmlnLmZ1bmNzID0gJm10a19k cm1fbW9kZV9jb25maWdfZnVuY3M7DQo+ICsJZHJtLT5tb2RlX2NvbmZpZy5oZWxwZXJfcHJpdmF0 ZSA9ICZtdGtfZHJtX21vZGVfY29uZmlnX2hlbHBlcnM7DQo+ICANCj4gIAlyZXQgPSBjb21wb25l bnRfYmluZF9hbGwoZHJtLT5kZXYsIGRybSk7DQo+ICAJaWYgKHJldCkNCj4gQEAgLTU0MCw4ICs0 NjYsNiBAQCBzdGF0aWMgaW50IG10a19kcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikNCj4gIAlpZiAoIXByaXZhdGUpDQo+ICAJCXJldHVybiAtRU5PTUVNOw0KPiAgDQo+IC0J bXV0ZXhfaW5pdCgmcHJpdmF0ZS0+Y29tbWl0LmxvY2spOw0KPiAtCUlOSVRfV09SSygmcHJpdmF0 ZS0+Y29tbWl0LndvcmssIG10a19hdG9taWNfd29yayk7DQo+ICAJcHJpdmF0ZS0+ZGF0YSA9IG9m X2RldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYpOw0KPiAgDQo+ICAJbWVtID0gcGxhdGZvcm1fZ2V0 X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsNCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kcm1fZHJ2LmgNCj4gaW5kZXggYjZhODI3MjhkNTYzLi45ZjRjZTYwMTc0ZjYgMTAw NjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oDQo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oDQo+IEBAIC00NiwxMyAr NDYsNiBAQCBzdHJ1Y3QgbXRrX2RybV9wcml2YXRlIHsNCj4gIAlzdHJ1Y3QgZGV2aWNlX25vZGUg KmNvbXBfbm9kZVtERFBfQ09NUE9ORU5UX0lEX01BWF07DQo+ICAJc3RydWN0IG10a19kZHBfY29t cCAqZGRwX2NvbXBbRERQX0NPTVBPTkVOVF9JRF9NQVhdOw0KPiAgCWNvbnN0IHN0cnVjdCBtdGtf bW1zeXNfZHJpdmVyX2RhdGEgKmRhdGE7DQo+IC0NCj4gLQlzdHJ1Y3Qgew0KPiAtCQlzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7DQo+IC0JCXN0cnVjdCB3b3JrX3N0cnVjdCB3b3JrOw0K PiAtCQlzdHJ1Y3QgbXV0ZXggbG9jazsNCj4gLQl9IGNvbW1pdDsNCj4gLQ0KPiAgCXN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdXNwZW5kX3N0YXRlOw0KPiAgDQo+ICAJYm9vbCBkbWFfcGFybXNf YWxsb2NhdGVkOw0KDQo=