diff for duplicates of <1575331327.4793.469.camel@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 10fe6b6..4f94071 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -88,8 +88,10 @@ comments below. > + > + entry = kzalloc(sizeof(*entry), GFP_KERNEL); > + if (entry) { -> + entry->payload > + kmemdup(payload, payload_len, GFP_KERNEL); -> + entry->keyring_name > + kstrdup(keyring->description, GFP_KERNEL); +> + entry->payload = +> + kmemdup(payload, payload_len, GFP_KERNEL); +> + entry->keyring_name = +> + kstrdup(keyring->description, GFP_KERNEL); No need to break up the assignments like this. Neither line when joined is greater than 80 bytes. @@ -97,8 +99,8 @@ joined is greater than 80 bytes. > + entry->payload_len = payload_len; > + } > + -> + if ((entry = NULL) || (entry->payload = NULL) || -> + (entry->keyring_name = NULL)) { +> + if ((entry == NULL) || (entry->payload == NULL) || +> + (entry->keyring_name == NULL)) { > + rc = -ENOMEM; > + goto out; > + } diff --git a/a/content_digest b/N1/content_digest index 59a4329..8cceedc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020191127025212.3077-2-nramas@linux.microsoft.com\0" "From\0Mimi Zohar <zohar@linux.ibm.com>\0" "Subject\0Re: [PATCH v0 1/2] IMA: Defined queue functions\0" - "Date\0Tue, 03 Dec 2019 00:02:07 +0000\0" + "Date\0Mon, 02 Dec 2019 19:02:07 -0500\0" "To\0Lakshmi Ramasubramanian <nramas@linux.microsoft.com>" " linux-integrity@vger.kernel.org\0" "Cc\0eric.snowberg@oracle.com" @@ -104,8 +104,10 @@ "> +\n" "> +\tentry = kzalloc(sizeof(*entry), GFP_KERNEL);\n" "> +\tif (entry) {\n" - "> +\t\tentry->payload > +\t\t\tkmemdup(payload, payload_len, GFP_KERNEL);\n" - "> +\t\tentry->keyring_name > +\t\t\tkstrdup(keyring->description, GFP_KERNEL);\n" + "> +\t\tentry->payload =\n" + "> +\t\t\tkmemdup(payload, payload_len, GFP_KERNEL);\n" + "> +\t\tentry->keyring_name =\n" + "> +\t\t\tkstrdup(keyring->description, GFP_KERNEL);\n" "\n" "No need to break up the assignments like this. \302\240Neither line when\n" "joined is greater than 80 bytes.\n" @@ -113,8 +115,8 @@ "> +\t\tentry->payload_len = payload_len;\n" "> +\t}\n" "> +\n" - "> +\tif ((entry = NULL) || (entry->payload = NULL) ||\n" - "> +\t (entry->keyring_name = NULL)) {\n" + "> +\tif ((entry == NULL) || (entry->payload == NULL) ||\n" + "> +\t (entry->keyring_name == NULL)) {\n" "> +\t\trc = -ENOMEM;\n" "> +\t\tgoto out;\n" "> +\t}\n" @@ -220,4 +222,4 @@ "> +}\n" > + -73b0e2ccbea59738ebfe21e0026fc30ba8fd89a186f24947b4ee2e62a081c156 +435bc64c720f51ff003b36abca78b1b7c44dd2a386b9fe4f488734337d87314c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.