From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53AF2C432C0 for ; Tue, 3 Dec 2019 06:18:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EAF020726 for ; Tue, 3 Dec 2019 06:18:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XO/dEbR/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="I5i22qUJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EAF020726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1sUlI0+Ny26pI/+K+aR/yRR1yf2vBggMy8hSBdU/Hz8=; b=XO/dEbR/t0Nn3F OI2f6WK/wrig+ezMIS1ZEZGNB2frpWnAcK4IWnIzBCJqO5PreZLOjAAI8k+xvQ7NW2UgIWelmnIBo vql/uXHP6/gxnqUU6cKfG6Ds67BJFZJaT0HVE/2DkafL+ZpvUeQ4c1HyaBqfaY1n6cnpXF3DMPJ0N ZNTMF0mIB66QmjLw+rS1pvfYpiMqDpAntpQ57jE7qWi3k96mW4IFgSdVau3eLqFC55isorIJigd8r dTmpC7ANyLYuol7vzm6U4ZoD/h1jMb4z2aaHDHltm0+u3fuxT520WZ3fXKRz6AMhj/9QtjIBCfk4q jWS3QYL72Dat7FVSY41g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1Vd-0000Oy-2p; Tue, 03 Dec 2019 06:18:05 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1VU-0000HX-T7; Tue, 03 Dec 2019 06:17:59 +0000 X-UUID: 1ba8a16af1474b1f9a3c87618bdaf854-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jo9OIf4noLNpOSggpQFh4hTIdnn1N4FLV/ao8egMNkY=; b=I5i22qUJeIFfMSu/6g9a9vtofreuT2xfXJ5blPhRors35MKTWJJDPbFPEh5gRWtXrGJ5ZR7L+7gDaOUzhv91thWxc15ROGkZLtQ8STf27b2R+3odS4Brn6no1gDsTvr8vumnIWRruYl/PRc7Z+I93kJxrFgpQnRN5HGRvV92B/Y=; X-UUID: 1ba8a16af1474b1f9a3c87618bdaf854-20191202 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 938699759; Mon, 02 Dec 2019 22:17:53 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 22:18:39 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 14:17:38 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 14:17:32 +0800 Message-ID: <1575353870.15194.2.camel@mtksdaap41> Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow From: CK Hu To: Bibby Hsieh Date: Tue, 3 Dec 2019 14:17:50 +0800 In-Reply-To: <1575352691.3410.2.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> <1575337114.1155.4.camel@mtksdaap41> <1575352691.3410.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_221756_952930_97AC8A95 X-CRM114-Status: GOOD ( 26.24 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Tue, 2019-12-03 at 13:58 +0800, Bibby Hsieh wrote: > On Tue, 2019-12-03 at 09:38 +0800, CK Hu wrote: > > Hi, Bibby: > > > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > > Unlike other SoCs, MT8183 does not have "shadow" > > > registers for performaing an atomic video mode > > > set or page flip at vblank/vsync. > > > > > > The CMDQ (Commend Queue) in MT8183 is used to help > > > update all relevant display controller registers > > > with critical time limation. > > > > > > Signed-off-by: YT Shen > > > Signed-off-by: CK Hu > > > Signed-off-by: Philipp Zabel > > > Signed-off-by: Bibby Hsieh > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 86 ++++++++++++++++++++- > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 ++++++++ > > > 2 files changed, 113 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > index fcf4e755e0bd..1b4e537ac3c1 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > @@ -12,6 +12,8 @@ > > > #include > > > #include > > > #include > > > +#include > > > +#include > > > > > > #include "mtk_drm_drv.h" > > > #include "mtk_drm_crtc.h" > > > @@ -42,6 +44,9 @@ struct mtk_drm_crtc { > > > unsigned int layer_nr; > > > bool pending_planes; > > > > > > + struct cmdq_client *cmdq_client; > > > + u32 cmdq_event; > > > + > > > void __iomem *config_regs; > > > const struct mtk_mmsys_reg_data *mmsys_reg_data; > > > struct mtk_disp_mutex *mutex; > > > @@ -56,6 +61,11 @@ struct mtk_crtc_state { > > > unsigned int pending_width; > > > unsigned int pending_height; > > > unsigned int pending_vrefresh; > > > + struct cmdq_pkt *cmdq_handle; > > > +}; > > > + > > > +struct mtk_cmdq_cb_data { > > > + struct cmdq_pkt *cmdq_handle; > > > }; > > > > > > static inline struct mtk_drm_crtc *to_mtk_crtc(struct drm_crtc *c) > > > @@ -229,6 +239,46 @@ struct mtk_ddp_comp *mtk_drm_ddp_comp_for_plane(struct drm_crtc *crtc, > > > return NULL; > > > } > > > > > > +#ifdef CONFIG_MTK_CMDQ > > > +static void ddp_cmdq_cb(struct cmdq_cb_data data) > > > +{ > > > + struct mtk_cmdq_cb_data *cb_data = data.data; > > > + > > > + cmdq_pkt_destroy(cb_data->cmdq_handle); > > > + kfree(cb_data); > > > +} > > > + > > > +static void mtk_cmdq_acquire(struct drm_crtc *crtc) > > > +{ > > > + struct mtk_crtc_state *mtk_crtc_state = > > > + to_mtk_crtc_state(crtc->state); > > > + struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > > > + > > > + mtk_crtc_state->cmdq_handle = > > > + cmdq_pkt_create(mtk_crtc->cmdq_client, > > > + PAGE_SIZE); > > > > I would like to remove atomic feature in cmdq driver and drm driver > > could reuse the pkt. Please refer to [1] for detail. > > > > [1] > > http://lists.infradead.org/pipermail/linux-mediatek/2019-January/016866.html > Hi, CK, > > Thanks for all the comments. > I will change them in my next version. > > About the atomic feature removing, I think we already made note at here. > Let's fix them after the atomic feature removed really. Removing atomic feature would modify the device tree, and I'm worry that device tree setting could not be modified at that time. I think we could modify the device tree now because there no client use cmdq in upstream. Regards, CK > > Bibby > > > > > + cmdq_pkt_clear_event(mtk_crtc_state->cmdq_handle, > > > + mtk_crtc->cmdq_event); > > > + cmdq_pkt_wfe(mtk_crtc_state->cmdq_handle, mtk_crtc->cmdq_event); > > > +} > > > + > > > +static void mtk_cmdq_release(struct drm_crtc *crtc) > > > +{ > > > + struct mtk_crtc_state *mtk_crtc_state = > > > + to_mtk_crtc_state(crtc->state); > > > + struct mtk_cmdq_cb_data *cb_data; > > > + > > > + cb_data = kmalloc(sizeof(*cb_data), GFP_KERNEL); > > > + if (!cb_data) { > > > + DRM_DEV_ERROR(crtc->dev->dev, "Failed to alloc cb_data\n"); > > > + return; > > > + } > > > + > > > + cb_data->cmdq_handle = mtk_crtc_state->cmdq_handle; > > > + cmdq_pkt_flush_async(mtk_crtc_state->cmdq_handle, > > > + ddp_cmdq_cb, cb_data); > > > +} > > > +#endif > > > static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) > > > { > > > struct drm_crtc *crtc = &mtk_crtc->base; > > > @@ -383,7 +433,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > > > if (state->pending_config) { > > > mtk_ddp_comp_config(comp, state->pending_width, > > > state->pending_height, > > > - state->pending_vrefresh, 0, NULL); > > > + state->pending_vrefresh, 0, > > > + state->cmdq_handle); > > > > > > state->pending_config = false; > > > } > > > @@ -403,7 +454,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > > > > > > if (comp) > > > mtk_ddp_comp_layer_config(comp, local_layer, > > > - plane_state, NULL); > > > + plane_state, > > > + state->cmdq_handle); > > > plane_state->pending.config = false; > > > } > > > mtk_crtc->pending_planes = false; > > > @@ -454,6 +506,13 @@ void mtk_drm_crtc_cursor_update(struct drm_crtc *crtc, struct drm_plane *plane, > > > mtk_crtc_ddp_config(crtc); > > > mtk_disp_mutex_release(mtk_crtc->mutex); > > > } > > > +#ifdef CONFIG_MTK_CMDQ > > > + if (mtk_crtc->cmdq_client) { > > > + mtk_cmdq_acquire(crtc); > > > + mtk_crtc_ddp_config(crtc); > > > + mtk_cmdq_release(crtc); > > > + } > > > +#endif > > > mutex_unlock(&priv->hw_lock); > > > } > > > > > > @@ -570,6 +629,13 @@ static void mtk_drm_crtc_atomic_flush(struct drm_crtc *crtc, > > > mtk_crtc_ddp_config(crtc); > > > mtk_disp_mutex_release(mtk_crtc->mutex); > > > } > > > +#ifdef CONFIG_MTK_CMDQ > > > + if (mtk_crtc->cmdq_client) { > > > + mtk_cmdq_acquire(crtc); > > > + mtk_crtc_ddp_config(crtc); > > > + mtk_cmdq_release(crtc); > > > + } > > > +#endif > > > > This part is almost the same as the one in mtk_drm_crtc_cursor_update(), > > try to merge them. > > > > > } > > > > > > static const struct drm_crtc_funcs mtk_crtc_funcs = { > > > @@ -619,7 +685,7 @@ void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct mtk_ddp_comp *comp) > > > struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > > > struct mtk_drm_private *priv = crtc->dev->dev_private; > > > > > > - if (!priv->data->shadow_register) > > > + if (!priv->data->shadow_register && !mtk_crtc->cmdq_client) > > > mtk_crtc_ddp_config(crtc); > > > > > > mtk_drm_finish_page_flip(mtk_crtc); > > > @@ -761,6 +827,18 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > > drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > > > drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > > > priv->num_pipes++; > > > - > > > +#ifdef CONFIG_MTK_CMDQ > > > + mtk_crtc->cmdq_client = > > > + cmdq_mbox_create(dev, drm_crtc_index(&mtk_crtc->base), > > > + 2000); > > > + of_property_read_u32_index(dev->of_node, "mediatek,gce-events", > > > + drm_crtc_index(&mtk_crtc->base), > > > + &mtk_crtc->cmdq_event); > > > + if (IS_ERR(mtk_crtc->cmdq_client)) { > > > + dev_dbg(dev, "mtk_crtc %d failed to create mailbox client, writing register by CPU now\n", > > > + drm_crtc_index(&mtk_crtc->base)); > > > + mtk_crtc->cmdq_client = NULL; > > > + } > > > +#endif > > > return 0; > > > } > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > index 6d0f349ddf82..9cc12af2bc06 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > @@ -370,6 +370,9 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > > const struct mtk_ddp_comp_funcs *funcs) > > > { > > > struct platform_device *comp_pdev; > > > + struct resource res; > > > + struct cmdq_client_reg *cmdq_reg; > > > + int ret = 0; > > > > > > if (comp_id < 0 || comp_id >= DDP_COMPONENT_ID_MAX) > > > return -EINVAL; > > > @@ -404,6 +407,34 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > > } > > > comp->dev = &comp_pdev->dev; > > > > > > +#ifdef CONFIG_MTK_CMDQ > > > + if (of_address_to_resource(node, 0, &res) != 0) { > > > + dev_err(dev, "Missing reg in %s node\n", > > > + node->full_name); > > > + return -EINVAL; > > > + } > > > + comp->regs_pa = res.start; > > > + > > > + comp_pdev = of_find_device_by_node(node); > > > + if (!comp_pdev) { > > > + dev_warn(dev, "Waiting for component device %s\n", > > > + node->full_name); > > > + return -EPROBE_DEFER; > > > + } > > > + > > > + cmdq_reg = kzalloc(sizeof(*cmdq_reg), GFP_KERNEL); > > > + if (!cmdq_reg) > > > + return -EINVAL; > > > + > > > + ret = cmdq_dev_get_client_reg(&comp_pdev->dev, cmdq_reg, 0); > > > + if (ret != 0) > > > + dev_dbg(&comp_pdev->dev, > > > + "get mediatek,gce-client-reg fail!\n"); > > > + else > > > + comp->subsys = cmdq_reg->subsys; > > > + > > > + kfree(cmdq_reg); > > > +#endif > > > > I would like to move this part to the patch "drm/mediatek: support CMDQ > > interface in ddp component". > > > > Regards, > > CK > > > > > return 0; > > > } > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50793C432C0 for ; Tue, 3 Dec 2019 06:18:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FBA62068E for ; Tue, 3 Dec 2019 06:18:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cbO2bE/o"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="I5i22qUJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FBA62068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oXTnUVpztbcHRYF0YwuaRhJSh/B0msXDBHRdilT499k=; b=cbO2bE/onx1rvk 1AFDpUuazP8piuU4ZR0stWsYiH9v5ZbxKMlWMukSeHZzQ0G5zstDDVAt5skjaLGjKc3WFBpMQ9Q24 zakQ0FvRcBy3U/iEeyaqCILu/gGUfSWbO7o8talyFbFrOu7TmCin+LcpGX+EI0P3XO2ZVnJ84ObS2 zMEJCLyVZtk0RCjBhhZu9iH7+cF6XdiGPHAbDGhyOcvyqMADx7nW6L/kv+Yn3+MOtVEkhEjBCZ5GE iKjmLgP20JPyHaoxIEIyAfrP5Zxh8G6PklHRhuox3l9JfEQPMy030LDG8Q0rM0P2710QMs6FkGjSt KEFBkoRljshvKCbKqBOg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1VY-0000Hz-H6; Tue, 03 Dec 2019 06:18:00 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1VU-0000HX-T7; Tue, 03 Dec 2019 06:17:59 +0000 X-UUID: 1ba8a16af1474b1f9a3c87618bdaf854-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jo9OIf4noLNpOSggpQFh4hTIdnn1N4FLV/ao8egMNkY=; b=I5i22qUJeIFfMSu/6g9a9vtofreuT2xfXJ5blPhRors35MKTWJJDPbFPEh5gRWtXrGJ5ZR7L+7gDaOUzhv91thWxc15ROGkZLtQ8STf27b2R+3odS4Brn6no1gDsTvr8vumnIWRruYl/PRc7Z+I93kJxrFgpQnRN5HGRvV92B/Y=; X-UUID: 1ba8a16af1474b1f9a3c87618bdaf854-20191202 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 938699759; Mon, 02 Dec 2019 22:17:53 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 22:18:39 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 14:17:38 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 14:17:32 +0800 Message-ID: <1575353870.15194.2.camel@mtksdaap41> Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow From: CK Hu To: Bibby Hsieh Date: Tue, 3 Dec 2019 14:17:50 +0800 In-Reply-To: <1575352691.3410.2.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> <1575337114.1155.4.camel@mtksdaap41> <1575352691.3410.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_221756_952930_97AC8A95 X-CRM114-Status: GOOD ( 26.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, YT Shen , Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Tue, 2019-12-03 at 13:58 +0800, Bibby Hsieh wrote: > On Tue, 2019-12-03 at 09:38 +0800, CK Hu wrote: > > Hi, Bibby: > > > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > > Unlike other SoCs, MT8183 does not have "shadow" > > > registers for performaing an atomic video mode > > > set or page flip at vblank/vsync. > > > > > > The CMDQ (Commend Queue) in MT8183 is used to help > > > update all relevant display controller registers > > > with critical time limation. > > > > > > Signed-off-by: YT Shen > > > Signed-off-by: CK Hu > > > Signed-off-by: Philipp Zabel > > > Signed-off-by: Bibby Hsieh > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 86 ++++++++++++++++++++- > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 ++++++++ > > > 2 files changed, 113 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > index fcf4e755e0bd..1b4e537ac3c1 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > > @@ -12,6 +12,8 @@ > > > #include > > > #include > > > #include > > > +#include > > > +#include > > > > > > #include "mtk_drm_drv.h" > > > #include "mtk_drm_crtc.h" > > > @@ -42,6 +44,9 @@ struct mtk_drm_crtc { > > > unsigned int layer_nr; > > > bool pending_planes; > > > > > > + struct cmdq_client *cmdq_client; > > > + u32 cmdq_event; > > > + > > > void __iomem *config_regs; > > > const struct mtk_mmsys_reg_data *mmsys_reg_data; > > > struct mtk_disp_mutex *mutex; > > > @@ -56,6 +61,11 @@ struct mtk_crtc_state { > > > unsigned int pending_width; > > > unsigned int pending_height; > > > unsigned int pending_vrefresh; > > > + struct cmdq_pkt *cmdq_handle; > > > +}; > > > + > > > +struct mtk_cmdq_cb_data { > > > + struct cmdq_pkt *cmdq_handle; > > > }; > > > > > > static inline struct mtk_drm_crtc *to_mtk_crtc(struct drm_crtc *c) > > > @@ -229,6 +239,46 @@ struct mtk_ddp_comp *mtk_drm_ddp_comp_for_plane(struct drm_crtc *crtc, > > > return NULL; > > > } > > > > > > +#ifdef CONFIG_MTK_CMDQ > > > +static void ddp_cmdq_cb(struct cmdq_cb_data data) > > > +{ > > > + struct mtk_cmdq_cb_data *cb_data = data.data; > > > + > > > + cmdq_pkt_destroy(cb_data->cmdq_handle); > > > + kfree(cb_data); > > > +} > > > + > > > +static void mtk_cmdq_acquire(struct drm_crtc *crtc) > > > +{ > > > + struct mtk_crtc_state *mtk_crtc_state = > > > + to_mtk_crtc_state(crtc->state); > > > + struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > > > + > > > + mtk_crtc_state->cmdq_handle = > > > + cmdq_pkt_create(mtk_crtc->cmdq_client, > > > + PAGE_SIZE); > > > > I would like to remove atomic feature in cmdq driver and drm driver > > could reuse the pkt. Please refer to [1] for detail. > > > > [1] > > http://lists.infradead.org/pipermail/linux-mediatek/2019-January/016866.html > Hi, CK, > > Thanks for all the comments. > I will change them in my next version. > > About the atomic feature removing, I think we already made note at here. > Let's fix them after the atomic feature removed really. Removing atomic feature would modify the device tree, and I'm worry that device tree setting could not be modified at that time. I think we could modify the device tree now because there no client use cmdq in upstream. Regards, CK > > Bibby > > > > > + cmdq_pkt_clear_event(mtk_crtc_state->cmdq_handle, > > > + mtk_crtc->cmdq_event); > > > + cmdq_pkt_wfe(mtk_crtc_state->cmdq_handle, mtk_crtc->cmdq_event); > > > +} > > > + > > > +static void mtk_cmdq_release(struct drm_crtc *crtc) > > > +{ > > > + struct mtk_crtc_state *mtk_crtc_state = > > > + to_mtk_crtc_state(crtc->state); > > > + struct mtk_cmdq_cb_data *cb_data; > > > + > > > + cb_data = kmalloc(sizeof(*cb_data), GFP_KERNEL); > > > + if (!cb_data) { > > > + DRM_DEV_ERROR(crtc->dev->dev, "Failed to alloc cb_data\n"); > > > + return; > > > + } > > > + > > > + cb_data->cmdq_handle = mtk_crtc_state->cmdq_handle; > > > + cmdq_pkt_flush_async(mtk_crtc_state->cmdq_handle, > > > + ddp_cmdq_cb, cb_data); > > > +} > > > +#endif > > > static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) > > > { > > > struct drm_crtc *crtc = &mtk_crtc->base; > > > @@ -383,7 +433,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > > > if (state->pending_config) { > > > mtk_ddp_comp_config(comp, state->pending_width, > > > state->pending_height, > > > - state->pending_vrefresh, 0, NULL); > > > + state->pending_vrefresh, 0, > > > + state->cmdq_handle); > > > > > > state->pending_config = false; > > > } > > > @@ -403,7 +454,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > > > > > > if (comp) > > > mtk_ddp_comp_layer_config(comp, local_layer, > > > - plane_state, NULL); > > > + plane_state, > > > + state->cmdq_handle); > > > plane_state->pending.config = false; > > > } > > > mtk_crtc->pending_planes = false; > > > @@ -454,6 +506,13 @@ void mtk_drm_crtc_cursor_update(struct drm_crtc *crtc, struct drm_plane *plane, > > > mtk_crtc_ddp_config(crtc); > > > mtk_disp_mutex_release(mtk_crtc->mutex); > > > } > > > +#ifdef CONFIG_MTK_CMDQ > > > + if (mtk_crtc->cmdq_client) { > > > + mtk_cmdq_acquire(crtc); > > > + mtk_crtc_ddp_config(crtc); > > > + mtk_cmdq_release(crtc); > > > + } > > > +#endif > > > mutex_unlock(&priv->hw_lock); > > > } > > > > > > @@ -570,6 +629,13 @@ static void mtk_drm_crtc_atomic_flush(struct drm_crtc *crtc, > > > mtk_crtc_ddp_config(crtc); > > > mtk_disp_mutex_release(mtk_crtc->mutex); > > > } > > > +#ifdef CONFIG_MTK_CMDQ > > > + if (mtk_crtc->cmdq_client) { > > > + mtk_cmdq_acquire(crtc); > > > + mtk_crtc_ddp_config(crtc); > > > + mtk_cmdq_release(crtc); > > > + } > > > +#endif > > > > This part is almost the same as the one in mtk_drm_crtc_cursor_update(), > > try to merge them. > > > > > } > > > > > > static const struct drm_crtc_funcs mtk_crtc_funcs = { > > > @@ -619,7 +685,7 @@ void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct mtk_ddp_comp *comp) > > > struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > > > struct mtk_drm_private *priv = crtc->dev->dev_private; > > > > > > - if (!priv->data->shadow_register) > > > + if (!priv->data->shadow_register && !mtk_crtc->cmdq_client) > > > mtk_crtc_ddp_config(crtc); > > > > > > mtk_drm_finish_page_flip(mtk_crtc); > > > @@ -761,6 +827,18 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > > drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > > > drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > > > priv->num_pipes++; > > > - > > > +#ifdef CONFIG_MTK_CMDQ > > > + mtk_crtc->cmdq_client = > > > + cmdq_mbox_create(dev, drm_crtc_index(&mtk_crtc->base), > > > + 2000); > > > + of_property_read_u32_index(dev->of_node, "mediatek,gce-events", > > > + drm_crtc_index(&mtk_crtc->base), > > > + &mtk_crtc->cmdq_event); > > > + if (IS_ERR(mtk_crtc->cmdq_client)) { > > > + dev_dbg(dev, "mtk_crtc %d failed to create mailbox client, writing register by CPU now\n", > > > + drm_crtc_index(&mtk_crtc->base)); > > > + mtk_crtc->cmdq_client = NULL; > > > + } > > > +#endif > > > return 0; > > > } > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > index 6d0f349ddf82..9cc12af2bc06 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > @@ -370,6 +370,9 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > > const struct mtk_ddp_comp_funcs *funcs) > > > { > > > struct platform_device *comp_pdev; > > > + struct resource res; > > > + struct cmdq_client_reg *cmdq_reg; > > > + int ret = 0; > > > > > > if (comp_id < 0 || comp_id >= DDP_COMPONENT_ID_MAX) > > > return -EINVAL; > > > @@ -404,6 +407,34 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > > } > > > comp->dev = &comp_pdev->dev; > > > > > > +#ifdef CONFIG_MTK_CMDQ > > > + if (of_address_to_resource(node, 0, &res) != 0) { > > > + dev_err(dev, "Missing reg in %s node\n", > > > + node->full_name); > > > + return -EINVAL; > > > + } > > > + comp->regs_pa = res.start; > > > + > > > + comp_pdev = of_find_device_by_node(node); > > > + if (!comp_pdev) { > > > + dev_warn(dev, "Waiting for component device %s\n", > > > + node->full_name); > > > + return -EPROBE_DEFER; > > > + } > > > + > > > + cmdq_reg = kzalloc(sizeof(*cmdq_reg), GFP_KERNEL); > > > + if (!cmdq_reg) > > > + return -EINVAL; > > > + > > > + ret = cmdq_dev_get_client_reg(&comp_pdev->dev, cmdq_reg, 0); > > > + if (ret != 0) > > > + dev_dbg(&comp_pdev->dev, > > > + "get mediatek,gce-client-reg fail!\n"); > > > + else > > > + comp->subsys = cmdq_reg->subsys; > > > + > > > + kfree(cmdq_reg); > > > +#endif > > > > I would like to move this part to the patch "drm/mediatek: support CMDQ > > interface in ddp component". > > > > Regards, > > CK > > > > > return 0; > > > } > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow Date: Tue, 3 Dec 2019 14:17:50 +0800 Message-ID: <1575353870.15194.2.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> <1575337114.1155.4.camel@mtksdaap41> <1575352691.3410.2.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B2EC89BEC for ; Tue, 3 Dec 2019 06:17:53 +0000 (UTC) In-Reply-To: <1575352691.3410.2.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bibby Hsieh Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGksIEJpYmJ5Og0KDQpPbiBUdWUsIDIwMTktMTItMDMgYXQgMTM6NTggKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBPbiBUdWUsIDIwMTktMTItMDMgYXQgMDk6MzggKzA4MDAsIENLIEh1IHdy b3RlOg0KPiA+IEhpLCBCaWJieToNCj4gPiANCj4gPiBPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6 NDIgKzA4MDAsIEJpYmJ5IEhzaWVoIHdyb3RlOg0KPiA+ID4gVW5saWtlIG90aGVyIFNvQ3MsIE1U ODE4MyBkb2VzIG5vdCBoYXZlICJzaGFkb3ciDQo+ID4gPiByZWdpc3RlcnMgZm9yIHBlcmZvcm1h aW5nIGFuIGF0b21pYyB2aWRlbyBtb2RlDQo+ID4gPiBzZXQgb3IgcGFnZSBmbGlwIGF0IHZibGFu ay92c3luYy4NCj4gPiA+IA0KPiA+ID4gVGhlIENNRFEgKENvbW1lbmQgUXVldWUpIGluIE1UODE4 MyBpcyB1c2VkIHRvIGhlbHANCj4gPiA+IHVwZGF0ZSBhbGwgcmVsZXZhbnQgZGlzcGxheSBjb250 cm9sbGVyIHJlZ2lzdGVycw0KPiA+ID4gd2l0aCBjcml0aWNhbCB0aW1lIGxpbWF0aW9uLg0KPiA+ ID4gDQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBZVCBTaGVuIDx5dC5zaGVuQG1lZGlhdGVrLmNvbT4N Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENLIEh1IDxjay5odUBtZWRpYXRlay5jb20+DQo+ID4gPiBT aWduZWQtb2ZmLWJ5OiBQaGlsaXBwIFphYmVsIDxwLnphYmVsQHBlbmd1dHJvbml4LmRlPg0KPiA+ ID4gU2lnbmVkLW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4N Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFlvbmdxaWFuZyBOaXUgPHlvbmdxaWFuZy5uaXVAbWVkaWF0 ZWsuY29tPg0KPiA+ID4gLS0tDQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19k cm1fY3J0Yy5jICAgICB8IDg2ICsrKysrKysrKysrKysrKysrKysrLQ0KPiA+ID4gIGRyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgfCAzMSArKysrKysrKw0KPiA+ID4g IDIgZmlsZXMgY2hhbmdlZCwgMTEzIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+ID4g PiANCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9j cnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMNCj4gPiA+IGlu ZGV4IGZjZjRlNzU1ZTBiZC4uMWI0ZTUzN2FjM2MxIDEwMDY0NA0KPiA+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+ID4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMNCj4gPiA+IEBAIC0xMiw2ICsxMiw4IEBADQo+ ID4gPiAgI2luY2x1ZGUgPGRybS9kcm1fcGxhbmVfaGVscGVyLmg+DQo+ID4gPiAgI2luY2x1ZGUg PGRybS9kcm1fcHJvYmVfaGVscGVyLmg+DQo+ID4gPiAgI2luY2x1ZGUgPGRybS9kcm1fdmJsYW5r Lmg+DQo+ID4gPiArI2luY2x1ZGUgPGxpbnV4L29mX2FkZHJlc3MuaD4NCj4gPiA+ICsjaW5jbHVk ZSA8bGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmg+DQo+ID4gPiAgDQo+ID4gPiAgI2luY2x1 ZGUgIm10a19kcm1fZHJ2LmgiDQo+ID4gPiAgI2luY2x1ZGUgIm10a19kcm1fY3J0Yy5oIg0KPiA+ ID4gQEAgLTQyLDYgKzQ0LDkgQEAgc3RydWN0IG10a19kcm1fY3J0YyB7DQo+ID4gPiAgCXVuc2ln bmVkIGludAkJCWxheWVyX25yOw0KPiA+ID4gIAlib29sCQkJCXBlbmRpbmdfcGxhbmVzOw0KPiA+ ID4gIA0KPiA+ID4gKwlzdHJ1Y3QgY21kcV9jbGllbnQJCSpjbWRxX2NsaWVudDsNCj4gPiA+ICsJ dTMyCQkJCWNtZHFfZXZlbnQ7DQo+ID4gPiArDQo+ID4gPiAgCXZvaWQgX19pb21lbQkJCSpjb25m aWdfcmVnczsNCj4gPiA+ICAJY29uc3Qgc3RydWN0IG10a19tbXN5c19yZWdfZGF0YSAqbW1zeXNf cmVnX2RhdGE7DQo+ID4gPiAgCXN0cnVjdCBtdGtfZGlzcF9tdXRleAkJKm11dGV4Ow0KPiA+ID4g QEAgLTU2LDYgKzYxLDExIEBAIHN0cnVjdCBtdGtfY3J0Y19zdGF0ZSB7DQo+ID4gPiAgCXVuc2ln bmVkIGludAkJCXBlbmRpbmdfd2lkdGg7DQo+ID4gPiAgCXVuc2lnbmVkIGludAkJCXBlbmRpbmdf aGVpZ2h0Ow0KPiA+ID4gIAl1bnNpZ25lZCBpbnQJCQlwZW5kaW5nX3ZyZWZyZXNoOw0KPiA+ID4g KwlzdHJ1Y3QgY21kcV9wa3QJCQkqY21kcV9oYW5kbGU7DQo+ID4gPiArfTsNCj4gPiA+ICsNCj4g PiA+ICtzdHJ1Y3QgbXRrX2NtZHFfY2JfZGF0YSB7DQo+ID4gPiArCXN0cnVjdCBjbWRxX3BrdAkJ CSpjbWRxX2hhbmRsZTsNCj4gPiA+ICB9Ow0KPiA+ID4gIA0KPiA+ID4gIHN0YXRpYyBpbmxpbmUg c3RydWN0IG10a19kcm1fY3J0YyAqdG9fbXRrX2NydGMoc3RydWN0IGRybV9jcnRjICpjKQ0KPiA+ ID4gQEAgLTIyOSw2ICsyMzksNDYgQEAgc3RydWN0IG10a19kZHBfY29tcCAqbXRrX2RybV9kZHBf Y29tcF9mb3JfcGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLA0KPiA+ID4gIAlyZXR1cm4gTlVM TDsNCj4gPiA+ICB9DQo+ID4gPiAgDQo+ID4gPiArI2lmZGVmIENPTkZJR19NVEtfQ01EUQ0KPiA+ ID4gK3N0YXRpYyB2b2lkIGRkcF9jbWRxX2NiKHN0cnVjdCBjbWRxX2NiX2RhdGEgZGF0YSkNCj4g PiA+ICt7DQo+ID4gPiArCXN0cnVjdCBtdGtfY21kcV9jYl9kYXRhICpjYl9kYXRhID0gZGF0YS5k YXRhOw0KPiA+ID4gKw0KPiA+ID4gKwljbWRxX3BrdF9kZXN0cm95KGNiX2RhdGEtPmNtZHFfaGFu ZGxlKTsNCj4gPiA+ICsJa2ZyZWUoY2JfZGF0YSk7DQo+ID4gPiArfQ0KPiA+ID4gKw0KPiA+ID4g K3N0YXRpYyB2b2lkIG10a19jbWRxX2FjcXVpcmUoc3RydWN0IGRybV9jcnRjICpjcnRjKQ0KPiA+ ID4gK3sNCj4gPiA+ICsJc3RydWN0IG10a19jcnRjX3N0YXRlICptdGtfY3J0Y19zdGF0ZSA9DQo+ ID4gPiArCQkJdG9fbXRrX2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUpOw0KPiA+ID4gKwlzdHJ1Y3Qg bXRrX2RybV9jcnRjICptdGtfY3J0YyA9IHRvX210a19jcnRjKGNydGMpOw0KPiA+ID4gKw0KPiA+ ID4gKwltdGtfY3J0Y19zdGF0ZS0+Y21kcV9oYW5kbGUgPQ0KPiA+ID4gKwkJCWNtZHFfcGt0X2Ny ZWF0ZShtdGtfY3J0Yy0+Y21kcV9jbGllbnQsDQo+ID4gPiArCQkJCQlQQUdFX1NJWkUpOw0KPiA+ IA0KPiA+IEkgd291bGQgbGlrZSB0byByZW1vdmUgYXRvbWljIGZlYXR1cmUgaW4gY21kcSBkcml2 ZXIgYW5kIGRybSBkcml2ZXINCj4gPiBjb3VsZCByZXVzZSB0aGUgcGt0LiBQbGVhc2UgcmVmZXIg dG8gWzFdIGZvciBkZXRhaWwuDQo+ID4gDQo+ID4gWzFdDQo+ID4gaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvcGlwZXJtYWlsL2xpbnV4LW1lZGlhdGVrLzIwMTktSmFudWFyeS8wMTY4NjYuaHRt bA0KPiBIaSwgQ0ssDQo+IA0KPiBUaGFua3MgZm9yIGFsbCB0aGUgY29tbWVudHMuDQo+IEkgd2ls bCBjaGFuZ2UgdGhlbSBpbiBteSBuZXh0IHZlcnNpb24uDQo+IA0KPiBBYm91dCB0aGUgYXRvbWlj IGZlYXR1cmUgcmVtb3ZpbmcsIEkgdGhpbmsgd2UgYWxyZWFkeSBtYWRlIG5vdGUgYXQgaGVyZS4N Cj4gTGV0J3MgZml4IHRoZW0gYWZ0ZXIgdGhlIGF0b21pYyBmZWF0dXJlIHJlbW92ZWQgcmVhbGx5 Lg0KDQpSZW1vdmluZyBhdG9taWMgZmVhdHVyZSB3b3VsZCBtb2RpZnkgdGhlIGRldmljZSB0cmVl LCBhbmQgSSdtIHdvcnJ5IHRoYXQNCmRldmljZSB0cmVlIHNldHRpbmcgY291bGQgbm90IGJlIG1v ZGlmaWVkIGF0IHRoYXQgdGltZS4gSSB0aGluayB3ZSBjb3VsZA0KbW9kaWZ5IHRoZSBkZXZpY2Ug dHJlZSBub3cgYmVjYXVzZSB0aGVyZSBubyBjbGllbnQgdXNlIGNtZHEgaW4gdXBzdHJlYW0uDQoN ClJlZ2FyZHMsDQpDSw0KDQo+IA0KPiBCaWJieQ0KPiA+IA0KPiA+ID4gKwljbWRxX3BrdF9jbGVh cl9ldmVudChtdGtfY3J0Y19zdGF0ZS0+Y21kcV9oYW5kbGUsDQo+ID4gPiArCQkJICAgICBtdGtf Y3J0Yy0+Y21kcV9ldmVudCk7DQo+ID4gPiArCWNtZHFfcGt0X3dmZShtdGtfY3J0Y19zdGF0ZS0+ Y21kcV9oYW5kbGUsIG10a19jcnRjLT5jbWRxX2V2ZW50KTsNCj4gPiA+ICt9DQo+ID4gPiArDQo+ ID4gPiArc3RhdGljIHZvaWQgbXRrX2NtZHFfcmVsZWFzZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMp DQo+ID4gPiArew0KPiA+ID4gKwlzdHJ1Y3QgbXRrX2NydGNfc3RhdGUgKm10a19jcnRjX3N0YXRl ID0NCj4gPiA+ICsJCQl0b19tdGtfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSk7DQo+ID4gPiArCXN0 cnVjdCBtdGtfY21kcV9jYl9kYXRhICpjYl9kYXRhOw0KPiA+ID4gKw0KPiA+ID4gKwljYl9kYXRh ID0ga21hbGxvYyhzaXplb2YoKmNiX2RhdGEpLCBHRlBfS0VSTkVMKTsNCj4gPiA+ICsJaWYgKCFj Yl9kYXRhKSB7DQo+ID4gPiArCQlEUk1fREVWX0VSUk9SKGNydGMtPmRldi0+ZGV2LCAiRmFpbGVk IHRvIGFsbG9jIGNiX2RhdGFcbiIpOw0KPiA+ID4gKwkJcmV0dXJuOw0KPiA+ID4gKwl9DQo+ID4g PiArDQo+ID4gPiArCWNiX2RhdGEtPmNtZHFfaGFuZGxlID0gbXRrX2NydGNfc3RhdGUtPmNtZHFf aGFuZGxlOw0KPiA+ID4gKwljbWRxX3BrdF9mbHVzaF9hc3luYyhtdGtfY3J0Y19zdGF0ZS0+Y21k cV9oYW5kbGUsDQo+ID4gPiArCQkJICAgICBkZHBfY21kcV9jYiwgY2JfZGF0YSk7DQo+ID4gPiAr fQ0KPiA+ID4gKyNlbmRpZg0KPiA+ID4gIHN0YXRpYyBpbnQgbXRrX2NydGNfZGRwX2h3X2luaXQo c3RydWN0IG10a19kcm1fY3J0YyAqbXRrX2NydGMpDQo+ID4gPiAgew0KPiA+ID4gIAlzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMgPSAmbXRrX2NydGMtPmJhc2U7DQo+ID4gPiBAQCAtMzgzLDcgKzQzMyw4 IEBAIHN0YXRpYyB2b2lkIG10a19jcnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRj KQ0KPiA+ID4gIAlpZiAoc3RhdGUtPnBlbmRpbmdfY29uZmlnKSB7DQo+ID4gPiAgCQltdGtfZGRw X2NvbXBfY29uZmlnKGNvbXAsIHN0YXRlLT5wZW5kaW5nX3dpZHRoLA0KPiA+ID4gIAkJCQkgICAg c3RhdGUtPnBlbmRpbmdfaGVpZ2h0LA0KPiA+ID4gLQkJCQkgICAgc3RhdGUtPnBlbmRpbmdfdnJl ZnJlc2gsIDAsIE5VTEwpOw0KPiA+ID4gKwkJCQkgICAgc3RhdGUtPnBlbmRpbmdfdnJlZnJlc2gs IDAsDQo+ID4gPiArCQkJCSAgICBzdGF0ZS0+Y21kcV9oYW5kbGUpOw0KPiA+ID4gIA0KPiA+ID4g IAkJc3RhdGUtPnBlbmRpbmdfY29uZmlnID0gZmFsc2U7DQo+ID4gPiAgCX0NCj4gPiA+IEBAIC00 MDMsNyArNDU0LDggQEAgc3RhdGljIHZvaWQgbXRrX2NydGNfZGRwX2NvbmZpZyhzdHJ1Y3QgZHJt X2NydGMgKmNydGMpDQo+ID4gPiAgDQo+ID4gPiAgCQkJaWYgKGNvbXApDQo+ID4gPiAgCQkJCW10 a19kZHBfY29tcF9sYXllcl9jb25maWcoY29tcCwgbG9jYWxfbGF5ZXIsDQo+ID4gPiAtCQkJCQkJ CSAgcGxhbmVfc3RhdGUsIE5VTEwpOw0KPiA+ID4gKwkJCQkJCQkgIHBsYW5lX3N0YXRlLA0KPiA+ ID4gKwkJCQkJCQkgIHN0YXRlLT5jbWRxX2hhbmRsZSk7DQo+ID4gPiAgCQkJcGxhbmVfc3RhdGUt PnBlbmRpbmcuY29uZmlnID0gZmFsc2U7DQo+ID4gPiAgCQl9DQo+ID4gPiAgCQltdGtfY3J0Yy0+ cGVuZGluZ19wbGFuZXMgPSBmYWxzZTsNCj4gPiA+IEBAIC00NTQsNiArNTA2LDEzIEBAIHZvaWQg bXRrX2RybV9jcnRjX2N1cnNvcl91cGRhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLCBzdHJ1Y3Qg ZHJtX3BsYW5lICpwbGFuZSwNCj4gPiA+ICAJCW10a19jcnRjX2RkcF9jb25maWcoY3J0Yyk7DQo+ ID4gPiAgCQltdGtfZGlzcF9tdXRleF9yZWxlYXNlKG10a19jcnRjLT5tdXRleCk7DQo+ID4gPiAg CX0NCj4gPiA+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ID4gPiArCWlmIChtdGtfY3J0Yy0+ Y21kcV9jbGllbnQpIHsNCj4gPiA+ICsJCW10a19jbWRxX2FjcXVpcmUoY3J0Yyk7DQo+ID4gPiAr CQltdGtfY3J0Y19kZHBfY29uZmlnKGNydGMpOw0KPiA+ID4gKwkJbXRrX2NtZHFfcmVsZWFzZShj cnRjKTsNCj4gPiA+ICsJfQ0KPiA+ID4gKyNlbmRpZg0KPiA+ID4gIAltdXRleF91bmxvY2soJnBy aXYtPmh3X2xvY2spOw0KPiA+ID4gIH0NCj4gPiA+ICANCj4gPiA+IEBAIC01NzAsNiArNjI5LDEz IEBAIHN0YXRpYyB2b2lkIG10a19kcm1fY3J0Y19hdG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRj ICpjcnRjLA0KPiA+ID4gIAkJbXRrX2NydGNfZGRwX2NvbmZpZyhjcnRjKTsNCj4gPiA+ICAJCW10 a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4gPiA+ICAJfQ0KPiA+ID4g KyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gPiA+ICsJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVu dCkgew0KPiA+ID4gKwkJbXRrX2NtZHFfYWNxdWlyZShjcnRjKTsNCj4gPiA+ICsJCW10a19jcnRj X2RkcF9jb25maWcoY3J0Yyk7DQo+ID4gPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiA+ ID4gKwl9DQo+ID4gPiArI2VuZGlmDQo+ID4gDQo+ID4gVGhpcyBwYXJ0IGlzIGFsbW9zdCB0aGUg c2FtZSBhcyB0aGUgb25lIGluIG10a19kcm1fY3J0Y19jdXJzb3JfdXBkYXRlKCksDQo+ID4gdHJ5 IHRvIG1lcmdlIHRoZW0uDQo+ID4gDQo+ID4gPiAgfQ0KPiA+ID4gIA0KPiA+ID4gIHN0YXRpYyBj b25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgbXRrX2NydGNfZnVuY3MgPSB7DQo+ID4gPiBAQCAt NjE5LDcgKzY4NSw3IEBAIHZvaWQgbXRrX2NydGNfZGRwX2lycShzdHJ1Y3QgZHJtX2NydGMgKmNy dGMsIHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXApDQo+ID4gPiAgCXN0cnVjdCBtdGtfZHJtX2Ny dGMgKm10a19jcnRjID0gdG9fbXRrX2NydGMoY3J0Yyk7DQo+ID4gPiAgCXN0cnVjdCBtdGtfZHJt X3ByaXZhdGUgKnByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOw0KPiA+ID4gIA0KPiA+ID4g LQlpZiAoIXByaXYtPmRhdGEtPnNoYWRvd19yZWdpc3RlcikNCj4gPiA+ICsJaWYgKCFwcml2LT5k YXRhLT5zaGFkb3dfcmVnaXN0ZXIgJiYgIW10a19jcnRjLT5jbWRxX2NsaWVudCkNCj4gPiA+ICAJ CW10a19jcnRjX2RkcF9jb25maWcoY3J0Yyk7DQo+ID4gPiAgDQo+ID4gPiAgCW10a19kcm1fZmlu aXNoX3BhZ2VfZmxpcChtdGtfY3J0Yyk7DQo+ID4gPiBAQCAtNzYxLDYgKzgyNywxOCBAQCBpbnQg bXRrX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiwNCj4gPiA+ICAJ ZHJtX21vZGVfY3J0Y19zZXRfZ2FtbWFfc2l6ZSgmbXRrX2NydGMtPmJhc2UsIE1US19MVVRfU0la RSk7DQo+ID4gPiAgCWRybV9jcnRjX2VuYWJsZV9jb2xvcl9tZ210KCZtdGtfY3J0Yy0+YmFzZSwg MCwgZmFsc2UsIE1US19MVVRfU0laRSk7DQo+ID4gPiAgCXByaXYtPm51bV9waXBlcysrOw0KPiA+ ID4gLQ0KPiA+ID4gKyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gPiA+ICsJbXRrX2NydGMtPmNt ZHFfY2xpZW50ID0NCj4gPiA+ICsJCQljbWRxX21ib3hfY3JlYXRlKGRldiwgZHJtX2NydGNfaW5k ZXgoJm10a19jcnRjLT5iYXNlKSwNCj4gPiA+ICsJCQkJCSAyMDAwKTsNCj4gPiA+ICsJb2ZfcHJv cGVydHlfcmVhZF91MzJfaW5kZXgoZGV2LT5vZl9ub2RlLCAibWVkaWF0ZWssZ2NlLWV2ZW50cyIs DQo+ID4gPiArCQkJCSAgIGRybV9jcnRjX2luZGV4KCZtdGtfY3J0Yy0+YmFzZSksDQo+ID4gPiAr CQkJCSAgICZtdGtfY3J0Yy0+Y21kcV9ldmVudCk7DQo+ID4gPiArCWlmIChJU19FUlIobXRrX2Ny dGMtPmNtZHFfY2xpZW50KSkgew0KPiA+ID4gKwkJZGV2X2RiZyhkZXYsICJtdGtfY3J0YyAlZCBm YWlsZWQgdG8gY3JlYXRlIG1haWxib3ggY2xpZW50LCB3cml0aW5nIHJlZ2lzdGVyIGJ5IENQVSBu b3dcbiIsDQo+ID4gPiArCQkJZHJtX2NydGNfaW5kZXgoJm10a19jcnRjLT5iYXNlKSk7DQo+ID4g PiArCQltdGtfY3J0Yy0+Y21kcV9jbGllbnQgPSBOVUxMOw0KPiA+ID4gKwl9DQo+ID4gPiArI2Vu ZGlmDQo+ID4gPiAgCXJldHVybiAwOw0KPiA+ID4gIH0NCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIGIvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYw0KPiA+ID4gaW5kZXggNmQwZjM0OWRkZjgyLi45 Y2MxMmFmMmJjMDYgMTAwNjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsv bXRrX2RybV9kZHBfY29tcC5jDQo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsv bXRrX2RybV9kZHBfY29tcC5jDQo+ID4gPiBAQCAtMzcwLDYgKzM3MCw5IEBAIGludCBtdGtfZGRw X2NvbXBfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSwN Cj4gPiA+ICAJCSAgICAgIGNvbnN0IHN0cnVjdCBtdGtfZGRwX2NvbXBfZnVuY3MgKmZ1bmNzKQ0K PiA+ID4gIHsNCj4gPiA+ICAJc3RydWN0IHBsYXRmb3JtX2RldmljZSAqY29tcF9wZGV2Ow0KPiA+ ID4gKwlzdHJ1Y3QgcmVzb3VyY2UgcmVzOw0KPiA+ID4gKwlzdHJ1Y3QgY21kcV9jbGllbnRfcmVn ICpjbWRxX3JlZzsNCj4gPiA+ICsJaW50IHJldCA9IDA7DQo+ID4gPiAgDQo+ID4gPiAgCWlmIChj b21wX2lkIDwgMCB8fCBjb21wX2lkID49IEREUF9DT01QT05FTlRfSURfTUFYKQ0KPiA+ID4gIAkJ cmV0dXJuIC1FSU5WQUw7DQo+ID4gPiBAQCAtNDA0LDYgKzQwNywzNCBAQCBpbnQgbXRrX2RkcF9j b21wX2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUsDQo+ ID4gPiAgCX0NCj4gPiA+ICAJY29tcC0+ZGV2ID0gJmNvbXBfcGRldi0+ZGV2Ow0KPiA+ID4gIA0K PiA+ID4gKyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gPiA+ICsJaWYgKG9mX2FkZHJlc3NfdG9f cmVzb3VyY2Uobm9kZSwgMCwgJnJlcykgIT0gMCkgew0KPiA+ID4gKwkJZGV2X2VycihkZXYsICJN aXNzaW5nIHJlZyBpbiAlcyBub2RlXG4iLA0KPiA+ID4gKwkJCW5vZGUtPmZ1bGxfbmFtZSk7DQo+ ID4gPiArCQlyZXR1cm4gLUVJTlZBTDsNCj4gPiA+ICsJfQ0KPiA+ID4gKwljb21wLT5yZWdzX3Bh ID0gcmVzLnN0YXJ0Ow0KPiA+ID4gKw0KPiA+ID4gKwljb21wX3BkZXYgPSBvZl9maW5kX2Rldmlj ZV9ieV9ub2RlKG5vZGUpOw0KPiA+ID4gKwlpZiAoIWNvbXBfcGRldikgew0KPiA+ID4gKwkJZGV2 X3dhcm4oZGV2LCAiV2FpdGluZyBmb3IgY29tcG9uZW50IGRldmljZSAlc1xuIiwNCj4gPiA+ICsJ CQkgbm9kZS0+ZnVsbF9uYW1lKTsNCj4gPiA+ICsJCXJldHVybiAtRVBST0JFX0RFRkVSOw0KPiA+ ID4gKwl9DQo+ID4gPiArDQo+ID4gPiArCWNtZHFfcmVnID0ga3phbGxvYyhzaXplb2YoKmNtZHFf cmVnKSwgR0ZQX0tFUk5FTCk7DQo+ID4gPiArCWlmICghY21kcV9yZWcpDQo+ID4gPiArCQlyZXR1 cm4gLUVJTlZBTDsNCj4gPiA+ICsNCj4gPiA+ICsJcmV0ID0gY21kcV9kZXZfZ2V0X2NsaWVudF9y ZWcoJmNvbXBfcGRldi0+ZGV2LCBjbWRxX3JlZywgMCk7DQo+ID4gPiArCWlmIChyZXQgIT0gMCkN Cj4gPiA+ICsJCWRldl9kYmcoJmNvbXBfcGRldi0+ZGV2LA0KPiA+ID4gKwkJCSJnZXQgbWVkaWF0 ZWssZ2NlLWNsaWVudC1yZWcgZmFpbCFcbiIpOw0KPiA+ID4gKwllbHNlDQo+ID4gPiArCQljb21w LT5zdWJzeXMgPSBjbWRxX3JlZy0+c3Vic3lzOw0KPiA+ID4gKw0KPiA+ID4gKwlrZnJlZShjbWRx X3JlZyk7DQo+ID4gPiArI2VuZGlmDQo+ID4gDQo+ID4gSSB3b3VsZCBsaWtlIHRvIG1vdmUgdGhp cyBwYXJ0IHRvIHRoZSBwYXRjaCAiZHJtL21lZGlhdGVrOiBzdXBwb3J0IENNRFENCj4gPiBpbnRl cmZhY2UgaW4gZGRwIGNvbXBvbmVudCIuDQo+ID4gDQo+ID4gUmVnYXJkcywNCj4gPiBDSw0KPiA+ IA0KPiA+ID4gIAlyZXR1cm4gMDsNCj4gPiA+ICB9DQo+ID4gPiAgDQo+ID4gDQo+ID4gDQo+IA0K PiANCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A1EC432C3 for ; Tue, 3 Dec 2019 06:18:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70A3B2068E for ; Tue, 3 Dec 2019 06:18:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="I5i22qUJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbfLCGSA (ORCPT ); Tue, 3 Dec 2019 01:18:00 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:41933 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726521AbfLCGSA (ORCPT ); Tue, 3 Dec 2019 01:18:00 -0500 X-UUID: f8a66902f2e249e5837e90adbc22e057-20191203 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jo9OIf4noLNpOSggpQFh4hTIdnn1N4FLV/ao8egMNkY=; b=I5i22qUJeIFfMSu/6g9a9vtofreuT2xfXJ5blPhRors35MKTWJJDPbFPEh5gRWtXrGJ5ZR7L+7gDaOUzhv91thWxc15ROGkZLtQ8STf27b2R+3odS4Brn6no1gDsTvr8vumnIWRruYl/PRc7Z+I93kJxrFgpQnRN5HGRvV92B/Y=; X-UUID: f8a66902f2e249e5837e90adbc22e057-20191203 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1817371736; Tue, 03 Dec 2019 14:17:51 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 14:17:38 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 14:17:32 +0800 Message-ID: <1575353870.15194.2.camel@mtksdaap41> Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Philipp Zabel , YT Shen , Thierry Reding , , , , , , Yongqiang Niu Date: Tue, 3 Dec 2019 14:17:50 +0800 In-Reply-To: <1575352691.3410.2.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> <1575337114.1155.4.camel@mtksdaap41> <1575352691.3410.2.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIEJpYmJ5Og0KDQpPbiBUdWUsIDIwMTktMTItMDMgYXQgMTM6NTggKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBPbiBUdWUsIDIwMTktMTItMDMgYXQgMDk6MzggKzA4MDAsIENLIEh1IHdy b3RlOg0KPiA+IEhpLCBCaWJieToNCj4gPiANCj4gPiBPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6 NDIgKzA4MDAsIEJpYmJ5IEhzaWVoIHdyb3RlOg0KPiA+ID4gVW5saWtlIG90aGVyIFNvQ3MsIE1U ODE4MyBkb2VzIG5vdCBoYXZlICJzaGFkb3ciDQo+ID4gPiByZWdpc3RlcnMgZm9yIHBlcmZvcm1h aW5nIGFuIGF0b21pYyB2aWRlbyBtb2RlDQo+ID4gPiBzZXQgb3IgcGFnZSBmbGlwIGF0IHZibGFu ay92c3luYy4NCj4gPiA+IA0KPiA+ID4gVGhlIENNRFEgKENvbW1lbmQgUXVldWUpIGluIE1UODE4 MyBpcyB1c2VkIHRvIGhlbHANCj4gPiA+IHVwZGF0ZSBhbGwgcmVsZXZhbnQgZGlzcGxheSBjb250 cm9sbGVyIHJlZ2lzdGVycw0KPiA+ID4gd2l0aCBjcml0aWNhbCB0aW1lIGxpbWF0aW9uLg0KPiA+ ID4gDQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBZVCBTaGVuIDx5dC5zaGVuQG1lZGlhdGVrLmNvbT4N Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENLIEh1IDxjay5odUBtZWRpYXRlay5jb20+DQo+ID4gPiBT aWduZWQtb2ZmLWJ5OiBQaGlsaXBwIFphYmVsIDxwLnphYmVsQHBlbmd1dHJvbml4LmRlPg0KPiA+ ID4gU2lnbmVkLW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4N Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFlvbmdxaWFuZyBOaXUgPHlvbmdxaWFuZy5uaXVAbWVkaWF0 ZWsuY29tPg0KPiA+ID4gLS0tDQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19k cm1fY3J0Yy5jICAgICB8IDg2ICsrKysrKysrKysrKysrKysrKysrLQ0KPiA+ID4gIGRyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgfCAzMSArKysrKysrKw0KPiA+ID4g IDIgZmlsZXMgY2hhbmdlZCwgMTEzIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+ID4g PiANCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9j cnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMNCj4gPiA+IGlu ZGV4IGZjZjRlNzU1ZTBiZC4uMWI0ZTUzN2FjM2MxIDEwMDY0NA0KPiA+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+ID4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMNCj4gPiA+IEBAIC0xMiw2ICsxMiw4IEBADQo+ ID4gPiAgI2luY2x1ZGUgPGRybS9kcm1fcGxhbmVfaGVscGVyLmg+DQo+ID4gPiAgI2luY2x1ZGUg PGRybS9kcm1fcHJvYmVfaGVscGVyLmg+DQo+ID4gPiAgI2luY2x1ZGUgPGRybS9kcm1fdmJsYW5r Lmg+DQo+ID4gPiArI2luY2x1ZGUgPGxpbnV4L29mX2FkZHJlc3MuaD4NCj4gPiA+ICsjaW5jbHVk ZSA8bGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmg+DQo+ID4gPiAgDQo+ID4gPiAgI2luY2x1 ZGUgIm10a19kcm1fZHJ2LmgiDQo+ID4gPiAgI2luY2x1ZGUgIm10a19kcm1fY3J0Yy5oIg0KPiA+ ID4gQEAgLTQyLDYgKzQ0LDkgQEAgc3RydWN0IG10a19kcm1fY3J0YyB7DQo+ID4gPiAgCXVuc2ln bmVkIGludAkJCWxheWVyX25yOw0KPiA+ID4gIAlib29sCQkJCXBlbmRpbmdfcGxhbmVzOw0KPiA+ ID4gIA0KPiA+ID4gKwlzdHJ1Y3QgY21kcV9jbGllbnQJCSpjbWRxX2NsaWVudDsNCj4gPiA+ICsJ dTMyCQkJCWNtZHFfZXZlbnQ7DQo+ID4gPiArDQo+ID4gPiAgCXZvaWQgX19pb21lbQkJCSpjb25m aWdfcmVnczsNCj4gPiA+ICAJY29uc3Qgc3RydWN0IG10a19tbXN5c19yZWdfZGF0YSAqbW1zeXNf cmVnX2RhdGE7DQo+ID4gPiAgCXN0cnVjdCBtdGtfZGlzcF9tdXRleAkJKm11dGV4Ow0KPiA+ID4g QEAgLTU2LDYgKzYxLDExIEBAIHN0cnVjdCBtdGtfY3J0Y19zdGF0ZSB7DQo+ID4gPiAgCXVuc2ln bmVkIGludAkJCXBlbmRpbmdfd2lkdGg7DQo+ID4gPiAgCXVuc2lnbmVkIGludAkJCXBlbmRpbmdf aGVpZ2h0Ow0KPiA+ID4gIAl1bnNpZ25lZCBpbnQJCQlwZW5kaW5nX3ZyZWZyZXNoOw0KPiA+ID4g KwlzdHJ1Y3QgY21kcV9wa3QJCQkqY21kcV9oYW5kbGU7DQo+ID4gPiArfTsNCj4gPiA+ICsNCj4g PiA+ICtzdHJ1Y3QgbXRrX2NtZHFfY2JfZGF0YSB7DQo+ID4gPiArCXN0cnVjdCBjbWRxX3BrdAkJ CSpjbWRxX2hhbmRsZTsNCj4gPiA+ICB9Ow0KPiA+ID4gIA0KPiA+ID4gIHN0YXRpYyBpbmxpbmUg c3RydWN0IG10a19kcm1fY3J0YyAqdG9fbXRrX2NydGMoc3RydWN0IGRybV9jcnRjICpjKQ0KPiA+ ID4gQEAgLTIyOSw2ICsyMzksNDYgQEAgc3RydWN0IG10a19kZHBfY29tcCAqbXRrX2RybV9kZHBf Y29tcF9mb3JfcGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLA0KPiA+ID4gIAlyZXR1cm4gTlVM TDsNCj4gPiA+ICB9DQo+ID4gPiAgDQo+ID4gPiArI2lmZGVmIENPTkZJR19NVEtfQ01EUQ0KPiA+ ID4gK3N0YXRpYyB2b2lkIGRkcF9jbWRxX2NiKHN0cnVjdCBjbWRxX2NiX2RhdGEgZGF0YSkNCj4g PiA+ICt7DQo+ID4gPiArCXN0cnVjdCBtdGtfY21kcV9jYl9kYXRhICpjYl9kYXRhID0gZGF0YS5k YXRhOw0KPiA+ID4gKw0KPiA+ID4gKwljbWRxX3BrdF9kZXN0cm95KGNiX2RhdGEtPmNtZHFfaGFu ZGxlKTsNCj4gPiA+ICsJa2ZyZWUoY2JfZGF0YSk7DQo+ID4gPiArfQ0KPiA+ID4gKw0KPiA+ID4g K3N0YXRpYyB2b2lkIG10a19jbWRxX2FjcXVpcmUoc3RydWN0IGRybV9jcnRjICpjcnRjKQ0KPiA+ ID4gK3sNCj4gPiA+ICsJc3RydWN0IG10a19jcnRjX3N0YXRlICptdGtfY3J0Y19zdGF0ZSA9DQo+ ID4gPiArCQkJdG9fbXRrX2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUpOw0KPiA+ID4gKwlzdHJ1Y3Qg bXRrX2RybV9jcnRjICptdGtfY3J0YyA9IHRvX210a19jcnRjKGNydGMpOw0KPiA+ID4gKw0KPiA+ ID4gKwltdGtfY3J0Y19zdGF0ZS0+Y21kcV9oYW5kbGUgPQ0KPiA+ID4gKwkJCWNtZHFfcGt0X2Ny ZWF0ZShtdGtfY3J0Yy0+Y21kcV9jbGllbnQsDQo+ID4gPiArCQkJCQlQQUdFX1NJWkUpOw0KPiA+ IA0KPiA+IEkgd291bGQgbGlrZSB0byByZW1vdmUgYXRvbWljIGZlYXR1cmUgaW4gY21kcSBkcml2 ZXIgYW5kIGRybSBkcml2ZXINCj4gPiBjb3VsZCByZXVzZSB0aGUgcGt0LiBQbGVhc2UgcmVmZXIg dG8gWzFdIGZvciBkZXRhaWwuDQo+ID4gDQo+ID4gWzFdDQo+ID4gaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvcGlwZXJtYWlsL2xpbnV4LW1lZGlhdGVrLzIwMTktSmFudWFyeS8wMTY4NjYuaHRt bA0KPiBIaSwgQ0ssDQo+IA0KPiBUaGFua3MgZm9yIGFsbCB0aGUgY29tbWVudHMuDQo+IEkgd2ls bCBjaGFuZ2UgdGhlbSBpbiBteSBuZXh0IHZlcnNpb24uDQo+IA0KPiBBYm91dCB0aGUgYXRvbWlj IGZlYXR1cmUgcmVtb3ZpbmcsIEkgdGhpbmsgd2UgYWxyZWFkeSBtYWRlIG5vdGUgYXQgaGVyZS4N Cj4gTGV0J3MgZml4IHRoZW0gYWZ0ZXIgdGhlIGF0b21pYyBmZWF0dXJlIHJlbW92ZWQgcmVhbGx5 Lg0KDQpSZW1vdmluZyBhdG9taWMgZmVhdHVyZSB3b3VsZCBtb2RpZnkgdGhlIGRldmljZSB0cmVl LCBhbmQgSSdtIHdvcnJ5IHRoYXQNCmRldmljZSB0cmVlIHNldHRpbmcgY291bGQgbm90IGJlIG1v ZGlmaWVkIGF0IHRoYXQgdGltZS4gSSB0aGluayB3ZSBjb3VsZA0KbW9kaWZ5IHRoZSBkZXZpY2Ug dHJlZSBub3cgYmVjYXVzZSB0aGVyZSBubyBjbGllbnQgdXNlIGNtZHEgaW4gdXBzdHJlYW0uDQoN ClJlZ2FyZHMsDQpDSw0KDQo+IA0KPiBCaWJieQ0KPiA+IA0KPiA+ID4gKwljbWRxX3BrdF9jbGVh cl9ldmVudChtdGtfY3J0Y19zdGF0ZS0+Y21kcV9oYW5kbGUsDQo+ID4gPiArCQkJICAgICBtdGtf Y3J0Yy0+Y21kcV9ldmVudCk7DQo+ID4gPiArCWNtZHFfcGt0X3dmZShtdGtfY3J0Y19zdGF0ZS0+ Y21kcV9oYW5kbGUsIG10a19jcnRjLT5jbWRxX2V2ZW50KTsNCj4gPiA+ICt9DQo+ID4gPiArDQo+ ID4gPiArc3RhdGljIHZvaWQgbXRrX2NtZHFfcmVsZWFzZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMp DQo+ID4gPiArew0KPiA+ID4gKwlzdHJ1Y3QgbXRrX2NydGNfc3RhdGUgKm10a19jcnRjX3N0YXRl ID0NCj4gPiA+ICsJCQl0b19tdGtfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSk7DQo+ID4gPiArCXN0 cnVjdCBtdGtfY21kcV9jYl9kYXRhICpjYl9kYXRhOw0KPiA+ID4gKw0KPiA+ID4gKwljYl9kYXRh ID0ga21hbGxvYyhzaXplb2YoKmNiX2RhdGEpLCBHRlBfS0VSTkVMKTsNCj4gPiA+ICsJaWYgKCFj Yl9kYXRhKSB7DQo+ID4gPiArCQlEUk1fREVWX0VSUk9SKGNydGMtPmRldi0+ZGV2LCAiRmFpbGVk IHRvIGFsbG9jIGNiX2RhdGFcbiIpOw0KPiA+ID4gKwkJcmV0dXJuOw0KPiA+ID4gKwl9DQo+ID4g PiArDQo+ID4gPiArCWNiX2RhdGEtPmNtZHFfaGFuZGxlID0gbXRrX2NydGNfc3RhdGUtPmNtZHFf aGFuZGxlOw0KPiA+ID4gKwljbWRxX3BrdF9mbHVzaF9hc3luYyhtdGtfY3J0Y19zdGF0ZS0+Y21k cV9oYW5kbGUsDQo+ID4gPiArCQkJICAgICBkZHBfY21kcV9jYiwgY2JfZGF0YSk7DQo+ID4gPiAr fQ0KPiA+ID4gKyNlbmRpZg0KPiA+ID4gIHN0YXRpYyBpbnQgbXRrX2NydGNfZGRwX2h3X2luaXQo c3RydWN0IG10a19kcm1fY3J0YyAqbXRrX2NydGMpDQo+ID4gPiAgew0KPiA+ID4gIAlzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMgPSAmbXRrX2NydGMtPmJhc2U7DQo+ID4gPiBAQCAtMzgzLDcgKzQzMyw4 IEBAIHN0YXRpYyB2b2lkIG10a19jcnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRj KQ0KPiA+ID4gIAlpZiAoc3RhdGUtPnBlbmRpbmdfY29uZmlnKSB7DQo+ID4gPiAgCQltdGtfZGRw X2NvbXBfY29uZmlnKGNvbXAsIHN0YXRlLT5wZW5kaW5nX3dpZHRoLA0KPiA+ID4gIAkJCQkgICAg c3RhdGUtPnBlbmRpbmdfaGVpZ2h0LA0KPiA+ID4gLQkJCQkgICAgc3RhdGUtPnBlbmRpbmdfdnJl ZnJlc2gsIDAsIE5VTEwpOw0KPiA+ID4gKwkJCQkgICAgc3RhdGUtPnBlbmRpbmdfdnJlZnJlc2gs IDAsDQo+ID4gPiArCQkJCSAgICBzdGF0ZS0+Y21kcV9oYW5kbGUpOw0KPiA+ID4gIA0KPiA+ID4g IAkJc3RhdGUtPnBlbmRpbmdfY29uZmlnID0gZmFsc2U7DQo+ID4gPiAgCX0NCj4gPiA+IEBAIC00 MDMsNyArNDU0LDggQEAgc3RhdGljIHZvaWQgbXRrX2NydGNfZGRwX2NvbmZpZyhzdHJ1Y3QgZHJt X2NydGMgKmNydGMpDQo+ID4gPiAgDQo+ID4gPiAgCQkJaWYgKGNvbXApDQo+ID4gPiAgCQkJCW10 a19kZHBfY29tcF9sYXllcl9jb25maWcoY29tcCwgbG9jYWxfbGF5ZXIsDQo+ID4gPiAtCQkJCQkJ CSAgcGxhbmVfc3RhdGUsIE5VTEwpOw0KPiA+ID4gKwkJCQkJCQkgIHBsYW5lX3N0YXRlLA0KPiA+ ID4gKwkJCQkJCQkgIHN0YXRlLT5jbWRxX2hhbmRsZSk7DQo+ID4gPiAgCQkJcGxhbmVfc3RhdGUt PnBlbmRpbmcuY29uZmlnID0gZmFsc2U7DQo+ID4gPiAgCQl9DQo+ID4gPiAgCQltdGtfY3J0Yy0+ cGVuZGluZ19wbGFuZXMgPSBmYWxzZTsNCj4gPiA+IEBAIC00NTQsNiArNTA2LDEzIEBAIHZvaWQg bXRrX2RybV9jcnRjX2N1cnNvcl91cGRhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLCBzdHJ1Y3Qg ZHJtX3BsYW5lICpwbGFuZSwNCj4gPiA+ICAJCW10a19jcnRjX2RkcF9jb25maWcoY3J0Yyk7DQo+ ID4gPiAgCQltdGtfZGlzcF9tdXRleF9yZWxlYXNlKG10a19jcnRjLT5tdXRleCk7DQo+ID4gPiAg CX0NCj4gPiA+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ID4gPiArCWlmIChtdGtfY3J0Yy0+ Y21kcV9jbGllbnQpIHsNCj4gPiA+ICsJCW10a19jbWRxX2FjcXVpcmUoY3J0Yyk7DQo+ID4gPiAr CQltdGtfY3J0Y19kZHBfY29uZmlnKGNydGMpOw0KPiA+ID4gKwkJbXRrX2NtZHFfcmVsZWFzZShj cnRjKTsNCj4gPiA+ICsJfQ0KPiA+ID4gKyNlbmRpZg0KPiA+ID4gIAltdXRleF91bmxvY2soJnBy aXYtPmh3X2xvY2spOw0KPiA+ID4gIH0NCj4gPiA+ICANCj4gPiA+IEBAIC01NzAsNiArNjI5LDEz IEBAIHN0YXRpYyB2b2lkIG10a19kcm1fY3J0Y19hdG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRj ICpjcnRjLA0KPiA+ID4gIAkJbXRrX2NydGNfZGRwX2NvbmZpZyhjcnRjKTsNCj4gPiA+ICAJCW10 a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4gPiA+ICAJfQ0KPiA+ID4g KyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gPiA+ICsJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVu dCkgew0KPiA+ID4gKwkJbXRrX2NtZHFfYWNxdWlyZShjcnRjKTsNCj4gPiA+ICsJCW10a19jcnRj X2RkcF9jb25maWcoY3J0Yyk7DQo+ID4gPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiA+ ID4gKwl9DQo+ID4gPiArI2VuZGlmDQo+ID4gDQo+ID4gVGhpcyBwYXJ0IGlzIGFsbW9zdCB0aGUg c2FtZSBhcyB0aGUgb25lIGluIG10a19kcm1fY3J0Y19jdXJzb3JfdXBkYXRlKCksDQo+ID4gdHJ5 IHRvIG1lcmdlIHRoZW0uDQo+ID4gDQo+ID4gPiAgfQ0KPiA+ID4gIA0KPiA+ID4gIHN0YXRpYyBj b25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgbXRrX2NydGNfZnVuY3MgPSB7DQo+ID4gPiBAQCAt NjE5LDcgKzY4NSw3IEBAIHZvaWQgbXRrX2NydGNfZGRwX2lycShzdHJ1Y3QgZHJtX2NydGMgKmNy dGMsIHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXApDQo+ID4gPiAgCXN0cnVjdCBtdGtfZHJtX2Ny dGMgKm10a19jcnRjID0gdG9fbXRrX2NydGMoY3J0Yyk7DQo+ID4gPiAgCXN0cnVjdCBtdGtfZHJt X3ByaXZhdGUgKnByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOw0KPiA+ID4gIA0KPiA+ID4g LQlpZiAoIXByaXYtPmRhdGEtPnNoYWRvd19yZWdpc3RlcikNCj4gPiA+ICsJaWYgKCFwcml2LT5k YXRhLT5zaGFkb3dfcmVnaXN0ZXIgJiYgIW10a19jcnRjLT5jbWRxX2NsaWVudCkNCj4gPiA+ICAJ CW10a19jcnRjX2RkcF9jb25maWcoY3J0Yyk7DQo+ID4gPiAgDQo+ID4gPiAgCW10a19kcm1fZmlu aXNoX3BhZ2VfZmxpcChtdGtfY3J0Yyk7DQo+ID4gPiBAQCAtNzYxLDYgKzgyNywxOCBAQCBpbnQg bXRrX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiwNCj4gPiA+ICAJ ZHJtX21vZGVfY3J0Y19zZXRfZ2FtbWFfc2l6ZSgmbXRrX2NydGMtPmJhc2UsIE1US19MVVRfU0la RSk7DQo+ID4gPiAgCWRybV9jcnRjX2VuYWJsZV9jb2xvcl9tZ210KCZtdGtfY3J0Yy0+YmFzZSwg MCwgZmFsc2UsIE1US19MVVRfU0laRSk7DQo+ID4gPiAgCXByaXYtPm51bV9waXBlcysrOw0KPiA+ ID4gLQ0KPiA+ID4gKyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gPiA+ICsJbXRrX2NydGMtPmNt ZHFfY2xpZW50ID0NCj4gPiA+ICsJCQljbWRxX21ib3hfY3JlYXRlKGRldiwgZHJtX2NydGNfaW5k ZXgoJm10a19jcnRjLT5iYXNlKSwNCj4gPiA+ICsJCQkJCSAyMDAwKTsNCj4gPiA+ICsJb2ZfcHJv cGVydHlfcmVhZF91MzJfaW5kZXgoZGV2LT5vZl9ub2RlLCAibWVkaWF0ZWssZ2NlLWV2ZW50cyIs DQo+ID4gPiArCQkJCSAgIGRybV9jcnRjX2luZGV4KCZtdGtfY3J0Yy0+YmFzZSksDQo+ID4gPiAr CQkJCSAgICZtdGtfY3J0Yy0+Y21kcV9ldmVudCk7DQo+ID4gPiArCWlmIChJU19FUlIobXRrX2Ny dGMtPmNtZHFfY2xpZW50KSkgew0KPiA+ID4gKwkJZGV2X2RiZyhkZXYsICJtdGtfY3J0YyAlZCBm YWlsZWQgdG8gY3JlYXRlIG1haWxib3ggY2xpZW50LCB3cml0aW5nIHJlZ2lzdGVyIGJ5IENQVSBu b3dcbiIsDQo+ID4gPiArCQkJZHJtX2NydGNfaW5kZXgoJm10a19jcnRjLT5iYXNlKSk7DQo+ID4g PiArCQltdGtfY3J0Yy0+Y21kcV9jbGllbnQgPSBOVUxMOw0KPiA+ID4gKwl9DQo+ID4gPiArI2Vu ZGlmDQo+ID4gPiAgCXJldHVybiAwOw0KPiA+ID4gIH0NCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIGIvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYw0KPiA+ID4gaW5kZXggNmQwZjM0OWRkZjgyLi45 Y2MxMmFmMmJjMDYgMTAwNjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsv bXRrX2RybV9kZHBfY29tcC5jDQo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsv bXRrX2RybV9kZHBfY29tcC5jDQo+ID4gPiBAQCAtMzcwLDYgKzM3MCw5IEBAIGludCBtdGtfZGRw X2NvbXBfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSwN Cj4gPiA+ICAJCSAgICAgIGNvbnN0IHN0cnVjdCBtdGtfZGRwX2NvbXBfZnVuY3MgKmZ1bmNzKQ0K PiA+ID4gIHsNCj4gPiA+ICAJc3RydWN0IHBsYXRmb3JtX2RldmljZSAqY29tcF9wZGV2Ow0KPiA+ ID4gKwlzdHJ1Y3QgcmVzb3VyY2UgcmVzOw0KPiA+ID4gKwlzdHJ1Y3QgY21kcV9jbGllbnRfcmVn ICpjbWRxX3JlZzsNCj4gPiA+ICsJaW50IHJldCA9IDA7DQo+ID4gPiAgDQo+ID4gPiAgCWlmIChj b21wX2lkIDwgMCB8fCBjb21wX2lkID49IEREUF9DT01QT05FTlRfSURfTUFYKQ0KPiA+ID4gIAkJ cmV0dXJuIC1FSU5WQUw7DQo+ID4gPiBAQCAtNDA0LDYgKzQwNywzNCBAQCBpbnQgbXRrX2RkcF9j b21wX2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUsDQo+ ID4gPiAgCX0NCj4gPiA+ICAJY29tcC0+ZGV2ID0gJmNvbXBfcGRldi0+ZGV2Ow0KPiA+ID4gIA0K PiA+ID4gKyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gPiA+ICsJaWYgKG9mX2FkZHJlc3NfdG9f cmVzb3VyY2Uobm9kZSwgMCwgJnJlcykgIT0gMCkgew0KPiA+ID4gKwkJZGV2X2VycihkZXYsICJN aXNzaW5nIHJlZyBpbiAlcyBub2RlXG4iLA0KPiA+ID4gKwkJCW5vZGUtPmZ1bGxfbmFtZSk7DQo+ ID4gPiArCQlyZXR1cm4gLUVJTlZBTDsNCj4gPiA+ICsJfQ0KPiA+ID4gKwljb21wLT5yZWdzX3Bh ID0gcmVzLnN0YXJ0Ow0KPiA+ID4gKw0KPiA+ID4gKwljb21wX3BkZXYgPSBvZl9maW5kX2Rldmlj ZV9ieV9ub2RlKG5vZGUpOw0KPiA+ID4gKwlpZiAoIWNvbXBfcGRldikgew0KPiA+ID4gKwkJZGV2 X3dhcm4oZGV2LCAiV2FpdGluZyBmb3IgY29tcG9uZW50IGRldmljZSAlc1xuIiwNCj4gPiA+ICsJ CQkgbm9kZS0+ZnVsbF9uYW1lKTsNCj4gPiA+ICsJCXJldHVybiAtRVBST0JFX0RFRkVSOw0KPiA+ ID4gKwl9DQo+ID4gPiArDQo+ID4gPiArCWNtZHFfcmVnID0ga3phbGxvYyhzaXplb2YoKmNtZHFf cmVnKSwgR0ZQX0tFUk5FTCk7DQo+ID4gPiArCWlmICghY21kcV9yZWcpDQo+ID4gPiArCQlyZXR1 cm4gLUVJTlZBTDsNCj4gPiA+ICsNCj4gPiA+ICsJcmV0ID0gY21kcV9kZXZfZ2V0X2NsaWVudF9y ZWcoJmNvbXBfcGRldi0+ZGV2LCBjbWRxX3JlZywgMCk7DQo+ID4gPiArCWlmIChyZXQgIT0gMCkN Cj4gPiA+ICsJCWRldl9kYmcoJmNvbXBfcGRldi0+ZGV2LA0KPiA+ID4gKwkJCSJnZXQgbWVkaWF0 ZWssZ2NlLWNsaWVudC1yZWcgZmFpbCFcbiIpOw0KPiA+ID4gKwllbHNlDQo+ID4gPiArCQljb21w LT5zdWJzeXMgPSBjbWRxX3JlZy0+c3Vic3lzOw0KPiA+ID4gKw0KPiA+ID4gKwlrZnJlZShjbWRx X3JlZyk7DQo+ID4gPiArI2VuZGlmDQo+ID4gDQo+ID4gSSB3b3VsZCBsaWtlIHRvIG1vdmUgdGhp cyBwYXJ0IHRvIHRoZSBwYXRjaCAiZHJtL21lZGlhdGVrOiBzdXBwb3J0IENNRFENCj4gPiBpbnRl cmZhY2UgaW4gZGRwIGNvbXBvbmVudCIuDQo+ID4gDQo+ID4gUmVnYXJkcywNCj4gPiBDSw0KPiA+ IA0KPiA+ID4gIAlyZXR1cm4gMDsNCj4gPiA+ICB9DQo+ID4gPiAgDQo+ID4gDQo+ID4gDQo+IA0K PiANCg0K