From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 24 Jul 2018 14:38:44 +0000 Subject: Re: [PATCH] fbdev: Distinguish between interlaced and progressive modes Message-Id: <1576014.4cjCWdVE3G@amdc3058> List-Id: References: <1828178.vF6XXv5T2I@amdc3058> <20180704190846.GC2701@localhost.localdomain> In-Reply-To: <20180704190846.GC2701@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Fredrik Noring Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Maciej W. Rozycki" On Wednesday, July 04, 2018 09:08:48 PM Fredrik Noring wrote: > Hi Bartlomiej, > > > > With this change fb_find_mode can match interlaced and progressive > > > modes equally well, and distinguish between for example 1920x1080i > > > and 1920x1080p. > > > > > > Signed-off-by: Fredrik Noring > > > > Could you please give some examples of use cases that need this change > > (i.e. which fbdev drivers need it for which modes etc.)? > > I discovered the problem when developing a frame buffer driver for the > PlayStation 2 (not yet merged), using the following video modes for the > PlayStation 3 in drivers/video/fbdev/ps3fb.c: > > }, { > /* 1080if */ > "1080if", 50, 1920, 1080, 13468, 148, 484, 36, 4, 88, 5, > FB_SYNC_BROADCAST, FB_VMODE_INTERLACED > }, { > /* 1080pf */ > "1080pf", 50, 1920, 1080, 6734, 148, 484, 36, 4, 88, 5, > FB_SYNC_BROADCAST, FB_VMODE_NONINTERLACED > }, > > In ps3fb_probe, the mode_option module parameter is used with fb_find_mode > but it can only select the interlaced variant of 1920x1080 since the loop > matching the modes does not take the difference between interlaced and > progressive modes into account. > > In short, without the patch, progressive 1920x1080 cannot be chosen as a > mode_option parameter since fb_find_mode (falsely) thinks interlace is a > perfect match. Patch queued for 4.19 (with the above explanation used as patch description), thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] fbdev: Distinguish between interlaced and progressive modes Date: Tue, 24 Jul 2018 16:38:44 +0200 Message-ID: <1576014.4cjCWdVE3G@amdc3058> References: <1828178.vF6XXv5T2I@amdc3058> <20180704190846.GC2701@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFFEE6E0CA for ; Tue, 24 Jul 2018 14:38:48 +0000 (UTC) In-reply-to: <20180704190846.GC2701@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fredrik Noring Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Maciej W. Rozycki" List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCBKdWx5IDA0LCAyMDE4IDA5OjA4OjQ4IFBNIEZyZWRyaWsgTm9yaW5nIHdy b3RlOgo+IEhpIEJhcnRsb21pZWosCj4gCj4gPiA+IFdpdGggdGhpcyBjaGFuZ2UgZmJfZmluZF9t b2RlIGNhbiBtYXRjaCBpbnRlcmxhY2VkIGFuZCBwcm9ncmVzc2l2ZQo+ID4gPiBtb2RlcyBlcXVh bGx5IHdlbGwsIGFuZCBkaXN0aW5ndWlzaCBiZXR3ZWVuIGZvciBleGFtcGxlIDE5MjB4MTA4MGkK PiA+ID4gYW5kIDE5MjB4MTA4MHAuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBGcmVkcmlr IE5vcmluZyA8bm9yaW5nQG5vY3Jldy5vcmc+Cj4gPiAKPiA+IENvdWxkIHlvdSBwbGVhc2UgZ2l2 ZSBzb21lIGV4YW1wbGVzIG9mIHVzZSBjYXNlcyB0aGF0IG5lZWQgdGhpcyBjaGFuZ2UKPiA+IChp LmUuIHdoaWNoIGZiZGV2IGRyaXZlcnMgbmVlZCBpdCBmb3Igd2hpY2ggbW9kZXMgZXRjLik/Cj4g Cj4gSSBkaXNjb3ZlcmVkIHRoZSBwcm9ibGVtIHdoZW4gZGV2ZWxvcGluZyBhIGZyYW1lIGJ1ZmZl ciBkcml2ZXIgZm9yIHRoZQo+IFBsYXlTdGF0aW9uIDIgKG5vdCB5ZXQgbWVyZ2VkKSwgdXNpbmcg dGhlIGZvbGxvd2luZyB2aWRlbyBtb2RlcyBmb3IgdGhlCj4gUGxheVN0YXRpb24gMyBpbiBkcml2 ZXJzL3ZpZGVvL2ZiZGV2L3BzM2ZiLmM6Cj4gCj4gICAgIH0sIHsKPiAJLyogMTA4MGlmICovCj4g CSIxMDgwaWYiLCA1MCwgMTkyMCwgMTA4MCwgMTM0NjgsIDE0OCwgNDg0LCAzNiwgNCwgODgsIDUs Cj4gCUZCX1NZTkNfQlJPQURDQVNULCBGQl9WTU9ERV9JTlRFUkxBQ0VECj4gICAgIH0sIHsKPiAJ LyogMTA4MHBmICovCj4gCSIxMDgwcGYiLCA1MCwgMTkyMCwgMTA4MCwgNjczNCwgMTQ4LCA0ODQs IDM2LCA0LCA4OCwgNSwKPiAJRkJfU1lOQ19CUk9BRENBU1QsIEZCX1ZNT0RFX05PTklOVEVSTEFD RUQKPiAgICAgfSwKPiAKPiBJbiBwczNmYl9wcm9iZSwgdGhlIG1vZGVfb3B0aW9uIG1vZHVsZSBw YXJhbWV0ZXIgaXMgdXNlZCB3aXRoIGZiX2ZpbmRfbW9kZQo+IGJ1dCBpdCBjYW4gb25seSBzZWxl Y3QgdGhlIGludGVybGFjZWQgdmFyaWFudCBvZiAxOTIweDEwODAgc2luY2UgdGhlIGxvb3AKPiBt YXRjaGluZyB0aGUgbW9kZXMgZG9lcyBub3QgdGFrZSB0aGUgZGlmZmVyZW5jZSBiZXR3ZWVuIGlu dGVybGFjZWQgYW5kCj4gcHJvZ3Jlc3NpdmUgbW9kZXMgaW50byBhY2NvdW50Lgo+IAo+IEluIHNo b3J0LCB3aXRob3V0IHRoZSBwYXRjaCwgcHJvZ3Jlc3NpdmUgMTkyMHgxMDgwIGNhbm5vdCBiZSBj aG9zZW4gYXMgYQo+IG1vZGVfb3B0aW9uIHBhcmFtZXRlciBzaW5jZSBmYl9maW5kX21vZGUgKGZh bHNlbHkpIHRoaW5rcyBpbnRlcmxhY2UgaXMgYQo+IHBlcmZlY3QgbWF0Y2guCgpQYXRjaCBxdWV1 ZWQgZm9yIDQuMTkgKHdpdGggdGhlIGFib3ZlIGV4cGxhbmF0aW9uIHVzZWQgYXMgcGF0Y2ggZGVz Y3JpcHRpb24pLAp0aGFua3MhCgpCZXN0IHJlZ2FyZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtp ZXdpY3oKU2Ftc3VuZyBSJkQgSW5zdGl0dXRlIFBvbGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK