All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons
Date: Mon, 21 Aug 2017 09:51:30 -0400 (EDT)	[thread overview]
Message-ID: <1576327362.1079876.1503323490461.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1503321812.26016.19.camel@redhat.com>

Hi

----- Original Message -----
> On Wed, 2017-08-09 at 00:47 +0200, Marc-André Lureau wrote:
> > qemu uses wheel-up/down button events for mouse wheel input, however
> > linux applications typically want REL_WHEEL events.
> 
> --verbose please.
> 
> Both should work just fine.

I haven't done extensive review of all input code on linux, but from what I remember the event got dropped here:

https://cgit.freedesktop.org/xorg/driver/xf86-input-evdev/tree/src/evdev.c#n2720

It seems BTN_GEAR isn't clearly defined either.

Perhaps libinput does a better job at mapping the event, but we should consider older guests. Spice agent is using rel-wheel events, and we never had issues with it.

thanks

  reply	other threads:[~2017-08-21 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 22:47 [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons Marc-André Lureau
2017-08-09  2:33 ` Michael S. Tsirkin
2017-08-21 13:27   ` Gerd Hoffmann
2017-08-21 13:23 ` Gerd Hoffmann
2017-08-21 13:51   ` Marc-André Lureau [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-23 13:51 Gerd Hoffmann
2017-08-23 14:38 ` Marc-André Lureau
2017-08-23 14:49   ` Gerd Hoffmann
2017-08-29  7:48 ` Ladi Prosek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1576327362.1079876.1503323490461.JavaMail.zimbra@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.