From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC07C43603 for ; Fri, 20 Dec 2019 08:28:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EE1E227BF for ; Fri, 20 Dec 2019 08:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bUrfNKe5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="s2UOmCDx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EE1E227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DDu5KeOvyf1cN4Q0Q7iAwrAPOHMcMze6fX5mApDLNnY=; b=bUrfNKe5AdSjlU du97FrXNeLpCXc0Jqf27rOOImqLUKWdjWPSky8M4lQu8CO1MyiNZozb5YBaPPkRw7v+cnZcrhoRUi bFpS+3JrQE0EILO1++bncXDEPG7RnAMLz3z2D0iLmqbPVPSq1GULVrjZE0w03v6QlRLeWMeLYp4Oq Ie4Ekm+nfJlh0FBLkBT6CYeVciSOgqZWblBO+Xje+JoAQUYg4v1Xt1StxEM2LjtZD4bpKBHLROBQt 3eZLrt+LIovirzx02wiVhPcXfQdS78NMdcUG/QkLAaqpZBkZ27R6B7IHY91M1dVXaPAD9IE1sFwt9 FmwMet20vEpIqnGV9bGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiDeQ-0003YA-Di; Fri, 20 Dec 2019 08:28:46 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiDe9-0003K5-CC; Fri, 20 Dec 2019 08:28:31 +0000 X-UUID: a319e5c97b19494293368a13f70d25b3-20191220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2fvqpXZ4f+f8Am+74fysA+SXl4Y8KX7VvKLUjOFoqG0=; b=s2UOmCDxarzcVbKJicgl9WQddBKO1XD3I5dKz8Kv/gCpn685W0zCUWxqUj9ZQ3sV6mRrW1pWyZ6PMDgf5xr34SbJWyXbMnK/nzqQ7ERlXNd5SgU+cbl6ZdGNYcI87+5EfKcWoMoNfc6eIkTVtV1t9XyGkTMIx1pZbgMMwMlo440=; X-UUID: a319e5c97b19494293368a13f70d25b3-20191220 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 233265706; Fri, 20 Dec 2019 00:28:19 -0800 Received: from mtkmbs08n1.mediatek.inc (172.21.101.55) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 20 Dec 2019 00:28:43 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 20 Dec 2019 16:28:24 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 20 Dec 2019 16:28:14 +0800 Message-ID: <1576830496.22904.1.camel@mtksdaap41> Subject: Re: [PATCH v5 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM From: CK Hu To: Bibby Hsieh Date: Fri, 20 Dec 2019 16:28:16 +0800 In-Reply-To: <20191210050526.4437-1-bibby.hsieh@mediatek.com> References: <20191210050526.4437-1-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191220_002829_449529_53E6E1F6 X-CRM114-Status: GOOD ( 14.67 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: For this series, applied to mediatek-drm-next-5.6 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.6 Regards, CK On Tue, 2019-12-10 at 13:05 +0800, Bibby Hsieh wrote: > The CMDQ (Command Queue) in MT8183 is used to help update all > relevant display controller registers with critical time limation. > This patch add cmdq interface in ddp_comp interface, let all > ddp_comp interface can support cpu/cmdq function at the same time. > > These patches also can fixup cursor moving is not smooth > when heavy load in webgl. > > This patch depends on ptach: > add drm support for MT8183 > (https://patchwork.kernel.org/cover/11121519/) > support gce on mt8183 platform > (https://patchwork.kernel.org/cover/11255147/) > drm/mediatek: Check return value of mtk_drm_ddp_comp_for_plane > (https://lore.kernel.org/patchwork/patch/1154517/) > > Changes since v4: > - rebase to Linux 5.5-rc1 > - add fixes tag > > Changes since v3: > - remove redundant code and variable > > Changes since v2: > - move some changes to another patch > - disable layer in atomic_disable() > > Changes since v1: > - remove redundant code > - merge the duplicate code > - use async instead of cursor > > Changes since v0: > - remove redundant code > - remove patch > "drm/mediatek: fix atomic_state reference counting" > After remove this patch, the issue we met before is gone. > So I do not add any extra code to do something. > > Bibby Hsieh (7): > drm/mediatek: use DRM core's atomic commit helper > drm/mediatek: handle events when enabling/disabling crtc > drm/mediatek: update cursors by using async atomic update > drm/mediatek: disable all the planes in atomic_disable > drm/mediatek: remove unused external function > drm/mediatek: support CMDQ interface in ddp component > drm/mediatek: apply CMDQ control flow > > drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 67 ++++---- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 43 ++--- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 165 ++++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 131 ++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 47 +++--- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 +--------- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7 - > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 47 ++++++ > drivers/gpu/drm/mediatek/mtk_drm_plane.h | 2 + > 11 files changed, 380 insertions(+), 224 deletions(-) > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A21DDC43603 for ; Fri, 20 Dec 2019 08:28:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75C3724680 for ; Fri, 20 Dec 2019 08:28:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ThzRhSch"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="s2UOmCDx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75C3724680 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aAKlZnNoqphOWc1wyVeJ6l56MmdHwO0c24rMpdB23c8=; b=ThzRhSchmRoSkS ckRjdv4y+TJJF+erEEYdPFrgWoGSJWauV51zU9c0Um22ZES9V2xvIPbJBBMKhHEJ5Hrmol8m2hKKE HLJcseQubdefdGSZBUqHFBYaRtyIkL/Xx2x+fC6x+U5a82mD0SWsTJhpdKqhvA5kRB3jKtI+G+THi iXa73YHpS88xDRYNKZiPfp3XF0hPEjhA9akzGCVUfkS6QkUU50RLKl0wyWvdUKuYJELk1axMHnTE8 sqqiRoShBPPYi+Gs3m4a7VvO8HKpEi+TLKAxD2EcMw99jcW02drqHFNFXiPEkmlnGM5gmG7iKQ5US FXSerjpOAf50NifiCmIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiDeE-0003N8-Ed; Fri, 20 Dec 2019 08:28:34 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiDe9-0003K5-CC; Fri, 20 Dec 2019 08:28:31 +0000 X-UUID: a319e5c97b19494293368a13f70d25b3-20191220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2fvqpXZ4f+f8Am+74fysA+SXl4Y8KX7VvKLUjOFoqG0=; b=s2UOmCDxarzcVbKJicgl9WQddBKO1XD3I5dKz8Kv/gCpn685W0zCUWxqUj9ZQ3sV6mRrW1pWyZ6PMDgf5xr34SbJWyXbMnK/nzqQ7ERlXNd5SgU+cbl6ZdGNYcI87+5EfKcWoMoNfc6eIkTVtV1t9XyGkTMIx1pZbgMMwMlo440=; X-UUID: a319e5c97b19494293368a13f70d25b3-20191220 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 233265706; Fri, 20 Dec 2019 00:28:19 -0800 Received: from mtkmbs08n1.mediatek.inc (172.21.101.55) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 20 Dec 2019 00:28:43 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 20 Dec 2019 16:28:24 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 20 Dec 2019 16:28:14 +0800 Message-ID: <1576830496.22904.1.camel@mtksdaap41> Subject: Re: [PATCH v5 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM From: CK Hu To: Bibby Hsieh Date: Fri, 20 Dec 2019 16:28:16 +0800 In-Reply-To: <20191210050526.4437-1-bibby.hsieh@mediatek.com> References: <20191210050526.4437-1-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191220_002829_449529_53E6E1F6 X-CRM114-Status: GOOD ( 14.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, YT Shen , Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: For this series, applied to mediatek-drm-next-5.6 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.6 Regards, CK On Tue, 2019-12-10 at 13:05 +0800, Bibby Hsieh wrote: > The CMDQ (Command Queue) in MT8183 is used to help update all > relevant display controller registers with critical time limation. > This patch add cmdq interface in ddp_comp interface, let all > ddp_comp interface can support cpu/cmdq function at the same time. > > These patches also can fixup cursor moving is not smooth > when heavy load in webgl. > > This patch depends on ptach: > add drm support for MT8183 > (https://patchwork.kernel.org/cover/11121519/) > support gce on mt8183 platform > (https://patchwork.kernel.org/cover/11255147/) > drm/mediatek: Check return value of mtk_drm_ddp_comp_for_plane > (https://lore.kernel.org/patchwork/patch/1154517/) > > Changes since v4: > - rebase to Linux 5.5-rc1 > - add fixes tag > > Changes since v3: > - remove redundant code and variable > > Changes since v2: > - move some changes to another patch > - disable layer in atomic_disable() > > Changes since v1: > - remove redundant code > - merge the duplicate code > - use async instead of cursor > > Changes since v0: > - remove redundant code > - remove patch > "drm/mediatek: fix atomic_state reference counting" > After remove this patch, the issue we met before is gone. > So I do not add any extra code to do something. > > Bibby Hsieh (7): > drm/mediatek: use DRM core's atomic commit helper > drm/mediatek: handle events when enabling/disabling crtc > drm/mediatek: update cursors by using async atomic update > drm/mediatek: disable all the planes in atomic_disable > drm/mediatek: remove unused external function > drm/mediatek: support CMDQ interface in ddp component > drm/mediatek: apply CMDQ control flow > > drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 67 ++++---- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 43 ++--- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 165 ++++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 131 ++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 47 +++--- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 +--------- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7 - > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 47 ++++++ > drivers/gpu/drm/mediatek/mtk_drm_plane.h | 2 + > 11 files changed, 380 insertions(+), 224 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D1EC43603 for ; Fri, 20 Dec 2019 08:28:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 044D824680 for ; Fri, 20 Dec 2019 08:28:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="s2UOmCDx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 044D824680 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71E246EBE6; Fri, 20 Dec 2019 08:28:24 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id C26CD6EBE6 for ; Fri, 20 Dec 2019 08:28:22 +0000 (UTC) X-UUID: c65f143ada1c46afac0f06d2010f4ee7-20191220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2fvqpXZ4f+f8Am+74fysA+SXl4Y8KX7VvKLUjOFoqG0=; b=s2UOmCDxarzcVbKJicgl9WQddBKO1XD3I5dKz8Kv/gCpn685W0zCUWxqUj9ZQ3sV6mRrW1pWyZ6PMDgf5xr34SbJWyXbMnK/nzqQ7ERlXNd5SgU+cbl6ZdGNYcI87+5EfKcWoMoNfc6eIkTVtV1t9XyGkTMIx1pZbgMMwMlo440=; X-UUID: c65f143ada1c46afac0f06d2010f4ee7-20191220 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1412223534; Fri, 20 Dec 2019 16:28:18 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 20 Dec 2019 16:28:24 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 20 Dec 2019 16:28:14 +0800 Message-ID: <1576830496.22904.1.camel@mtksdaap41> Subject: Re: [PATCH v5 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM From: CK Hu To: Bibby Hsieh Date: Fri, 20 Dec 2019 16:28:16 +0800 In-Reply-To: <20191210050526.4437-1-bibby.hsieh@mediatek.com> References: <20191210050526.4437-1-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Bibby: For this series, applied to mediatek-drm-next-5.6 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.6 Regards, CK On Tue, 2019-12-10 at 13:05 +0800, Bibby Hsieh wrote: > The CMDQ (Command Queue) in MT8183 is used to help update all > relevant display controller registers with critical time limation. > This patch add cmdq interface in ddp_comp interface, let all > ddp_comp interface can support cpu/cmdq function at the same time. > > These patches also can fixup cursor moving is not smooth > when heavy load in webgl. > > This patch depends on ptach: > add drm support for MT8183 > (https://patchwork.kernel.org/cover/11121519/) > support gce on mt8183 platform > (https://patchwork.kernel.org/cover/11255147/) > drm/mediatek: Check return value of mtk_drm_ddp_comp_for_plane > (https://lore.kernel.org/patchwork/patch/1154517/) > > Changes since v4: > - rebase to Linux 5.5-rc1 > - add fixes tag > > Changes since v3: > - remove redundant code and variable > > Changes since v2: > - move some changes to another patch > - disable layer in atomic_disable() > > Changes since v1: > - remove redundant code > - merge the duplicate code > - use async instead of cursor > > Changes since v0: > - remove redundant code > - remove patch > "drm/mediatek: fix atomic_state reference counting" > After remove this patch, the issue we met before is gone. > So I do not add any extra code to do something. > > Bibby Hsieh (7): > drm/mediatek: use DRM core's atomic commit helper > drm/mediatek: handle events when enabling/disabling crtc > drm/mediatek: update cursors by using async atomic update > drm/mediatek: disable all the planes in atomic_disable > drm/mediatek: remove unused external function > drm/mediatek: support CMDQ interface in ddp component > drm/mediatek: apply CMDQ control flow > > drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 67 ++++---- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 43 ++--- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 165 ++++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 131 ++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 47 +++--- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 +--------- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 7 - > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 47 ++++++ > drivers/gpu/drm/mediatek/mtk_drm_plane.h | 2 + > 11 files changed, 380 insertions(+), 224 deletions(-) > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63770C2D0D2 for ; Fri, 20 Dec 2019 08:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31B1424680 for ; Fri, 20 Dec 2019 08:28:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="s2UOmCDx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727231AbfLTI2Z (ORCPT ); Fri, 20 Dec 2019 03:28:25 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:25378 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725941AbfLTI2Y (ORCPT ); Fri, 20 Dec 2019 03:28:24 -0500 X-UUID: c65f143ada1c46afac0f06d2010f4ee7-20191220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2fvqpXZ4f+f8Am+74fysA+SXl4Y8KX7VvKLUjOFoqG0=; b=s2UOmCDxarzcVbKJicgl9WQddBKO1XD3I5dKz8Kv/gCpn685W0zCUWxqUj9ZQ3sV6mRrW1pWyZ6PMDgf5xr34SbJWyXbMnK/nzqQ7ERlXNd5SgU+cbl6ZdGNYcI87+5EfKcWoMoNfc6eIkTVtV1t9XyGkTMIx1pZbgMMwMlo440=; X-UUID: c65f143ada1c46afac0f06d2010f4ee7-20191220 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1412223534; Fri, 20 Dec 2019 16:28:18 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 20 Dec 2019 16:28:24 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 20 Dec 2019 16:28:14 +0800 Message-ID: <1576830496.22904.1.camel@mtksdaap41> Subject: Re: [PATCH v5 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Philipp Zabel , YT Shen , Thierry Reding , , , , , Date: Fri, 20 Dec 2019 16:28:16 +0800 In-Reply-To: <20191210050526.4437-1-bibby.hsieh@mediatek.com> References: <20191210050526.4437-1-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIEJpYmJ5Og0KDQpGb3IgdGhpcyBzZXJpZXMsIGFwcGxpZWQgdG8gbWVkaWF0ZWstZHJtLW5l eHQtNS42IFsxXSwgdGhhbmtzLg0KDQpbMV0NCmh0dHBzOi8vZ2l0aHViLmNvbS9ja2h1LW1lZGlh dGVrL2xpbnV4LmdpdC10YWdzL2NvbW1pdHMvbWVkaWF0ZWstZHJtLW5leHQtNS42DQoNClJlZ2Fy ZHMsDQpDSw0KDQpPbiBUdWUsIDIwMTktMTItMTAgYXQgMTM6MDUgKzA4MDAsIEJpYmJ5IEhzaWVo IHdyb3RlOg0KPiBUaGUgQ01EUSAoQ29tbWFuZCBRdWV1ZSkgaW4gTVQ4MTgzIGlzIHVzZWQgdG8g aGVscCB1cGRhdGUgYWxsDQo+IHJlbGV2YW50IGRpc3BsYXkgY29udHJvbGxlciByZWdpc3RlcnMg d2l0aCBjcml0aWNhbCB0aW1lIGxpbWF0aW9uLg0KPiBUaGlzIHBhdGNoIGFkZCBjbWRxIGludGVy ZmFjZSBpbiBkZHBfY29tcCBpbnRlcmZhY2UsIGxldCBhbGwNCj4gZGRwX2NvbXAgaW50ZXJmYWNl IGNhbiBzdXBwb3J0IGNwdS9jbWRxIGZ1bmN0aW9uIGF0IHRoZSBzYW1lIHRpbWUuDQo+IA0KPiBU aGVzZSBwYXRjaGVzIGFsc28gY2FuIGZpeHVwIGN1cnNvciBtb3ZpbmcgaXMgbm90IHNtb290aA0K PiB3aGVuIGhlYXZ5IGxvYWQgaW4gd2ViZ2wuDQo+IA0KPiBUaGlzIHBhdGNoIGRlcGVuZHMgb24g cHRhY2g6DQo+IGFkZCBkcm0gc3VwcG9ydCBmb3IgTVQ4MTgzDQo+IChodHRwczovL3BhdGNod29y ay5rZXJuZWwub3JnL2NvdmVyLzExMTIxNTE5LykNCj4gc3VwcG9ydCBnY2Ugb24gbXQ4MTgzIHBs YXRmb3JtDQo+IChodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL2NvdmVyLzExMjU1MTQ3LykN Cj4gZHJtL21lZGlhdGVrOiBDaGVjayByZXR1cm4gdmFsdWUgb2YgbXRrX2RybV9kZHBfY29tcF9m b3JfcGxhbmUNCj4gKGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3BhdGNod29yay9wYXRjaC8xMTU0 NTE3LykNCj4gDQo+IENoYW5nZXMgc2luY2UgdjQ6DQo+ICAtIHJlYmFzZSB0byBMaW51eCA1LjUt cmMxDQo+ICAtIGFkZCBmaXhlcyB0YWcNCj4gDQo+IENoYW5nZXMgc2luY2UgdjM6DQo+ICAtIHJl bW92ZSByZWR1bmRhbnQgY29kZSBhbmQgdmFyaWFibGUNCj4gDQo+IENoYW5nZXMgc2luY2UgdjI6 DQo+ICAtIG1vdmUgc29tZSBjaGFuZ2VzIHRvIGFub3RoZXIgcGF0Y2gNCj4gIC0gZGlzYWJsZSBs YXllciBpbiBhdG9taWNfZGlzYWJsZSgpDQo+IA0KPiBDaGFuZ2VzIHNpbmNlIHYxOg0KPiAgLSBy ZW1vdmUgcmVkdW5kYW50IGNvZGUNCj4gIC0gbWVyZ2UgdGhlIGR1cGxpY2F0ZSBjb2RlDQo+ICAt IHVzZSBhc3luYyBpbnN0ZWFkIG9mIGN1cnNvcg0KPiANCj4gQ2hhbmdlcyBzaW5jZSB2MDoNCj4g IC0gcmVtb3ZlIHJlZHVuZGFudCBjb2RlDQo+ICAtIHJlbW92ZSBwYXRjaA0KPiAgICAiZHJtL21l ZGlhdGVrOiBmaXggYXRvbWljX3N0YXRlIHJlZmVyZW5jZSBjb3VudGluZyINCj4gICAgQWZ0ZXIg cmVtb3ZlIHRoaXMgcGF0Y2gsIHRoZSBpc3N1ZSB3ZSBtZXQgYmVmb3JlIGlzIGdvbmUuDQo+ICAg IFNvIEkgZG8gbm90IGFkZCBhbnkgZXh0cmEgY29kZSB0byBkbyBzb21ldGhpbmcuDQo+IA0KPiBC aWJieSBIc2llaCAoNyk6DQo+ICAgZHJtL21lZGlhdGVrOiB1c2UgRFJNIGNvcmUncyBhdG9taWMg Y29tbWl0IGhlbHBlcg0KPiAgIGRybS9tZWRpYXRlazogaGFuZGxlIGV2ZW50cyB3aGVuIGVuYWJs aW5nL2Rpc2FibGluZyBjcnRjDQo+ICAgZHJtL21lZGlhdGVrOiB1cGRhdGUgY3Vyc29ycyBieSB1 c2luZyBhc3luYyBhdG9taWMgdXBkYXRlDQo+ICAgZHJtL21lZGlhdGVrOiBkaXNhYmxlIGFsbCB0 aGUgcGxhbmVzIGluIGF0b21pY19kaXNhYmxlDQo+ICAgZHJtL21lZGlhdGVrOiByZW1vdmUgdW51 c2VkIGV4dGVybmFsIGZ1bmN0aW9uDQo+ICAgZHJtL21lZGlhdGVrOiBzdXBwb3J0IENNRFEgaW50 ZXJmYWNlIGluIGRkcCBjb21wb25lbnQNCj4gICBkcm0vbWVkaWF0ZWs6IGFwcGx5IENNRFEgY29u dHJvbCBmbG93DQo+IA0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX2NvbG9y LmMgICB8ICAgNyArLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX292bC5j ICAgICB8ICA2NyArKysrLS0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNw X3JkbWEuYyAgICB8ICA0MyArKy0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19k cm1fY3J0Yy5jICAgICB8IDE2NSArKysrKysrKysrKysrKysrLS0tLQ0KPiAgZHJpdmVycy9ncHUv ZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5oICAgICB8ICAgMiArDQo+ICBkcml2ZXJzL2dwdS9k cm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIHwgMTMxICsrKysrKysrKysrKy0tLS0NCj4g IGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmggfCAgNDcgKysrLS0t DQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyAgICAgIHwgIDg2ICst LS0tLS0tLS0NCj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oICAgICAg fCAgIDcgLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fcGxhbmUuYyAgICB8 ICA0NyArKysrKysNCj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX3BsYW5lLmgg ICAgfCAgIDIgKw0KPiAgMTEgZmlsZXMgY2hhbmdlZCwgMzgwIGluc2VydGlvbnMoKyksIDIyNCBk ZWxldGlvbnMoLSkNCj4gDQoNCg==