Re: [meta-virtualization][PATCH 2/2] libvirt: add json-c for driver_qemu

[Hongxu Jia <hongxu.jia@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 5901 bytes --]

On 2/10/25 12:20, Bruce Ashfield wrote:
> **
> *CAUTION: This email comes from a non Wind River email account!*
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
>
>
> On Sun, Feb 9, 2025 at 9:46 PM hongxu via lists.yoctoproject.org 
> <https://urldefense.com/v3/__http://lists.yoctoproject.org__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PMDAuGVu$> 
> <hongxu.jia=eng.windriver.com@lists.yoctoproject.org> wrote:
>
>     After upstreamm applied commit [meson: switch checks to depend on
>     json-c as well
>     as yajl][1], json-c is required to build QEMU driver. Otherwise
>     build libvirt
>     failed at do_configure
>
>     $ bitbake libvirt
>
>
> Again, you have something different in your environment.
>
> I can build the qemu driver just fine in my configuration.
>
> % bitbake-getvar -r libvirt PACKAGECONFIG
> PACKAGECONFIG="gnutls qemu openvz vmware vbox esx lxc test remote     
>      libvirtd netcf udev python fuse firewalld libpcap                 
>                        libxl                                     "
>
> % bitbake libvirt
>
> .. works. Since qemu is in the default PACAKGECONFIG, you can be 
> assured that it was built before the updates were pushed. So we need 
> to understand what is different.
>
I could reproduce the issue via latest poky + meta-virtualization + 
meta-openembedded on master branch

I guess the indirect dependence on json-c was introduced by libvirt in 
your build, you could use the following way:
...
$ bitbake libvirt -g
$ grep 'json-c.do_populate_sysroot' task-depends.dot
"libvirt.do_prepare_recipe_sysroot" -> "json-c.do_populate_sysroot"

...

//Hongxu


> Bruce
>
>     ...
>     ../git/meson.build
>     <https://urldefense.com/v3/__http://meson.build__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PNpRPhQx$>:1672:6:
>     ERROR: Problem encountered: json-c is required to build QEMU driver
>     ...
>
>     [1]
>     https://github.com/libvirt/libvirt/commit/28c987263980afc5b606a36a8d264b68cb01e9b9
>     <https://urldefense.com/v3/__https://github.com/libvirt/libvirt/commit/28c987263980afc5b606a36a8d264b68cb01e9b9__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PM9XJ8xI$>
>
>     Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>     ---
>      recipes-extended/libvirt/libvirt_git.bb
>     <https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PAQ2L6XF$>
>     | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/recipes-extended/libvirt/libvirt_git.bb
>     <https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PAQ2L6XF$>
>     b/recipes-extended/libvirt/libvirt_git.bb
>     <https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PAQ2L6XF$>
>     index 432b5da8..6a524977 100644
>     --- a/recipes-extended/libvirt/libvirt_git.bb
>     <https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PAQ2L6XF$>
>     +++ b/recipes-extended/libvirt/libvirt_git.bb
>     <https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PAQ2L6XF$>
>     @@ -149,7 +149,7 @@ PACKAGECONFIG:remove:armeb = "numactl"
>      # enable,disable,depends,rdepends
>      #
>      PACKAGECONFIG[gnutls] = ",,,gnutls-bin"
>     -PACKAGECONFIG[qemu] = "-Ddriver_qemu=enabled -Dqemu_user=qemu
>     -Dqemu_group=qemu,-Ddriver_qemu=disabled,qemu,"
>     +PACKAGECONFIG[qemu] = "-Ddriver_qemu=enabled -Dqemu_user=qemu
>     -Dqemu_group=qemu,-Ddriver_qemu=disabled,qemu json-c,"
>      PACKAGECONFIG[libxl] =
>     "-Ddriver_libxl=enabled,-Ddriver_libxl=disabled,xen,"
>      PACKAGECONFIG[openvz] =
>     "-Ddriver_openvz=enabled,-Ddriver_openvz=disabled,,"
>      PACKAGECONFIG[vmware] =
>     "-Ddriver_vmware=enabled,-Ddriver_vmware=disabled,,"
>     -- 
>     2.34.1
>
>
>     -=-=-=-=-=-=-=-=-=-=-=-
>     Links: You receive all messages sent to this group.
>     View/Reply Online (#9126):
>     https://lists.yoctoproject.org/g/meta-virtualization/message/9126
>     <https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-virtualization/message/9126__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PA0WULUO$>
>     Mute This Topic:
>     https://lists.yoctoproject.org/mt/111096111/1050810
>     <https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/111096111/1050810__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8POZMZ3Ee$>
>     Group Owner: meta-virtualization+owner@lists.yoctoproject.org
>     <mailto:meta-virtualization%2Bowner@lists.yoctoproject.org>
>     Unsubscribe:
>     https://lists.yoctoproject.org/g/meta-virtualization/unsub
>     <https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-virtualization/unsub__;!!AjveYdw8EvQ!cPpr-DjHYfzJqX_LYWzEvY1mwQJ-G1IXdk2hVRfMDxX7pALdstjYYfoYnGDw_IAIMO6NLiFKyNjs6Orjo_-g-6d8PMOFfCu6$>
>     [bruce.ashfield@gmail.com]
>     -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
> -- 
> - Thou shalt not follow the NULL pointer, for chaos and madness await 
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>

[-- Attachment #2: Type: text/html, Size: 11715 bytes --]