From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5ECC2D0C3 for ; Sat, 28 Dec 2019 02:54:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CC1A207E0 for ; Sat, 28 Dec 2019 02:54:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lkBKh3mT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Xqb8qm4V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CC1A207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sqsXZx2+im6hNUi2LF+db9Vh6JFoc4llXI7HDohk8Nw=; b=lkBKh3mTB+78lY uds7VuwGwoBAfrGIqST+FEfJ1pi0tvFIOStj+zoKE4APTa1eskVh31fWL2OwH22kyXo/YfmRaaAaX y3dDpsAbU92Kccud9ZGqDQQW1uW+0YgDDQo1FfOTsTyp5XeANQetuT5WOXuwPLvFJ9rlgphGcB4U8 S2ZtKNq2yO/mNffNhsVJjyzcJn2RJdiGVb0oTlwRyCNtTorVD/a1z3S/12+WvskJZlPfj+gHFWHPY c0oWCwOoomY/IGh8VZsb8TlbPHUuXT792j7jbJkGlAGFgf2F5CjILkvWCatUWEJ3sd24aH+NSbzf9 WadKx15PW2XU4c6/13wg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1il2FQ-0007Kj-Dy; Sat, 28 Dec 2019 02:54:36 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1il2FE-0007BA-K7; Sat, 28 Dec 2019 02:54:25 +0000 X-UUID: 8f72a633fe8e4b2c964a2f6bb7712a5d-20191227 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DuK72F7gBZXvEYq3y3vW4ZuOMFEZduG7ni5TClqn+Jw=; b=Xqb8qm4VIFCwJy9or7rS3RLV8gGOtdoZSvTFnFmjX0rcv8HHXjTmhsDuT6K4czVKSUes1e5HDS62BaaMNCTRZJxaRyEk5xR+5yjZy1d+sGewC/wYEiyycvQlt2wLzYOAuzoRTqU1VdyYMxUGH3sM97AWxddrvudiryLpj9rru98=; X-UUID: 8f72a633fe8e4b2c964a2f6bb7712a5d-20191227 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1038913153; Fri, 27 Dec 2019 18:54:19 -0800 Received: from MTKMBS32N1.mediatek.inc (172.27.4.71) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 27 Dec 2019 18:54:24 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N1.mediatek.inc (172.27.4.71) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 28 Dec 2019 10:53:43 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 28 Dec 2019 10:54:44 +0800 Message-ID: <1577501595.21256.8.camel@mhfsdcap03> Subject: Re: [PATCH v3 3/6] phy: amlogic: Add Amlogic A1 USB2 PHY Driver From: Chunfeng Yun To: Hanjie Lin Date: Sat, 28 Dec 2019 10:53:15 +0800 In-Reply-To: <1577428606-69855-4-git-send-email-hanjie.lin@amlogic.com> References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-4-git-send-email-hanjie.lin@amlogic.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 7D6A139BDF8753CECA92F2F08A4142A8071CBE782207FE70DB2AA7114E397CFB2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191227_185424_668926_3EDC882C X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Martin Blumenstingl , devicetree@vger.kernel.org, Liang Yang , Qiufang Dai , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, Jian Hu , linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, 2019-12-27 at 14:36 +0800, Hanjie Lin wrote: > This adds support for the USB2 PHY found in the Amlogic A1 SoC Family. > > It supports host mode only. > > Signed-off-by: Hanjie Lin > Signed-off-by: Yue Wang > --- > drivers/phy/amlogic/phy-meson-g12a-usb2.c | 93 +++++++++++++++++++++---------- > 1 file changed, 64 insertions(+), 29 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c > index 9065ffc..a564747 100644 > --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c > +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c > @@ -146,11 +146,17 @@ [...] > + priv->soc_id = (enum meson_soc_id)of_device_get_match_data(&pdev->dev); > + > priv->regmap = devm_regmap_init_mmio(dev, base, > &phy_meson_g12a_usb2_regmap_conf); > if (IS_ERR(priv->regmap)) > return PTR_ERR(priv->regmap); > > - priv->clk = devm_clk_get(dev, "xtal"); > - if (IS_ERR(priv->clk)) > - return PTR_ERR(priv->clk); > + if (priv->soc_id == MESON_SOC_G12A) { > + priv->clk = devm_clk_get(dev, "xtal"); > + if (IS_ERR(priv->clk)) > + return PTR_ERR(priv->clk); > + } How about use devm_clk_get_optional(), then make it as optional clock also in dt-binding > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E577DC2D0DA for ; Sat, 28 Dec 2019 02:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB819207E0 for ; Sat, 28 Dec 2019 02:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="eD08jS+X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbfL1CyX (ORCPT ); Fri, 27 Dec 2019 21:54:23 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:60158 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725957AbfL1CyX (ORCPT ); Fri, 27 Dec 2019 21:54:23 -0500 X-UUID: 6f8a195f94a94c1db1db6633e7a40227-20191228 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DuK72F7gBZXvEYq3y3vW4ZuOMFEZduG7ni5TClqn+Jw=; b=eD08jS+XMS6lxdLuWJZUq3UTil5RDa6ktIO9N6cibeIztxAFTT91MQJ8FSGMYEwZRUx1ccjQdhYxp65Iiyo2l90x/StMH8+yc9K2K46nu0dKpdtVKOcwYKOL4zkpxR/J6MfJpSfAaNsl7azmsCuv/wVjc2l+pTtUsY8FVYfcUuU=; X-UUID: 6f8a195f94a94c1db1db6633e7a40227-20191228 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1593761629; Sat, 28 Dec 2019 10:54:16 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N1.mediatek.inc (172.27.4.71) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 28 Dec 2019 10:53:43 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 28 Dec 2019 10:54:44 +0800 Message-ID: <1577501595.21256.8.camel@mhfsdcap03> Subject: Re: [PATCH v3 3/6] phy: amlogic: Add Amlogic A1 USB2 PHY Driver From: Chunfeng Yun To: Hanjie Lin CC: Jerome Brunet , Neil Armstrong , Rob Herring , "Greg Kroah-Hartman" , Kevin Hilman , Yue Wang , , , , , Carlo Caione , Michael Turquette , "Stephen Boyd" , Martin Blumenstingl , Liang Yang , Jianxin Pan , Qiufang Dai , Jian Hu , Victor Wan , Xingyu Chen Date: Sat, 28 Dec 2019 10:53:15 +0800 In-Reply-To: <1577428606-69855-4-git-send-email-hanjie.lin@amlogic.com> References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-4-git-send-email-hanjie.lin@amlogic.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 7D6A139BDF8753CECA92F2F08A4142A8071CBE782207FE70DB2AA7114E397CFB2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gRnJpLCAyMDE5LTEyLTI3IGF0IDE0OjM2ICswODAwLCBIYW5qaWUgTGluIHdyb3RlOg0KPiBU aGlzIGFkZHMgc3VwcG9ydCBmb3IgdGhlIFVTQjIgUEhZIGZvdW5kIGluIHRoZSBBbWxvZ2ljIEEx IFNvQyBGYW1pbHkuDQo+IA0KPiBJdCBzdXBwb3J0cyBob3N0IG1vZGUgb25seS4NCj4gDQo+IFNp Z25lZC1vZmYtYnk6IEhhbmppZSBMaW4gPGhhbmppZS5saW5AYW1sb2dpYy5jb20+DQo+IFNpZ25l ZC1vZmYtYnk6IFl1ZSBXYW5nIDx5dWUud2FuZ0BhbWxvZ2ljLmNvbT4NCj4gLS0tDQo+ICBkcml2 ZXJzL3BoeS9hbWxvZ2ljL3BoeS1tZXNvbi1nMTJhLXVzYjIuYyB8IDkzICsrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCA2NCBpbnNlcnRpb25zKCspLCAy OSBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9hbWxvZ2ljL3Bo eS1tZXNvbi1nMTJhLXVzYjIuYyBiL2RyaXZlcnMvcGh5L2FtbG9naWMvcGh5LW1lc29uLWcxMmEt dXNiMi5jDQo+IGluZGV4IDkwNjVmZmMuLmE1NjQ3NDcgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMv cGh5L2FtbG9naWMvcGh5LW1lc29uLWcxMmEtdXNiMi5jDQo+ICsrKyBiL2RyaXZlcnMvcGh5L2Ft bG9naWMvcGh5LW1lc29uLWcxMmEtdXNiMi5jDQo+IEBAIC0xNDYsMTEgKzE0NiwxNyBAQA0KWy4u Ll0NCj4gKwlwcml2LT5zb2NfaWQgPSAoZW51bSBtZXNvbl9zb2NfaWQpb2ZfZGV2aWNlX2dldF9t YXRjaF9kYXRhKCZwZGV2LT5kZXYpOw0KPiArDQo+ICAJcHJpdi0+cmVnbWFwID0gZGV2bV9yZWdt YXBfaW5pdF9tbWlvKGRldiwgYmFzZSwNCj4gIAkJCQkJICAgICAmcGh5X21lc29uX2cxMmFfdXNi Ml9yZWdtYXBfY29uZik7DQo+ICAJaWYgKElTX0VSUihwcml2LT5yZWdtYXApKQ0KPiAgCQlyZXR1 cm4gUFRSX0VSUihwcml2LT5yZWdtYXApOw0KPiAgDQo+IC0JcHJpdi0+Y2xrID0gZGV2bV9jbGtf Z2V0KGRldiwgInh0YWwiKTsNCj4gLQlpZiAoSVNfRVJSKHByaXYtPmNsaykpDQo+IC0JCXJldHVy biBQVFJfRVJSKHByaXYtPmNsayk7DQo+ICsJaWYgKHByaXYtPnNvY19pZCA9PSBNRVNPTl9TT0Nf RzEyQSkgew0KPiArCQlwcml2LT5jbGsgPSBkZXZtX2Nsa19nZXQoZGV2LCAieHRhbCIpOw0KPiAr CQlpZiAoSVNfRVJSKHByaXYtPmNsaykpDQo+ICsJCQlyZXR1cm4gUFRSX0VSUihwcml2LT5jbGsp Ow0KPiArCX0NCkhvdyBhYm91dCB1c2UgZGV2bV9jbGtfZ2V0X29wdGlvbmFsKCksIHRoZW4gbWFr ZSBpdCBhcyBvcHRpb25hbCBjbG9jaw0KYWxzbyBpbiBkdC1iaW5kaW5nDQo+ICANCg0KPiAgDQoN Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15FAEC2D0C3 for ; Sat, 28 Dec 2019 02:54:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA144207E0 for ; Sat, 28 Dec 2019 02:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t8znvT9n"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Xqb8qm4V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA144207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9K2/IlFtpAPSHsuUczBgzxEZG7CDP3ZgQbnirUedsNk=; b=t8znvT9na4M9PA 54E55QMODWtvmosntFPYOqEmpCYahA7TKs2B2fWPy4LWhBoNpTG6zUFTwi0QE7KuQod9lKULT9POg 6SxY4H1sKKK4w+N0mtapwaSjrx6rRsoXmlJBdEzAD3KWUUGDLFOiFEeoGQkFS/C8N08NzG/jksyJn ZiSbFFmooMk34XSAileud04tFhscaG1NxvEoBhcgh4966Za1f787lL2X0T3SpS6P/tlfUG9JLqQiH 2D752BzdoiQdhYm/RApfrQatHQtn1MMXKm2BbJs9bvRn37gZV0VfTIv8W26W73CDaH4eq3jk4xfjC DGf+WdpTNwnzFj8zVGdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1il2FH-0007Bj-Gg; Sat, 28 Dec 2019 02:54:27 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1il2FE-0007BA-K7; Sat, 28 Dec 2019 02:54:25 +0000 X-UUID: 8f72a633fe8e4b2c964a2f6bb7712a5d-20191227 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DuK72F7gBZXvEYq3y3vW4ZuOMFEZduG7ni5TClqn+Jw=; b=Xqb8qm4VIFCwJy9or7rS3RLV8gGOtdoZSvTFnFmjX0rcv8HHXjTmhsDuT6K4czVKSUes1e5HDS62BaaMNCTRZJxaRyEk5xR+5yjZy1d+sGewC/wYEiyycvQlt2wLzYOAuzoRTqU1VdyYMxUGH3sM97AWxddrvudiryLpj9rru98=; X-UUID: 8f72a633fe8e4b2c964a2f6bb7712a5d-20191227 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1038913153; Fri, 27 Dec 2019 18:54:19 -0800 Received: from MTKMBS32N1.mediatek.inc (172.27.4.71) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 27 Dec 2019 18:54:24 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N1.mediatek.inc (172.27.4.71) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 28 Dec 2019 10:53:43 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 28 Dec 2019 10:54:44 +0800 Message-ID: <1577501595.21256.8.camel@mhfsdcap03> Subject: Re: [PATCH v3 3/6] phy: amlogic: Add Amlogic A1 USB2 PHY Driver From: Chunfeng Yun To: Hanjie Lin Date: Sat, 28 Dec 2019 10:53:15 +0800 In-Reply-To: <1577428606-69855-4-git-send-email-hanjie.lin@amlogic.com> References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-4-git-send-email-hanjie.lin@amlogic.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 7D6A139BDF8753CECA92F2F08A4142A8071CBE782207FE70DB2AA7114E397CFB2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191227_185424_668926_3EDC882C X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Martin Blumenstingl , devicetree@vger.kernel.org, Liang Yang , Qiufang Dai , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, Jian Hu , linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-12-27 at 14:36 +0800, Hanjie Lin wrote: > This adds support for the USB2 PHY found in the Amlogic A1 SoC Family. > > It supports host mode only. > > Signed-off-by: Hanjie Lin > Signed-off-by: Yue Wang > --- > drivers/phy/amlogic/phy-meson-g12a-usb2.c | 93 +++++++++++++++++++++---------- > 1 file changed, 64 insertions(+), 29 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c > index 9065ffc..a564747 100644 > --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c > +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c > @@ -146,11 +146,17 @@ [...] > + priv->soc_id = (enum meson_soc_id)of_device_get_match_data(&pdev->dev); > + > priv->regmap = devm_regmap_init_mmio(dev, base, > &phy_meson_g12a_usb2_regmap_conf); > if (IS_ERR(priv->regmap)) > return PTR_ERR(priv->regmap); > > - priv->clk = devm_clk_get(dev, "xtal"); > - if (IS_ERR(priv->clk)) > - return PTR_ERR(priv->clk); > + if (priv->soc_id == MESON_SOC_G12A) { > + priv->clk = devm_clk_get(dev, "xtal"); > + if (IS_ERR(priv->clk)) > + return PTR_ERR(priv->clk); > + } How about use devm_clk_get_optional(), then make it as optional clock also in dt-binding > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel