From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F92C2D0C2 for ; Tue, 31 Dec 2019 09:40:16 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC639206DA for ; Tue, 31 Dec 2019 09:40:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RU5Mmrft" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC639206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7C1678628E; Tue, 31 Dec 2019 09:40:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 862K2Nosoh5v; Tue, 31 Dec 2019 09:40:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id A399D8627B; Tue, 31 Dec 2019 09:40:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 88E36C18DC; Tue, 31 Dec 2019 09:40:14 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id BA5E0C077D for ; Tue, 31 Dec 2019 09:40:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 644838628E for ; Tue, 31 Dec 2019 09:40:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dOLJHr0Bz28C for ; Tue, 31 Dec 2019 09:40:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by whitealder.osuosl.org (Postfix) with ESMTP id DB6A88627B for ; Tue, 31 Dec 2019 09:40:10 +0000 (UTC) X-UUID: 999695b8557c4a70aff2cfe1fb5226b9-20191231 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EWgLWzIEGVc+n5/bGxe6G7fqAIYcTKrSyKvFxLFVniQ=; b=RU5MmrftnXRk0INYLt23nURiXYsaoydt0ASL3Vr1mwm7bK+grGcin8Gh1iq5O+rCykUq6ZLW78PgnwXmoWAg/Z+sBbgBKNMDfAqFZeOxWfVrmQ118vGpQ+VG+9wRQ14ypfbpwK37paYUIMueOh/SYqni2ukR3Ngbi/bUvDiFiAE=; X-UUID: 999695b8557c4a70aff2cfe1fb5226b9-20191231 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1297004599; Tue, 31 Dec 2019 17:40:07 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 31 Dec 2019 17:40:06 +0800 Received: from [10.15.20.246] (10.15.20.246) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 31 Dec 2019 17:39:33 +0800 Message-ID: <1577785148.30177.5.camel@mbjsdccf07> Subject: Re: [RESEND,PATCH 03/13] iommu/mediatek: Add mtk_iommu_pgtable structure From: chao hao To: Yong Wu Date: Tue, 31 Dec 2019 17:39:08 +0800 In-Reply-To: <1576498396.28043.78.camel@mhfsdcap03> References: <20191104115238.2394-1-chao.hao@mediatek.com> <20191104115238.2394-4-chao.hao@mediatek.com> <1576498396.28043.78.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Cc: Anan Sun , devicetree@vger.kernel.org, Cui Zhang , Jun Yan , wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org, Chao Hao , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Miles Chen , Matthias Brugger , linux-arm-kernel@lists.infradead.org, Guangming Cao X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, 2019-12-16 at 20:13 +0800, Yong Wu wrote: > On Mon, 2019-11-04 at 19:52 +0800, Chao Hao wrote: > > Start with this patch, we will change the SW architecture > > to support multiple domains. SW architecture will has a big change, > > so we need to modify a little bit by more than one patch. > > The new SW overall architecture is as below: > > > > iommu0 iommu1 > > | | > > ----------- > > | > > mtk_iommu_pgtable > > | > > ------------------------------------------ > > | | | > > mtk_iommu_domain1 mtk_iommu_domain2 mtk_iommu_domain3 > > | | | > > iommu_group1 iommu_group2 iommu_group3 > > | | | > > iommu_domain1 iommu_domain2 iommu_domain3 > > | | | > > iova region1(normal) iova region2(CCU) iova region3(VPU) > > > > For current structure, no matter how many iommus there are, > > they use the same page table to simplify the usage of module. > > In order to make the software architecture more explicit, this > > patch will create a global mtk_iommu_pgtable structure to describe > > page table and all the iommus use it. > > Thanks for the hard work of this file. Actually this patch and the later > ones confuse me. Why do you make this flow change? > for making the code "more explicit" or for adding multi-domain support > in 13/13. > > IMHO, the change is unnecessary. > a) For me, this change has no improvement. currently we use a global > mtk_iommu_get_m4u_data to get the M4U data. I will be very glad if you > could get rid of it. But in this patchset, You use a another global > mtk_iommu_pgtable to instead. For me. It has no improvement. Thanks for you advice! For current SW arch, all the IOMMU HW use the same page table, we can use a global mtk_iommu_pgtable to discribe the information of page table and all the IOMMU attach it, I think that it is more clear and unambiguous. For beginners, it maybe more easily explicable? > > b) This patchset break the original flow. device_group give you a > software chance for initializing, then you move pagetable allocating > code into it. But it isn't device_group job. > As is shown above diagram, mtk_iommu_pgtable includes iommu_group and iommu_domain,so we need to allocate mtk_iommu_pgtable and initialize it in device_group firstly,and then execute the original flow, it only changes place for creating mtk_iommu_pgtable and don't break original device_group flow. > I can not decide if your flow is right. But if you only want to add > support multi-domain, I guess you could extend the current "m4u_group" > to a array "m4u_group[N]". It may be more simple. To make mt6779 > progress easily, I suggest you can use this way to support multi-domain > firstly. Then you could send this new mtk_iommu_pgtable patchset for the > code "more explicit" if you insist. > > > The diagram is as below: > > > > mtk_iommu_data1(MM) mtk_iommu_data2(APU) > > | | > > | | > > ------mtk_iommu_pgtable----- > > > > We need to create global mtk_iommu_pgtable to include all the iova > > regions firstly and special iova regions by divided based on it, > > so the information of pgtable needs to be created in device_group. > > > > Signed-off-by: Chao Hao > > --- > > drivers/iommu/mtk_iommu.c | 84 +++++++++++++++++++++++++++++++++++++++ > > drivers/iommu/mtk_iommu.h | 1 + > > 2 files changed, 85 insertions(+) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index f2847e661137..fcbde6b0f58d 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -123,6 +123,12 @@ struct mtk_iommu_domain { > > struct iommu_domain domain; > > }; > > > > +struct mtk_iommu_pgtable { > > + struct io_pgtable_cfg cfg; > > + struct io_pgtable_ops *iop; > > +}; > > + > > +static struct mtk_iommu_pgtable *share_pgtable; > > static const struct iommu_ops mtk_iommu_ops; > > > > /* > > @@ -170,6 +176,11 @@ static struct mtk_iommu_data *mtk_iommu_get_m4u_data(void) > > return NULL; > > } > > > > +static struct mtk_iommu_pgtable *mtk_iommu_get_pgtable(void) > > +{ > > + return share_pgtable; > > +} > > + > > static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom) > > { > > return container_of(dom, struct mtk_iommu_domain, domain); > > @@ -322,6 +333,13 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom) > > { > > struct mtk_iommu_data *data = mtk_iommu_get_m4u_data(); > > > > + if (data->pgtable) { > > + dom->cfg = data->pgtable->cfg; > > + dom->iop = data->pgtable->iop; > > + dom->domain.pgsize_bitmap = data->pgtable->cfg.pgsize_bitmap; > > + return 0; > > + } > > + > > dom->cfg = (struct io_pgtable_cfg) { > > .quirks = IO_PGTABLE_QUIRK_ARM_NS | > > IO_PGTABLE_QUIRK_NO_PERMS | > > @@ -345,6 +363,61 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom) > > return 0; > > } > > > > +static struct mtk_iommu_pgtable *create_pgtable(struct mtk_iommu_data *data) > > +{ > > + struct mtk_iommu_pgtable *pgtable; > > + > > + pgtable = kzalloc(sizeof(*pgtable), GFP_KERNEL); > > + if (!pgtable) > > + return ERR_PTR(-ENOMEM); > > + > > + pgtable->cfg = (struct io_pgtable_cfg) { > > + .quirks = IO_PGTABLE_QUIRK_ARM_NS | > > + IO_PGTABLE_QUIRK_NO_PERMS | > > + IO_PGTABLE_QUIRK_TLBI_ON_MAP | > > + IO_PGTABLE_QUIRK_ARM_MTK_EXT, > > + .pgsize_bitmap = mtk_iommu_ops.pgsize_bitmap, > > + .ias = 32, > > + .oas = 34, > > + .tlb = &mtk_iommu_flush_ops, > > + .iommu_dev = data->dev, > > + }; > > + > > + pgtable->iop = alloc_io_pgtable_ops(ARM_V7S, &pgtable->cfg, data); > > + if (!pgtable->iop) { > > + dev_err(data->dev, "Failed to alloc io pgtable\n"); > > + return ERR_PTR(-EINVAL); > > + } > > + > > + dev_info(data->dev, "%s create pgtable done\n", __func__); > > + > > + return pgtable; > > +} > > + > > +static int mtk_iommu_attach_pgtable(struct mtk_iommu_data *data, > > + struct device *dev) > > +{ > > + struct mtk_iommu_pgtable *pgtable = mtk_iommu_get_pgtable(); > > + > > + /* create share pgtable */ > > + if (!pgtable) { > > + pgtable = create_pgtable(data); > > + if (IS_ERR(pgtable)) { > > + dev_err(data->dev, "Failed to create pgtable\n"); > > + return -ENOMEM; > > + } > > + > > + share_pgtable = pgtable; > > + } > > + > > + /* binding to pgtable */ > > + data->pgtable = pgtable; > > + > > + dev_info(data->dev, "m4u%d attach_pgtable done!\n", data->m4u_id); > > + > > + return 0; > > +} > > + > > static struct iommu_domain *mtk_iommu_domain_alloc(unsigned type) > > { > > struct mtk_iommu_domain *dom; > > @@ -508,10 +581,21 @@ static void mtk_iommu_remove_device(struct device *dev) > > static struct iommu_group *mtk_iommu_device_group(struct device *dev) > > { > > struct mtk_iommu_data *data = mtk_iommu_get_m4u_data(); > > + struct mtk_iommu_pgtable *pgtable; > > + int ret = 0; > > > > if (!data) > > return ERR_PTR(-ENODEV); > > > > + pgtable = data->pgtable; > > + if (!pgtable) { > > + ret = mtk_iommu_attach_pgtable(data, dev); > > + if (ret) { > > + dev_err(data->dev, "Failed to device_group\n"); > > + return NULL; > > + } > > + } > > + > > /* All the client devices are in the same m4u iommu-group */ > > if (!data->m4u_group) { > > data->m4u_group = iommu_group_alloc(); > > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h > > index 132dc765a40b..dd5f19f78b62 100644 > > --- a/drivers/iommu/mtk_iommu.h > > +++ b/drivers/iommu/mtk_iommu.h > > @@ -61,6 +61,7 @@ struct mtk_iommu_data { > > struct clk *bclk; > > phys_addr_t protect_base; /* protect memory base */ > > struct mtk_iommu_suspend_reg reg; > > + struct mtk_iommu_pgtable *pgtable; > > struct mtk_iommu_domain *m4u_dom; > > struct iommu_group *m4u_group; > > bool enable_4GB; > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2A5C2D0C2 for ; Tue, 31 Dec 2019 09:40:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0911206DA for ; Tue, 31 Dec 2019 09:40:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oGV45Mx8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RU5Mmrft" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0911206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lVvHa8zcbJ0p4dLF8+TmR0M5U2wJ7Mu/Dt+qjqmeO18=; b=oGV45Mx8mpXCAm EwmEfqpQYgJSbFgdTmS6b2Ib8zeX8dow7PaG09/Z11je6zs6QoGbz1UOhqDKc2WL2yLVQD2p90Knu qqlSQURR5jH0grFby8XIeMBS0PbUD+x4fQl5nwhO/Nj7Y/OIXfpbvsYlKo8z6QVmKlfk7XYBjKaWA uW4UuFBw4ZWJJsrn1TRKqtPJF3qxEL20+cjNB+LbkDHgo4hfSwAP7x3TvC/aNsfUO+fjOPE0n/MJs QYupX+maW6Ih4UbXgwWHnw68Pp5hxduWztxVmBcfdNIXPL+4rbF9nyeFnl19/tnZKWAXZqFuUO81c 5+dC5s+DHP7x0ysORALg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imE0w-00041I-84; Tue, 31 Dec 2019 09:40:34 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imE0j-0003pB-58; Tue, 31 Dec 2019 09:40:22 +0000 X-UUID: 634a73618ae144bd8fdb2283650f74dc-20191231 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EWgLWzIEGVc+n5/bGxe6G7fqAIYcTKrSyKvFxLFVniQ=; b=RU5MmrftnXRk0INYLt23nURiXYsaoydt0ASL3Vr1mwm7bK+grGcin8Gh1iq5O+rCykUq6ZLW78PgnwXmoWAg/Z+sBbgBKNMDfAqFZeOxWfVrmQ118vGpQ+VG+9wRQ14ypfbpwK37paYUIMueOh/SYqni2ukR3Ngbi/bUvDiFiAE=; X-UUID: 634a73618ae144bd8fdb2283650f74dc-20191231 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 858323671; Tue, 31 Dec 2019 01:40:09 -0800 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 31 Dec 2019 01:40:25 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 31 Dec 2019 17:40:06 +0800 Received: from [10.15.20.246] (10.15.20.246) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 31 Dec 2019 17:39:33 +0800 Message-ID: <1577785148.30177.5.camel@mbjsdccf07> Subject: Re: [RESEND,PATCH 03/13] iommu/mediatek: Add mtk_iommu_pgtable structure From: chao hao To: Yong Wu Date: Tue, 31 Dec 2019 17:39:08 +0800 In-Reply-To: <1576498396.28043.78.camel@mhfsdcap03> References: <20191104115238.2394-1-chao.hao@mediatek.com> <20191104115238.2394-4-chao.hao@mediatek.com> <1576498396.28043.78.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191231_014021_209492_7105752A X-CRM114-Status: GOOD ( 32.42 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anan Sun , devicetree@vger.kernel.org, Cui Zhang , Jun Yan , wsd_upstream@mediatek.com, Joerg Roedel , linux-kernel@vger.kernel.org, Chao Hao , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Miles Chen , Matthias Brugger , linux-arm-kernel@lists.infradead.org, Guangming Cao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2019-12-16 at 20:13 +0800, Yong Wu wrote: > On Mon, 2019-11-04 at 19:52 +0800, Chao Hao wrote: > > Start with this patch, we will change the SW architecture > > to support multiple domains. SW architecture will has a big change, > > so we need to modify a little bit by more than one patch. > > The new SW overall architecture is as below: > > > > iommu0 iommu1 > > | | > > ----------- > > | > > mtk_iommu_pgtable > > | > > ------------------------------------------ > > | | | > > mtk_iommu_domain1 mtk_iommu_domain2 mtk_iommu_domain3 > > | | | > > iommu_group1 iommu_group2 iommu_group3 > > | | | > > iommu_domain1 iommu_domain2 iommu_domain3 > > | | | > > iova region1(normal) iova region2(CCU) iova region3(VPU) > > > > For current structure, no matter how many iommus there are, > > they use the same page table to simplify the usage of module. > > In order to make the software architecture more explicit, this > > patch will create a global mtk_iommu_pgtable structure to describe > > page table and all the iommus use it. > > Thanks for the hard work of this file. Actually this patch and the later > ones confuse me. Why do you make this flow change? > for making the code "more explicit" or for adding multi-domain support > in 13/13. > > IMHO, the change is unnecessary. > a) For me, this change has no improvement. currently we use a global > mtk_iommu_get_m4u_data to get the M4U data. I will be very glad if you > could get rid of it. But in this patchset, You use a another global > mtk_iommu_pgtable to instead. For me. It has no improvement. Thanks for you advice! For current SW arch, all the IOMMU HW use the same page table, we can use a global mtk_iommu_pgtable to discribe the information of page table and all the IOMMU attach it, I think that it is more clear and unambiguous. For beginners, it maybe more easily explicable? > > b) This patchset break the original flow. device_group give you a > software chance for initializing, then you move pagetable allocating > code into it. But it isn't device_group job. > As is shown above diagram, mtk_iommu_pgtable includes iommu_group and iommu_domain,so we need to allocate mtk_iommu_pgtable and initialize it in device_group firstly,and then execute the original flow, it only changes place for creating mtk_iommu_pgtable and don't break original device_group flow. > I can not decide if your flow is right. But if you only want to add > support multi-domain, I guess you could extend the current "m4u_group" > to a array "m4u_group[N]". It may be more simple. To make mt6779 > progress easily, I suggest you can use this way to support multi-domain > firstly. Then you could send this new mtk_iommu_pgtable patchset for the > code "more explicit" if you insist. > > > The diagram is as below: > > > > mtk_iommu_data1(MM) mtk_iommu_data2(APU) > > | | > > | | > > ------mtk_iommu_pgtable----- > > > > We need to create global mtk_iommu_pgtable to include all the iova > > regions firstly and special iova regions by divided based on it, > > so the information of pgtable needs to be created in device_group. > > > > Signed-off-by: Chao Hao > > --- > > drivers/iommu/mtk_iommu.c | 84 +++++++++++++++++++++++++++++++++++++++ > > drivers/iommu/mtk_iommu.h | 1 + > > 2 files changed, 85 insertions(+) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index f2847e661137..fcbde6b0f58d 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -123,6 +123,12 @@ struct mtk_iommu_domain { > > struct iommu_domain domain; > > }; > > > > +struct mtk_iommu_pgtable { > > + struct io_pgtable_cfg cfg; > > + struct io_pgtable_ops *iop; > > +}; > > + > > +static struct mtk_iommu_pgtable *share_pgtable; > > static const struct iommu_ops mtk_iommu_ops; > > > > /* > > @@ -170,6 +176,11 @@ static struct mtk_iommu_data *mtk_iommu_get_m4u_data(void) > > return NULL; > > } > > > > +static struct mtk_iommu_pgtable *mtk_iommu_get_pgtable(void) > > +{ > > + return share_pgtable; > > +} > > + > > static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom) > > { > > return container_of(dom, struct mtk_iommu_domain, domain); > > @@ -322,6 +333,13 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom) > > { > > struct mtk_iommu_data *data = mtk_iommu_get_m4u_data(); > > > > + if (data->pgtable) { > > + dom->cfg = data->pgtable->cfg; > > + dom->iop = data->pgtable->iop; > > + dom->domain.pgsize_bitmap = data->pgtable->cfg.pgsize_bitmap; > > + return 0; > > + } > > + > > dom->cfg = (struct io_pgtable_cfg) { > > .quirks = IO_PGTABLE_QUIRK_ARM_NS | > > IO_PGTABLE_QUIRK_NO_PERMS | > > @@ -345,6 +363,61 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom) > > return 0; > > } > > > > +static struct mtk_iommu_pgtable *create_pgtable(struct mtk_iommu_data *data) > > +{ > > + struct mtk_iommu_pgtable *pgtable; > > + > > + pgtable = kzalloc(sizeof(*pgtable), GFP_KERNEL); > > + if (!pgtable) > > + return ERR_PTR(-ENOMEM); > > + > > + pgtable->cfg = (struct io_pgtable_cfg) { > > + .quirks = IO_PGTABLE_QUIRK_ARM_NS | > > + IO_PGTABLE_QUIRK_NO_PERMS | > > + IO_PGTABLE_QUIRK_TLBI_ON_MAP | > > + IO_PGTABLE_QUIRK_ARM_MTK_EXT, > > + .pgsize_bitmap = mtk_iommu_ops.pgsize_bitmap, > > + .ias = 32, > > + .oas = 34, > > + .tlb = &mtk_iommu_flush_ops, > > + .iommu_dev = data->dev, > > + }; > > + > > + pgtable->iop = alloc_io_pgtable_ops(ARM_V7S, &pgtable->cfg, data); > > + if (!pgtable->iop) { > > + dev_err(data->dev, "Failed to alloc io pgtable\n"); > > + return ERR_PTR(-EINVAL); > > + } > > + > > + dev_info(data->dev, "%s create pgtable done\n", __func__); > > + > > + return pgtable; > > +} > > + > > +static int mtk_iommu_attach_pgtable(struct mtk_iommu_data *data, > > + struct device *dev) > > +{ > > + struct mtk_iommu_pgtable *pgtable = mtk_iommu_get_pgtable(); > > + > > + /* create share pgtable */ > > + if (!pgtable) { > > + pgtable = create_pgtable(data); > > + if (IS_ERR(pgtable)) { > > + dev_err(data->dev, "Failed to create pgtable\n"); > > + return -ENOMEM; > > + } > > + > > + share_pgtable = pgtable; > > + } > > + > > + /* binding to pgtable */ > > + data->pgtable = pgtable; > > + > > + dev_info(data->dev, "m4u%d attach_pgtable done!\n", data->m4u_id); > > + > > + return 0; > > +} > > + > > static struct iommu_domain *mtk_iommu_domain_alloc(unsigned type) > > { > > struct mtk_iommu_domain *dom; > > @@ -508,10 +581,21 @@ static void mtk_iommu_remove_device(struct device *dev) > > static struct iommu_group *mtk_iommu_device_group(struct device *dev) > > { > > struct mtk_iommu_data *data = mtk_iommu_get_m4u_data(); > > + struct mtk_iommu_pgtable *pgtable; > > + int ret = 0; > > > > if (!data) > > return ERR_PTR(-ENODEV); > > > > + pgtable = data->pgtable; > > + if (!pgtable) { > > + ret = mtk_iommu_attach_pgtable(data, dev); > > + if (ret) { > > + dev_err(data->dev, "Failed to device_group\n"); > > + return NULL; > > + } > > + } > > + > > /* All the client devices are in the same m4u iommu-group */ > > if (!data->m4u_group) { > > data->m4u_group = iommu_group_alloc(); > > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h > > index 132dc765a40b..dd5f19f78b62 100644 > > --- a/drivers/iommu/mtk_iommu.h > > +++ b/drivers/iommu/mtk_iommu.h > > @@ -61,6 +61,7 @@ struct mtk_iommu_data { > > struct clk *bclk; > > phys_addr_t protect_base; /* protect memory base */ > > struct mtk_iommu_suspend_reg reg; > > + struct mtk_iommu_pgtable *pgtable; > > struct mtk_iommu_domain *m4u_dom; > > struct iommu_group *m4u_group; > > bool enable_4GB; > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408E8C2D0C2 for ; Tue, 31 Dec 2019 09:40:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11A15206DA for ; Tue, 31 Dec 2019 09:40:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rSws/Fs2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RU5Mmrft" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11A15206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YASehlivMwLEqyLLLa8RvMlEOW2mx5Yfbot80YHnYB4=; b=rSws/Fs293YLf6 As8Lb6q73lUD8mV9wEtXOKj25/XDzJsLrX3cqfKlX8MldfDegkWJaoF0OomWY3s2SscWBs50/gGBQ fIhwYx6RR1q96Y/hrL57bjDh7uR+1kuei+1gk+lr6De2OAC9sQ/8/BMsOyukToSjuqkoUck8CuM95 NMn437FcgadLwV267N3HVfX3W1tVWsRLar9NUql9mMNuN+hsOfsDwSQ271w7Dd8HxmZjBxoHety6l Whg+Gzb22tELrWYhI7iCPj/Ua657dyp2YmPQRKKq3pbMWekr2AY/as5w+UPogtlrDnryrB2X292AW ltxbLmSrOL1MwOWZ6tyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imE0n-0003rx-3L; Tue, 31 Dec 2019 09:40:25 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imE0j-0003pB-58; Tue, 31 Dec 2019 09:40:22 +0000 X-UUID: 634a73618ae144bd8fdb2283650f74dc-20191231 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EWgLWzIEGVc+n5/bGxe6G7fqAIYcTKrSyKvFxLFVniQ=; b=RU5MmrftnXRk0INYLt23nURiXYsaoydt0ASL3Vr1mwm7bK+grGcin8Gh1iq5O+rCykUq6ZLW78PgnwXmoWAg/Z+sBbgBKNMDfAqFZeOxWfVrmQ118vGpQ+VG+9wRQ14ypfbpwK37paYUIMueOh/SYqni2ukR3Ngbi/bUvDiFiAE=; X-UUID: 634a73618ae144bd8fdb2283650f74dc-20191231 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 858323671; Tue, 31 Dec 2019 01:40:09 -0800 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 31 Dec 2019 01:40:25 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 31 Dec 2019 17:40:06 +0800 Received: from [10.15.20.246] (10.15.20.246) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 31 Dec 2019 17:39:33 +0800 Message-ID: <1577785148.30177.5.camel@mbjsdccf07> Subject: Re: [RESEND,PATCH 03/13] iommu/mediatek: Add mtk_iommu_pgtable structure From: chao hao To: Yong Wu Date: Tue, 31 Dec 2019 17:39:08 +0800 In-Reply-To: <1576498396.28043.78.camel@mhfsdcap03> References: <20191104115238.2394-1-chao.hao@mediatek.com> <20191104115238.2394-4-chao.hao@mediatek.com> <1576498396.28043.78.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191231_014021_209492_7105752A X-CRM114-Status: GOOD ( 32.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anan Sun , devicetree@vger.kernel.org, Cui Zhang , Jun Yan , wsd_upstream@mediatek.com, Joerg Roedel , linux-kernel@vger.kernel.org, Chao Hao , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Miles Chen , Matthias Brugger , linux-arm-kernel@lists.infradead.org, Guangming Cao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-12-16 at 20:13 +0800, Yong Wu wrote: > On Mon, 2019-11-04 at 19:52 +0800, Chao Hao wrote: > > Start with this patch, we will change the SW architecture > > to support multiple domains. SW architecture will has a big change, > > so we need to modify a little bit by more than one patch. > > The new SW overall architecture is as below: > > > > iommu0 iommu1 > > | | > > ----------- > > | > > mtk_iommu_pgtable > > | > > ------------------------------------------ > > | | | > > mtk_iommu_domain1 mtk_iommu_domain2 mtk_iommu_domain3 > > | | | > > iommu_group1 iommu_group2 iommu_group3 > > | | | > > iommu_domain1 iommu_domain2 iommu_domain3 > > | | | > > iova region1(normal) iova region2(CCU) iova region3(VPU) > > > > For current structure, no matter how many iommus there are, > > they use the same page table to simplify the usage of module. > > In order to make the software architecture more explicit, this > > patch will create a global mtk_iommu_pgtable structure to describe > > page table and all the iommus use it. > > Thanks for the hard work of this file. Actually this patch and the later > ones confuse me. Why do you make this flow change? > for making the code "more explicit" or for adding multi-domain support > in 13/13. > > IMHO, the change is unnecessary. > a) For me, this change has no improvement. currently we use a global > mtk_iommu_get_m4u_data to get the M4U data. I will be very glad if you > could get rid of it. But in this patchset, You use a another global > mtk_iommu_pgtable to instead. For me. It has no improvement. Thanks for you advice! For current SW arch, all the IOMMU HW use the same page table, we can use a global mtk_iommu_pgtable to discribe the information of page table and all the IOMMU attach it, I think that it is more clear and unambiguous. For beginners, it maybe more easily explicable? > > b) This patchset break the original flow. device_group give you a > software chance for initializing, then you move pagetable allocating > code into it. But it isn't device_group job. > As is shown above diagram, mtk_iommu_pgtable includes iommu_group and iommu_domain,so we need to allocate mtk_iommu_pgtable and initialize it in device_group firstly,and then execute the original flow, it only changes place for creating mtk_iommu_pgtable and don't break original device_group flow. > I can not decide if your flow is right. But if you only want to add > support multi-domain, I guess you could extend the current "m4u_group" > to a array "m4u_group[N]". It may be more simple. To make mt6779 > progress easily, I suggest you can use this way to support multi-domain > firstly. Then you could send this new mtk_iommu_pgtable patchset for the > code "more explicit" if you insist. > > > The diagram is as below: > > > > mtk_iommu_data1(MM) mtk_iommu_data2(APU) > > | | > > | | > > ------mtk_iommu_pgtable----- > > > > We need to create global mtk_iommu_pgtable to include all the iova > > regions firstly and special iova regions by divided based on it, > > so the information of pgtable needs to be created in device_group. > > > > Signed-off-by: Chao Hao > > --- > > drivers/iommu/mtk_iommu.c | 84 +++++++++++++++++++++++++++++++++++++++ > > drivers/iommu/mtk_iommu.h | 1 + > > 2 files changed, 85 insertions(+) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index f2847e661137..fcbde6b0f58d 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -123,6 +123,12 @@ struct mtk_iommu_domain { > > struct iommu_domain domain; > > }; > > > > +struct mtk_iommu_pgtable { > > + struct io_pgtable_cfg cfg; > > + struct io_pgtable_ops *iop; > > +}; > > + > > +static struct mtk_iommu_pgtable *share_pgtable; > > static const struct iommu_ops mtk_iommu_ops; > > > > /* > > @@ -170,6 +176,11 @@ static struct mtk_iommu_data *mtk_iommu_get_m4u_data(void) > > return NULL; > > } > > > > +static struct mtk_iommu_pgtable *mtk_iommu_get_pgtable(void) > > +{ > > + return share_pgtable; > > +} > > + > > static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom) > > { > > return container_of(dom, struct mtk_iommu_domain, domain); > > @@ -322,6 +333,13 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom) > > { > > struct mtk_iommu_data *data = mtk_iommu_get_m4u_data(); > > > > + if (data->pgtable) { > > + dom->cfg = data->pgtable->cfg; > > + dom->iop = data->pgtable->iop; > > + dom->domain.pgsize_bitmap = data->pgtable->cfg.pgsize_bitmap; > > + return 0; > > + } > > + > > dom->cfg = (struct io_pgtable_cfg) { > > .quirks = IO_PGTABLE_QUIRK_ARM_NS | > > IO_PGTABLE_QUIRK_NO_PERMS | > > @@ -345,6 +363,61 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom) > > return 0; > > } > > > > +static struct mtk_iommu_pgtable *create_pgtable(struct mtk_iommu_data *data) > > +{ > > + struct mtk_iommu_pgtable *pgtable; > > + > > + pgtable = kzalloc(sizeof(*pgtable), GFP_KERNEL); > > + if (!pgtable) > > + return ERR_PTR(-ENOMEM); > > + > > + pgtable->cfg = (struct io_pgtable_cfg) { > > + .quirks = IO_PGTABLE_QUIRK_ARM_NS | > > + IO_PGTABLE_QUIRK_NO_PERMS | > > + IO_PGTABLE_QUIRK_TLBI_ON_MAP | > > + IO_PGTABLE_QUIRK_ARM_MTK_EXT, > > + .pgsize_bitmap = mtk_iommu_ops.pgsize_bitmap, > > + .ias = 32, > > + .oas = 34, > > + .tlb = &mtk_iommu_flush_ops, > > + .iommu_dev = data->dev, > > + }; > > + > > + pgtable->iop = alloc_io_pgtable_ops(ARM_V7S, &pgtable->cfg, data); > > + if (!pgtable->iop) { > > + dev_err(data->dev, "Failed to alloc io pgtable\n"); > > + return ERR_PTR(-EINVAL); > > + } > > + > > + dev_info(data->dev, "%s create pgtable done\n", __func__); > > + > > + return pgtable; > > +} > > + > > +static int mtk_iommu_attach_pgtable(struct mtk_iommu_data *data, > > + struct device *dev) > > +{ > > + struct mtk_iommu_pgtable *pgtable = mtk_iommu_get_pgtable(); > > + > > + /* create share pgtable */ > > + if (!pgtable) { > > + pgtable = create_pgtable(data); > > + if (IS_ERR(pgtable)) { > > + dev_err(data->dev, "Failed to create pgtable\n"); > > + return -ENOMEM; > > + } > > + > > + share_pgtable = pgtable; > > + } > > + > > + /* binding to pgtable */ > > + data->pgtable = pgtable; > > + > > + dev_info(data->dev, "m4u%d attach_pgtable done!\n", data->m4u_id); > > + > > + return 0; > > +} > > + > > static struct iommu_domain *mtk_iommu_domain_alloc(unsigned type) > > { > > struct mtk_iommu_domain *dom; > > @@ -508,10 +581,21 @@ static void mtk_iommu_remove_device(struct device *dev) > > static struct iommu_group *mtk_iommu_device_group(struct device *dev) > > { > > struct mtk_iommu_data *data = mtk_iommu_get_m4u_data(); > > + struct mtk_iommu_pgtable *pgtable; > > + int ret = 0; > > > > if (!data) > > return ERR_PTR(-ENODEV); > > > > + pgtable = data->pgtable; > > + if (!pgtable) { > > + ret = mtk_iommu_attach_pgtable(data, dev); > > + if (ret) { > > + dev_err(data->dev, "Failed to device_group\n"); > > + return NULL; > > + } > > + } > > + > > /* All the client devices are in the same m4u iommu-group */ > > if (!data->m4u_group) { > > data->m4u_group = iommu_group_alloc(); > > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h > > index 132dc765a40b..dd5f19f78b62 100644 > > --- a/drivers/iommu/mtk_iommu.h > > +++ b/drivers/iommu/mtk_iommu.h > > @@ -61,6 +61,7 @@ struct mtk_iommu_data { > > struct clk *bclk; > > phys_addr_t protect_base; /* protect memory base */ > > struct mtk_iommu_suspend_reg reg; > > + struct mtk_iommu_pgtable *pgtable; > > struct mtk_iommu_domain *m4u_dom; > > struct iommu_group *m4u_group; > > bool enable_4GB; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BBDC2D0DD for ; Tue, 31 Dec 2019 09:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6750206DA for ; Tue, 31 Dec 2019 09:40:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RU5Mmrft" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725793AbfLaJkR (ORCPT ); Tue, 31 Dec 2019 04:40:17 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:18698 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725770AbfLaJkR (ORCPT ); Tue, 31 Dec 2019 04:40:17 -0500 X-UUID: 999695b8557c4a70aff2cfe1fb5226b9-20191231 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EWgLWzIEGVc+n5/bGxe6G7fqAIYcTKrSyKvFxLFVniQ=; b=RU5MmrftnXRk0INYLt23nURiXYsaoydt0ASL3Vr1mwm7bK+grGcin8Gh1iq5O+rCykUq6ZLW78PgnwXmoWAg/Z+sBbgBKNMDfAqFZeOxWfVrmQ118vGpQ+VG+9wRQ14ypfbpwK37paYUIMueOh/SYqni2ukR3Ngbi/bUvDiFiAE=; X-UUID: 999695b8557c4a70aff2cfe1fb5226b9-20191231 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1297004599; Tue, 31 Dec 2019 17:40:07 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 31 Dec 2019 17:40:06 +0800 Received: from [10.15.20.246] (10.15.20.246) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 31 Dec 2019 17:39:33 +0800 Message-ID: <1577785148.30177.5.camel@mbjsdccf07> Subject: Re: [RESEND,PATCH 03/13] iommu/mediatek: Add mtk_iommu_pgtable structure From: chao hao To: Yong Wu CC: Joerg Roedel , Rob Herring , Matthias Brugger , , , , , , , Jun Yan , Cui Zhang , Guangming Cao , Anan Sun , Miles Chen , Chao Hao Date: Tue, 31 Dec 2019 17:39:08 +0800 In-Reply-To: <1576498396.28043.78.camel@mhfsdcap03> References: <20191104115238.2394-1-chao.hao@mediatek.com> <20191104115238.2394-4-chao.hao@mediatek.com> <1576498396.28043.78.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org T24gTW9uLCAyMDE5LTEyLTE2IGF0IDIwOjEzICswODAwLCBZb25nIFd1IHdyb3RlOg0KPiBPbiBN b24sIDIwMTktMTEtMDQgYXQgMTk6NTIgKzA4MDAsIENoYW8gSGFvIHdyb3RlOg0KPiA+IFN0YXJ0 IHdpdGggdGhpcyBwYXRjaCwgd2Ugd2lsbCBjaGFuZ2UgdGhlIFNXIGFyY2hpdGVjdHVyZQ0KPiA+ IHRvIHN1cHBvcnQgbXVsdGlwbGUgZG9tYWlucy4gU1cgYXJjaGl0ZWN0dXJlIHdpbGwgaGFzIGEg YmlnIGNoYW5nZSwNCj4gPiBzbyB3ZSBuZWVkIHRvIG1vZGlmeSBhIGxpdHRsZSBiaXQgYnkgbW9y ZSB0aGFuIG9uZSBwYXRjaC4NCj4gPiBUaGUgbmV3IFNXIG92ZXJhbGwgYXJjaGl0ZWN0dXJlIGlz IGFzIGJlbG93Og0KPiA+IA0KPiA+IAkJCQlpb21tdTAgICBpb21tdTENCj4gPiAJCQkJICB8CSAg ICB8DQo+ID4gCQkJCSAgLS0tLS0tLS0tLS0NCj4gPiAJCQkJCXwNCj4gPiAJCQkJbXRrX2lvbW11 X3BndGFibGUNCj4gPiAJCQkJCXwNCj4gPiAJCQktLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0NCj4gPiAJCQl8CQkgICAgIHwJCQkgfA0KPiA+IAkJbXRrX2lvbW11X2Rv bWFpbjEgICBtdGtfaW9tbXVfZG9tYWluMiAgbXRrX2lvbW11X2RvbWFpbjMNCj4gPiAJCQl8ICAg ICAgICAgICAgICAgICAgICB8ICAgICAgICAgICAgICAgICAgIHwNCj4gPiAJCWlvbW11X2dyb3Vw MSAgICAgICAgIGlvbW11X2dyb3VwMiAgICAgICAgICAgaW9tbXVfZ3JvdXAzDQo+ID4gCQkJfCAg ICAgICAgICAgICAgICAgICAgfCAgICAgICAgICAgICAgICAgICB8DQo+ID4gCQlpb21tdV9kb21h aW4xICAgICAgIGlvbW11X2RvbWFpbjIJICAgIGlvbW11X2RvbWFpbjMNCj4gPiAJCQl8ICAgICAg ICAgICAgICAgICAgICB8ICAgICAgICAgICAgICAgICAgIHwNCj4gPiAJCWlvdmEgcmVnaW9uMShu b3JtYWwpICBpb3ZhIHJlZ2lvbjIoQ0NVKSAgICBpb3ZhIHJlZ2lvbjMoVlBVKQ0KPiA+IA0KPiA+ IEZvciBjdXJyZW50IHN0cnVjdHVyZSwgbm8gbWF0dGVyIGhvdyBtYW55IGlvbW11cyB0aGVyZSBh cmUsDQo+ID4gdGhleSB1c2UgdGhlIHNhbWUgcGFnZSB0YWJsZSB0byBzaW1wbGlmeSB0aGUgdXNh Z2Ugb2YgbW9kdWxlLg0KPiA+IEluIG9yZGVyIHRvIG1ha2UgdGhlIHNvZnR3YXJlIGFyY2hpdGVj dHVyZSBtb3JlIGV4cGxpY2l0LCB0aGlzDQo+ID4gcGF0Y2ggd2lsbCBjcmVhdGUgYSBnbG9iYWwg bXRrX2lvbW11X3BndGFibGUgc3RydWN0dXJlIHRvIGRlc2NyaWJlDQo+ID4gcGFnZSB0YWJsZSBh bmQgYWxsIHRoZSBpb21tdXMgdXNlIGl0Lg0KPiANCj4gVGhhbmtzIGZvciB0aGUgaGFyZCB3b3Jr IG9mIHRoaXMgZmlsZS4gQWN0dWFsbHkgdGhpcyBwYXRjaCBhbmQgdGhlIGxhdGVyDQo+IG9uZXMg Y29uZnVzZSBtZS4gV2h5IGRvIHlvdSBtYWtlIHRoaXMgZmxvdyBjaGFuZ2U/IA0KPiBmb3IgbWFr aW5nIHRoZSBjb2RlICJtb3JlIGV4cGxpY2l0IiBvciBmb3IgYWRkaW5nIG11bHRpLWRvbWFpbiBz dXBwb3J0DQo+IGluIDEzLzEzLg0KPiANCj4gSU1ITywgdGhlIGNoYW5nZSBpcyB1bm5lY2Vzc2Fy eS4NCj4gYSkgRm9yIG1lLCB0aGlzIGNoYW5nZSBoYXMgbm8gaW1wcm92ZW1lbnQuIGN1cnJlbnRs eSB3ZSB1c2UgYSBnbG9iYWwNCj4gbXRrX2lvbW11X2dldF9tNHVfZGF0YSB0byBnZXQgdGhlIE00 VSBkYXRhLiBJIHdpbGwgYmUgdmVyeSBnbGFkIGlmIHlvdQ0KPiBjb3VsZCBnZXQgcmlkIG9mIGl0 LiBCdXQgaW4gdGhpcyBwYXRjaHNldCwgWW91IHVzZSBhIGFub3RoZXIgZ2xvYmFsDQo+IG10a19p b21tdV9wZ3RhYmxlIHRvIGluc3RlYWQuIEZvciBtZS4gSXQgaGFzIG5vIGltcHJvdmVtZW50Lg0K DQpUaGFua3MgZm9yIHlvdSBhZHZpY2UhDQoNCkZvciBjdXJyZW50IFNXIGFyY2gsIGFsbCB0aGUg SU9NTVUgSFcgdXNlIHRoZSBzYW1lIHBhZ2UgdGFibGUsIHdlIGNhbg0KdXNlIGEgZ2xvYmFsIG10 a19pb21tdV9wZ3RhYmxlIHRvIGRpc2NyaWJlIHRoZSBpbmZvcm1hdGlvbiBvZiBwYWdlIHRhYmxl DQphbmQgYWxsIHRoZSBJT01NVSBhdHRhY2ggaXQsIEkgdGhpbmsgdGhhdCBpdCBpcyBtb3JlIGNs ZWFyIGFuZA0KdW5hbWJpZ3VvdXMuIEZvciBiZWdpbm5lcnMsIGl0IG1heWJlIG1vcmUgZWFzaWx5 IGV4cGxpY2FibGU/IA0KDQo+IA0KPiBiKSBUaGlzIHBhdGNoc2V0IGJyZWFrIHRoZSBvcmlnaW5h bCBmbG93LiBkZXZpY2VfZ3JvdXAgZ2l2ZSB5b3UgYQ0KPiBzb2Z0d2FyZSBjaGFuY2UgZm9yIGlu aXRpYWxpemluZywgdGhlbiB5b3UgbW92ZSBwYWdldGFibGUgYWxsb2NhdGluZw0KPiBjb2RlIGlu dG8gaXQuIEJ1dCBpdCBpc24ndCBkZXZpY2VfZ3JvdXAgam9iLg0KPiANCg0KQXMgaXMgc2hvd24g YWJvdmUgZGlhZ3JhbSwgbXRrX2lvbW11X3BndGFibGUgaW5jbHVkZXMgaW9tbXVfZ3JvdXAgYW5k DQppb21tdV9kb21haW4sc28gd2UgbmVlZCB0byBhbGxvY2F0ZSBtdGtfaW9tbXVfcGd0YWJsZSBh bmQgaW5pdGlhbGl6ZSBpdA0KaW4gZGV2aWNlX2dyb3VwIGZpcnN0bHksYW5kIHRoZW4gZXhlY3V0 ZSB0aGUgb3JpZ2luYWwgZmxvdywgaXQgb25seQ0KY2hhbmdlcyBwbGFjZSBmb3IgY3JlYXRpbmcg bXRrX2lvbW11X3BndGFibGUgYW5kIGRvbid0IGJyZWFrIG9yaWdpbmFsDQpkZXZpY2VfZ3JvdXAg Zmxvdy4NCg0KDQoNCg0KPiBJIGNhbiBub3QgZGVjaWRlIGlmIHlvdXIgZmxvdyBpcyByaWdodC4g QnV0IGlmIHlvdSBvbmx5IHdhbnQgdG8gYWRkDQo+IHN1cHBvcnQgbXVsdGktZG9tYWluLCBJIGd1 ZXNzIHlvdSBjb3VsZCBleHRlbmQgdGhlIGN1cnJlbnQgIm00dV9ncm91cCINCj4gdG8gYSBhcnJh eSAibTR1X2dyb3VwW05dIi4gSXQgbWF5IGJlIG1vcmUgc2ltcGxlLiBUbyBtYWtlIG10Njc3OQ0K PiBwcm9ncmVzcyBlYXNpbHksIEkgc3VnZ2VzdCB5b3UgY2FuIHVzZSB0aGlzIHdheSB0byBzdXBw b3J0IG11bHRpLWRvbWFpbg0KPiBmaXJzdGx5LiBUaGVuIHlvdSBjb3VsZCBzZW5kIHRoaXMgbmV3 IG10a19pb21tdV9wZ3RhYmxlIHBhdGNoc2V0IGZvciB0aGUNCj4gY29kZSAibW9yZSBleHBsaWNp dCIgaWYgeW91IGluc2lzdC4NCj4gDQo+ID4gVGhlIGRpYWdyYW0gaXMgYXMgYmVsb3c6DQo+ID4g DQo+ID4gCW10a19pb21tdV9kYXRhMShNTSkgICAgICAgbXRrX2lvbW11X2RhdGEyKEFQVSkNCj4g PiAJCXwJCQkgICB8DQo+ID4gCQl8CQkJICAgfA0KPiA+IAkJLS0tLS0tbXRrX2lvbW11X3BndGFi bGUtLS0tLQ0KPiA+IA0KPiA+IFdlIG5lZWQgdG8gY3JlYXRlIGdsb2JhbCBtdGtfaW9tbXVfcGd0 YWJsZSB0byBpbmNsdWRlIGFsbCB0aGUgaW92YQ0KPiA+IHJlZ2lvbnMgZmlyc3RseSBhbmQgc3Bl Y2lhbCBpb3ZhIHJlZ2lvbnMgYnkgZGl2aWRlZCBiYXNlZCBvbiBpdCwNCj4gPiBzbyB0aGUgaW5m b3JtYXRpb24gb2YgcGd0YWJsZSBuZWVkcyB0byBiZSBjcmVhdGVkIGluIGRldmljZV9ncm91cC4N Cj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaGFvIEhhbyA8Y2hhby5oYW9AbWVkaWF0ZWsuY29t Pg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL2lvbW11L210a19pb21tdS5jIHwgODQgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ID4gIGRyaXZlcnMvaW9tbXUvbXRrX2lv bW11LmggfCAgMSArDQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgODUgaW5zZXJ0aW9ucygrKQ0KPiA+ IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lvbW11L210a19pb21tdS5jIGIvZHJpdmVycy9p b21tdS9tdGtfaW9tbXUuYw0KPiA+IGluZGV4IGYyODQ3ZTY2MTEzNy4uZmNiZGU2YjBmNThkIDEw MDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvaW9tbXUvbXRrX2lvbW11LmMNCj4gPiArKysgYi9kcml2 ZXJzL2lvbW11L210a19pb21tdS5jDQo+ID4gQEAgLTEyMyw2ICsxMjMsMTIgQEAgc3RydWN0IG10 a19pb21tdV9kb21haW4gew0KPiA+ICAJc3RydWN0IGlvbW11X2RvbWFpbgkJZG9tYWluOw0KPiA+ ICB9Ow0KPiA+ICANCj4gPiArc3RydWN0IG10a19pb21tdV9wZ3RhYmxlIHsNCj4gPiArCXN0cnVj dCBpb19wZ3RhYmxlX2NmZwljZmc7DQo+ID4gKwlzdHJ1Y3QgaW9fcGd0YWJsZV9vcHMJKmlvcDsN Cj4gPiArfTsNCj4gPiArDQo+ID4gK3N0YXRpYyBzdHJ1Y3QgbXRrX2lvbW11X3BndGFibGUgKnNo YXJlX3BndGFibGU7DQo+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIG10a19pb21t dV9vcHM7DQo+ID4gIA0KPiA+ICAvKg0KPiA+IEBAIC0xNzAsNiArMTc2LDExIEBAIHN0YXRpYyBz dHJ1Y3QgbXRrX2lvbW11X2RhdGEgKm10a19pb21tdV9nZXRfbTR1X2RhdGEodm9pZCkNCj4gPiAg CXJldHVybiBOVUxMOw0KPiA+ICB9DQo+ID4gIA0KPiA+ICtzdGF0aWMgc3RydWN0IG10a19pb21t dV9wZ3RhYmxlICptdGtfaW9tbXVfZ2V0X3BndGFibGUodm9pZCkNCj4gPiArew0KPiA+ICsJcmV0 dXJuIHNoYXJlX3BndGFibGU7DQo+ID4gK30NCj4gPiArDQo+ID4gIHN0YXRpYyBzdHJ1Y3QgbXRr X2lvbW11X2RvbWFpbiAqdG9fbXRrX2RvbWFpbihzdHJ1Y3QgaW9tbXVfZG9tYWluICpkb20pDQo+ ID4gIHsNCj4gPiAgCXJldHVybiBjb250YWluZXJfb2YoZG9tLCBzdHJ1Y3QgbXRrX2lvbW11X2Rv bWFpbiwgZG9tYWluKTsNCj4gPiBAQCAtMzIyLDYgKzMzMywxMyBAQCBzdGF0aWMgaW50IG10a19p b21tdV9kb21haW5fZmluYWxpc2Uoc3RydWN0IG10a19pb21tdV9kb21haW4gKmRvbSkNCj4gPiAg ew0KPiA+ICAJc3RydWN0IG10a19pb21tdV9kYXRhICpkYXRhID0gbXRrX2lvbW11X2dldF9tNHVf ZGF0YSgpOw0KPiA+ICANCj4gPiArCWlmIChkYXRhLT5wZ3RhYmxlKSB7DQo+ID4gKwkJZG9tLT5j ZmcgPSBkYXRhLT5wZ3RhYmxlLT5jZmc7DQo+ID4gKwkJZG9tLT5pb3AgPSBkYXRhLT5wZ3RhYmxl LT5pb3A7DQo+ID4gKwkJZG9tLT5kb21haW4ucGdzaXplX2JpdG1hcCA9IGRhdGEtPnBndGFibGUt PmNmZy5wZ3NpemVfYml0bWFwOw0KPiA+ICsJCXJldHVybiAwOw0KPiA+ICsJfQ0KPiA+ICsNCj4g PiAgCWRvbS0+Y2ZnID0gKHN0cnVjdCBpb19wZ3RhYmxlX2NmZykgew0KPiA+ICAJCS5xdWlya3Mg PSBJT19QR1RBQkxFX1FVSVJLX0FSTV9OUyB8DQo+ID4gIAkJCUlPX1BHVEFCTEVfUVVJUktfTk9f UEVSTVMgfA0KPiA+IEBAIC0zNDUsNiArMzYzLDYxIEBAIHN0YXRpYyBpbnQgbXRrX2lvbW11X2Rv bWFpbl9maW5hbGlzZShzdHJ1Y3QgbXRrX2lvbW11X2RvbWFpbiAqZG9tKQ0KPiA+ICAJcmV0dXJu IDA7DQo+ID4gIH0NCj4gPiAgDQo+ID4gK3N0YXRpYyBzdHJ1Y3QgbXRrX2lvbW11X3BndGFibGUg KmNyZWF0ZV9wZ3RhYmxlKHN0cnVjdCBtdGtfaW9tbXVfZGF0YSAqZGF0YSkNCj4gPiArew0KPiA+ ICsJc3RydWN0IG10a19pb21tdV9wZ3RhYmxlICpwZ3RhYmxlOw0KPiA+ICsNCj4gPiArCXBndGFi bGUgPSBremFsbG9jKHNpemVvZigqcGd0YWJsZSksIEdGUF9LRVJORUwpOw0KPiA+ICsJaWYgKCFw Z3RhYmxlKQ0KPiA+ICsJCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOw0KPiA+ICsNCj4gPiArCXBn dGFibGUtPmNmZyA9IChzdHJ1Y3QgaW9fcGd0YWJsZV9jZmcpIHsNCj4gPiArCQkucXVpcmtzID0g SU9fUEdUQUJMRV9RVUlSS19BUk1fTlMgfA0KPiA+ICsJCQlJT19QR1RBQkxFX1FVSVJLX05PX1BF Uk1TIHwNCj4gPiArCQkJSU9fUEdUQUJMRV9RVUlSS19UTEJJX09OX01BUCB8DQo+ID4gKwkJCUlP X1BHVEFCTEVfUVVJUktfQVJNX01US19FWFQsDQo+ID4gKwkJLnBnc2l6ZV9iaXRtYXAgPSBtdGtf aW9tbXVfb3BzLnBnc2l6ZV9iaXRtYXAsDQo+ID4gKwkJLmlhcyA9IDMyLA0KPiA+ICsJCS5vYXMg PSAzNCwNCj4gPiArCQkudGxiID0gJm10a19pb21tdV9mbHVzaF9vcHMsDQo+ID4gKwkJLmlvbW11 X2RldiA9IGRhdGEtPmRldiwNCj4gPiArCX07DQo+ID4gKw0KPiA+ICsJcGd0YWJsZS0+aW9wID0g YWxsb2NfaW9fcGd0YWJsZV9vcHMoQVJNX1Y3UywgJnBndGFibGUtPmNmZywgZGF0YSk7DQo+ID4g KwlpZiAoIXBndGFibGUtPmlvcCkgew0KPiA+ICsJCWRldl9lcnIoZGF0YS0+ZGV2LCAiRmFpbGVk IHRvIGFsbG9jIGlvIHBndGFibGVcbiIpOw0KPiA+ICsJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwp Ow0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCWRldl9pbmZvKGRhdGEtPmRldiwgIiVzIGNyZWF0ZSBw Z3RhYmxlIGRvbmVcbiIsIF9fZnVuY19fKTsNCj4gPiArDQo+ID4gKwlyZXR1cm4gcGd0YWJsZTsN Cj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBtdGtfaW9tbXVfYXR0YWNoX3BndGFibGUo c3RydWN0IG10a19pb21tdV9kYXRhICpkYXRhLA0KPiA+ICsJCQkJICAgIHN0cnVjdCBkZXZpY2Ug KmRldikNCj4gPiArew0KPiA+ICsJc3RydWN0IG10a19pb21tdV9wZ3RhYmxlICpwZ3RhYmxlID0g bXRrX2lvbW11X2dldF9wZ3RhYmxlKCk7DQo+ID4gKw0KPiA+ICsJLyogY3JlYXRlIHNoYXJlIHBn dGFibGUgKi8NCj4gPiArCWlmICghcGd0YWJsZSkgew0KPiA+ICsJCXBndGFibGUgPSBjcmVhdGVf cGd0YWJsZShkYXRhKTsNCj4gPiArCQlpZiAoSVNfRVJSKHBndGFibGUpKSB7DQo+ID4gKwkJCWRl dl9lcnIoZGF0YS0+ZGV2LCAiRmFpbGVkIHRvIGNyZWF0ZSBwZ3RhYmxlXG4iKTsNCj4gPiArCQkJ cmV0dXJuIC1FTk9NRU07DQo+ID4gKwkJfQ0KPiA+ICsNCj4gPiArCQlzaGFyZV9wZ3RhYmxlID0g cGd0YWJsZTsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwkvKiBiaW5kaW5nIHRvIHBndGFibGUgKi8N Cj4gPiArCWRhdGEtPnBndGFibGUgPSBwZ3RhYmxlOw0KPiA+ICsNCj4gPiArCWRldl9pbmZvKGRh dGEtPmRldiwgIm00dSVkIGF0dGFjaF9wZ3RhYmxlIGRvbmUhXG4iLCBkYXRhLT5tNHVfaWQpOw0K PiA+ICsNCj4gPiArCXJldHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICBzdGF0aWMgc3RydWN0 IGlvbW11X2RvbWFpbiAqbXRrX2lvbW11X2RvbWFpbl9hbGxvYyh1bnNpZ25lZCB0eXBlKQ0KPiA+ ICB7DQo+ID4gIAlzdHJ1Y3QgbXRrX2lvbW11X2RvbWFpbiAqZG9tOw0KPiA+IEBAIC01MDgsMTAg KzU4MSwyMSBAQCBzdGF0aWMgdm9pZCBtdGtfaW9tbXVfcmVtb3ZlX2RldmljZShzdHJ1Y3QgZGV2 aWNlICpkZXYpDQo+ID4gIHN0YXRpYyBzdHJ1Y3QgaW9tbXVfZ3JvdXAgKm10a19pb21tdV9kZXZp Y2VfZ3JvdXAoc3RydWN0IGRldmljZSAqZGV2KQ0KPiA+ICB7DQo+ID4gIAlzdHJ1Y3QgbXRrX2lv bW11X2RhdGEgKmRhdGEgPSBtdGtfaW9tbXVfZ2V0X200dV9kYXRhKCk7DQo+ID4gKwlzdHJ1Y3Qg bXRrX2lvbW11X3BndGFibGUgKnBndGFibGU7DQo+ID4gKwlpbnQgcmV0ID0gMDsNCj4gPiAgDQo+ ID4gIAlpZiAoIWRhdGEpDQo+ID4gIAkJcmV0dXJuIEVSUl9QVFIoLUVOT0RFVik7DQo+ID4gIA0K PiA+ICsJcGd0YWJsZSA9IGRhdGEtPnBndGFibGU7DQo+ID4gKwlpZiAoIXBndGFibGUpIHsNCj4g PiArCQlyZXQgPSBtdGtfaW9tbXVfYXR0YWNoX3BndGFibGUoZGF0YSwgZGV2KTsNCj4gPiArCQlp ZiAocmV0KSB7DQo+ID4gKwkJCWRldl9lcnIoZGF0YS0+ZGV2LCAiRmFpbGVkIHRvIGRldmljZV9n cm91cFxuIik7DQo+ID4gKwkJCXJldHVybiBOVUxMOw0KPiA+ICsJCX0NCj4gPiArCX0NCj4gPiAr DQo+ID4gIAkvKiBBbGwgdGhlIGNsaWVudCBkZXZpY2VzIGFyZSBpbiB0aGUgc2FtZSBtNHUgaW9t bXUtZ3JvdXAgKi8NCj4gPiAgCWlmICghZGF0YS0+bTR1X2dyb3VwKSB7DQo+ID4gIAkJZGF0YS0+ bTR1X2dyb3VwID0gaW9tbXVfZ3JvdXBfYWxsb2MoKTsNCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9pb21tdS9tdGtfaW9tbXUuaCBiL2RyaXZlcnMvaW9tbXUvbXRrX2lvbW11LmgNCj4gPiBpbmRl eCAxMzJkYzc2NWE0MGIuLmRkNWYxOWY3OGI2MiAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2lv bW11L210a19pb21tdS5oDQo+ID4gKysrIGIvZHJpdmVycy9pb21tdS9tdGtfaW9tbXUuaA0KPiA+ IEBAIC02MSw2ICs2MSw3IEBAIHN0cnVjdCBtdGtfaW9tbXVfZGF0YSB7DQo+ID4gIAlzdHJ1Y3Qg Y2xrCQkJKmJjbGs7DQo+ID4gIAlwaHlzX2FkZHJfdAkJCXByb3RlY3RfYmFzZTsgLyogcHJvdGVj dCBtZW1vcnkgYmFzZSAqLw0KPiA+ICAJc3RydWN0IG10a19pb21tdV9zdXNwZW5kX3JlZwlyZWc7 DQo+ID4gKwlzdHJ1Y3QgbXRrX2lvbW11X3BndGFibGUJKnBndGFibGU7DQo+ID4gIAlzdHJ1Y3Qg bXRrX2lvbW11X2RvbWFpbgkJKm00dV9kb207DQo+ID4gIAlzdHJ1Y3QgaW9tbXVfZ3JvdXAJCSpt NHVfZ3JvdXA7DQo+ID4gIAlib29sICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVuYWJsZV80 R0I7DQo+IA0KPiANCg0K