From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF79FC2D0DD for ; Thu, 2 Jan 2020 05:42:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3ADA206E6 for ; Thu, 2 Jan 2020 05:42:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LbXn5KAZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="POvMlw9f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3ADA206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QUvQ73VmMrfvPkiOSUV+QQgS1Hf5pXibgB/BkxLuHgE=; b=LbXn5KAZdM+2CH vLvvA84Ci9aiKVIo72wVBK8UA1hAG+kM6sggztjmbJtrkORWlu/O6SVJ+6uLvnRTu8cPqlQfSnITv Khul4Y6f7iCULIzui2fV1pP7jdVVasEIht9wPE+mL/o44rndGsFcT8zhoJtR/vIvN4+afsqFIrEiT oOOEjOacZzn/jo9QaPtVnuuiiaHOI3Twux7lpUbhkBK1TrPiIYFd3GlkKe5Btwq8F7QrU4Q++s9ey dd8S1DmJxryJXACvloGg+SyE4GNbVhEwG6NwP1YCLkMK/C+OuAtS5893k7w7vuWdfgscBeTtoIWM0 pyP0eBxKvlahiWBgekwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtF9-0007H7-0k; Thu, 02 Jan 2020 05:41:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtF2-0007Ab-Cy; Thu, 02 Jan 2020 05:41:53 +0000 X-UUID: 2d4ac5d91a8b4e1d81f23bb00013f9a6-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=grGSLMHsu/cpV4RBGH89GKd36Lx7zKXB7OI8Y/1330c=; b=POvMlw9f5MDvgIRJwbLaebwkXKzxA7ccgIdYBoRVlyNWUUyFH9XFsv/3pDY64yWDo678GT0//MJlnWirpKXd5RugELaKKBRz3sEvYazxiqXvkH0kJMJRyp3L/NmczXeRCPXFgV9yzUb4i3UrAW9axRUOqXyOQGpt+e9jHhXYQQU=; X-UUID: 2d4ac5d91a8b4e1d81f23bb00013f9a6-20200101 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1890339222; Wed, 01 Jan 2020 21:41:49 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 21:41:33 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 13:40:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 13:41:35 +0800 Message-ID: <1577943579.15116.1.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu To: CK Hu Date: Thu, 2 Jan 2020 13:39:39 +0800 In-Reply-To: <1577941388.24650.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_214152_445882_2DD6D1C2 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > move dsi/dpi select input into mtk_ddp_sel_in > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > index 39700b9..91c9b19 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > *addr = DISP_REG_CONFIG_DSI_SEL; > > value = DSI_SEL_IN_BLS; > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > + value = DSI_SEL_IN_RDMA; > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > DDP_COMPONENT_DPI0. Why do you change the condition? > > Regards, > CK if bls connect with dpi0, rdma1 should connect with dsi0, the condition is same with before. > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > + value = DPI_SEL_IN_BLS; > > } else { > > value = 0; > > } > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > BLS_TO_DPI_RDMA1_TO_DSI); > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > - DSI_SEL_IN_RDMA); > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > - DPI_SEL_IN_BLS); > > } > > } > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760E8C2D0DD for ; Thu, 2 Jan 2020 05:42:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46A02206E6 for ; Thu, 2 Jan 2020 05:42:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tOeg3Zga"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="POvMlw9f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46A02206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eofpPYgUbVAytp05AYvngySLk7T4RfpQzpn6BxFIcrE=; b=tOeg3ZgafXYUqh d8b04Z6a5yWZMP/tCrAgQWY+qBzvBrz9gBS0hi2rZPAlNqs8E+nVAvgczP3hvvurtFdg2iervbHIn fbCkBr6nfIr2VlohA5f+myuQqN/rKLycmdCWtHasfveIB/Q7SoCX2TTfaBzx+QXfrvWw9SgwRyWPl w3awzgTMZREroYEptv/Wc2qBAivBDKLPZa8xGyzUGDHTJIed+YeNAqcPEjyeuyWHcKsEOnjRLfBbz n1kimSz8+P03U7I9w9xsbpxNHQcJEbU5Y3cc6dRmaaypL2bRyaEiTsNUC5U/ekMoNOCZhy5Krv7Y2 P+oVdNYxs3zOUP5jiy6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtF5-0007B0-8p; Thu, 02 Jan 2020 05:41:55 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtF2-0007Ab-Cy; Thu, 02 Jan 2020 05:41:53 +0000 X-UUID: 2d4ac5d91a8b4e1d81f23bb00013f9a6-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=grGSLMHsu/cpV4RBGH89GKd36Lx7zKXB7OI8Y/1330c=; b=POvMlw9f5MDvgIRJwbLaebwkXKzxA7ccgIdYBoRVlyNWUUyFH9XFsv/3pDY64yWDo678GT0//MJlnWirpKXd5RugELaKKBRz3sEvYazxiqXvkH0kJMJRyp3L/NmczXeRCPXFgV9yzUb4i3UrAW9axRUOqXyOQGpt+e9jHhXYQQU=; X-UUID: 2d4ac5d91a8b4e1d81f23bb00013f9a6-20200101 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1890339222; Wed, 01 Jan 2020 21:41:49 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 21:41:33 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 13:40:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 13:41:35 +0800 Message-ID: <1577943579.15116.1.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu To: CK Hu Date: Thu, 2 Jan 2020 13:39:39 +0800 In-Reply-To: <1577941388.24650.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_214152_445882_2DD6D1C2 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > move dsi/dpi select input into mtk_ddp_sel_in > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > index 39700b9..91c9b19 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > *addr = DISP_REG_CONFIG_DSI_SEL; > > value = DSI_SEL_IN_BLS; > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > + value = DSI_SEL_IN_RDMA; > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > DDP_COMPONENT_DPI0. Why do you change the condition? > > Regards, > CK if bls connect with dpi0, rdma1 should connect with dsi0, the condition is same with before. > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > + value = DPI_SEL_IN_BLS; > > } else { > > value = 0; > > } > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > BLS_TO_DPI_RDMA1_TO_DSI); > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > - DSI_SEL_IN_RDMA); > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > - DPI_SEL_IN_BLS); > > } > > } > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C557DC2D0DD for ; Thu, 2 Jan 2020 05:41:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 988EA206E6 for ; Thu, 2 Jan 2020 05:41:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="OQRpVxnk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726019AbgABFlT (ORCPT ); Thu, 2 Jan 2020 00:41:19 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:52191 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725788AbgABFlS (ORCPT ); Thu, 2 Jan 2020 00:41:18 -0500 X-UUID: df0ec7433a0c45419b6ba66a6c6ba05f-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=grGSLMHsu/cpV4RBGH89GKd36Lx7zKXB7OI8Y/1330c=; b=OQRpVxnk/C5Ai/83w4xNFWYSHXlSTEeEPHd/+vsYOWr3EopWB948ENM+GfZX02Xn5oGSzjXCUmhwZr13FB3gE9H8betxxqCuApda76lbKT8GBqxtlxwDVs8t4GX67JzuPgg6MU2yygCliYLdLtCAwxfGc86kx4XiNARmDnXkdLI=; X-UUID: df0ec7433a0c45419b6ba66a6c6ba05f-20200102 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 509224428; Thu, 02 Jan 2020 13:41:12 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 13:40:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 13:41:35 +0800 Message-ID: <1577943579.15116.1.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu Reply-To: Yongqiang Niu To: CK Hu CC: Philipp Zabel , Rob Herring , Matthias Brugger , "David Airlie" , Daniel Vetter , Mark Rutland , , , , , Date: Thu, 2 Jan 2020 13:39:39 +0800 In-Reply-To: <1577941388.24650.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org T24gVGh1LCAyMDIwLTAxLTAyIGF0IDEzOjAzICswODAwLCBDSyBIdSB3cm90ZToNCj4gSGksIFlv bmdxaWFuZzoNCj4gDQo+IE9uIFRodSwgMjAyMC0wMS0wMiBhdCAxMjowMCArMDgwMCwgWW9uZ3Fp YW5nIE5pdSB3cm90ZToNCj4gPiBtb3ZlIGRzaS9kcGkgc2VsZWN0IGlucHV0IGludG8gbXRrX2Rk cF9zZWxfaW4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBZb25ncWlhbmcgTml1IDx5b25ncWlh bmcubml1QG1lZGlhdGVrLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kcm1fZGRwLmMgfCAxMCArKysrKystLS0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2 IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcC5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fZGRwLmMNCj4gPiBpbmRleCAzOTcwMGI5Li45MWM5YjE5IDEwMDY0NA0K PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcC5jDQo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMNCj4gPiBAQCAtMzc2LDYg KzM3NiwxMiBAQCBzdGF0aWMgdW5zaWduZWQgaW50IG10a19kZHBfc2VsX2luKGVudW0gbXRrX2Rk cF9jb21wX2lkIGN1ciwNCj4gPiAgCX0gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfQkxT ICYmIG5leHQgPT0gRERQX0NPTVBPTkVOVF9EU0kwKSB7DQo+ID4gIAkJKmFkZHIgPSBESVNQX1JF R19DT05GSUdfRFNJX1NFTDsNCj4gPiAgCQl2YWx1ZSA9IERTSV9TRUxfSU5fQkxTOw0KPiA+ICsJ fSBlbHNlIGlmIChjdXIgPT0gRERQX0NPTVBPTkVOVF9SRE1BMSAmJiBuZXh0ID09IEREUF9DT01Q T05FTlRfRFNJMCkgew0KPiA+ICsJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RTSV9TRUw7DQo+ ID4gKwkJdmFsdWUgPSBEU0lfU0VMX0lOX1JETUE7DQo+IA0KPiBJbiBvcmlnaW5hbCBjb2RlLCB0 aGlzIGlzIHNldCB3aGVuIGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyBhbmQgbmV4dCA9PQ0KPiBE RFBfQ09NUE9ORU5UX0RQSTAuIFdoeSBkbyB5b3UgY2hhbmdlIHRoZSBjb25kaXRpb24/DQo+IA0K PiBSZWdhcmRzLA0KPiBDSw0KDQppZiBibHMgY29ubmVjdCB3aXRoIGRwaTAsIHJkbWExIHNob3Vs ZCBjb25uZWN0IHdpdGggZHNpMCwgdGhlIGNvbmRpdGlvbg0KaXMgc2FtZSB3aXRoIGJlZm9yZS4N Cj4gDQo+ID4gKwl9IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyAmJiBuZXh0ID09 IEREUF9DT01QT05FTlRfRFBJMCkgew0KPiA+ICsJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RQ SV9TRUw7DQo+ID4gKwkJdmFsdWUgPSBEUElfU0VMX0lOX0JMUzsNCj4gPiAgCX0gZWxzZSB7DQo+ ID4gIAkJdmFsdWUgPSAwOw0KPiA+ICAJfQ0KPiA+IEBAIC0zOTMsMTAgKzM5OSw2IEBAIHN0YXRp YyB2b2lkIG10a19kZHBfc291dF9zZWwoc3RydWN0IHJlZ21hcCAqY29uZmlnX3JlZ3MsDQo+ID4g IAl9IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyAmJiBuZXh0ID09IEREUF9DT01Q T05FTlRfRFBJMCkgew0KPiA+ICAJCXJlZ21hcF93cml0ZShjb25maWdfcmVncywgRElTUF9SRUdf Q09ORklHX09VVF9TRUwsDQo+ID4gIAkJCQlCTFNfVE9fRFBJX1JETUExX1RPX0RTSSk7DQo+ID4g LQkJcmVnbWFwX3dyaXRlKGNvbmZpZ19yZWdzLCBESVNQX1JFR19DT05GSUdfRFNJX1NFTCwNCj4g PiAtCQkJCURTSV9TRUxfSU5fUkRNQSk7DQo+ID4gLQkJcmVnbWFwX3dyaXRlKGNvbmZpZ19yZWdz LCBESVNQX1JFR19DT05GSUdfRFBJX1NFTCwNCj4gPiAtCQkJCURQSV9TRUxfSU5fQkxTKTsNCj4g PiAgCX0NCj4gPiAgfQ0KPiA+ICANCj4gDQo+IA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C67DCC2D0DC for ; Thu, 2 Jan 2020 10:58:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CBE1215A4 for ; Thu, 2 Jan 2020 10:58:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="OQRpVxnk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CBE1215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 448566E081; Thu, 2 Jan 2020 10:58:21 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 86D6789B18 for ; Thu, 2 Jan 2020 05:41:18 +0000 (UTC) X-UUID: df0ec7433a0c45419b6ba66a6c6ba05f-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=grGSLMHsu/cpV4RBGH89GKd36Lx7zKXB7OI8Y/1330c=; b=OQRpVxnk/C5Ai/83w4xNFWYSHXlSTEeEPHd/+vsYOWr3EopWB948ENM+GfZX02Xn5oGSzjXCUmhwZr13FB3gE9H8betxxqCuApda76lbKT8GBqxtlxwDVs8t4GX67JzuPgg6MU2yygCliYLdLtCAwxfGc86kx4XiNARmDnXkdLI=; X-UUID: df0ec7433a0c45419b6ba66a6c6ba05f-20200102 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 509224428; Thu, 02 Jan 2020 13:41:12 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 13:40:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 13:41:35 +0800 Message-ID: <1577943579.15116.1.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu To: CK Hu Date: Thu, 2 Jan 2020 13:39:39 +0800 In-Reply-To: <1577941388.24650.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Thu, 02 Jan 2020 10:58:15 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > move dsi/dpi select input into mtk_ddp_sel_in > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > index 39700b9..91c9b19 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > *addr = DISP_REG_CONFIG_DSI_SEL; > > value = DSI_SEL_IN_BLS; > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > + value = DSI_SEL_IN_RDMA; > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > DDP_COMPONENT_DPI0. Why do you change the condition? > > Regards, > CK if bls connect with dpi0, rdma1 should connect with dsi0, the condition is same with before. > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > + value = DPI_SEL_IN_BLS; > > } else { > > value = 0; > > } > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > BLS_TO_DPI_RDMA1_TO_DSI); > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > - DSI_SEL_IN_RDMA); > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > - DPI_SEL_IN_BLS); > > } > > } > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel