From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 283F3C2D0DD for ; Thu, 2 Jan 2020 06:02:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFEAC215A4 for ; Thu, 2 Jan 2020 06:02:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FwQYIM1E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="O7hF0nTw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFEAC215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PrOsvd6ShscEii8O078N7i3arCt+ZjkC8eiaRJVSvzQ=; b=FwQYIM1EH+NLgr tTcwIjgWVJ8BJMnuJBWarV8it8pyzPZ8GGPMaN+UMlVHXkYLcFtm446DEMWOwGrqDtCezUeivOavr nyubSbnc012WU0PRSxX7TZs6IFZ9lQHQJzxMi+NfXkjOY3cqxdVCiL30tGQzeYx5LrXxu+ZfFBSBP 5CqY7XBqk9j16ZUu/cxaJnlXBUdgvLzoEqw4g6IE21H9K6Oqly4C1Vqq5KH0D7Purch1LT1QO+WsZ 6vH1o/bX6uMpIs0Xwe3sI4aeTmp/huRQPucAE8Sbt/ZPkzP9njkMV6o6vRaSVa/26Jllr/tBBfkvp zF5quukXBzG9HrEiNeKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtZE-0005lI-EC; Thu, 02 Jan 2020 06:02:44 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtZ7-0005eR-GG; Thu, 02 Jan 2020 06:02:38 +0000 X-UUID: eb7e7374a7f243a8b4e57f475926882e-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VDLfXcYUJeQkJKhzGgI3LI0lhtwysIGtBl5WGX6utNk=; b=O7hF0nTwd6lPRQ8AqSbs/D1ddVdIWyzkxpkc8oXvAqKCzabUqM0AIvGL6Ku7KwXchbQ1AU5VGzAxbEJ0vgjMfKEsREIQTbMWyIn50Y60Qm6OLw8oOm0I3Q79n7dYOe1z/SwzkJZjUnJabHRO7AvQwyqnAt8NDUjiHvbKQosdAUE=; X-UUID: eb7e7374a7f243a8b4e57f475926882e-20200101 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 782958140; Wed, 01 Jan 2020 22:02:34 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 22:02:54 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:02:00 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:02:56 +0800 Message-ID: <1577944949.32066.1.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 14:02:29 +0800 In-Reply-To: <1577943579.15116.1.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A1684504572D72737A9A3F6FE56B804FCF8791910A3C4C4D11C54BBD967F1E9D2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_220237_550262_7D83BC92 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > index 39700b9..91c9b19 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > value = DSI_SEL_IN_BLS; > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > + value = DSI_SEL_IN_RDMA; > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > Regards, > > CK > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > is same with before. You suggest that two crtcs are both enabled. If only one crtc is enabled, just one of these two would be set. Regards, CK > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > + value = DPI_SEL_IN_BLS; > > > } else { > > > value = 0; > > > } > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > - DSI_SEL_IN_RDMA); > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > - DPI_SEL_IN_BLS); > > > } > > > } > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B32C2D0DD for ; Thu, 2 Jan 2020 06:02:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE2F5215A4 for ; Thu, 2 Jan 2020 06:02:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RKv8KPS9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="O7hF0nTw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE2F5215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uqRpGAc2M75ggIEmjMaz6lYmjw5709BbHyvh74vKxTU=; b=RKv8KPS9Qoj688 9dkEBgX7REg3rOArYAZYewWJwCGnDhDuEo5PuBcAlc5jFo2UCkWuCnTmM1uCQrV3F4ExUcxtNYQRw TcZn4Sv/k3LIIE8AL7nPcWQMW6RCP5CcjdRHEH9/FC6ZtyXKEqXkF/JjKcmbeXb+qLNOY13HS32Kr zSKMIA6zWeZnHCYk2nzfwjTNQjZCaPALHghgZ8NeWXDiYAsKVbE06eh1hlvuzqsloJrzYzoC+FcSY jq+9zEUgju8YswMT5kJimHu6tiqat26EtcpVd1Znmdf28tBWdZjUHOiWGGUzWSbIaAZ2Zq9Y5OV8L DbTCJIWGpzDQGjtb8dxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtZA-0005ev-3m; Thu, 02 Jan 2020 06:02:40 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imtZ7-0005eR-GG; Thu, 02 Jan 2020 06:02:38 +0000 X-UUID: eb7e7374a7f243a8b4e57f475926882e-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VDLfXcYUJeQkJKhzGgI3LI0lhtwysIGtBl5WGX6utNk=; b=O7hF0nTwd6lPRQ8AqSbs/D1ddVdIWyzkxpkc8oXvAqKCzabUqM0AIvGL6Ku7KwXchbQ1AU5VGzAxbEJ0vgjMfKEsREIQTbMWyIn50Y60Qm6OLw8oOm0I3Q79n7dYOe1z/SwzkJZjUnJabHRO7AvQwyqnAt8NDUjiHvbKQosdAUE=; X-UUID: eb7e7374a7f243a8b4e57f475926882e-20200101 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 782958140; Wed, 01 Jan 2020 22:02:34 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 22:02:54 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:02:00 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:02:56 +0800 Message-ID: <1577944949.32066.1.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 14:02:29 +0800 In-Reply-To: <1577943579.15116.1.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A1684504572D72737A9A3F6FE56B804FCF8791910A3C4C4D11C54BBD967F1E9D2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_220237_550262_7D83BC92 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > index 39700b9..91c9b19 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > value = DSI_SEL_IN_BLS; > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > + value = DSI_SEL_IN_RDMA; > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > Regards, > > CK > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > is same with before. You suggest that two crtcs are both enabled. If only one crtc is enabled, just one of these two would be set. Regards, CK > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > + value = DPI_SEL_IN_BLS; > > > } else { > > > value = 0; > > > } > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > - DSI_SEL_IN_RDMA); > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > - DPI_SEL_IN_BLS); > > > } > > > } > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5FF3C2D0DD for ; Thu, 2 Jan 2020 06:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D4DD215A4 for ; Thu, 2 Jan 2020 06:02:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="BH0kFVI/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726036AbgABGCg (ORCPT ); Thu, 2 Jan 2020 01:02:36 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:2170 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725788AbgABGCg (ORCPT ); Thu, 2 Jan 2020 01:02:36 -0500 X-UUID: dd7d204af3d64f0a9d0cc923b9ac291b-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VDLfXcYUJeQkJKhzGgI3LI0lhtwysIGtBl5WGX6utNk=; b=BH0kFVI/GfyFnrjxaR1KLl8zPJfGM+eUIy2VW299DXTrYnDB5XZcB2PN0fD+1v2h7vZacl6yO7aSkzSrotC4BXYTcfJBczEu3kato1AB6+5lIyIJUd6rpreIV8dsNiiPj690hxK37PAgc304s0V1m90JPvz6RvJGQPK99qCwqrE=; X-UUID: dd7d204af3d64f0a9d0cc923b9ac291b-20200102 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1129739519; Thu, 02 Jan 2020 14:02:31 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:02:00 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:02:56 +0800 Message-ID: <1577944949.32066.1.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu CC: Philipp Zabel , Rob Herring , Matthias Brugger , "David Airlie" , Daniel Vetter , Mark Rutland , , , , , Date: Thu, 2 Jan 2020 14:02:29 +0800 In-Reply-To: <1577943579.15116.1.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A1684504572D72737A9A3F6FE56B804FCF8791910A3C4C4D11C54BBD967F1E9D2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGksIFlvbmdxaWFuZzoNCg0KT24gVGh1LCAyMDIwLTAxLTAyIGF0IDEzOjM5ICswODAwLCBZb25n cWlhbmcgTml1IHdyb3RlOg0KPiBPbiBUaHUsIDIwMjAtMDEtMDIgYXQgMTM6MDMgKzA4MDAsIENL IEh1IHdyb3RlOg0KPiA+IEhpLCBZb25ncWlhbmc6DQo+ID4gDQo+ID4gT24gVGh1LCAyMDIwLTAx LTAyIGF0IDEyOjAwICswODAwLCBZb25ncWlhbmcgTml1IHdyb3RlOg0KPiA+ID4gbW92ZSBkc2kv ZHBpIHNlbGVjdCBpbnB1dCBpbnRvIG10a19kZHBfc2VsX2luDQo+ID4gPiANCj4gPiA+IFNpZ25l ZC1vZmYtYnk6IFlvbmdxaWFuZyBOaXUgPHlvbmdxaWFuZy5uaXVAbWVkaWF0ZWsuY29tPg0KPiA+ ID4gLS0tDQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMgfCAx MCArKysrKystLS0tDQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBk ZWxldGlvbnMoLSkNCj4gPiA+IA0KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9t ZWRpYXRlay9tdGtfZHJtX2RkcC5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1f ZGRwLmMNCj4gPiA+IGluZGV4IDM5NzAwYjkuLjkxYzliMTkgMTAwNjQ0DQo+ID4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYw0KPiA+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMNCj4gPiA+IEBAIC0zNzYsNiArMzc2LDEy IEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQgbXRrX2RkcF9zZWxfaW4oZW51bSBtdGtfZGRwX2NvbXBf aWQgY3VyLA0KPiA+ID4gIAl9IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyAmJiBu ZXh0ID09IEREUF9DT01QT05FTlRfRFNJMCkgew0KPiA+ID4gIAkJKmFkZHIgPSBESVNQX1JFR19D T05GSUdfRFNJX1NFTDsNCj4gPiA+ICAJCXZhbHVlID0gRFNJX1NFTF9JTl9CTFM7DQo+ID4gPiAr CX0gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfUkRNQTEgJiYgbmV4dCA9PSBERFBfQ09N UE9ORU5UX0RTSTApIHsNCj4gPiA+ICsJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RTSV9TRUw7 DQo+ID4gPiArCQl2YWx1ZSA9IERTSV9TRUxfSU5fUkRNQTsNCj4gPiANCj4gPiBJbiBvcmlnaW5h bCBjb2RlLCB0aGlzIGlzIHNldCB3aGVuIGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyBhbmQgbmV4 dCA9PQ0KPiA+IEREUF9DT01QT05FTlRfRFBJMC4gV2h5IGRvIHlvdSBjaGFuZ2UgdGhlIGNvbmRp dGlvbj8NCj4gPiANCj4gPiBSZWdhcmRzLA0KPiA+IENLDQo+IA0KPiBpZiBibHMgY29ubmVjdCB3 aXRoIGRwaTAsIHJkbWExIHNob3VsZCBjb25uZWN0IHdpdGggZHNpMCwgdGhlIGNvbmRpdGlvbg0K PiBpcyBzYW1lIHdpdGggYmVmb3JlLg0KDQpZb3Ugc3VnZ2VzdCB0aGF0IHR3byBjcnRjcyBhcmUg Ym90aCBlbmFibGVkLiBJZiBvbmx5IG9uZSBjcnRjIGlzDQplbmFibGVkLCBqdXN0IG9uZSBvZiB0 aGVzZSB0d28gd291bGQgYmUgc2V0Lg0KDQpSZWdhcmRzLA0KQ0sNCg0KPiA+IA0KPiA+ID4gKwl9 IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyAmJiBuZXh0ID09IEREUF9DT01QT05F TlRfRFBJMCkgew0KPiA+ID4gKwkJKmFkZHIgPSBESVNQX1JFR19DT05GSUdfRFBJX1NFTDsNCj4g PiA+ICsJCXZhbHVlID0gRFBJX1NFTF9JTl9CTFM7DQo+ID4gPiAgCX0gZWxzZSB7DQo+ID4gPiAg CQl2YWx1ZSA9IDA7DQo+ID4gPiAgCX0NCj4gPiA+IEBAIC0zOTMsMTAgKzM5OSw2IEBAIHN0YXRp YyB2b2lkIG10a19kZHBfc291dF9zZWwoc3RydWN0IHJlZ21hcCAqY29uZmlnX3JlZ3MsDQo+ID4g PiAgCX0gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfQkxTICYmIG5leHQgPT0gRERQX0NP TVBPTkVOVF9EUEkwKSB7DQo+ID4gPiAgCQlyZWdtYXBfd3JpdGUoY29uZmlnX3JlZ3MsIERJU1Bf UkVHX0NPTkZJR19PVVRfU0VMLA0KPiA+ID4gIAkJCQlCTFNfVE9fRFBJX1JETUExX1RPX0RTSSk7 DQo+ID4gPiAtCQlyZWdtYXBfd3JpdGUoY29uZmlnX3JlZ3MsIERJU1BfUkVHX0NPTkZJR19EU0lf U0VMLA0KPiA+ID4gLQkJCQlEU0lfU0VMX0lOX1JETUEpOw0KPiA+ID4gLQkJcmVnbWFwX3dyaXRl KGNvbmZpZ19yZWdzLCBESVNQX1JFR19DT05GSUdfRFBJX1NFTCwNCj4gPiA+IC0JCQkJRFBJX1NF TF9JTl9CTFMpOw0KPiA+ID4gIAl9DQo+ID4gPiAgfQ0KPiA+ID4gIA0KPiA+IA0KPiA+IA0KPiAN Cj4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3932C3276C for ; Thu, 2 Jan 2020 06:02:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAEB5215A4 for ; Thu, 2 Jan 2020 06:02:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="BH0kFVI/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAEB5215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F9E189BA1; Thu, 2 Jan 2020 06:02:38 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DCCB89BDB for ; Thu, 2 Jan 2020 06:02:34 +0000 (UTC) X-UUID: dd7d204af3d64f0a9d0cc923b9ac291b-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VDLfXcYUJeQkJKhzGgI3LI0lhtwysIGtBl5WGX6utNk=; b=BH0kFVI/GfyFnrjxaR1KLl8zPJfGM+eUIy2VW299DXTrYnDB5XZcB2PN0fD+1v2h7vZacl6yO7aSkzSrotC4BXYTcfJBczEu3kato1AB6+5lIyIJUd6rpreIV8dsNiiPj690hxK37PAgc304s0V1m90JPvz6RvJGQPK99qCwqrE=; X-UUID: dd7d204af3d64f0a9d0cc923b9ac291b-20200102 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1129739519; Thu, 02 Jan 2020 14:02:31 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:02:00 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:02:56 +0800 Message-ID: <1577944949.32066.1.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 14:02:29 +0800 In-Reply-To: <1577943579.15116.1.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A1684504572D72737A9A3F6FE56B804FCF8791910A3C4C4D11C54BBD967F1E9D2000:8 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Yongqiang: On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > index 39700b9..91c9b19 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > value = DSI_SEL_IN_BLS; > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > + value = DSI_SEL_IN_RDMA; > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > Regards, > > CK > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > is same with before. You suggest that two crtcs are both enabled. If only one crtc is enabled, just one of these two would be set. Regards, CK > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > + value = DPI_SEL_IN_BLS; > > > } else { > > > value = 0; > > > } > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > - DSI_SEL_IN_RDMA); > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > - DPI_SEL_IN_BLS); > > > } > > > } > > > > > > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel