From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3419C2D0DD for ; Thu, 2 Jan 2020 06:40:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75528215A4 for ; Thu, 2 Jan 2020 06:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H9dftgao"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rLXJCS4S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75528215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=buu3ECW2Ow0QmbMEo2SFJHwtV43bKwvzCZc/lmkxeyY=; b=H9dftgao7mCgRc 0OySdeGjvpETtpnExC0uf1ew9YXVv7afbcMEaRYsiJDv6dL7iUAPd5QFoCJ3eBY1bm+HEQqGD8GrD ugUK2ImdBfT5mMARYXonS1mT/uyxJZg4kSrZCkbyGItGxunm1Y63EjX5HoeEp4uFzcJQrn3DCysVL vZNIBxJv1HEhM1Vv+IcVgNciZhE+JPFrl9gxxaDhKs1DR4YC4mOiayNoBhDyzxACJfAfeJvv1LaOH YpJ6vtYniAMI0WHYDBLQ3AsKwodyl1povmeOT99bVng2dim2eZ2LmzvxWV+33POlvzdNz6UkfvHFX ffxFPC0r1bVVCQZ4zJgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imuA5-0002Pe-UO; Thu, 02 Jan 2020 06:40:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imu9x-0002H1-Ta; Thu, 02 Jan 2020 06:40:43 +0000 X-UUID: b3b759d353bd481caa5a0aeec13915ed-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XssQnV8CVAKLRbzGIfmtbhpXNMaK0W6w1OOKXrYbbt4=; b=rLXJCS4S5PntTciQ0VbV5AbQLbdcnzuso/mK1p/hjgdZYY3ojVtvXhV6BvhSjOA3HTScsnIMdkLryOFgI9Vdd62eDkjNVsqUqpb5SFdnEP9qvx5qX7t0DTXwS9uH0r/FP2mAwqTM6B1uFpchJ1kPtLPAr+0+03Kzzo2QgvBAyd4=; X-UUID: b3b759d353bd481caa5a0aeec13915ed-20200101 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1899013100; Wed, 01 Jan 2020 22:40:39 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 22:40:59 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:39:27 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:40:37 +0800 Message-ID: <1577947234.4925.2.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 14:40:34 +0800 In-Reply-To: <1577946073.15116.8.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3DAF5B765299B3D8444E42D119D503830C3F8456D6691FBEACE97524642F0F1F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_224041_961275_E4C6F422 X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Thu, 2020-01-02 at 14:21 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 14:02 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > > > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > > > Hi, Yongqiang: > > > > > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > > > > > Signed-off-by: Yongqiang Niu > > > > > --- > > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > index 39700b9..91c9b19 100644 > > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > value = DSI_SEL_IN_BLS; > > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > + value = DSI_SEL_IN_RDMA; > > > > > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > > > > > Regards, > > > > CK > > > > > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > > > is same with before. > > > > You suggest that two crtcs are both enabled. If only one crtc is > > enabled, just one of these two would be set. > > > > Regards, > > CK > > OK, i will modify like this > else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > *addr = DISP_REG_CONFIG_DSI_SEL; > value = DPI_SEL_IN_RDMA; > } > in mtk_ddp_sel_in. > > don't set DISP_REG_CONFIG_DPI_SEL to DPI_SEL_IN_BLS anymore, because > DPI_SEL_IN_BLS is zero, it is same with hardware default setting. In Bibby's case, there is only the path from BLS to DPI0 and has no path from RDMA1 to DSI0, but it need to set these two register. Maybe its setting is just for some SoC, so you may use the compatible name to judge how to set this two register. Regards, CK > > > > > > > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > > > + value = DPI_SEL_IN_BLS; > > > > > } else { > > > > > value = 0; > > > > > } > > > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > > > - DSI_SEL_IN_RDMA); > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > > > - DPI_SEL_IN_BLS); > > > > > } > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B30C3C2D0DD for ; Thu, 2 Jan 2020 06:40:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8530A21655 for ; Thu, 2 Jan 2020 06:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i+dVo86g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rLXJCS4S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8530A21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f8J2d1PAdJbmXLCLihXml2eA4APySlPfyrSRyQ9hoDY=; b=i+dVo86gWxTzHc RfeS8eapcJoqNttUy0TYmihuB+EQ3yDAjUDmtPT/jM9Cr7o0iUrnjM+j9+VbirpJ+AH0kCQc/Zcd1 vllJ8UoMK/0u+BR7NvwRiaGn/15QWWx7RX1etEdMCP881h4jWVuaauvB/cX63G0eobARDA1JOnJQf nsfcOmDEA1SZzl1FRuZ1EfqNOuu7Ufk0scLd/X4Wt8IbjUukHOOT3z43/AwVpTjibV3SCNQwyDY4c RLtrCf2qQMGOVPhlK/HcnlDkYkWXlgjTm1CH0LPwKTh/82mYMPfywNhjBIHaDe1qEQ5WbDqKWfvKW UqOhzBjxX64KVIG1YUJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imuA1-0002Hm-8R; Thu, 02 Jan 2020 06:40:45 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imu9x-0002H1-Ta; Thu, 02 Jan 2020 06:40:43 +0000 X-UUID: b3b759d353bd481caa5a0aeec13915ed-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XssQnV8CVAKLRbzGIfmtbhpXNMaK0W6w1OOKXrYbbt4=; b=rLXJCS4S5PntTciQ0VbV5AbQLbdcnzuso/mK1p/hjgdZYY3ojVtvXhV6BvhSjOA3HTScsnIMdkLryOFgI9Vdd62eDkjNVsqUqpb5SFdnEP9qvx5qX7t0DTXwS9uH0r/FP2mAwqTM6B1uFpchJ1kPtLPAr+0+03Kzzo2QgvBAyd4=; X-UUID: b3b759d353bd481caa5a0aeec13915ed-20200101 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1899013100; Wed, 01 Jan 2020 22:40:39 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 22:40:59 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:39:27 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:40:37 +0800 Message-ID: <1577947234.4925.2.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 14:40:34 +0800 In-Reply-To: <1577946073.15116.8.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3DAF5B765299B3D8444E42D119D503830C3F8456D6691FBEACE97524642F0F1F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_224041_961275_E4C6F422 X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Thu, 2020-01-02 at 14:21 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 14:02 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > > > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > > > Hi, Yongqiang: > > > > > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > > > > > Signed-off-by: Yongqiang Niu > > > > > --- > > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > index 39700b9..91c9b19 100644 > > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > value = DSI_SEL_IN_BLS; > > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > + value = DSI_SEL_IN_RDMA; > > > > > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > > > > > Regards, > > > > CK > > > > > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > > > is same with before. > > > > You suggest that two crtcs are both enabled. If only one crtc is > > enabled, just one of these two would be set. > > > > Regards, > > CK > > OK, i will modify like this > else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > *addr = DISP_REG_CONFIG_DSI_SEL; > value = DPI_SEL_IN_RDMA; > } > in mtk_ddp_sel_in. > > don't set DISP_REG_CONFIG_DPI_SEL to DPI_SEL_IN_BLS anymore, because > DPI_SEL_IN_BLS is zero, it is same with hardware default setting. In Bibby's case, there is only the path from BLS to DPI0 and has no path from RDMA1 to DSI0, but it need to set these two register. Maybe its setting is just for some SoC, so you may use the compatible name to judge how to set this two register. Regards, CK > > > > > > > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > > > + value = DPI_SEL_IN_BLS; > > > > > } else { > > > > > value = 0; > > > > > } > > > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > > > - DSI_SEL_IN_RDMA); > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > > > - DPI_SEL_IN_BLS); > > > > > } > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1295C3276D for ; Thu, 2 Jan 2020 06:40:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7644D21655 for ; Thu, 2 Jan 2020 06:40:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="mk+aYi7p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbgABGkq (ORCPT ); Thu, 2 Jan 2020 01:40:46 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:5824 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725788AbgABGkp (ORCPT ); Thu, 2 Jan 2020 01:40:45 -0500 X-UUID: 41312f93994d4f0c8e3e241188f2b99f-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XssQnV8CVAKLRbzGIfmtbhpXNMaK0W6w1OOKXrYbbt4=; b=mk+aYi7pfPM4JnB5A0sJyUt5MNg1Uq29k6m14BhoG+Qsh5DhftfX00UPBriZVpMByMhLR4X3WQAHU0XBFLNZ2OduIuGyUv1TPW6JBv6/ZD53Zh5k6Bi7vqMEp7WDe64Y9hEVedL7d7bQ3W0Xcqxu7b9WWJ6HuujuDHxkxAlnbbk=; X-UUID: 41312f93994d4f0c8e3e241188f2b99f-20200102 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 575438286; Thu, 02 Jan 2020 14:40:37 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:39:27 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:40:37 +0800 Message-ID: <1577947234.4925.2.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu CC: Philipp Zabel , Rob Herring , Matthias Brugger , "David Airlie" , Daniel Vetter , Mark Rutland , , , , , Date: Thu, 2 Jan 2020 14:40:34 +0800 In-Reply-To: <1577946073.15116.8.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3DAF5B765299B3D8444E42D119D503830C3F8456D6691FBEACE97524642F0F1F2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGksIFlvbmdxaWFuZzoNCg0KT24gVGh1LCAyMDIwLTAxLTAyIGF0IDE0OjIxICswODAwLCBZb25n cWlhbmcgTml1IHdyb3RlOg0KPiBPbiBUaHUsIDIwMjAtMDEtMDIgYXQgMTQ6MDIgKzA4MDAsIENL IEh1IHdyb3RlOg0KPiA+IEhpLCBZb25ncWlhbmc6DQo+ID4gDQo+ID4gT24gVGh1LCAyMDIwLTAx LTAyIGF0IDEzOjM5ICswODAwLCBZb25ncWlhbmcgTml1IHdyb3RlOg0KPiA+ID4gT24gVGh1LCAy MDIwLTAxLTAyIGF0IDEzOjAzICswODAwLCBDSyBIdSB3cm90ZToNCj4gPiA+ID4gSGksIFlvbmdx aWFuZzoNCj4gPiA+ID4gDQo+ID4gPiA+IE9uIFRodSwgMjAyMC0wMS0wMiBhdCAxMjowMCArMDgw MCwgWW9uZ3FpYW5nIE5pdSB3cm90ZToNCj4gPiA+ID4gPiBtb3ZlIGRzaS9kcGkgc2VsZWN0IGlu cHV0IGludG8gbXRrX2RkcF9zZWxfaW4NCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBZb25ncWlhbmcgTml1IDx5b25ncWlhbmcubml1QG1lZGlhdGVrLmNvbT4NCj4gPiA+ID4g PiAtLS0NCj4gPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMg fCAxMCArKysrKystLS0tDQo+ID4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pDQo+ID4gPiA+ID4gDQo+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcC5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fZGRwLmMNCj4gPiA+ID4gPiBpbmRleCAzOTcwMGI5Li45MWM5YjE5IDEw MDY0NA0KPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rk cC5jDQo+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRw LmMNCj4gPiA+ID4gPiBAQCAtMzc2LDYgKzM3NiwxMiBAQCBzdGF0aWMgdW5zaWduZWQgaW50IG10 a19kZHBfc2VsX2luKGVudW0gbXRrX2RkcF9jb21wX2lkIGN1ciwNCj4gPiA+ID4gPiAgCX0gZWxz ZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfQkxTICYmIG5leHQgPT0gRERQX0NPTVBPTkVOVF9E U0kwKSB7DQo+ID4gPiA+ID4gIAkJKmFkZHIgPSBESVNQX1JFR19DT05GSUdfRFNJX1NFTDsNCj4g PiA+ID4gPiAgCQl2YWx1ZSA9IERTSV9TRUxfSU5fQkxTOw0KPiA+ID4gPiA+ICsJfSBlbHNlIGlm IChjdXIgPT0gRERQX0NPTVBPTkVOVF9SRE1BMSAmJiBuZXh0ID09IEREUF9DT01QT05FTlRfRFNJ MCkgew0KPiA+ID4gPiA+ICsJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RTSV9TRUw7DQo+ID4g PiA+ID4gKwkJdmFsdWUgPSBEU0lfU0VMX0lOX1JETUE7DQo+ID4gPiA+IA0KPiA+ID4gPiBJbiBv cmlnaW5hbCBjb2RlLCB0aGlzIGlzIHNldCB3aGVuIGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyBh bmQgbmV4dCA9PQ0KPiA+ID4gPiBERFBfQ09NUE9ORU5UX0RQSTAuIFdoeSBkbyB5b3UgY2hhbmdl IHRoZSBjb25kaXRpb24/DQo+ID4gPiA+IA0KPiA+ID4gPiBSZWdhcmRzLA0KPiA+ID4gPiBDSw0K PiA+ID4gDQo+ID4gPiBpZiBibHMgY29ubmVjdCB3aXRoIGRwaTAsIHJkbWExIHNob3VsZCBjb25u ZWN0IHdpdGggZHNpMCwgdGhlIGNvbmRpdGlvbg0KPiA+ID4gaXMgc2FtZSB3aXRoIGJlZm9yZS4N Cj4gPiANCj4gPiBZb3Ugc3VnZ2VzdCB0aGF0IHR3byBjcnRjcyBhcmUgYm90aCBlbmFibGVkLiBJ ZiBvbmx5IG9uZSBjcnRjIGlzDQo+ID4gZW5hYmxlZCwganVzdCBvbmUgb2YgdGhlc2UgdHdvIHdv dWxkIGJlIHNldC4NCj4gPiANCj4gPiBSZWdhcmRzLA0KPiA+IENLDQo+IA0KPiBPSywgaSB3aWxs IG1vZGlmeSBsaWtlIHRoaXMNCj4gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfQkxTICYm IG5leHQgPT0gRERQX0NPTVBPTkVOVF9EUEkwKSB7DQo+IAkJKmFkZHIgPSBESVNQX1JFR19DT05G SUdfRFNJX1NFTDsNCj4gCQl2YWx1ZSA9IERQSV9TRUxfSU5fUkRNQTsNCj4gCX0NCj4gaW4gbXRr X2RkcF9zZWxfaW4uDQo+IA0KPiBkb24ndCBzZXQgRElTUF9SRUdfQ09ORklHX0RQSV9TRUwgdG8g RFBJX1NFTF9JTl9CTFMgYW55bW9yZSwgYmVjYXVzZQ0KPiBEUElfU0VMX0lOX0JMUyBpcyB6ZXJv LCBpdCBpcyBzYW1lIHdpdGggaGFyZHdhcmUgZGVmYXVsdCBzZXR0aW5nLg0KDQpJbiBCaWJieSdz IGNhc2UsIHRoZXJlIGlzIG9ubHkgdGhlIHBhdGggZnJvbSBCTFMgdG8gRFBJMCBhbmQgaGFzIG5v IHBhdGgNCmZyb20gUkRNQTEgdG8gRFNJMCwgYnV0IGl0IG5lZWQgdG8gc2V0IHRoZXNlIHR3byBy ZWdpc3Rlci4gTWF5YmUgaXRzDQpzZXR0aW5nIGlzIGp1c3QgZm9yIHNvbWUgU29DLCBzbyB5b3Ug bWF5IHVzZSB0aGUgY29tcGF0aWJsZSBuYW1lIHRvDQpqdWRnZSBob3cgdG8gc2V0IHRoaXMgdHdv IHJlZ2lzdGVyLg0KDQpSZWdhcmRzLA0KQ0sNCg0KPiA+IA0KPiA+ID4gPiANCj4gPiA+ID4gPiAr CX0gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfQkxTICYmIG5leHQgPT0gRERQX0NPTVBP TkVOVF9EUEkwKSB7DQo+ID4gPiA+ID4gKwkJKmFkZHIgPSBESVNQX1JFR19DT05GSUdfRFBJX1NF TDsNCj4gPiA+ID4gPiArCQl2YWx1ZSA9IERQSV9TRUxfSU5fQkxTOw0KPiA+ID4gPiA+ICAJfSBl bHNlIHsNCj4gPiA+ID4gPiAgCQl2YWx1ZSA9IDA7DQo+ID4gPiA+ID4gIAl9DQo+ID4gPiA+ID4g QEAgLTM5MywxMCArMzk5LDYgQEAgc3RhdGljIHZvaWQgbXRrX2RkcF9zb3V0X3NlbChzdHJ1Y3Qg cmVnbWFwICpjb25maWdfcmVncywNCj4gPiA+ID4gPiAgCX0gZWxzZSBpZiAoY3VyID09IEREUF9D T01QT05FTlRfQkxTICYmIG5leHQgPT0gRERQX0NPTVBPTkVOVF9EUEkwKSB7DQo+ID4gPiA+ID4g IAkJcmVnbWFwX3dyaXRlKGNvbmZpZ19yZWdzLCBESVNQX1JFR19DT05GSUdfT1VUX1NFTCwNCj4g PiA+ID4gPiAgCQkJCUJMU19UT19EUElfUkRNQTFfVE9fRFNJKTsNCj4gPiA+ID4gPiAtCQlyZWdt YXBfd3JpdGUoY29uZmlnX3JlZ3MsIERJU1BfUkVHX0NPTkZJR19EU0lfU0VMLA0KPiA+ID4gPiA+ IC0JCQkJRFNJX1NFTF9JTl9SRE1BKTsNCj4gPiA+ID4gPiAtCQlyZWdtYXBfd3JpdGUoY29uZmln X3JlZ3MsIERJU1BfUkVHX0NPTkZJR19EUElfU0VMLA0KPiA+ID4gPiA+IC0JCQkJRFBJX1NFTF9J Tl9CTFMpOw0KPiA+ID4gPiA+ICAJfQ0KPiA+ID4gPiA+ICB9DQo+ID4gPiA+ID4gIA0KPiA+ID4g PiANCj4gPiA+ID4gDQo+ID4gPiANCj4gPiA+IA0KPiA+IA0KPiA+IA0KPiANCj4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773D8C2D0DD for ; Thu, 2 Jan 2020 06:40:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A456215A4 for ; Thu, 2 Jan 2020 06:40:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="mk+aYi7p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A456215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BFFBA89A83; Thu, 2 Jan 2020 06:40:47 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [1.203.163.78]) by gabe.freedesktop.org (Postfix) with ESMTP id E6E5289A83 for ; Thu, 2 Jan 2020 06:40:45 +0000 (UTC) X-UUID: 41312f93994d4f0c8e3e241188f2b99f-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XssQnV8CVAKLRbzGIfmtbhpXNMaK0W6w1OOKXrYbbt4=; b=mk+aYi7pfPM4JnB5A0sJyUt5MNg1Uq29k6m14BhoG+Qsh5DhftfX00UPBriZVpMByMhLR4X3WQAHU0XBFLNZ2OduIuGyUv1TPW6JBv6/ZD53Zh5k6Bi7vqMEp7WDe64Y9hEVedL7d7bQ3W0Xcqxu7b9WWJ6HuujuDHxkxAlnbbk=; X-UUID: 41312f93994d4f0c8e3e241188f2b99f-20200102 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 575438286; Thu, 02 Jan 2020 14:40:37 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 14:39:27 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 14:40:37 +0800 Message-ID: <1577947234.4925.2.camel@mtksdaap41> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 14:40:34 +0800 In-Reply-To: <1577946073.15116.8.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3DAF5B765299B3D8444E42D119D503830C3F8456D6691FBEACE97524642F0F1F2000:8 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Yongqiang: On Thu, 2020-01-02 at 14:21 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 14:02 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > > > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > > > Hi, Yongqiang: > > > > > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > > > > > Signed-off-by: Yongqiang Niu > > > > > --- > > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > index 39700b9..91c9b19 100644 > > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > value = DSI_SEL_IN_BLS; > > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > + value = DSI_SEL_IN_RDMA; > > > > > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > > > > > Regards, > > > > CK > > > > > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > > > is same with before. > > > > You suggest that two crtcs are both enabled. If only one crtc is > > enabled, just one of these two would be set. > > > > Regards, > > CK > > OK, i will modify like this > else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > *addr = DISP_REG_CONFIG_DSI_SEL; > value = DPI_SEL_IN_RDMA; > } > in mtk_ddp_sel_in. > > don't set DISP_REG_CONFIG_DPI_SEL to DPI_SEL_IN_BLS anymore, because > DPI_SEL_IN_BLS is zero, it is same with hardware default setting. In Bibby's case, there is only the path from BLS to DPI0 and has no path from RDMA1 to DSI0, but it need to set these two register. Maybe its setting is just for some SoC, so you may use the compatible name to judge how to set this two register. Regards, CK > > > > > > > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > > > + value = DPI_SEL_IN_BLS; > > > > > } else { > > > > > value = 0; > > > > > } > > > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > > > - DSI_SEL_IN_RDMA); > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > > > - DPI_SEL_IN_BLS); > > > > > } > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel