From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF2CC2D0DD for ; Thu, 2 Jan 2020 07:11:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AE6D20672 for ; Thu, 2 Jan 2020 07:11:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KGeHyUqS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Ng4aCPd6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AE6D20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZGoz3Bl4KhNTHHi5MqRckqXqs103Juwhk5t+9hRIfWU=; b=KGeHyUqSYSFzXW QqRG28mxLAIxXpoAe5miyH86yRG2j0JFwynGUhgKsngOhtGwYcnZfHTRkX+OX9f9N43Rtyo1oIzrl AJ7mL2gSPWIoeV1V2TfsI9Ko+MsRlR7cbBTcC7m7UlqKQbwX8E2hNfxZK/z+v6r0ZTbwGrrgJolHE xJPmnJkUP2ruFGK4L1M7066DkWKr0zeB7nTO3pVj5rD/avn3ThKVXpYjpOsYaM5mR/FgG9r+N1txH EO/EsbZYqEVf5Qs6lL6N5SRus/QFGH8FbRFKRJhyfysLbqU4EzJdH9wvMLlg24ghtH60rq/RCCjpo TfVzein7ziDVyGg00E/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imuds-0004VF-IF; Thu, 02 Jan 2020 07:11:36 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imudh-0004Ls-AZ; Thu, 02 Jan 2020 07:11:26 +0000 X-UUID: 928c2037745542a98efcf0c0850f3413-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=In6OwDT/YxJiEkeYl7SpJiR0aYr+OGSpKakTOdvs2lk=; b=Ng4aCPd6r6anBWqRlSeYsycj6KGTjQIGp9NUz9AXnuDECTp8S4hO0NxatQbhqzEtfuDLjDS3cq75vf53S5lS//k8LvRyAGajku7x7ameCsWhaiz3u8KPIp9BWlzvBWpZcYiP+ZwOCGQ7RX0Kh8ahBxErgItiUFUxMqvquWhwg1k=; X-UUID: 928c2037745542a98efcf0c0850f3413-20200101 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1702616137; Wed, 01 Jan 2020 23:11:22 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 23:01:59 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:01:10 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:01:59 +0800 Message-ID: <1577948404.15116.18.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu To: CK Hu Date: Thu, 2 Jan 2020 15:00:04 +0800 In-Reply-To: <1577947234.4925.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> <1577947234.4925.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_231125_373051_BF0D2568 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-01-02 at 14:40 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2020-01-02 at 14:21 +0800, Yongqiang Niu wrote: > > On Thu, 2020-01-02 at 14:02 +0800, CK Hu wrote: > > > Hi, Yongqiang: > > > > > > On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > > > > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > > > > Hi, Yongqiang: > > > > > > > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > > > > > > > Signed-off-by: Yongqiang Niu > > > > > > --- > > > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > index 39700b9..91c9b19 100644 > > > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > > value = DSI_SEL_IN_BLS; > > > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > > + value = DSI_SEL_IN_RDMA; > > > > > > > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > > > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > > > > > > > Regards, > > > > > CK > > > > > > > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > > > > is same with before. > > > > > > You suggest that two crtcs are both enabled. If only one crtc is > > > enabled, just one of these two would be set. > > > > > > Regards, > > > CK > > > > OK, i will modify like this > > else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > *addr = DISP_REG_CONFIG_DSI_SEL; > > value = DPI_SEL_IN_RDMA; > > } > > in mtk_ddp_sel_in. > > > > don't set DISP_REG_CONFIG_DPI_SEL to DPI_SEL_IN_BLS anymore, because > > DPI_SEL_IN_BLS is zero, it is same with hardware default setting. > > In Bibby's case, there is only the path from BLS to DPI0 and has no path > from RDMA1 to DSI0, but it need to set these two register. Maybe its > setting is just for some SoC, so you may use the compatible name to > judge how to set this two register. > > Regards, > CK > it the original use case, if bls->dpi0, it set 3 register, DISP_REG_CONFIG_DPI_SEL set to DPI_SEL_IN_BLS ,and this is 0, so this is useless setting. then are only 2 useful setting. in this patch i have upload, i keep DISP_REG_CONFIG_OUT_SEL still in mtk_ddp_sout_sel. and only move DISP_REG_CONFIG_DSI_SEL into mtk_ddp_sel_in. i suppose this is enough for this use case. and no need compatible name to control this. please double confirm. and there will more and more SOC upstream in the future. these function will be more complex. there should be coding one more suitable function to handle these connection > > > > > > > > > > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > > > > + value = DPI_SEL_IN_BLS; > > > > > > } else { > > > > > > value = 0; > > > > > > } > > > > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > > > > - DSI_SEL_IN_RDMA); > > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > > > > - DPI_SEL_IN_BLS); > > > > > > } > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7B8C2D0DD for ; Thu, 2 Jan 2020 07:11:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76A8220672 for ; Thu, 2 Jan 2020 07:11:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZJ1dUBca"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Ng4aCPd6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76A8220672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JDWSoByI6iMGLGAQQTngTWwN4ZIXHxAOI3ZQjTXIpBY=; b=ZJ1dUBcaUZc6uf Gs9BJaYllcjp0yg+gVkn8XBigEx49XZOzl9Jie0fznmMf0ajvx1CouOaK2/C2o8HrZ2CdL4meRsx2 y5tMTcwiRt4MMnm2eT2LIHHLpaTX5YoyVwOOgPbezfQJu7ihLsc6p3zXbbGjHqPIk6aGhL7wZ3/+B Q0DL/KtG4N1UmMMN7ZXoY918jIA7X6NzXsHDwpKe9LDVgXfEGwHQmnicX+R9CYxR6eM/eQdBtmZfn AOGuLFVMX6oY8PwRMEKPHvp5lmLsiwUmbtd1ul8lVOl0LWVgHU+4ThwZTCrbzcZ94VbKQrRZGRUDu +lr7mGH77/mc1U77gvgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imudl-0004MU-1l; Thu, 02 Jan 2020 07:11:29 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imudh-0004Ls-AZ; Thu, 02 Jan 2020 07:11:26 +0000 X-UUID: 928c2037745542a98efcf0c0850f3413-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=In6OwDT/YxJiEkeYl7SpJiR0aYr+OGSpKakTOdvs2lk=; b=Ng4aCPd6r6anBWqRlSeYsycj6KGTjQIGp9NUz9AXnuDECTp8S4hO0NxatQbhqzEtfuDLjDS3cq75vf53S5lS//k8LvRyAGajku7x7ameCsWhaiz3u8KPIp9BWlzvBWpZcYiP+ZwOCGQ7RX0Kh8ahBxErgItiUFUxMqvquWhwg1k=; X-UUID: 928c2037745542a98efcf0c0850f3413-20200101 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1702616137; Wed, 01 Jan 2020 23:11:22 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 23:01:59 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:01:10 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:01:59 +0800 Message-ID: <1577948404.15116.18.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu To: CK Hu Date: Thu, 2 Jan 2020 15:00:04 +0800 In-Reply-To: <1577947234.4925.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> <1577947234.4925.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_231125_373051_BF0D2568 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-01-02 at 14:40 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2020-01-02 at 14:21 +0800, Yongqiang Niu wrote: > > On Thu, 2020-01-02 at 14:02 +0800, CK Hu wrote: > > > Hi, Yongqiang: > > > > > > On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > > > > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > > > > Hi, Yongqiang: > > > > > > > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > > > > > > > Signed-off-by: Yongqiang Niu > > > > > > --- > > > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > index 39700b9..91c9b19 100644 > > > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > > value = DSI_SEL_IN_BLS; > > > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > > + value = DSI_SEL_IN_RDMA; > > > > > > > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > > > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > > > > > > > Regards, > > > > > CK > > > > > > > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > > > > is same with before. > > > > > > You suggest that two crtcs are both enabled. If only one crtc is > > > enabled, just one of these two would be set. > > > > > > Regards, > > > CK > > > > OK, i will modify like this > > else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > *addr = DISP_REG_CONFIG_DSI_SEL; > > value = DPI_SEL_IN_RDMA; > > } > > in mtk_ddp_sel_in. > > > > don't set DISP_REG_CONFIG_DPI_SEL to DPI_SEL_IN_BLS anymore, because > > DPI_SEL_IN_BLS is zero, it is same with hardware default setting. > > In Bibby's case, there is only the path from BLS to DPI0 and has no path > from RDMA1 to DSI0, but it need to set these two register. Maybe its > setting is just for some SoC, so you may use the compatible name to > judge how to set this two register. > > Regards, > CK > it the original use case, if bls->dpi0, it set 3 register, DISP_REG_CONFIG_DPI_SEL set to DPI_SEL_IN_BLS ,and this is 0, so this is useless setting. then are only 2 useful setting. in this patch i have upload, i keep DISP_REG_CONFIG_OUT_SEL still in mtk_ddp_sout_sel. and only move DISP_REG_CONFIG_DSI_SEL into mtk_ddp_sel_in. i suppose this is enough for this use case. and no need compatible name to control this. please double confirm. and there will more and more SOC upstream in the future. these function will be more complex. there should be coding one more suitable function to handle these connection > > > > > > > > > > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > > > > + value = DPI_SEL_IN_BLS; > > > > > > } else { > > > > > > value = 0; > > > > > > } > > > > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > > > > - DSI_SEL_IN_RDMA); > > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > > > > - DPI_SEL_IN_BLS); > > > > > > } > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8612CC2D0DD for ; Thu, 2 Jan 2020 07:01:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4742A20672 for ; Thu, 2 Jan 2020 07:01:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="YUkiflPG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726103AbgABHBk (ORCPT ); Thu, 2 Jan 2020 02:01:40 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:17739 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726078AbgABHBk (ORCPT ); Thu, 2 Jan 2020 02:01:40 -0500 X-UUID: 6d68b873afc64aa59e6a0199438765db-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=In6OwDT/YxJiEkeYl7SpJiR0aYr+OGSpKakTOdvs2lk=; b=YUkiflPGEm4wImhJkdA9cRkGXUVtkBJjO+Psmd2HhUHTCR/rlikevJe8w3XQMX3Fh/K8ZvXCq3OmxgFayb5VB9Ih5abwFnmVBPcUoCX3qQycpw4A3CPuo0LqkG3M5j+EOEle4GlpMuMdmEU+bTmtPUfoVh2aTQ9OL7snHXUa3PI=; X-UUID: 6d68b873afc64aa59e6a0199438765db-20200102 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 296047620; Thu, 02 Jan 2020 15:01:37 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:01:10 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:01:59 +0800 Message-ID: <1577948404.15116.18.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu Reply-To: Yongqiang Niu To: CK Hu CC: Philipp Zabel , Rob Herring , Matthias Brugger , "David Airlie" , Daniel Vetter , Mark Rutland , , , , , Date: Thu, 2 Jan 2020 15:00:04 +0800 In-Reply-To: <1577947234.4925.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> <1577947234.4925.2.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org T24gVGh1LCAyMDIwLTAxLTAyIGF0IDE0OjQwICswODAwLCBDSyBIdSB3cm90ZToNCj4gSGksIFlv bmdxaWFuZzoNCj4gDQo+IE9uIFRodSwgMjAyMC0wMS0wMiBhdCAxNDoyMSArMDgwMCwgWW9uZ3Fp YW5nIE5pdSB3cm90ZToNCj4gPiBPbiBUaHUsIDIwMjAtMDEtMDIgYXQgMTQ6MDIgKzA4MDAsIENL IEh1IHdyb3RlOg0KPiA+ID4gSGksIFlvbmdxaWFuZzoNCj4gPiA+IA0KPiA+ID4gT24gVGh1LCAy MDIwLTAxLTAyIGF0IDEzOjM5ICswODAwLCBZb25ncWlhbmcgTml1IHdyb3RlOg0KPiA+ID4gPiBP biBUaHUsIDIwMjAtMDEtMDIgYXQgMTM6MDMgKzA4MDAsIENLIEh1IHdyb3RlOg0KPiA+ID4gPiA+ IEhpLCBZb25ncWlhbmc6DQo+ID4gPiA+ID4gDQo+ID4gPiA+ID4gT24gVGh1LCAyMDIwLTAxLTAy IGF0IDEyOjAwICswODAwLCBZb25ncWlhbmcgTml1IHdyb3RlOg0KPiA+ID4gPiA+ID4gbW92ZSBk c2kvZHBpIHNlbGVjdCBpbnB1dCBpbnRvIG10a19kZHBfc2VsX2luDQo+ID4gPiA+ID4gPiANCj4g PiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFlvbmdxaWFuZyBOaXUgPHlvbmdxaWFuZy5uaXVAbWVk aWF0ZWsuY29tPg0KPiA+ID4gPiA+ID4gLS0tDQo+ID4gPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fZGRwLmMgfCAxMCArKysrKystLS0tDQo+ID4gPiA+ID4gPiAgMSBm aWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPiA+ID4gPiA+ IA0KPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX2RkcC5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMNCj4gPiA+ ID4gPiA+IGluZGV4IDM5NzAwYjkuLjkxYzliMTkgMTAwNjQ0DQo+ID4gPiA+ID4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYw0KPiA+ID4gPiA+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMNCj4gPiA+ID4gPiA+IEBAIC0z NzYsNiArMzc2LDEyIEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQgbXRrX2RkcF9zZWxfaW4oZW51bSBt dGtfZGRwX2NvbXBfaWQgY3VyLA0KPiA+ID4gPiA+ID4gIAl9IGVsc2UgaWYgKGN1ciA9PSBERFBf Q09NUE9ORU5UX0JMUyAmJiBuZXh0ID09IEREUF9DT01QT05FTlRfRFNJMCkgew0KPiA+ID4gPiA+ ID4gIAkJKmFkZHIgPSBESVNQX1JFR19DT05GSUdfRFNJX1NFTDsNCj4gPiA+ID4gPiA+ICAJCXZh bHVlID0gRFNJX1NFTF9JTl9CTFM7DQo+ID4gPiA+ID4gPiArCX0gZWxzZSBpZiAoY3VyID09IERE UF9DT01QT05FTlRfUkRNQTEgJiYgbmV4dCA9PSBERFBfQ09NUE9ORU5UX0RTSTApIHsNCj4gPiA+ ID4gPiA+ICsJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RTSV9TRUw7DQo+ID4gPiA+ID4gPiAr CQl2YWx1ZSA9IERTSV9TRUxfSU5fUkRNQTsNCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBJbiBvcmln aW5hbCBjb2RlLCB0aGlzIGlzIHNldCB3aGVuIGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyBhbmQg bmV4dCA9PQ0KPiA+ID4gPiA+IEREUF9DT01QT05FTlRfRFBJMC4gV2h5IGRvIHlvdSBjaGFuZ2Ug dGhlIGNvbmRpdGlvbj8NCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBSZWdhcmRzLA0KPiA+ID4gPiA+ IENLDQo+ID4gPiA+IA0KPiA+ID4gPiBpZiBibHMgY29ubmVjdCB3aXRoIGRwaTAsIHJkbWExIHNo b3VsZCBjb25uZWN0IHdpdGggZHNpMCwgdGhlIGNvbmRpdGlvbg0KPiA+ID4gPiBpcyBzYW1lIHdp dGggYmVmb3JlLg0KPiA+ID4gDQo+ID4gPiBZb3Ugc3VnZ2VzdCB0aGF0IHR3byBjcnRjcyBhcmUg Ym90aCBlbmFibGVkLiBJZiBvbmx5IG9uZSBjcnRjIGlzDQo+ID4gPiBlbmFibGVkLCBqdXN0IG9u ZSBvZiB0aGVzZSB0d28gd291bGQgYmUgc2V0Lg0KPiA+ID4gDQo+ID4gPiBSZWdhcmRzLA0KPiA+ ID4gQ0sNCj4gPiANCj4gPiBPSywgaSB3aWxsIG1vZGlmeSBsaWtlIHRoaXMNCj4gPiBlbHNlIGlm IChjdXIgPT0gRERQX0NPTVBPTkVOVF9CTFMgJiYgbmV4dCA9PSBERFBfQ09NUE9ORU5UX0RQSTAp IHsNCj4gPiAJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RTSV9TRUw7DQo+ID4gCQl2YWx1ZSA9 IERQSV9TRUxfSU5fUkRNQTsNCj4gPiAJfQ0KPiA+IGluIG10a19kZHBfc2VsX2luLg0KPiA+IA0K PiA+IGRvbid0IHNldCBESVNQX1JFR19DT05GSUdfRFBJX1NFTCB0byBEUElfU0VMX0lOX0JMUyBh bnltb3JlLCBiZWNhdXNlDQo+ID4gRFBJX1NFTF9JTl9CTFMgaXMgemVybywgaXQgaXMgc2FtZSB3 aXRoIGhhcmR3YXJlIGRlZmF1bHQgc2V0dGluZy4NCj4gDQo+IEluIEJpYmJ5J3MgY2FzZSwgdGhl cmUgaXMgb25seSB0aGUgcGF0aCBmcm9tIEJMUyB0byBEUEkwIGFuZCBoYXMgbm8gcGF0aA0KPiBm cm9tIFJETUExIHRvIERTSTAsIGJ1dCBpdCBuZWVkIHRvIHNldCB0aGVzZSB0d28gcmVnaXN0ZXIu IE1heWJlIGl0cw0KPiBzZXR0aW5nIGlzIGp1c3QgZm9yIHNvbWUgU29DLCBzbyB5b3UgbWF5IHVz ZSB0aGUgY29tcGF0aWJsZSBuYW1lIHRvDQo+IGp1ZGdlIGhvdyB0byBzZXQgdGhpcyB0d28gcmVn aXN0ZXIuDQo+IA0KPiBSZWdhcmRzLA0KPiBDSw0KPiANCg0KaXQgdGhlIG9yaWdpbmFsIHVzZSBj YXNlLCBpZiBibHMtPmRwaTAsIGl0IHNldCAzIHJlZ2lzdGVyLA0KRElTUF9SRUdfQ09ORklHX0RQ SV9TRUwgc2V0IHRvIERQSV9TRUxfSU5fQkxTICxhbmQgdGhpcyBpcyANCjAsIHNvIHRoaXMgaXMg dXNlbGVzcyBzZXR0aW5nLg0KDQp0aGVuIGFyZSBvbmx5IDIgdXNlZnVsIHNldHRpbmcuDQppbiB0 aGlzIHBhdGNoIGkgaGF2ZSB1cGxvYWQsIGkga2VlcCBESVNQX1JFR19DT05GSUdfT1VUX1NFTA0K c3RpbGwgaW4gbXRrX2RkcF9zb3V0X3NlbC4NCmFuZCBvbmx5IG1vdmUgRElTUF9SRUdfQ09ORklH X0RTSV9TRUwgaW50byBtdGtfZGRwX3NlbF9pbi4NCmkgc3VwcG9zZSB0aGlzIGlzIGVub3VnaCBm b3IgdGhpcyB1c2UgY2FzZS4NCmFuZCBubyBuZWVkIGNvbXBhdGlibGUgbmFtZSB0byBjb250cm9s IHRoaXMuDQpwbGVhc2UgZG91YmxlIGNvbmZpcm0uDQoNCmFuZCB0aGVyZSB3aWxsIG1vcmUgYW5k IG1vcmUgU09DIHVwc3RyZWFtIGluIHRoZSBmdXR1cmUuDQp0aGVzZSBmdW5jdGlvbiB3aWxsIGJl IG1vcmUgY29tcGxleC4NCnRoZXJlIHNob3VsZCBiZSBjb2Rpbmcgb25lIG1vcmUgc3VpdGFibGUg ZnVuY3Rpb24gdG8gDQpoYW5kbGUgdGhlc2UgY29ubmVjdGlvbg0KDQo+ID4gPiANCj4gPiA+ID4g PiANCj4gPiA+ID4gPiA+ICsJfSBlbHNlIGlmIChjdXIgPT0gRERQX0NPTVBPTkVOVF9CTFMgJiYg bmV4dCA9PSBERFBfQ09NUE9ORU5UX0RQSTApIHsNCj4gPiA+ID4gPiA+ICsJCSphZGRyID0gRElT UF9SRUdfQ09ORklHX0RQSV9TRUw7DQo+ID4gPiA+ID4gPiArCQl2YWx1ZSA9IERQSV9TRUxfSU5f QkxTOw0KPiA+ID4gPiA+ID4gIAl9IGVsc2Ugew0KPiA+ID4gPiA+ID4gIAkJdmFsdWUgPSAwOw0K PiA+ID4gPiA+ID4gIAl9DQo+ID4gPiA+ID4gPiBAQCAtMzkzLDEwICszOTksNiBAQCBzdGF0aWMg dm9pZCBtdGtfZGRwX3NvdXRfc2VsKHN0cnVjdCByZWdtYXAgKmNvbmZpZ19yZWdzLA0KPiA+ID4g PiA+ID4gIAl9IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX0JMUyAmJiBuZXh0ID09IERE UF9DT01QT05FTlRfRFBJMCkgew0KPiA+ID4gPiA+ID4gIAkJcmVnbWFwX3dyaXRlKGNvbmZpZ19y ZWdzLCBESVNQX1JFR19DT05GSUdfT1VUX1NFTCwNCj4gPiA+ID4gPiA+ICAJCQkJQkxTX1RPX0RQ SV9SRE1BMV9UT19EU0kpOw0KPiA+ID4gPiA+ID4gLQkJcmVnbWFwX3dyaXRlKGNvbmZpZ19yZWdz LCBESVNQX1JFR19DT05GSUdfRFNJX1NFTCwNCj4gPiA+ID4gPiA+IC0JCQkJRFNJX1NFTF9JTl9S RE1BKTsNCj4gPiA+ID4gPiA+IC0JCXJlZ21hcF93cml0ZShjb25maWdfcmVncywgRElTUF9SRUdf Q09ORklHX0RQSV9TRUwsDQo+ID4gPiA+ID4gPiAtCQkJCURQSV9TRUxfSU5fQkxTKTsNCj4gPiA+ ID4gPiA+ICAJfQ0KPiA+ID4gPiA+ID4gIH0NCj4gPiA+ID4gPiA+ICANCj4gPiA+ID4gPiANCj4g PiA+ID4gPiANCj4gPiA+ID4gDQo+ID4gPiA+IA0KPiA+ID4gDQo+ID4gPiANCj4gPiANCj4gPiAN Cj4gDQo+IA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E47C3276C for ; Thu, 2 Jan 2020 10:59:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F473215A4 for ; Thu, 2 Jan 2020 10:59:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="YUkiflPG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F473215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 812986E088; Thu, 2 Jan 2020 10:58:21 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id EF3D789715 for ; Thu, 2 Jan 2020 07:01:40 +0000 (UTC) X-UUID: 6d68b873afc64aa59e6a0199438765db-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=In6OwDT/YxJiEkeYl7SpJiR0aYr+OGSpKakTOdvs2lk=; b=YUkiflPGEm4wImhJkdA9cRkGXUVtkBJjO+Psmd2HhUHTCR/rlikevJe8w3XQMX3Fh/K8ZvXCq3OmxgFayb5VB9Ih5abwFnmVBPcUoCX3qQycpw4A3CPuo0LqkG3M5j+EOEle4GlpMuMdmEU+bTmtPUfoVh2aTQ9OL7snHXUa3PI=; X-UUID: 6d68b873afc64aa59e6a0199438765db-20200102 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 296047620; Thu, 02 Jan 2020 15:01:37 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:01:10 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:01:59 +0800 Message-ID: <1577948404.15116.18.camel@mhfsdcap03> Subject: Re: [PATCH v6, 02/14] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in From: Yongqiang Niu To: CK Hu Date: Thu, 2 Jan 2020 15:00:04 +0800 In-Reply-To: <1577947234.4925.2.camel@mtksdaap41> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-3-git-send-email-yongqiang.niu@mediatek.com> <1577941388.24650.2.camel@mtksdaap41> <1577943579.15116.1.camel@mhfsdcap03> <1577944949.32066.1.camel@mtksdaap41> <1577946073.15116.8.camel@mhfsdcap03> <1577947234.4925.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Thu, 02 Jan 2020 10:58:15 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 2020-01-02 at 14:40 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2020-01-02 at 14:21 +0800, Yongqiang Niu wrote: > > On Thu, 2020-01-02 at 14:02 +0800, CK Hu wrote: > > > Hi, Yongqiang: > > > > > > On Thu, 2020-01-02 at 13:39 +0800, Yongqiang Niu wrote: > > > > On Thu, 2020-01-02 at 13:03 +0800, CK Hu wrote: > > > > > Hi, Yongqiang: > > > > > > > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > > > > move dsi/dpi select input into mtk_ddp_sel_in > > > > > > > > > > > > Signed-off-by: Yongqiang Niu > > > > > > --- > > > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++---- > > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > index 39700b9..91c9b19 100644 > > > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > > > @@ -376,6 +376,12 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > > > > > *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > > value = DSI_SEL_IN_BLS; > > > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > > > > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > > > > > + value = DSI_SEL_IN_RDMA; > > > > > > > > > > In original code, this is set when cur == DDP_COMPONENT_BLS and next == > > > > > DDP_COMPONENT_DPI0. Why do you change the condition? > > > > > > > > > > Regards, > > > > > CK > > > > > > > > if bls connect with dpi0, rdma1 should connect with dsi0, the condition > > > > is same with before. > > > > > > You suggest that two crtcs are both enabled. If only one crtc is > > > enabled, just one of these two would be set. > > > > > > Regards, > > > CK > > > > OK, i will modify like this > > else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > *addr = DISP_REG_CONFIG_DSI_SEL; > > value = DPI_SEL_IN_RDMA; > > } > > in mtk_ddp_sel_in. > > > > don't set DISP_REG_CONFIG_DPI_SEL to DPI_SEL_IN_BLS anymore, because > > DPI_SEL_IN_BLS is zero, it is same with hardware default setting. > > In Bibby's case, there is only the path from BLS to DPI0 and has no path > from RDMA1 to DSI0, but it need to set these two register. Maybe its > setting is just for some SoC, so you may use the compatible name to > judge how to set this two register. > > Regards, > CK > it the original use case, if bls->dpi0, it set 3 register, DISP_REG_CONFIG_DPI_SEL set to DPI_SEL_IN_BLS ,and this is 0, so this is useless setting. then are only 2 useful setting. in this patch i have upload, i keep DISP_REG_CONFIG_OUT_SEL still in mtk_ddp_sout_sel. and only move DISP_REG_CONFIG_DSI_SEL into mtk_ddp_sel_in. i suppose this is enough for this use case. and no need compatible name to control this. please double confirm. and there will more and more SOC upstream in the future. these function will be more complex. there should be coding one more suitable function to handle these connection > > > > > > > > > > > > > > + } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > > + *addr = DISP_REG_CONFIG_DPI_SEL; > > > > > > + value = DPI_SEL_IN_BLS; > > > > > > } else { > > > > > > value = 0; > > > > > > } > > > > > > @@ -393,10 +399,6 @@ static void mtk_ddp_sout_sel(struct regmap *config_regs, > > > > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > > > > > regmap_write(config_regs, DISP_REG_CONFIG_OUT_SEL, > > > > > > BLS_TO_DPI_RDMA1_TO_DSI); > > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DSI_SEL, > > > > > > - DSI_SEL_IN_RDMA); > > > > > > - regmap_write(config_regs, DISP_REG_CONFIG_DPI_SEL, > > > > > > - DPI_SEL_IN_BLS); > > > > > > } > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel