From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CBC2C2D0DD for ; Thu, 2 Jan 2020 07:32:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D471215A4 for ; Thu, 2 Jan 2020 07:32:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ALdJA4RJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="F4p5VDWD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D471215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BF57jmIYaBhGBrDkKswfORGBemeksmi6IaAb1+NodXU=; b=ALdJA4RJ605X1A mOL7+yE7srq7GFmGrd0CqdaFN9vnkSaPHNxmLdWrFpoVQH7nL6odlv5SDyUZET3OQb5hPIhgVB6xH G3t5fpx4CMzb37M3Am8IJrbTqmdPbbPpliLXe68l7HjipzDCGI2BDcjZvqPn0NhkZfjruLRzYoMfO btMgMVSnoRXvrR5wuJVxyUV7uTYAx7aAi0wyHEaLH07iFGU9nXjZ8wr0P+UyY7eEd/6tm4ArQ9c3B PEYCV9esofzFevAypy12PSuacqEvyOIIoX2f4wGCuXSH9z4ff2I+4O4IFuCIIZa8mmpxM2cCbH+n7 C3QMtTKN6Z962Es3nIPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imuxt-0003JL-A0; Thu, 02 Jan 2020 07:32:17 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imuxk-0003B4-CF; Thu, 02 Jan 2020 07:32:10 +0000 X-UUID: 7780ebcb488641e18a4c5b6a5268cade-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=PCH3d6ww20Xcb8eTPquPc5VeMWFXLY/lz4kI3WEDJSA=; b=F4p5VDWDAvSr2Kr0ZjPc44TxNq7hQWr7t77SmaPA0W2fkNq17Qxm20FLZZQMLkkZJ9uHhqs7bQvR0pwqh9tS5q4e8+01j5J9AeiA44NWtSCfZ89aN5zjq8lRGDmgQ2aEIFlcwn85pzTM8UEN++yrvMNGzSAoKQOP2MhT/uAn2Ms=; X-UUID: 7780ebcb488641e18a4c5b6a5268cade-20200101 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1769587779; Wed, 01 Jan 2020 23:32:03 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 23:32:23 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:30:51 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:32:24 +0800 Message-ID: <1577950317.12633.3.camel@mtksdaap41> Subject: Re: [PATCH v6, 13/14] drm/mediatek: add fifo_size into rdma private data From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 15:31:57 +0800 In-Reply-To: <1577943764.15116.3.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-14-git-send-email-yongqiang.niu@mediatek.com> <1577942440.24650.5.camel@mtksdaap41> <1577943764.15116.3.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 235C97CA29A4272D17AFBE5A53C10D0B4DF8A318DC6B8E23D5887A814BBD57882000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_233208_427914_004EED85 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Thu, 2020-01-02 at 13:42 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 13:20 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > the fifo size of rdma in mt8183 is different. > > > rdma0 fifo size is 5k > > > rdma1 fifo size is 2k > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 21 ++++++++++++++++++++- > > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > index 405afef..691480b 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > @@ -62,6 +62,7 @@ struct mtk_disp_rdma { > > > struct mtk_ddp_comp ddp_comp; > > > struct drm_crtc *crtc; > > > const struct mtk_disp_rdma_data *data; > > > + u32 fifo_size; > > > }; > > > > > > static inline struct mtk_disp_rdma *comp_to_rdma(struct mtk_ddp_comp *comp) > > > @@ -130,10 +131,16 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > > unsigned int threshold; > > > unsigned int reg; > > > struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > > > + u32 rdma_fifo_size; > > > > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xfff, width); > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_1, 0xfffff, height); > > > > > > + if (rdma->fifo_size) > > > + rdma_fifo_size = rdma->fifo_size; > > > + else > > > + rdma_fifo_size = RDMA_FIFO_SIZE(rdma); > > > + > > > /* > > > * Enable FIFO underflow since DSI and DPI can't be blocked. > > > * Keep the FIFO pseudo size reset default of 8 KiB. Set the > > > @@ -142,7 +149,7 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > > */ > > > threshold = width * height * vrefresh * 4 * 7 / 1000000; > > > reg = RDMA_FIFO_UNDERFLOW_EN | > > > - RDMA_FIFO_PSEUDO_SIZE(RDMA_FIFO_SIZE(rdma)) | > > > + RDMA_FIFO_PSEUDO_SIZE(rdma_fifo_size) | > > > RDMA_OUTPUT_VALID_FIFO_THRESHOLD(threshold); > > > writel(reg, comp->regs + DISP_REG_RDMA_FIFO_CON); > > > } > > > @@ -284,6 +291,18 @@ static int mtk_disp_rdma_probe(struct platform_device *pdev) > > > return comp_id; > > > } > > > > > > + if (of_find_property(dev->of_node, "mediatek,rdma_fifo_size", &ret)) { > > > > "mediatek,rdma_fifo_size" does not exists in binding document. > > > > > + ret = of_property_read_u32(dev->of_node, > > > + "mediatek,rdma_fifo_size", > > > + &priv->fifo_size); > > > + if (ret) { > > > + dev_err(dev, "Failed to get rdma fifo size\n"); > > > + return ret; > > > + } > > > + > > > + priv->fifo_size *= SZ_1K; > > > > Why not define fifo_size in 'bytes' ? > > > > Regards, > > CK > > this is align the definition of fifo_size in mtk_disp_rdma_data, it is > SZ_1K, > and the macro RDMA_FIFO_PSEUDO_SIZE calculated with SZ_1K I mean why not set the fifo size in bytes in device tree. So you need not to do '*= SZ_1K' here. I think unit of fifo size in kernel is byte. Regards, CK > > > > > + } > > > + > > > ret = mtk_ddp_comp_init(dev, dev->of_node, &priv->ddp_comp, comp_id, > > > &mtk_disp_rdma_funcs); > > > if (ret) { > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC3BC2D0DD for ; Thu, 2 Jan 2020 07:32:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3008A21734 for ; Thu, 2 Jan 2020 07:32:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aIFuoSuu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="F4p5VDWD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3008A21734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nbMyJpRrMfSMTGITF5/qfjV/CGKfFRObgS/oOVRFJFQ=; b=aIFuoSuuDtM8fF O/ridqWi4ijMANlMjc+SrGz+9ZuXVN5dtbAaZV70cON62Q9V09whGmVyAIO9ZmxjZsyQn25bL1FS/ NSKD6KklxPcM7tl6NGdFGbqIbly/7kp2xH7ZXDo9B+ToebpLktj94IQphSGwmN+34gkQMj/fG/002 Xtod3vVYffP46mkewagDNE1+0ZezD/rTPMJ/LRB/fzZBtYnOPNQF6sRjTuD9nBA40Hvm/isKeIwSZ UlFvVzyLuZLr7VEYWt/DkEjO9jd6Awzhd7i7QAodiCCv2skQ2e0dEx68sO0E+Dq+WvGSw86wQGu9G ELKHy9XL5o04LRBq8BPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imuxo-0003CA-Q6; Thu, 02 Jan 2020 07:32:12 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imuxk-0003B4-CF; Thu, 02 Jan 2020 07:32:10 +0000 X-UUID: 7780ebcb488641e18a4c5b6a5268cade-20200101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=PCH3d6ww20Xcb8eTPquPc5VeMWFXLY/lz4kI3WEDJSA=; b=F4p5VDWDAvSr2Kr0ZjPc44TxNq7hQWr7t77SmaPA0W2fkNq17Qxm20FLZZQMLkkZJ9uHhqs7bQvR0pwqh9tS5q4e8+01j5J9AeiA44NWtSCfZ89aN5zjq8lRGDmgQ2aEIFlcwn85pzTM8UEN++yrvMNGzSAoKQOP2MhT/uAn2Ms=; X-UUID: 7780ebcb488641e18a4c5b6a5268cade-20200101 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1769587779; Wed, 01 Jan 2020 23:32:03 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Jan 2020 23:32:23 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:30:51 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:32:24 +0800 Message-ID: <1577950317.12633.3.camel@mtksdaap41> Subject: Re: [PATCH v6, 13/14] drm/mediatek: add fifo_size into rdma private data From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 15:31:57 +0800 In-Reply-To: <1577943764.15116.3.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-14-git-send-email-yongqiang.niu@mediatek.com> <1577942440.24650.5.camel@mtksdaap41> <1577943764.15116.3.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 235C97CA29A4272D17AFBE5A53C10D0B4DF8A318DC6B8E23D5887A814BBD57882000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200101_233208_427914_004EED85 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Thu, 2020-01-02 at 13:42 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 13:20 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > the fifo size of rdma in mt8183 is different. > > > rdma0 fifo size is 5k > > > rdma1 fifo size is 2k > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 21 ++++++++++++++++++++- > > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > index 405afef..691480b 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > @@ -62,6 +62,7 @@ struct mtk_disp_rdma { > > > struct mtk_ddp_comp ddp_comp; > > > struct drm_crtc *crtc; > > > const struct mtk_disp_rdma_data *data; > > > + u32 fifo_size; > > > }; > > > > > > static inline struct mtk_disp_rdma *comp_to_rdma(struct mtk_ddp_comp *comp) > > > @@ -130,10 +131,16 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > > unsigned int threshold; > > > unsigned int reg; > > > struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > > > + u32 rdma_fifo_size; > > > > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xfff, width); > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_1, 0xfffff, height); > > > > > > + if (rdma->fifo_size) > > > + rdma_fifo_size = rdma->fifo_size; > > > + else > > > + rdma_fifo_size = RDMA_FIFO_SIZE(rdma); > > > + > > > /* > > > * Enable FIFO underflow since DSI and DPI can't be blocked. > > > * Keep the FIFO pseudo size reset default of 8 KiB. Set the > > > @@ -142,7 +149,7 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > > */ > > > threshold = width * height * vrefresh * 4 * 7 / 1000000; > > > reg = RDMA_FIFO_UNDERFLOW_EN | > > > - RDMA_FIFO_PSEUDO_SIZE(RDMA_FIFO_SIZE(rdma)) | > > > + RDMA_FIFO_PSEUDO_SIZE(rdma_fifo_size) | > > > RDMA_OUTPUT_VALID_FIFO_THRESHOLD(threshold); > > > writel(reg, comp->regs + DISP_REG_RDMA_FIFO_CON); > > > } > > > @@ -284,6 +291,18 @@ static int mtk_disp_rdma_probe(struct platform_device *pdev) > > > return comp_id; > > > } > > > > > > + if (of_find_property(dev->of_node, "mediatek,rdma_fifo_size", &ret)) { > > > > "mediatek,rdma_fifo_size" does not exists in binding document. > > > > > + ret = of_property_read_u32(dev->of_node, > > > + "mediatek,rdma_fifo_size", > > > + &priv->fifo_size); > > > + if (ret) { > > > + dev_err(dev, "Failed to get rdma fifo size\n"); > > > + return ret; > > > + } > > > + > > > + priv->fifo_size *= SZ_1K; > > > > Why not define fifo_size in 'bytes' ? > > > > Regards, > > CK > > this is align the definition of fifo_size in mtk_disp_rdma_data, it is > SZ_1K, > and the macro RDMA_FIFO_PSEUDO_SIZE calculated with SZ_1K I mean why not set the fifo size in bytes in device tree. So you need not to do '*= SZ_1K' here. I think unit of fifo size in kernel is byte. Regards, CK > > > > > + } > > > + > > > ret = mtk_ddp_comp_init(dev, dev->of_node, &priv->ddp_comp, comp_id, > > > &mtk_disp_rdma_funcs); > > > if (ret) { > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE391C2D0DD for ; Thu, 2 Jan 2020 07:32:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADC7121734 for ; Thu, 2 Jan 2020 07:32:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="ptTe+t9w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbgABHcJ (ORCPT ); Thu, 2 Jan 2020 02:32:09 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:7233 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726078AbgABHcI (ORCPT ); Thu, 2 Jan 2020 02:32:08 -0500 X-UUID: 61fee457429949338280c00d953cb770-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=PCH3d6ww20Xcb8eTPquPc5VeMWFXLY/lz4kI3WEDJSA=; b=ptTe+t9wX5cT1eWh3tiaue7/s4w9FkX1JQb8KxZBigS6kJse9P2T4KR3L0eHGs5VUFHm/YaEfqd6GLqgDhgtbM+3zw1iCR7M/krCX5FSpcEpIqZzHgtKZKK/TnuGrDD+AZnbY6zSt42qEiYp5dIbckAD5WUpKeu2ODPR56bxrd4=; X-UUID: 61fee457429949338280c00d953cb770-20200102 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1369051708; Thu, 02 Jan 2020 15:32:00 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:30:51 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:32:24 +0800 Message-ID: <1577950317.12633.3.camel@mtksdaap41> Subject: Re: [PATCH v6, 13/14] drm/mediatek: add fifo_size into rdma private data From: CK Hu To: Yongqiang Niu CC: Philipp Zabel , Rob Herring , Matthias Brugger , "David Airlie" , Daniel Vetter , Mark Rutland , , , , , Date: Thu, 2 Jan 2020 15:31:57 +0800 In-Reply-To: <1577943764.15116.3.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-14-git-send-email-yongqiang.niu@mediatek.com> <1577942440.24650.5.camel@mtksdaap41> <1577943764.15116.3.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 235C97CA29A4272D17AFBE5A53C10D0B4DF8A318DC6B8E23D5887A814BBD57882000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGksIFlvbmdxaWFuZzoNCg0KT24gVGh1LCAyMDIwLTAxLTAyIGF0IDEzOjQyICswODAwLCBZb25n cWlhbmcgTml1IHdyb3RlOg0KPiBPbiBUaHUsIDIwMjAtMDEtMDIgYXQgMTM6MjAgKzA4MDAsIENL IEh1IHdyb3RlOg0KPiA+IEhpLCBZb25ncWlhbmc6DQo+ID4gDQo+ID4gT24gVGh1LCAyMDIwLTAx LTAyIGF0IDEyOjAwICswODAwLCBZb25ncWlhbmcgTml1IHdyb3RlOg0KPiA+ID4gdGhlIGZpZm8g c2l6ZSBvZiByZG1hIGluIG10ODE4MyBpcyBkaWZmZXJlbnQuDQo+ID4gPiByZG1hMCBmaWZvIHNp emUgaXMgNWsNCj4gPiA+IHJkbWExIGZpZm8gc2l6ZSBpcyAyaw0KPiA+ID4gDQo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBZb25ncWlhbmcgTml1IDx5b25ncWlhbmcubml1QG1lZGlhdGVrLmNvbT4NCj4g PiA+IC0tLQ0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9yZG1hLmMg fCAyMSArKysrKysrKysrKysrKysrKysrKy0NCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiA+ID4gDQo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX3JkbWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9t ZWRpYXRlay9tdGtfZGlzcF9yZG1hLmMNCj4gPiA+IGluZGV4IDQwNWFmZWYuLjY5MTQ4MGIgMTAw NjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rpc3BfcmRtYS5j DQo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rpc3BfcmRtYS5jDQo+ ID4gPiBAQCAtNjIsNiArNjIsNyBAQCBzdHJ1Y3QgbXRrX2Rpc3BfcmRtYSB7DQo+ID4gPiAgCXN0 cnVjdCBtdGtfZGRwX2NvbXAJCWRkcF9jb21wOw0KPiA+ID4gIAlzdHJ1Y3QgZHJtX2NydGMJCQkq Y3J0YzsNCj4gPiA+ICAJY29uc3Qgc3RydWN0IG10a19kaXNwX3JkbWFfZGF0YQkqZGF0YTsNCj4g PiA+ICsJdTMyCQkJCWZpZm9fc2l6ZTsNCj4gPiA+ICB9Ow0KPiA+ID4gIA0KPiA+ID4gIHN0YXRp YyBpbmxpbmUgc3RydWN0IG10a19kaXNwX3JkbWEgKmNvbXBfdG9fcmRtYShzdHJ1Y3QgbXRrX2Rk cF9jb21wICpjb21wKQ0KPiA+ID4gQEAgLTEzMCwxMCArMTMxLDE2IEBAIHN0YXRpYyB2b2lkIG10 a19yZG1hX2NvbmZpZyhzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgd2lk dGgsDQo+ID4gPiAgCXVuc2lnbmVkIGludCB0aHJlc2hvbGQ7DQo+ID4gPiAgCXVuc2lnbmVkIGlu dCByZWc7DQo+ID4gPiAgCXN0cnVjdCBtdGtfZGlzcF9yZG1hICpyZG1hID0gY29tcF90b19yZG1h KGNvbXApOw0KPiA+ID4gKwl1MzIgcmRtYV9maWZvX3NpemU7DQo+ID4gPiAgDQo+ID4gPiAgCXJk bWFfdXBkYXRlX2JpdHMoY29tcCwgRElTUF9SRUdfUkRNQV9TSVpFX0NPTl8wLCAweGZmZiwgd2lk dGgpOw0KPiA+ID4gIAlyZG1hX3VwZGF0ZV9iaXRzKGNvbXAsIERJU1BfUkVHX1JETUFfU0laRV9D T05fMSwgMHhmZmZmZiwgaGVpZ2h0KTsNCj4gPiA+ICANCj4gPiA+ICsJaWYgKHJkbWEtPmZpZm9f c2l6ZSkNCj4gPiA+ICsJCXJkbWFfZmlmb19zaXplID0gcmRtYS0+Zmlmb19zaXplOw0KPiA+ID4g KwllbHNlDQo+ID4gPiArCQlyZG1hX2ZpZm9fc2l6ZSA9IFJETUFfRklGT19TSVpFKHJkbWEpOw0K PiA+ID4gKw0KPiA+ID4gIAkvKg0KPiA+ID4gIAkgKiBFbmFibGUgRklGTyB1bmRlcmZsb3cgc2lu Y2UgRFNJIGFuZCBEUEkgY2FuJ3QgYmUgYmxvY2tlZC4NCj4gPiA+ICAJICogS2VlcCB0aGUgRklG TyBwc2V1ZG8gc2l6ZSByZXNldCBkZWZhdWx0IG9mIDggS2lCLiBTZXQgdGhlDQo+ID4gPiBAQCAt MTQyLDcgKzE0OSw3IEBAIHN0YXRpYyB2b2lkIG10a19yZG1hX2NvbmZpZyhzdHJ1Y3QgbXRrX2Rk cF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgd2lkdGgsDQo+ID4gPiAgCSAqLw0KPiA+ID4gIAl0 aHJlc2hvbGQgPSB3aWR0aCAqIGhlaWdodCAqIHZyZWZyZXNoICogNCAqIDcgLyAxMDAwMDAwOw0K PiA+ID4gIAlyZWcgPSBSRE1BX0ZJRk9fVU5ERVJGTE9XX0VOIHwNCj4gPiA+IC0JICAgICAgUkRN QV9GSUZPX1BTRVVET19TSVpFKFJETUFfRklGT19TSVpFKHJkbWEpKSB8DQo+ID4gPiArCSAgICAg IFJETUFfRklGT19QU0VVRE9fU0laRShyZG1hX2ZpZm9fc2l6ZSkgfA0KPiA+ID4gIAkgICAgICBS RE1BX09VVFBVVF9WQUxJRF9GSUZPX1RIUkVTSE9MRCh0aHJlc2hvbGQpOw0KPiA+ID4gIAl3cml0 ZWwocmVnLCBjb21wLT5yZWdzICsgRElTUF9SRUdfUkRNQV9GSUZPX0NPTik7DQo+ID4gPiAgfQ0K PiA+ID4gQEAgLTI4NCw2ICsyOTEsMTggQEAgc3RhdGljIGludCBtdGtfZGlzcF9yZG1hX3Byb2Jl KHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4gPiAgCQlyZXR1cm4gY29tcF9pZDsN Cj4gPiA+ICAJfQ0KPiA+ID4gIA0KPiA+ID4gKwlpZiAob2ZfZmluZF9wcm9wZXJ0eShkZXYtPm9m X25vZGUsICJtZWRpYXRlayxyZG1hX2ZpZm9fc2l6ZSIsICZyZXQpKSB7DQo+ID4gDQo+ID4gIm1l ZGlhdGVrLHJkbWFfZmlmb19zaXplIiBkb2VzIG5vdCBleGlzdHMgaW4gYmluZGluZyBkb2N1bWVu dC4NCj4gPiANCj4gPiA+ICsJCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKGRldi0+b2Zfbm9k ZSwNCj4gPiA+ICsJCQkJCSAgICJtZWRpYXRlayxyZG1hX2ZpZm9fc2l6ZSIsDQo+ID4gPiArCQkJ CQkgICAmcHJpdi0+Zmlmb19zaXplKTsNCj4gPiA+ICsJCWlmIChyZXQpIHsNCj4gPiA+ICsJCQlk ZXZfZXJyKGRldiwgIkZhaWxlZCB0byBnZXQgcmRtYSBmaWZvIHNpemVcbiIpOw0KPiA+ID4gKwkJ CXJldHVybiByZXQ7DQo+ID4gPiArCQl9DQo+ID4gPiArDQo+ID4gPiArCQlwcml2LT5maWZvX3Np emUgKj0gU1pfMUs7DQo+ID4gDQo+ID4gV2h5IG5vdCBkZWZpbmUgZmlmb19zaXplIGluICdieXRl cycgPw0KPiA+IA0KPiA+IFJlZ2FyZHMsDQo+ID4gQ0sNCj4gDQo+IHRoaXMgaXMgYWxpZ24gdGhl IGRlZmluaXRpb24gb2YgZmlmb19zaXplIGluIG10a19kaXNwX3JkbWFfZGF0YSwgaXQgaXMNCj4g U1pfMUssIA0KPiBhbmQgdGhlIG1hY3JvIFJETUFfRklGT19QU0VVRE9fU0laRSBjYWxjdWxhdGVk IHdpdGggU1pfMUsNCg0KSSBtZWFuIHdoeSBub3Qgc2V0IHRoZSBmaWZvIHNpemUgaW4gYnl0ZXMg aW4gZGV2aWNlIHRyZWUuIFNvIHlvdSBuZWVkDQpub3QgdG8gZG8gJyo9IFNaXzFLJyBoZXJlLiBJ IHRoaW5rIHVuaXQgb2YgZmlmbyBzaXplIGluIGtlcm5lbCBpcyBieXRlLg0KDQpSZWdhcmRzLA0K Q0sNCg0KPiA+IA0KPiA+ID4gKwl9DQo+ID4gPiArDQo+ID4gPiAgCXJldCA9IG10a19kZHBfY29t cF9pbml0KGRldiwgZGV2LT5vZl9ub2RlLCAmcHJpdi0+ZGRwX2NvbXAsIGNvbXBfaWQsDQo+ID4g PiAgCQkJCSZtdGtfZGlzcF9yZG1hX2Z1bmNzKTsNCj4gPiA+ICAJaWYgKHJldCkgew0KPiA+IA0K PiA+IA0KPiANCj4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95609C2D0DD for ; Thu, 2 Jan 2020 07:37:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6319321655 for ; Thu, 2 Jan 2020 07:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="ptTe+t9w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6319321655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D272689CB3; Thu, 2 Jan 2020 07:37:08 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by gabe.freedesktop.org (Postfix) with ESMTP id B4D4489CB3 for ; Thu, 2 Jan 2020 07:37:06 +0000 (UTC) X-UUID: 61fee457429949338280c00d953cb770-20200102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=PCH3d6ww20Xcb8eTPquPc5VeMWFXLY/lz4kI3WEDJSA=; b=ptTe+t9wX5cT1eWh3tiaue7/s4w9FkX1JQb8KxZBigS6kJse9P2T4KR3L0eHGs5VUFHm/YaEfqd6GLqgDhgtbM+3zw1iCR7M/krCX5FSpcEpIqZzHgtKZKK/TnuGrDD+AZnbY6zSt42qEiYp5dIbckAD5WUpKeu2ODPR56bxrd4=; X-UUID: 61fee457429949338280c00d953cb770-20200102 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1369051708; Thu, 02 Jan 2020 15:32:00 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 2 Jan 2020 15:30:51 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 2 Jan 2020 15:32:24 +0800 Message-ID: <1577950317.12633.3.camel@mtksdaap41> Subject: Re: [PATCH v6, 13/14] drm/mediatek: add fifo_size into rdma private data From: CK Hu To: Yongqiang Niu Date: Thu, 2 Jan 2020 15:31:57 +0800 In-Reply-To: <1577943764.15116.3.camel@mhfsdcap03> References: <1577937624-14313-1-git-send-email-yongqiang.niu@mediatek.com> <1577937624-14313-14-git-send-email-yongqiang.niu@mediatek.com> <1577942440.24650.5.camel@mtksdaap41> <1577943764.15116.3.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 235C97CA29A4272D17AFBE5A53C10D0B4DF8A318DC6B8E23D5887A814BBD57882000:8 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Yongqiang: On Thu, 2020-01-02 at 13:42 +0800, Yongqiang Niu wrote: > On Thu, 2020-01-02 at 13:20 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Thu, 2020-01-02 at 12:00 +0800, Yongqiang Niu wrote: > > > the fifo size of rdma in mt8183 is different. > > > rdma0 fifo size is 5k > > > rdma1 fifo size is 2k > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 21 ++++++++++++++++++++- > > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > index 405afef..691480b 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > > > @@ -62,6 +62,7 @@ struct mtk_disp_rdma { > > > struct mtk_ddp_comp ddp_comp; > > > struct drm_crtc *crtc; > > > const struct mtk_disp_rdma_data *data; > > > + u32 fifo_size; > > > }; > > > > > > static inline struct mtk_disp_rdma *comp_to_rdma(struct mtk_ddp_comp *comp) > > > @@ -130,10 +131,16 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > > unsigned int threshold; > > > unsigned int reg; > > > struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > > > + u32 rdma_fifo_size; > > > > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xfff, width); > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_1, 0xfffff, height); > > > > > > + if (rdma->fifo_size) > > > + rdma_fifo_size = rdma->fifo_size; > > > + else > > > + rdma_fifo_size = RDMA_FIFO_SIZE(rdma); > > > + > > > /* > > > * Enable FIFO underflow since DSI and DPI can't be blocked. > > > * Keep the FIFO pseudo size reset default of 8 KiB. Set the > > > @@ -142,7 +149,7 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > > */ > > > threshold = width * height * vrefresh * 4 * 7 / 1000000; > > > reg = RDMA_FIFO_UNDERFLOW_EN | > > > - RDMA_FIFO_PSEUDO_SIZE(RDMA_FIFO_SIZE(rdma)) | > > > + RDMA_FIFO_PSEUDO_SIZE(rdma_fifo_size) | > > > RDMA_OUTPUT_VALID_FIFO_THRESHOLD(threshold); > > > writel(reg, comp->regs + DISP_REG_RDMA_FIFO_CON); > > > } > > > @@ -284,6 +291,18 @@ static int mtk_disp_rdma_probe(struct platform_device *pdev) > > > return comp_id; > > > } > > > > > > + if (of_find_property(dev->of_node, "mediatek,rdma_fifo_size", &ret)) { > > > > "mediatek,rdma_fifo_size" does not exists in binding document. > > > > > + ret = of_property_read_u32(dev->of_node, > > > + "mediatek,rdma_fifo_size", > > > + &priv->fifo_size); > > > + if (ret) { > > > + dev_err(dev, "Failed to get rdma fifo size\n"); > > > + return ret; > > > + } > > > + > > > + priv->fifo_size *= SZ_1K; > > > > Why not define fifo_size in 'bytes' ? > > > > Regards, > > CK > > this is align the definition of fifo_size in mtk_disp_rdma_data, it is > SZ_1K, > and the macro RDMA_FIFO_PSEUDO_SIZE calculated with SZ_1K I mean why not set the fifo size in bytes in device tree. So you need not to do '*= SZ_1K' here. I think unit of fifo size in kernel is byte. Regards, CK > > > > > + } > > > + > > > ret = mtk_ddp_comp_init(dev, dev->of_node, &priv->ddp_comp, comp_id, > > > &mtk_disp_rdma_funcs); > > > if (ret) { > > > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel