From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A023C2D0C2 for ; Fri, 3 Jan 2020 16:22:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2A2321734 for ; Fri, 3 Jan 2020 16:22:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="D/uyn74N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727935AbgACQWU (ORCPT ); Fri, 3 Jan 2020 11:22:20 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36690 "EHLO mail-wr1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727701AbgACQWU (ORCPT ); Fri, 3 Jan 2020 11:22:20 -0500 Received: by mail-wr1-f43.google.com with SMTP id z3so42969443wru.3 for ; Fri, 03 Jan 2020 08:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=evzD0JK8LSn0ZimlzI9kK570jZJqixSLv6BagHOwVBY=; b=D/uyn74NsoOZZDLoIBT+vfDAvfmrTzLUJeeDoSF7hwDTrWW/WKVhaHDcSw4cZZ9dTJ MVssK1EjiDi8P1W38Rij0dce0rgE9AgN0TQFUDTiqFUQLVrhhgCJaUToyh6RWk3kHFXl bBXo/jWS7LgapOUmHOth+KmYm80IE9FpQ1j4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=evzD0JK8LSn0ZimlzI9kK570jZJqixSLv6BagHOwVBY=; b=KAoOtqaORhHwWQTyEsgYT94jUp+FJlY+cmtqmNU6JRVFdBHAbJuOytcOwEV680pgIx oUlhVZkHaGh2VPJtaXRMga4YsSrZj+Y+3u/D5Y+gbeWq/V/xUwZlzuNz985nT+onC677 zWCEsqqLNeibRJ/rb+cQgdBzsXq8/UOmGsr5SQAMnFiP63szbxN1uTY67IogZqVzyWQ0 3/qtlGVzu0Fa6YcOPm7yJtT23qsBb9nvQAzM/G5Ki9qLQ005d0NAEWyLGioPVUorHIOS NtXl2EKTawiRSTwCBjMd1Nwn7KikesnhVetbHZlkcmztR6G8GcPgQ8i55yPUAqlKBWTp nFMA== X-Gm-Message-State: APjAAAV94BnH4IEE7+j8q8N5wCbSNSsbqdEY+jk/1y34404Zc/9cFZcy 3KVhyyF2icY1vJY61q8T9rxlgA== X-Google-Smtp-Source: APXvYqyc9zP0ci94atqGfdtju2skV9XC2T3/AMgZm82OCBtWLKbOikxqihCEIAiksFtod1JZ9VKNvQ== X-Received: by 2002:a5d:6144:: with SMTP id y4mr90610098wrt.367.1578068538425; Fri, 03 Jan 2020 08:22:18 -0800 (PST) Received: from Ninja.ibn.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id n8sm61348706wrx.42.2020.01.03.08.22.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Jan 2020 08:22:17 -0800 (PST) From: Vikas Gupta To: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , "David S. Miller" , Sheetal Tigadoli , netdev@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Cc: vasundhara-v.volam@broadcom.com, vikram.prakash@broadcom.com, Vikas Gupta Subject: [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context Date: Fri, 3 Jan 2020 21:50:03 +0530 Message-Id: <1578068404-26195-1-git-send-email-vikas.gupta@broadcom.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Fix calling multiple tee_client_close_context in case of shm allocation fails. Fixes: 246880958ac9 (“firmware: broadcom: add OP-TEE based BNXT f/w manager”) Signed-off-by: Vikas Gupta --- drivers/firmware/broadcom/tee_bnxt_fw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c index 5b7ef89..ed10da5 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -215,7 +215,6 @@ static int tee_bnxt_fw_probe(struct device *dev) fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ, TEE_SHM_MAPPED | TEE_SHM_DMA_BUF); if (IS_ERR(fw_shm_pool)) { - tee_client_close_context(pvt_data.ctx); dev_err(pvt_data.dev, "tee_shm_alloc failed\n"); err = PTR_ERR(fw_shm_pool); goto out_sess; -- 2.7.4